13
0
Commit Graph

9157 Commits

Author SHA1 Message Date
André Nusser
2cc707e88f Fix fencepost error in duplicate_some_regions. Adapt start position. 2015-11-04 17:50:12 -05:00
André Nusser
d6219416e6 Let Entry of FaderOption react on ENTER and allow only numerical input.
This enables setting click gain and solo gain in the preferences using
the text field. -- fixes #6668
2015-11-04 23:23:12 +01:00
2f7c91c7da GUI checkbox to disable plugins
for the benefit of Windows and OSX users and everyone else who does
not run Ardour from the commandline.
2015-11-03 19:21:32 +01:00
ea063ade52 update midi channel button display when mode changes 2015-11-03 19:21:32 +01:00
nick_m
aa097c9e9f Clean up selection history in Editor destructor. 2015-11-03 05:25:15 +11:00
nick_m
00a1d23d83 Grey out unavailable note context menu items rather than hiding them. 2015-11-01 06:06:31 +11:00
nick_m
336f8d47fe Clarify context menu for midi notes.
- right click on a note selects it if unselected or selection empty.

	- note_context_menu is shown as described in #6348
2015-11-01 05:22:55 +11:00
nick_m
0e809dd1d5 Add comment to MRV snap workaround. 2015-11-01 01:43:13 +11:00
nick_m
d5c4d068b0 Fix snap modifiers not working on notes when grid is set to off. 2015-10-31 06:02:54 +11:00
4a3413f2d4 suspend timers while flushing the gtk-event queue.
This fixes an issues where Ardour never completes to flush the GUI event
queue due to rapid updates for meters and similar events.

ARDOUR_UI::load_session() never returned and the complete session
ran inside Gtkmm2ext::UI::flush_pending(), this later causes a crash
at exit.

as side effect, this also speeds up session load.
2015-10-30 15:55:27 +01:00
4fa564c03b RAII Timer Suspend wrapper 2015-10-30 15:55:27 +01:00
nick_m
3e63439637 "End" -> "end" in end point trim command name. 2015-10-30 23:43:09 +11:00
nick_m
5e7c7e52bd Use automation line's frame of reference for y position.
- removes the need for 'pixel hunting' wrt NAME_HIGHLIGHT_SIZE.
	- new control points generated by clicking on a line are placed
	  where the verbose canvas cursor says they are.
2015-10-30 21:14:16 +11:00
nick_m
6d98ccf901 Dont do duplocate calls to MidiRegionView::trim_front_ending () in TrimDrag.
- fixes #6658
	- also leaves undo history alone if point trim does nothing.
2015-10-30 04:01:44 +11:00
nick_m
73328172d6 Fix reversed ratio in last commit. 2015-10-30 00:01:33 +11:00
nick_m
36dd7f8d9d Start line drag using canvas y coords.
- fixes #5759
2015-10-29 23:37:01 +11:00
be69dd279b rework dbf28e3 (hidden parameters) 2015-10-28 21:25:01 +01:00
ebbe96aa08 note to self: at least test compilation before git push. 2015-10-28 19:00:59 +01:00
dbf28e320c don't display hidden automation-controls. 2015-10-28 18:58:46 +01:00
0992272858 fix embedding AU/carbon UIs
the UI shows top/left (not centered, no resize) more detail work to come.
2015-10-28 14:10:49 +01:00
8d1edb13d3 Revert "potential fix for some AU plugin UIs not displaying"
This reverts commit e8fe35d96e.
2015-10-28 14:02:57 +01:00
5dd5bf0f70 notify LV2 GUIs about port-changes when loading presets 2015-10-28 04:06:14 +01:00
e8fe35d96e potential fix for some AU plugin UIs not displaying
looks like not all AU plugin GUIs redraw themselves if 
[win setAutodisplay:1] is unnot.

A user reported that some Waves plugins and Shattered Glass 32bit AUs
are blank in 4.4 on 32bit OSX.

see also 5eefdf7 and earlier AU/API changes.
2015-10-27 23:12:53 +01:00
42424eeb6c another log-scale automation fix 2015-10-27 20:54:09 +01:00
nick_m
61729f8e68 LineDrag fixes wrt initial drag position and display of y value. 2015-10-28 05:33:43 +11:00
nick_m
bf9e752b4d AutomationLine::drag_motion () returns any clamped fractions correctly. 2015-10-28 03:14:10 +11:00
nick_m
fc8b03eef5 Fix incorrectly placed control points (y-axis). fixes #6647.
- also use the return from AutomationLine::drag_motion () in
	  anticipation of it correctly reporting its clamping to
	  AutomationRangeDrag.
2015-10-28 02:46:03 +11:00
1de4ed937c fun with valgrind 2015-10-27 11:15:34 +01:00
nick_m
e78a44d4e5 Markers use the selection change stack. 2015-10-25 05:26:44 +11:00
nick_m
d48564aee5 Amend last commit. 2015-10-25 04:12:38 +11:00
nick_m
663dd1cf2c Set a larger minimum size for recent session scrollers. 2015-10-25 04:07:19 +11:00
a50af45a14 back to mjpeg (revert 2cb511e and 3f157f9) for now
There is anecdotal evidence that using mpeg4 as codec leads to issues
(xjadeo indexes and gets stuck at 99%, likely in libavcodec).

The main motivation for using mpeg4 is/was windows/VFAT 2GB file limit
and improved video quality.  This will have to be revisited.
2015-10-23 23:34:21 +02:00
076ca20321 Delete SystemExec in the main process thread. 2015-10-23 23:29:04 +02:00
nick_m
90aec831cb Relative snap for markers.
- also removes many uninitialised variable warnings in
	  editor_drag.cc found by cppcheck.
2015-10-24 04:59:57 +11:00
nick_m
c9864b71a0 ResizeNoteDrag selection click behaves as NoteDrag's does. 2015-10-24 01:19:00 +11:00
nick_m
96524d863b Clear point selection when uniquely selecting a note.
- Also fix selection undo when creating notes w/control
	  in MouseContent mode.
2015-10-24 00:07:03 +11:00
f4100dc529 mime-type definition is version independent.
File glob "*.ardour" -> application/x-ardour is defined in ardour.xml
2015-10-22 21:05:20 +02:00
nick_m
4f5ca7ecb5 Use lwrcase_dirname for desktop file names and substitutions. 2015-10-23 04:03:16 +11:00
a02ffb9eed set executable and icon name in desktop-file
Also opt for version-agnostic mime-type (file-format version
is independent of program-version and of file-extension)
2015-10-22 18:09:16 +02:00
b074ff0dd5 Remove GhostRegion::CatchDeletion signal to reduce session close times
Currently when a GhostRegion is deleted by its "parent" RegionView it emits the
static GhostRegion::CatchDeletion signal which is connected to the
RegionView::remove_ghost method of every RegionView instance.

With a static GhostRegion::CatchDeletion signal a particular test session
causes 31 Million calls of RegionView::remove_ghost on Session deletion and the
session takes 70 seconds to close with a debug build.

The lifetime of a ghost region is tied to both the TimeAxisView(TAV) and
RegionView(RV) in that when a RegionView is deleted all GhostRegion instances
associated with the RegionView should be deleted or when a TimeAxisView is
deleted all ghost regions that are contained in the view should be deleted.

This means that there needs to be notification between GhostRegion and both
classes. Instead of using a signal for this as we know there are only two
listeners and GhostRegion already holds a reference to the TimeAxisView, also
take a reference to the parent RegionView in the GhostRegion constructor and
use it to notify the RegionView when GhostRegion destructor is called so it can
drop any references it holds.

Using a direct function call in the GhostRegion destructor to notify the
TimeAxisView and RegionView "parents" brings the unload/close time down for the
test session from 70 seconds to 4.5 seconds.

The GhostRegion also references canvas items that are added to the TimeAxisView
canvas group or at least a canvas group that it manages. So when the
TimeAxisView is destroyed and the canvas group that is the parent of those
items is destroyed, the GhostRegion's canvas items will also be
deleted/destroyed by the parent canvas item/group. This means the GhostRegions
must be destroyed when the TimeAxisView they are contained in is destroyed or
there will be dangling references to canvas items that have already been
deleted and trying to delete them again will be bad.
2015-10-22 11:51:03 -04:00
nick_m
0956708aa9 Build freedesktop files if requested. 2015-10-23 02:21:01 +11:00
nick_m
72556cdd7a Amend last commit. 2015-10-23 02:14:03 +11:00
nick_m
410d4316b9 Center some windows known to be presented by ardour. 2015-10-23 01:10:56 +11:00
d04c16e927 fix edge-case: (move playhead w/o session) 2015-10-22 14:14:27 +02:00
André Nusser
2c4e79d0a0 Also use overwrite_file_dialog at all the other places. 2015-10-21 23:28:44 -04:00
André Nusser
5d50abed75 Confirmation on overwrite for track and session templates. -fixes #6587 2015-10-21 23:28:44 -04:00
nick_m
217b2c7753 More desktop file renaming. 2015-10-22 03:51:15 +11:00
nick_m
cadeb3d009 Remove old ardour3 desktop files. 2015-10-22 02:54:53 +11:00
nick_m
203931e846 Add ardour4 desktop and mime type files.
- looks like the install target for these has been removed, but
	  the existence of these may be of help to packagers.
2015-10-22 02:46:18 +11:00
nick_m
54e613746c User interaction preferences tooltips clarify button names. 2015-10-22 01:23:36 +11:00
0880a166c4 variable name change: make purpose of formerly named "_values" in LV2 plugin UI code more clear
And if this is wrong, then rename it again with the right one
2015-10-21 08:10:25 -04:00
270ec425f8 confirm LV2 GUI changes
If a parameter change is initiated by the UI, the host sends a
notifications to confirm (echo) or invalidates (replaces) the value.
(automation: touch, playback,...).

Stateless LV2 GUIs without internal data-model depend on this.
2015-10-21 01:57:16 +02:00
4953d09893 hack to keep UI responsive with heavy AU views. 2015-10-20 19:14:14 +02:00
c22a899c6d OSX copy/constraint mod tweak (amend 0675fe1) 2015-10-20 17:57:00 +02:00
47bbffc5d8 do not update LV2 output port displays unless the value has changed 2015-10-20 11:39:56 -04:00
1d4494961b add commentary 2015-10-20 11:31:18 -04:00
8533b8244f also update LV2 output port displays as part of periodic updates 2015-10-20 11:28:53 -04:00
ac008dac02 Clean up generic and LV2 plugin GUI to deal with ParameterChanged(Externally) alteration 2015-10-20 10:23:49 -04:00
7804a524dc Revert "rename ParameterChanged signal in Plugin to ParameterChangedExternally to reflect its intent, and clean up the result."
This reverts commit 336b2eb9a4.
2015-10-20 10:23:49 -04:00
336b2eb9a4 rename ParameterChanged signal in Plugin to ParameterChangedExternally to reflect its intent, and clean up the result.
The signal exists to notify listeners that something outside of the host's control (e.g. a plugin's own GUI for AU or VST)
has modified a plugin parameter. Previous code had strange feedback loops and ambiguous semantics.

Significant modification of LV2 GUI updating was required.

Still to be tested for feedback loop issues: AudioUnits
2015-10-20 09:07:58 -04:00
0675fe1627 suggest primary-mod as default for copy
fixes inconsistency on OSX.
2015-10-20 11:12:14 +02:00
André Nusser
83b5bdbe95 Ctrl+shift functionality (toggle all) for plugin leds.
The Fader led has special behavior and is only toggled when clicked
explicitly.
2015-10-19 14:36:06 -04:00
nick_m
784adc53bb Test fix for further osx modifier ambiguity. 2015-10-20 04:08:28 +11:00
nick_m
1363f4f645 Fix incorrect display of "Command" modifier on osx. 2015-10-20 03:54:44 +11:00
nick_m
ea72303474 Rc option editor - don't translate "-". 2015-10-20 03:23:06 +11:00
nick_m
e1cb6f221c Fix typo for GTKOSX case. 2015-10-20 01:20:42 +11:00
nick_m
93d5b6c554 Set toggled automation controller using a double. 2015-10-20 00:53:31 +11:00
nick_m
d0c94c9779 Clarify user interaction preference tooltips. Also rebase branch on master. 2015-10-20 00:53:31 +11:00
nick_m
998fd1b015 Restored size of mixer list pane is at least 36 px. Revert default to 75. 2015-10-20 00:53:31 +11:00
nick_m
3fb3b85e3e Default to WIN_POS_MOUSE for dialogs also. 2015-10-20 00:53:31 +11:00
nick_m
4b230069f8 Mixer list pane can shrink to zero width. 2015-10-20 00:53:31 +11:00
nick_m
f46d3dbfaf New non-parented windows are initially positioned at WIN_POS_MOUSE again. 2015-10-20 00:53:30 +11:00
nick_m
e6b35d2cdd Fix snap modifier logic (again). 2015-10-20 00:53:30 +11:00
nick_m
a34f24d8de Rc option editor - alter restart message for user interaction tab. 2015-10-20 00:53:30 +11:00
nick_m
7494b94c63 No-op - rename variable. 2015-10-20 00:53:30 +11:00
nick_m
9511c9c86f Add tooltips to user config preferences. clean up combo ordering. 2015-10-20 00:53:30 +11:00
nick_m
231acfe191 ArdourKeyboard - fix snap / delta logic for triple modifier combinations. 2015-10-20 00:53:30 +11:00
nick_m
d295fe12e4 Click on a selected note unique selects it (as per regions, control points). 2015-10-20 00:53:30 +11:00
nick_m
d998fe10be Allow Alt-Shift-Windows modifier (nice for control point fine adjust).
- OSX equivalent to be decided.
2015-10-20 00:53:30 +11:00
nick_m
986a3a9775 Don't snap if fine adjust modifier used.
- permits non-alt modifier for fine adjust.
2015-10-20 00:53:29 +11:00
nick_m
be1396d066 Select the control point about to be deleted when using shift + right click.
- fixes incorrect selection changes when doing this.
2015-10-20 00:53:29 +11:00
nick_m
070c67bdcc Fix incorrect snap when adding region gain points. 2015-10-20 00:53:29 +11:00
nick_m
afcba4d3d3 Don't use the all_route_group() in Editor::set_selected_track_as_side_effect ().
- we don't appear to actually use it.
2015-10-20 00:53:29 +11:00
nick_m
52a239a254 Allow adding / toggling rubber band selection of automation control points. 2015-10-20 00:53:29 +11:00
nick_m
58068b4e85 Show verbose cursor control point values in MouseContent mode as well. 2015-10-20 00:53:29 +11:00
nick_m
6fe6f95d04 Fix for fine adjust overriding snap modifiers. 2015-10-20 00:53:29 +11:00
nick_m
578a60b875 Add error check to region gain control point selection undo. 2015-10-20 00:53:29 +11:00
nick_m
43b47d1169 Add missing diff to last commit. 2015-10-20 00:53:28 +11:00
nick_m
1451d8043a Region gain point selection behaves as per track automation. 2015-10-20 00:53:28 +11:00
nick_m
202a23d513 Add region gain point selection undo. 2015-10-20 00:53:28 +11:00
nick_m
ffed94d89b Automation - more toggled controller twiddling. 2015-10-20 00:53:28 +11:00
nick_m
24142a424e Fix redo action sensitivity for non-editor undo stack changes. 2015-10-20 00:53:28 +11:00
nick_m
9c102fa8d2 Make automation record undo per pass rather than per touch. 2015-10-20 00:53:28 +11:00
nick_m
877b258c74 Toggled automation fixes.
- don't attempt to insert two points on toggle.
	- remove forced touch->write mode change on toggle
	- initial state still wrong, but works much better overall.
2015-10-20 00:53:27 +11:00
nick_m
5afb645c9f Amend last commit. 2015-10-20 00:53:27 +11:00
nick_m
17294ab9ec Make control point selection more consistent.
- disallow simultaneous events via ControlList::editor_add ()
	- clicking on an automation line selects the points that define it.
	- don't 'flash' a region selection when using mousedraw mode.
	- cp click selection resembles region selection.
	- region gain points respect snap modifier (a la automation points).
2015-10-20 00:53:27 +11:00
bd6b4025de one less deprecated API 2015-10-18 23:29:58 +02:00
d17b73e989 GUI changes use new AppleUtility Library 2015-10-18 23:03:14 +02:00
601d51ce71 amend prev commit. 2015-10-18 14:31:04 +02:00
17b18a593e fix additive linkflags 2015-10-18 14:22:55 +02:00
e7b8e98db2 Replace static PBD::Signal in NoteBase with direct call to MidiRegionView
NoteBaseDeleted signal is static so each MidiRegionView(MRV) gets notified
about the deletion of each NodeBase instance even if it is contained in another
MRV

The NoteBase and MRV classes are currently coupled anyway, so this change uses
the reference to the MRV parent to directly call the parent when the NoteBase
is deleted. This is all in the GUI thread so I'm not sure why a PBD::Signal was
being used?

If the MRV class is the only reference holder to the NoteBase class
then I'm not sure if a callback is needed, perhaps the MRV should just remove
the note from the selection before deleting it but I'm not that familiar with
the code.

Signal emission/calls static NoteBaseDeleted signal vs direct with 10540
NoteBase instances.

static:

After Load Session: 6360638
After Unload Session: 12221026(5860388)

direct:

After load Session: 10540
After unload Session: 21080

Session Load/Unload time in master, debug/release with ~10000 Notes(seconds)

Load Debug: 32, 26
Unload Debug: 83
Load Release 32, 20, 42
Unload Release 26, 25

Session Load/Unload time with direct call debug/release(seconds)

Load Debug: 21.7, 18.1
Unload Debug: 69.4, 71
Load Release: 22.6, 13.4, 17.7
Unload Release: 24, 23.5

This is not a large Session, 1500 regions, 10000 notes so there is probably
some other funky stuff going on that needs fixing.
2015-10-17 22:15:07 -04:00
André Nusser
e807fe2b28 Introduce "Transpose..." also in the context menu of selected notes. 2015-10-17 22:12:55 -04:00
André Nusser
bc83699e44 Fix tiny memory leak. 2015-10-17 22:12:54 -04:00
André Nusser
d460bb3475 Include "Transform..." into MIDI region menu.
Everything has already been done except the including.
2015-10-17 22:12:54 -04:00
3de2f762f8 fftw-3.3.5/windows .dll includes threads lib 2015-10-18 02:44:26 +02:00
f307080808 disable follow-edits with external sync #6577 2015-10-18 02:03:41 +02:00
b5ef5aa40b and another "f" 2015-10-17 20:51:21 +02:00
dd8dfb47ec four f* f's. 2015-10-17 20:30:24 +02:00
9ae577fb07 thread-safe fftw (needs fftw-3.3.5)
see https://github.com/FFTW/fftw3/issues/16
2015-10-17 19:23:39 +02:00
619900e333 fix #6640 (snapshot clears "dirty" flag)
empty name indicates current-session name.
2015-10-16 21:10:21 +02:00
23b975e172 use API to add system-specific volumes - #6643 2015-10-16 19:07:25 +02:00
a27e9a68b2 strip silence: report analysis progress 2015-10-16 15:27:20 +02:00
dead81d284 strip silence: wait for analysis to complete
"apply"ing strip-silence while analysis is still running will at best
only process regions that have already been analyzed and at worst crash.
2015-10-16 00:13:02 +02:00
5ad63bd3f8 re-enable engine sensitive actions..
..after an engine stop/start cycle.
e.g "New Insert", "New External Send"
2015-10-15 21:50:01 +02:00
696b89b71a rework 8b80fe0, use std::string, not char* 2015-10-15 11:24:15 +02:00
8b80fe04ad Avoid calls to Glib::ustring << operator at all cost.
Glib::operator<<(std::ostream&, Glib::ustring const&) involves
loadlocale which is not thread-safe on OSX.

This fixes various seemingly random crashes on OSX.
2015-10-14 22:46:15 +02:00
5eefdf7536 update AU GUI positioning and resizing. 2015-10-14 22:46:07 +02:00
d369894dd5 no need for ugly cast constructors, just add a second argument 2015-10-12 13:34:00 -04:00
86f8b9e12d revert 7e0055; the original text better reflected reality 2015-10-11 11:37:52 -05:00
André Nusser
1df97b4174 Fix wrong 'Import to Region List' default on first call. -fixes #6631 2015-10-09 02:05:41 +02:00
André Nusser
4c26225ddc Fix "Select All * Edit Point" when used as shortcut. -fixes #6626 2015-10-08 13:46:22 +02:00
5762ee114d allow to use non-emphasis regardless of custom samples 2015-10-07 19:37:56 +02:00
9b8697b75b Added use click emphasis toggle (gtk2_ardour) 2015-10-07 19:34:40 +02:00
38405fa210 fix crash on 2nd Lock 2015-10-07 15:50:55 +02:00
dee89fb98a add missing include 2015-10-07 15:39:32 +02:00
0d137f7bdf fix solo-group override 2015-10-07 15:29:00 +02:00
e79b2e376f amend prev commit. 2015-10-07 14:25:33 +02:00
a02fc6340b update solo button callback semantics
override-group toggles current group state (not disables groups)
2015-10-07 14:21:30 +02:00
3bb492a0c0 fix crash for solo btn2 + primary-mod 2015-10-07 14:21:30 +02:00
6b00e149d2 cancel-solo always clears all solo-state, just in case. 2015-10-06 20:06:25 +02:00
8431d102b9 Do not restore engine state if we don't have control
When connecting to already running jack, display jack's buffersize
correctly.
2015-10-06 14:40:51 +02:00
ef0f13cb84 Stop engine when clicking back button in latency measurement tab of EngineControl dialog
The engine is started when you switch to latency measurement tab but it isn't
stopped if you just click the back button without measuring for latency.
2015-10-06 13:29:57 +10:00
528ad3416a Remove unused methods in ARDOUR_UI for starting/stopping engine 2015-10-06 13:29:57 +10:00
cd4dd08931 Add EngineControl::stop_engine method to show errors when stopping engine
This replaces using ARDOUR_UI::disconnect_from_session which is only used by the
EngineControl class. ARDOUR_UI::disconnect_from_session also disconnects from
the AudioEngine::Halted signal which seems unnecessary as Halted is not emitted
when stopping the engine and calling update_sample_rate() which is already
handled when the AudioEngine::Stopped signal is emitted.
2015-10-06 13:29:57 +10:00
1195aeb64e Handle all errors when starting backend in EngineDialog 2015-10-06 13:29:57 +10:00
4b9e738636 Align switch statement with case labels to reduce indentation in EngineDialog 2015-10-06 13:29:57 +10:00
5ed05218e6 Update sample rate and CPU load in status bar when AudioEngine stopped 2015-10-06 13:29:57 +10:00
2397429e99 use quotes for in-tree pbd/glib wrapper include 2015-10-05 22:15:18 +02:00
dc36b063bf remove unused fstream includes 2015-10-05 22:15:18 +02:00
c898707bdf remove ofstream from gtk2ardour 2015-10-05 22:15:17 +02:00
22b07e0233 NOOP, remove trailing tabs/whitespace. 2015-10-05 16:17:49 +02:00
4dc63966f0 globally remove all trailing whitespace from ardour code base.
Paul Davis was responsible for introducing almost all of this.
2015-10-04 14:51:05 -04:00
d25e1cb635 add a hidden option to show hidden processors
simplify debugging solo, monitor-processors, etc
2015-10-04 19:40:46 +02:00
7e00550e22 change wording of autosave option to be more clear 2015-10-04 12:25:38 -04:00
95df99e6d4 remove unused function 2015-10-04 17:53:02 +02:00
65716d968e don't export video-frame request function 2015-10-04 02:04:59 +02:00
79fecf0b61 escape markup in region list 2015-10-02 19:38:32 +02:00
3aa24b222b add missing markup escape
(e.g. import file with ampersand)
2015-10-02 19:14:24 +02:00
eebbf64484 provide Main/cancel-solo as an action and make rude solo button(s) use it 2015-10-02 07:32:56 -04:00
520b78b841 Add parent window argument to ARDOUR_UI::check_audioengine
Ensures relevant placement of the dialog when presented
2015-10-01 09:10:19 +10:00
73acaf6de6 Display warning when closing Audio Setup dialog with engine stopped
Only show warning when a session is loaded
2015-10-01 09:10:19 +10:00
463bd470e8 Don't hide Audio Setup dialog when clicking 'OK' if engine fails to start
This has to be handled in two places, in ARDOUR_UI::do_audio_midi_setup and in
the dialogs response handler and in as the window can also be triggered via the
window action manager.
2015-10-01 09:10:19 +10:00
2768ce9b05 Use AudioSetupDialog as parent of the error message popup when failing to start engine
Without a session loaded this makes the message dialog appear in front of the
AudioSetup dialog instead of randomly up in the top left somewhere. This does
mean though that if the AudioSetup dialog is not visible the error message
popup will appear randomly up in the top left(at least on windows, it seems
fine on linux) but I will fix that shortly.
2015-10-01 09:10:19 +10:00
d19605aeaa Use AudioEngine::get_last_backend_error in message dialog when failing to start engine
If a backend is not returning AudioBackend::ErrorCode values to indicate the
type of error then the default string will be returned which is the same as
what was previously displayed.
2015-10-01 09:10:19 +10:00
André Nusser
c6f9a65081 Gray out "strip silence" and "rhtyhm ferret" for midi regions.
The former even triggered a segfault.
2015-09-30 23:20:27 +02:00
André Nusser
71f6f982e3 Fixed spelling. 2015-09-30 14:43:02 -04:00
André Nusser
6fdd3f47ac Make all the context menu entries of the track list work. 2015-09-30 14:43:02 -04:00
48b904fcee is there a better way to make gcc+enumwriter happy? 2015-09-29 16:09:01 +02:00
3f8857b129 Fix midi tracer to show MSB too. (fixes #6566) 2015-09-29 06:06:40 -07:00
08446f79e1 set waveform height depending on Layer mode
Fixes background peakfile/waveform creation. Waves need to be
created directly with the proper attributes as set by StreamView.
2015-09-29 13:47:21 +02:00
7f86418340 Revert "change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits"
This reverts commit 601770837e.

This work continued in the "clockwork" branch where it was done correctly.
2015-09-28 20:28:40 -04:00
deabc0f41b change clearlooks style file so that small_entry and related styles use text color for text even when selected 2015-09-28 18:20:54 -04:00
André Nusser
42647c9920 Introduce Ctrl+Shift+Click on lock solo in the mixer. 2015-09-28 17:58:40 -04:00
621fd845e6 Revert "add new action and loop marker menu item for setting up loop record"
This reverts commit ebb43508f1.
2015-09-28 17:44:04 -04:00
601770837e change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits 2015-09-28 17:42:11 -04:00
3e0d801509 when editing an audio clock, swallow illegal keys rather than allowing them to reach the rest of the GUI 2015-09-28 17:42:11 -04:00
9cf56aab84 fix the logic of the GUI "toggle roll" action as it pertains to loop recording 2015-09-28 17:42:11 -04:00
ebb43508f1 add new action and loop marker menu item for setting up loop record 2015-09-28 17:42:11 -04:00
9f2aba1451 mixer-strip name context-menu cleanup
patch thanks to chaot4
2015-09-27 21:45:40 +02:00
2e6b455b19 add deva to authors. 2015-09-27 16:13:37 +02:00
e1c421c67b Close export directory browser dialog when clicking on 'Cancel' button, Fixes #6594 2015-09-27 21:55:20 +10:00
cf761d4f67 fix mixer group-tab width - #6572
EditorGroupTabs are re-exposed in the idle-callback, widgets
are packed and geometry is valid.

Mixer_UI::redisplay_track_list() does not have this property.
2015-09-27 01:33:02 +02:00
e935890fc5 fix crash at session-close, amend dec4790d 2015-09-25 01:05:13 +02:00
c3a7730c88 redisplay markers after removal - fixes #6596 2015-09-24 00:27:32 +02:00
cb0b22cb79 Hide create new item from Group Tab context menu
Creating a new empty group from the group tab area just looks broken since
nothing visible happens, so hide this item when the context menu is
triggered from this location.
2015-09-21 16:50:45 -05:00
Todd Naugle
203a72f883 Create new Groups with a consistent set of default properties.
This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default for all other methods (mixer strip button, etc).
2015-09-21 14:52:25 -05:00
cba31db6fe processor-box: explicitly check for "Amp" (Fader) 2015-09-21 13:14:29 +02:00
e64e4e19bc save-as, update button sensitivity when dir changes 2015-09-21 12:05:31 +02:00
86c93292d4 add André to authors list. 2015-09-20 22:30:43 +02:00
André Nusser
6a248b61f0 fix duplicating multiple selected regions - fixes #6202 2015-09-20 22:22:39 +02:00
dec4790dff update SFDB settings when track selection changes 2015-09-20 20:03:09 +02:00
cff0852df9 fix initial state of Import Dialog 2015-09-20 20:02:40 +02:00
6c53ebc4c1 basic GUI support to auto-align video by LTC. 2015-09-20 18:37:39 +02:00
65f215bb4c GUI part of silence-trim fade constraint. 2015-09-20 01:28:37 +02:00
21c1d0f832 Silence detect: constrain duration in GUI. 2015-09-19 23:33:35 +02:00
a6caf6ed3a NOOP, whitespace. 2015-09-19 20:31:32 +02:00
dad0e390ff indicate that silence trim is already active. 2015-09-19 20:28:56 +02:00
c829c10a74 band-aid for Glib::operator<<
it seems that g_locale_from_utf8() (called by <<) is not thread safe,
at least not on OSX.

glib error-code 1, Invalid byte sequence in conversion input
-> throws Glib::Error.

possible fix for #6435, route-creation is interrupted via catch(...)
2015-09-19 19:00:43 +02:00
dfd7e80fda fix crash at exit, ctrl+s during quit. 2015-09-19 19:00:43 +02:00
646bc2bb43 fix possible endless loop in silence detection 2015-09-19 19:00:43 +02:00
6569301001 remove cruft 2015-09-19 19:00:43 +02:00
0e55dc470d StripSilence: invalidate Completed connection - fixes #6600 2015-09-19 19:00:42 +02:00
cdd76636a0 tweak colors for silence-detection
The text annotation needs to be visible:
 - above default background (dark gray)
 - above waveform (orange)
 - above silent-highly regions (violet, was bright turqoise)

old color (dark blue) failed for all but the waveform.
2015-09-19 19:00:42 +02:00
62a161195c fix progress reporter, use idle callback.
do not directly hook into Glib's Main Context.
2015-09-19 19:00:42 +02:00
2ef2ea0b59 create new Event-IDs for pasted midi-notes 2015-09-18 20:37:23 +02:00
b753704c3e Revert "work around bug or feature of string_compose()"
This reverts commit 17baf93626.
It's no longer needed since c1d6a2f
2015-09-18 00:04:42 +02:00
f3a1ac21cb associate label more closely with VST path button. the plugin tab needs a complete layout rethink, someday 2015-09-17 16:07:40 -05:00
ff80d66088 speficy gtk treeview style for consistency 2015-09-17 21:09:13 +02:00
17baf93626 work around bug or feature of string_compose()
string_compose("x%1x x%2x x%3x", "A", "", "C") 
-> "xAx xCx xx"
and not
-> "xAx xx xCx"
2015-09-17 20:51:11 +02:00
f27800ea41 use pbd's gstdio compatibility wrapper (GUI) 2015-09-17 14:38:09 +02:00
5d38d1c751 explicit glibmm/datetime include
On some distros. glibmm.h does not include glibmm/datetime.h
2015-09-17 13:37:52 +02:00
6829d1593f Use PBD::open_uri in about dialog to open website, should fix #6463 2015-09-17 11:55:22 +10:00
23a384f8ae fix #6588. use ardour-codename only for Ardour. 2015-09-17 00:40:58 +02:00
202b9cc82a fix a tautologically undefined comparison 2015-09-17 00:21:38 +02:00
4a10dbbc1b deleting pointers to incomplete types may cause undefined behavior 2015-09-17 00:13:43 +02:00
5d02c47d3a fix clang compilation.
pbd/configuration_variable.h:84:6: error: call to function 'operator>>' that is neither visible in the template definition nor found by argument-dependent lookup

ardour/types.h defines  std::istream& operator>> and must be included prior to pbd/configuration_variable.h
2015-09-17 00:10:50 +02:00
31c0a536ba fix missed but required merge resolution related to UIConfiguration's new status as a singleton in this branch. 2015-09-16 17:11:54 -04:00
69b44ee829 Use tooltips.h in ArdourButton to remove ardour_ui.h inclusion 2015-09-16 16:55:17 -04:00
1d42ed077e Use ARDOUR_UI_UTILS::set_tooltip rather than via ARDOUR_UI::set_tip
This removes the direct dependence on ARDOUR_UI/Gtk_UI for setting
tooltips. Removes inclusion of ardour_ui.h from 16 files.
2015-09-16 16:55:17 -04:00
2031007a3a Add tooltips.h header for setting tooltips rather than via ardour_ui.h 2015-09-16 16:55:17 -04:00
29f43af53a Add missing header include in midi_channel_selector.h 2015-09-16 16:55:17 -04:00
f9cba95a8f Add missing header include in shuttle_control.h 2015-09-16 16:55:17 -04:00
b8546e0b69 Add missing header include in plugin_selector.h 2015-09-16 16:55:17 -04:00
38bae2996a Remove ardour_ui.h header inclusion 2015-09-16 16:55:17 -04:00
c256075e63 Remove tooltips() member from ARDOUR_UI and use Gtk_UI::set_tip 2015-09-16 16:55:17 -04:00
b8e9ee50e0 Use Forward declaration for non-MSVC compilers in ardour_ui.h
I can't test this with MSVC so John might have to fix this, just
adding the necessary header includes inside MSVC specific ifdef
but I think it should be OK
2015-09-16 16:55:17 -04:00
513ecad1f0 Forward declare Meterbridge class in ardour_ui.h 2015-09-16 16:55:17 -04:00
553c3ef557 Remove ui_config.h inclusion from ardour_ui.h 2015-09-16 16:55:17 -04:00
6b019a4953 Move UIConfiguration Singleton into UIConfiguration header
This removes the direct dependence on ardour_ui.h from 39 files
2015-09-16 16:55:17 -04:00
45d487f16e Move ARDOUR_UI::ui_scale into UIConfiguration class 2015-09-16 16:55:17 -04:00
c99bf353a5 Remove inclusion of ardour_ui.h from ui_config.cc 2015-09-16 16:55:17 -04:00
fc1e7dbb55 Move DPIReset and ColorsChanged signals into UIConfiguration 2015-09-16 16:55:17 -04:00
0fd1aa3808 Remove unused header include 2015-09-16 16:55:17 -04:00
2d47183dc9 Move util functions into UIConfiguration as they depend on it anyway 2015-09-16 16:55:17 -04:00
2e8af0c917 Remove duplicate extern declaration
DPIReset signal is declared in global_signals.h
2015-09-16 16:55:17 -04:00
482b71d35e add datetime to snapshot sidebar
Currently only information, not sortable.
2015-09-16 22:17:34 +02:00
18afd09b3b unify recent session dialogs 2015-09-16 21:37:56 +02:00
f2f7a21aea fix d6029f9 (recent sort-order)
add one, because (-0 == +0)
2015-09-16 19:30:41 +02:00
eda0a24454 add Hour:Minute to last-modified. 2015-09-16 19:01:13 +02:00
d6029f9285 remeber recent-session sort-column 2015-09-16 18:59:04 +02:00
b3e447f421 highlight default sort column 2015-09-16 18:24:57 +02:00
7e65835c0e disable even/odd row highlight for GtKTreeview.
Almost all TreeViews in Ardour had this disabled.
A few cases where it wasn't produced odd rendering artifacts. e.g.:

* Radio-buttons in the Plugin Manager used "base color" regardless of even/odd lines
* Sortable trees only used even/odd background for the sort-column (not others)
2015-09-16 18:24:57 +02:00
570d92c527 user-sortable recent session list 2015-09-16 18:24:56 +02:00
1fb38a416a add "last modified" column to session-dialog 2015-09-16 18:24:56 +02:00
6c43ca5334 partially revert de53fac (pre-sort session list)
<glib> header includes and commends remain for later use
2015-09-16 18:24:56 +02:00
7b82277c7e Don't try and split a region when dragging, should fix bug #6338 2015-09-16 16:28:18 +10:00
c510d8a49d prepare time column in recent session 2015-09-16 01:28:55 +02:00
f1be9114c2 inspect snapshot for its info (not parent) 2015-09-16 01:28:55 +02:00
de53fac303 pre-sort recent-sessions by modification time - #6575 2015-09-16 01:28:55 +02:00
af2b8c73b9 expose the new use monitor fades option 2015-09-15 16:35:37 -04:00
fdcc209354 remove unused variable 2015-09-15 21:21:09 +02:00
cf9176c3bb don't allow to focus sidebar checkboxes - fixes #6445 2015-09-15 21:21:01 +02:00
93cd0d17e4 display active peak-builds 2015-09-15 17:50:27 +02:00
655c581ef2 expose transport fade option 2015-09-15 09:01:26 -04:00
b05912b0cb GUI part: cleanup peak-files 2015-09-15 14:44:05 +02:00
11c0adfbae pending-peaks: checker pattern. 2015-09-15 02:28:24 +02:00
7e1baa70e4 visually indicate peak-file rebuild
Not yet a checker pattern, but closing it :)
2015-09-15 00:19:02 +02:00
aabc5108f3 Revert inadvertently pushed commit
This reverts commit 3a6114c025.
The actual solution is http://dev.drobilla.net/ticket/1085
2015-09-13 04:10:14 +02:00
3a6114c025 center, don't expand plugin widgets 2015-09-13 04:09:24 +02:00
dae330489b valgrind: only use objc supression file on OSX 2015-09-12 21:48:26 +02:00