13
0
Commit Graph

14969 Commits

Author SHA1 Message Date
229a8aea13
Add option to toggle TriggerBox PI
This does not show/hide the Triggerbox in the Mixer itself,
it only sets the presentation-info flag (to be used on the Trigger Page).
2021-12-01 23:10:07 +01:00
f584335f28 follow Beats API change in MidiRegionView::paste_internal() 2021-11-29 21:50:29 -07:00
60e522f4ee MIDI Program Changes: Fix some thinkos in patch-change flag locations
Program Changes are stored as an offset from the 'source' start, and must be translated to/from region time.

Better locating of patches wrt the grid:
You can't assume time_to_pixel is steady across the timeline
* calculate position of the patch-change flag
* calculate region start position, and set flag's x offset from there

also: consolidate patch-location code into display_patch_changes()
2021-11-23 14:14:35 -06:00
c27bfde045 MIDI Program Changes: prevent patch-changes from moving after every edit by the dialog.
The clock widget shows absolute time but must be converted to+from source time
2021-11-23 14:14:35 -06:00
5212fc9677 MIDI Program Changes: dragging patches was resulting in the wrong location or disappearing altogether
a Program Change's position is referenced from the midi Source which might not be the same as the region start
2021-11-23 14:14:35 -06:00
ec88635555 MIDI Draw: potential workaround for sticky menu items at startup 2021-11-19 13:01:54 -06:00
84111a343e Deinterlace MIDI: gui part 2021-11-19 10:28:37 -06:00
ca7e133e3d MIDI Draw: fix thinko in length=Auto 2021-11-19 10:28:37 -06:00
bc6766fc3f midi region view: fix crashes when adding notes
A region may have no notes, or none in the correct time range. Finding
a note to get channel or velocity info from may fail
2021-11-18 10:03:34 -07:00
252ae56a08 MIDI Draw: change behavior regarding MIDI Channel of new notes
When adding a note, use these criteria to choose the channel number:
* if the user has explicitly specified a note in the pulldown, use that
* if the user has AUTO selected and we are in a region, choose the nearest note's channel (consistent with velocity behavior)
* as a fallback, query the track for its channel-filter (old behavior)
2021-11-18 08:23:08 -06:00
eebf3717e3 MIDI Draw: note-length-auto means 'use the Grid for note-length' (prior behavior) 2021-11-18 07:35:13 -06:00
93e68a5a00 MIDI Draw: provide a menu for Channel and Velocity 2021-11-18 07:35:13 -06:00
2a6da0113f MIDI Draw: Provide a menu to explicitly select note-length
ToDo: 3,5,7's?  keyboard shortcuts?
2021-11-18 07:35:13 -06:00
c24cabead0 GUI changes to follow TempoMap::sample_at() API changes 2021-11-17 15:57:30 -07:00
fd5594f831 use Editor::reassociate_metric_markers() before performing edits on tempo map
The objects referenced by markers point to the copy of the map held by the per-thread ptr. But
the edits must be done on a writable copy of the map. ::reassociate_metric_markers() fixes
the references to use the writable copy, so that when we pass references to the objects in the map
to the writable copy, it will find them and modify them (rather then ones in the previous
generation of the tempo map)
2021-11-17 12:16:39 -07:00
18e851cd73 catch too-early use of PublicEditor::instance() 2021-11-17 12:16:39 -07:00
710c5b9b78 do not use PublicEditor::instance() in MainClock, since these obejcts can exist before the editor
The AudioEngine on the other hand is created in the global libardour init method, so use that instead
2021-11-17 12:16:39 -07:00
f0cd3b5c0c editor: when the tempo map changes, update the per-thread pointer
TempoMap::use() merely returns the current per-thread tempo map
pointer; if a change is signalled, we should force an update
of the per-thread ptr via TempoMap::fetch()
2021-11-17 12:16:38 -07:00
dd4e495d90 audioclock: use correct call for "right now" tempo display 2021-11-17 12:16:38 -07:00
2735022357 audio_clock: fix uninitalized variable 2021-11-17 12:16:38 -07:00
f6adf9c897 MIDI Import: gtk part 2021-11-14 08:21:00 -06:00
4c472ca1c5 TriggerSlot: Remove Queued menu-item (for now) 2021-11-13 15:54:11 -06:00
85fc3d5629 add missing file 2021-11-10 21:16:27 -07:00
4f58a92c6d show trigger/slot selection 2021-11-10 17:51:04 -07:00
a9949f20e6 basic architecture for Trigger selection
This is all done in the GUI, using GUI objects. THe primary goal
here is to allow actions to be applied to selected triggers, so
there's no real need for a trigger aspect to libardour (core)
selection.
2021-11-10 16:37:15 -07:00
0d96753364 remove unused variable 2021-11-10 11:55:20 -07:00
605daf23f2 add default bindings for note shortening 2021-11-06 10:21:31 -06:00
8cfdd0ca5b add actions to provide access to note-shortening 2021-11-06 09:49:39 -06:00
7fca55eeb5 Fix placement of drawn MIDI notes.
Important logic from 6.9 was either missing or incorrectly implemented. New
version is much simpler - we just use the RoundDownMaybe mode of round_to_bbt()
to ensure that the note start is always within the current grid even if the
mouse is more than halfway "through" it.
2021-11-04 18:27:02 -06:00
2d9eb6ec81 Fix error in drawing length of ghost MIDI notes in note drawing mode 2021-11-04 18:25:45 -06:00
efdd3e86c3 remove unused variable 2021-11-04 13:59:43 -06:00
af2af29c95 remove Kiwi constraint-based packing code from canvas library and users (GUI version) 2021-11-04 11:25:56 -06:00
0c5d41039a more scene triggering actions 2021-11-03 18:44:31 -06:00
aba0de91f8 add missing file 2021-11-01 13:40:23 -06:00
b7ce131557 triggerboxUI: skeleton for triggerbox bindings and actions, include triggering of scene 1 2021-11-01 12:11:57 -06:00
BrunoVernay
e16ac4b036 Typo in comment: paramater 2021-10-30 23:02:35 +02:00
65f85dfdfe triggerboxUI: GUI elements to load slots from selected regions 2021-10-24 09:25:49 -06:00
28d8ad1ede triggerbox UI: no need for a render method 2021-10-19 19:08:52 -06:00
9ed9544f87 triggerbox UI: indicate clip playing status with full-height, shaded fill color 2021-10-19 14:41:05 -06:00
ed823defe0 triggerbox_UI: mark text for size-allocate-based resizing 2021-10-19 10:55:10 -06:00
d129a64890 when GUI scale changes, drop Canvas::Text font size maps 2021-10-19 10:54:51 -06:00
ccc1fd8a2d remove some debug output 2021-10-17 21:18:06 -06:00
291adf11cd triggerbox UI: add two more quantization settings 2021-10-17 17:58:48 -06:00
ae83d8121d triggerbox UI: size_allocate() for trigger name text 2021-10-17 17:58:34 -06:00
82ba897be6 triggerbox UI: some color work 2021-10-17 17:58:08 -06:00
9d49efdc8c triggerbox ui: use radio menu elements not check elements 2021-10-17 10:49:15 -06:00
a30148b2a1 triggerboxUI: showing trigger box UI is global now; move load op to context menu; handle multiple selection 2021-10-11 17:58:51 -06:00
9e763c2672 remove all dangling event-loop-precall code 2021-10-11 17:48:53 -06:00
c0720c7a4c don't show standalone triggerbox window after adding tracks with a triggerbox 2021-10-10 13:53:45 -06:00
cf8f0b4702 triggerbox: respond to changes in default trigger input port (GUI) 2021-10-09 16:59:07 -06:00
af02413aef derive TriggerPortSelectionOption for trigger default input port preference (incomplete) 2021-10-08 17:04:07 -06:00
e677863424 refactor LTC port option element to make it re-usable 2021-10-08 16:34:08 -06:00
9ca287dbdb triggerboxUI: hide/show trigger play/stop buttons when entering/leaving trigger (logic-y experiment 2021-10-08 13:45:27 -06:00
305c9ba6e9 triggerboxGUI: use new API and tweak add route dialog to allow choice to add triggerbox 2021-10-08 13:45:27 -06:00
97f323137c triggerbox: initial (incorrect) attempt at handling tempo map changes 2021-10-07 08:03:46 -06:00
3ddfdbc790 triggerboxUI: start adding per-slot event handling 2021-10-07 07:57:47 -06:00
6daf0f0451 triggerbox UI: fix usual ambiguity on macOS etc. when using "Rect" 2021-10-07 07:48:07 -06:00
05df62ed79
Amend fdf1c1aba2, don't unconditionally show plugin-manager 2021-10-07 03:47:00 +02:00
fdf1c1aba2
Show plugin-manager when missing plugins are found 2021-10-07 03:10:48 +02:00
28784a0da7 triggerboxUI: change progress display to partial width, thin horizontal line 2021-10-06 15:21:44 -06:00
0bace97916 triggerboxUI: shrink font size 2021-10-06 15:21:44 -06:00
248d7e5980 prevent trim-dragging that doesn't change region duration from incorrectly resetting fades 2021-10-05 10:43:24 -06:00
8bdb8f51fd remove debug output 2021-10-04 17:47:55 -06:00
949e3eadc9 triggerui: fix map/unmap confusion 2021-10-04 01:30:32 -06:00
dc4d94b4ee triggerui: basic progress bar for trigger slots 2021-10-03 23:47:47 -06:00
b5c584befa triggerbox UI: make it respond to size_allocate() 2021-10-03 16:46:39 -06:00
bfc3c51052 triggerUI: somewhat functioning inline trigger box UI 2021-10-03 12:29:26 -06:00
7d0c67e376 Revert "A small experiment to try '#pragma GCC warning'"
This reverts commit 808bfe0916.

This pragma syntax is not compatible with gcc
2021-10-03 09:10:14 -06:00
acac302063 first steps in displaying triggerbox UI inside mixer strip (non-functional) 2021-10-03 09:09:01 -06:00
6ba8feed15 triggerui: work on colors, fonts and legato button 2021-10-03 09:09:01 -06:00
John Emmas
808bfe0916 A small experiment to try '#pragma GCC warning'
MSVC is happy to ignore the above pragma although it aborts the build if it encounters #warning

#pragma GCC warning seems to work fine here for Clang - so start by changing just 1 x file to see if there's any detrimental effect for the other builds.
2021-10-03 13:29:07 +01:00
b598750c2a triggerui: use new table attach API 2021-10-02 17:45:57 -06:00
56056f5590
Remove unused code
It that was apparently accidentally added in a git-rebase
in 6fd791423b.
2021-10-02 23:41:28 +02:00
8cd8e23bef triggerUI: continue extending trigger launch editor 2021-10-01 18:38:42 -06:00
9fe0c3912e triggerui: control and respond to trigger quantization changes 2021-09-29 18:01:19 -06:00
55e7d70fca triggerui: start adding more elements to launch settings dialog 2021-09-29 11:20:50 -06:00
b5c0f55831 triggerboxui: start connecting more widgets to trigger API 2021-09-29 11:20:50 -06:00
ef30c3dc8d
Allow to edit group from the RouteGroupMenu 2021-09-28 07:11:37 +02:00
0dcf7d54e5
Fix --no-nls compilation 2/2 -- #8802 2021-09-27 16:28:44 +02:00
754230921d there is no Properties::position any more (GUI)
Position is a part of a length property (a duple specifying
"duration AT position", and there is no distinct property
for just the position itself
2021-09-25 16:49:51 -06:00
66595ae60e a more correct fix (partial reversion) for Drag::adjusted_time() 2021-09-25 16:49:51 -06:00
e145a67ed6
Remove unused UI config (hiding-groups activation is a RC) 2021-09-25 00:01:20 +02:00
3a1d8c48df Fix implementation of Drag::adjusted_time() to behave like the pre-nutempo version 2021-09-24 15:46:11 -06:00
5ee2c91864 triggerui: return to normal packing 2021-09-23 11:48:29 -06:00
c11fadf884
Handle missing case TriggerTrack 2021-09-20 04:41:05 +02:00
747b24f063
Change LuaWindow into an ArdourWindow
* remember window visibility, size and position
* Show as toggle in the window-menu (rather than show action)
* reduce specialization, use WM and ArdourWindow infrastructure
  (transient parent, window-type, etc)
2021-09-20 04:26:24 +02:00
23c5793173
Remove duplicate calls to set_session
Windows managed as Proxy do not need direct calls to set_session().
This is already handled by WM::Manager::instance().set_session()

Also WM set_session() called it twice.
2021-09-20 04:21:21 +02:00
851fab7ec3
Print g_log messages to stdout as well
This handles an edge-case in case the message arrives
before the UI is up, there is still a message printed,
before Ardour crashes (e.g. when setup_windows() fails).
2021-09-20 04:16:09 +02:00
bcb9487c39
Only setup Editor tooltips once
ArdourUI::setup_tooltips() calls editor->setup_tooltips() already.
2021-09-19 18:51:56 +02:00
0b2b361b32
Dis/reconnect to session signals for each session
This allows to load a session from a running instance.
Prior to this change this caused a crash (_session = null)

```
#1  ARDOUR::Session::session_directory() const (this=0x0) at ../libs/ardour/ardour/session.h:257
#2  EditorSources::populate_row(Gtk::TreeRow, boost::shared_ptr<ARDOUR::Region>) (this=0x555559836900, row=..., region=...) at ../gtk2_ardour/editor_sources.cc:433
#3  EditorSources::regions_changed
[ .. signal propagation ..]
#20 ARDOUR::Region::send_change
#21 PBD::Stateful::resume_property_changes
#22 ARDOUR::AudioRegion::_set_state
#23 ARDOUR::AudioRegion::set_state
#24 ARDOUR::RegionFactory::create
#25 ARDOUR::Session::XMLAudioRegionFactory
#27 ARDOUR::Session::load_regions
#28 ARDOUR::Session::set_state
#29 ARDOUR::Session::post_engine_init
#30 ARDOUR::Session::Session
#31 ARDOUR_UI::load_session_stage_two
#32 ARDOUR_UI::load_session
#33 ARDOUR_UI::open_recent_session
```
2021-09-19 04:56:13 +02:00
0878894c59 triggerbox: set bg color for packing table in trigger UI 2021-09-14 21:38:48 -06:00
9925147aae triggerbox: follow UI changes to Table::attach() 2021-09-14 21:18:44 -06:00
5816ca31b8 triggerbox: add some padding around button elements (mostly just testing) 2021-09-14 18:50:01 -06:00
9e60fb92c2 triggerbox: mark GUI buttons for expansion 2021-09-14 18:43:18 -06:00
932ae71cbb triggerbox: use correct table coords to position things 2021-09-14 18:29:39 -06:00
46586f3a9d triggerbox: switch GUI packer from ConstraintPacker to Table (non-functional test platform) 2021-09-14 18:29:39 -06:00
a8092461f7
Do not terminate on G_LOG_LEVEL_CRITICAL
There are cases where gtk modules log critical messages,
notably gtk-2.0/modules/libgail.so can trigger
`g_log: g_object_unref: assertion 'G_IS_OBJECT (object)' failed`,
which should not cause Ardour to terminate.
2021-09-10 23:41:33 +02:00
27b64ac36c
Remove unused headers 2021-09-10 23:41:29 +02:00
f07885ea13 triggerbox: UI part of size_t => uint64_t change 2021-09-10 13:12:40 -06:00
2e4502763c triggerbox: (slowly) evolving the launch settings dialog 2021-09-10 13:05:19 -06:00
2c499332ab
PM-GUI: add action to discover newly installed plugins
Also re-orders actions on the left sidebar, and move
"discover" to the top, and "clear" to the bottom.
2021-09-09 15:29:25 +02:00
b3cb7d6136
Update ar* start-scripts --novst option was removed with wineVST 2021-09-08 23:28:50 +02:00
746f7220b1
Fix crash on quit without session 2021-09-08 22:39:33 +02:00
2b0a1b7bb3
Prefer ArdourMessageDialog, fix window stacking on top of port-matrix 2021-09-08 22:39:33 +02:00
7f11e295b3
Report roundtrip I/O latency in the GUI 2021-09-08 22:39:32 +02:00
27c6edc0b2 scaffolding and more skeleton for trigger UI 2021-09-06 23:21:31 -06:00
405ca42e75 skeleton for trigger GUI 2021-09-06 23:21:31 -06:00
f01c8faafe skeleton for trigger GUI 2021-09-06 23:21:31 -06:00
Hector Martin
a33261df3d
Allow track views to be more than 1000 pixels tall
People have 4K displays these days; having a single maximized track is
not unusual.
2021-09-07 04:32:22 +02:00
ceabc49232 triggerbox: closing in on a one-at-a-time design (GUI edition) 2021-09-04 23:20:08 -06:00
cc32201e9c
Keep plugin-preset dialog on top of plugin-UI 2021-09-04 18:42:50 +02:00
acd7703c36 Revert "remove unused variable"
variable is actually used!

This reverts commit 5c7f318bd68ac3256d32c29b8e267e1ba99d09e3.
2021-09-04 07:18:56 -06:00
21ea579aed remove unused variable 2021-09-04 07:18:56 -06:00
78d8a2448d allow editing of triggerbox processor 2021-08-31 22:33:47 -06:00
bca2f306ea tweaks and colors for triggerbox box UI 2021-08-31 14:50:55 -06:00
19d99b0a4b fix logic of MIdiTimeAxisView::add_region() to interoperate correctly with editor source list 2021-08-28 16:00:53 -06:00
07324bd1e2 change the way source list adds new regions to match the way the region list does it
This avoids duplicates, updates rows etc
2021-08-28 15:29:44 -06:00
d5223c0c2c allow Editor source list to contain empty MIDI whole file regions 2021-08-28 15:28:41 -06:00
76a01bab63
Hide splash screen for new-user-wizard 2021-08-14 22:03:57 +02:00
f5b6f76e12
Fix Windows builds (disambiguate API calls) 2021-08-14 01:08:23 +02:00
3fe0a2f53a fix warning noted by macOS compiler 2021-08-13 14:11:41 -06:00
6ac4d37bea fixes for macOS where Rect is a MacType 2021-08-13 14:11:41 -06:00
0b2c03b0e9 post-rebase manual fixups (GUI) 2021-08-13 12:51:37 -06:00
3f47c7dcc5 triggerbox (UI): changes required by 2 possible follow actions 2021-08-13 12:51:37 -06:00
6854c66f6f triggerbox (UI): get closer to Live semantics and descriptions for follow action/launch style 2021-08-13 12:51:37 -06:00
8cea19dd25 triggerbox (UI): tweaks to fllow API changes 2021-08-13 12:51:37 -06:00
ceb0cb861e triggerbox (UI): clean up drawing of play button 2021-08-13 12:51:37 -06:00
b0914bbc41 triggerbox (UI): initialize member variable to null 2021-08-13 12:51:37 -06:00
d8d9ffaf3d triggerbox (UI): various small changes in GUI (stop buttons, mostly) 2021-08-13 12:51:37 -06:00
46a64c2eef add whole and half note quantization options 2021-08-13 12:51:37 -06:00
f681212f42 triggerbox (UI): set displayed name when region/name changes 2021-08-13 12:51:37 -06:00
45eb81e7e8 triggerbox (UI): double click on trigger "box" to load sample 2021-08-13 12:51:37 -06:00
def9392ac6 triggerbox UI: lots of work on first pass control of follow action, launch style, quantization via context menu 2021-08-13 12:51:37 -06:00
66d16fdbce triggerbox UI: dbl-click on name pops up file chooser to load sample 2021-08-13 12:51:37 -06:00
08150c1547 use pack options in trigger box UI 2021-08-13 12:51:37 -06:00
aa46a91b0c continuing tweaks to triggerbox UI 2021-08-13 12:51:37 -06:00
ccf1c4fb57 some incredibly hasic functionality for the triggerbox UI 2021-08-13 12:51:37 -06:00
d6e9805c93 triggerbox UI: tweaks while working on box packing 2021-08-13 12:51:37 -06:00
44e67c3566 small API change to provide (debug) name to canvas cursor items 2021-08-13 12:51:36 -06:00
2bad9e0a85 do not create timepos_t from timepos_t unnecessarily 2021-08-13 12:51:36 -06:00
40c29640f5 fix crash when dragging markers 2021-08-13 12:51:36 -06:00
1927e4673b remove StepSequencer, BeatBox and BeatBoxGUI from wscripts and #ifdef code occurences. Files remain 2021-08-13 12:51:36 -06:00
f00e5f3c16 extend Triggerbox GUI with a window (for now) 2021-08-13 12:51:36 -06:00
aed9adceee display triggerbox GUI window when adding a track that has one 2021-08-13 12:51:36 -06:00
e68c60b407 initial extensions for TriggerBox UI 2021-08-13 12:51:36 -06:00
a63ec8afa2 new files for triggerbox GUI 2021-08-13 12:51:36 -06:00
aa4e578780 no instrument by default on trigger tracks 2021-08-13 12:51:36 -06:00
73e19c8fa7 add triggers to trigger tracks 2021-08-13 12:51:36 -06:00
139a051b18 remove default args to Session::new_midi_track() (gui edition) 2021-08-13 12:51:36 -06:00
b6f290add2 timeline type changes for new ripple code and post-conflict-resolution fixups 2021-08-13 12:51:36 -06:00
bf50d27b68 fix timeline type use 2021-08-13 12:51:36 -06:00
f755174c5f fix timeline type use 2021-08-13 12:51:36 -06:00
757acf381e fix typo/thinko with const "division" value 2021-08-13 12:51:36 -06:00
c6370948c4 fix call to RegionMotionDrag constructor 2021-08-13 12:51:36 -06:00
40c9b1482a region move drag now requires named argument 2021-08-13 12:51:36 -06:00
6a71f9988e fix timeline type use in brush dragging 2021-08-13 12:51:36 -06:00
90264e1d0d fix timeline type use 2021-08-13 12:51:36 -06:00
9531878596 remove incorrectly retained code (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
bb87f33506 fix timeline types in region/cue marker operations 2021-08-13 12:51:36 -06:00
7415f5cc18 fix timeline type usage in region/cue markers 2021-08-13 12:51:36 -06:00
dcd3766c33 fix semi-replicated code (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
cedf875a42 fix timeline types 2021-08-13 12:51:36 -06:00
31b7244856 fix timeline types (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
03bfb91aff fix argument name (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
83b9424082 fix namespace error (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
857ca46a95 fix timeline type usage 2021-08-13 12:51:36 -06:00
1520b53aae remove obsolete method (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
3c57e4a485 fix timeline type use 2021-08-13 12:51:36 -06:00
9009bbf986 fix declaration of {Public,}Editor::do_import() (post rebase conflict resolution) 2021-08-13 12:51:36 -06:00
dec3b9bc2e cleanup mess from manual rebase against master (GUI edition) 2021-08-13 12:51:35 -06:00
bc98af7433 fix a subtle detail in loudness analysis after timeline type changes 2021-08-13 12:51:35 -06:00
7938d8de4f fix (some) editing based on tempo & meter marks
After beginning an edit operation with TempoMap::write_copy(), the tempoPoint and meterPoint objects
referenced by markers are incorrect, since they refer to the original map, not the copy we are working
on. Fix this with Editor::reassociate_metric_markers()

Some instances requiring this fix may still remain
2021-08-13 12:51:35 -06:00
52d41fa4e1 fix timeline type usage on macOS 2021-08-13 12:51:35 -06:00
bcca1ad289 minor fixups post-rebase 2021-08-13 12:51:35 -06:00
5f3ad2cde9 follow new const requirements associated with Meter/Tempo 2021-08-13 12:51:35 -06:00
011b5ec61c remove debug output 2021-08-13 12:51:35 -06:00
36609c4067 remove public ::bbt_at (INTEGER) methods, because of superclock_t/samplepos_t confusion (GUI edition) 2021-08-13 12:51:35 -06:00
2ec93062d9 use simpler logic to avoid negative values when filling grid 2021-08-13 12:51:35 -06:00
88bed837c0 fix deadlock during tempo marker dragging, and don't start a tempo map update if a tempo point is inactive 2021-08-13 12:51:35 -06:00
ce3fb0507c change return type of Tempo::set_{ramped,clamped} and fix call sites 2021-08-13 12:51:35 -06:00
68959643e8 fix minor errors from rebase fixups 2021-08-13 12:51:35 -06:00
fed449d54d various fixes to get time stretching basically working again
Time domains are not well respected at present, so more work is needed here
2021-08-13 12:51:35 -06:00
76e5aaea44 remove another NUTEMPO #warning by using TempoMap::count_bars() 2021-08-13 12:51:35 -06:00
f05b2ed93b remove another NUTEMPO #warning by allow grab starts in rubber band selection to use the default time domain 2021-08-13 12:51:35 -06:00
162d36ffc8 remove some debug output 2021-08-13 12:51:35 -06:00
6bc8a7347f improve drag behavior on AudioClock 2021-08-13 12:51:35 -06:00
3a94b45b23 rework handling of scroll and drag on AudioClock by using timepos_t rather than samples 2021-08-13 12:51:35 -06:00
6effcc7723 reimplement quantization without (much) floating point (GUI edition) 2021-08-13 12:51:35 -06:00
fb66695081 fix (and improve) drawing of "ghost note" drawn while mouse pointer moves in MidiRegionView in draw mode 2021-08-13 12:51:35 -06:00
1868c4cac5 fix drawing percussive notes in MidiRegionView following nutempo SNAFU with relative time calc. 2021-08-13 12:51:35 -06:00
7244b03385 convert NoteCreateDrag::grid_aligned_beats() into a proxy for Editor::snap_to_bbt() 2021-08-13 12:51:35 -06:00
831c085b2e remove MidiRegionView::snap_sample_to_grid_underneath() and replace with calls directly into Editor snap method 2021-08-13 12:51:35 -06:00
37eea1da29 fix brace style 2021-08-13 12:51:35 -06:00
b2655d13f1 make Editor::snap_to_bbt() public 2021-08-13 12:51:35 -06:00
0ddfd7c873 force drag-created regions to use beat time for position 2021-08-13 12:51:34 -06:00
49424ab0e3 Region::_start should be a timepos_t not a timecnt_t (GUI edition) 2021-08-13 12:51:34 -06:00
485b74e0b9 rename EditorSummary::Position as Editor::SummaryPosition 2021-08-13 12:51:34 -06:00
e5d505365f rename ProcessorBox::Position as ProcessorBox::ProcessorPosition 2021-08-13 12:51:34 -06:00
daad7b74ae libtemporal: rename TempoMap::full_duration_at() to ::convert_duration() and reorder parameters 2021-08-13 12:51:34 -06:00
dad56af802 remove another 3 NUTEMPO #warnings
These all involve converting between ControlList-relative time and absolute time
2021-08-13 12:51:34 -06:00
a71ba473f7 fix up post-rebase issues after rebase on master 2021-08-13 12:51:34 -06:00
45a8da77f6 clean up rulers/grid mess after rebase on master 2021-08-13 12:51:34 -06:00
0162d3f9d6 GUI changes to *try* to adapt to a world without explicit beats<->samples converter objects (i.e. use AutomationLine::get_origin() instead 2021-08-13 12:51:34 -06:00
48ac681b03 fix note-resizing-at-front, change variable names 2021-08-13 12:51:34 -06:00
9a9bc3408f fixups for xrun-marker work, now that Region::sample() and Region::length() so not return sample types 2021-08-13 12:51:34 -06:00
6536655a0a add explanatory comment 2021-08-13 12:51:34 -06:00
21e6f1cf50 (mostly) fix note drag creation drawing 2021-08-13 12:51:34 -06:00
b66b98ce58 remove 2 more NUTEMPO warnings by use Editor::default_time_domain() appropriately (but perhaps without enough user control) 2021-08-13 12:51:34 -06:00
39f52cd3ce remove unused and unnecessary Drag::snap_delta_music() code 2021-08-13 12:51:34 -06:00
cb66ae496c don't even pretend to use non-modal dialog API for the BBT marker dialog 2021-08-13 12:51:34 -06:00
d4f52498fa somewhat working dialog for BBT/Position marker creation 2021-08-13 12:51:34 -06:00
4911779157 manual fixups after a rebase against master 2021-08-13 12:51:34 -06:00
5153124664 change (GUI) Marker objects to accept any Canvas::Item as parent, and use this to draw BBT position markers in the BBT ruler 2021-08-13 12:51:34 -06:00
4f1ad4ed0d start adding new BBT marker support 2021-08-13 12:51:34 -06:00
432fbe984a make "add BBT marker" test case use 3|1|0 for better testing 2021-08-13 12:51:34 -06:00
2445081dcc remove another NUTEMPO #warning - this one was just unnecessary concern 2021-08-13 12:51:34 -06:00
0f67dbf8cc remove another NUTEMPO #warning - use time domain of region's track for content trim dragging 2021-08-13 12:51:34 -06:00
18fba5dece whitespace adjustments 2021-08-13 12:51:33 -06:00
fe352311f6 make shift-leftclick on bbt ruler set that time to be 3|2|0 (experiment - GUI dialog to follow) 2021-08-13 12:51:33 -06:00
c22c8ed69f get TempoMarkerDrag and BBTRulerDrag to compile 2021-08-13 12:51:33 -06:00
c5c14e2416 remove two nutempo #warnings - initialize timecnt_t() using timedomain of route with first selected region (ripple dragging) 2021-08-13 12:51:33 -06:00
9d4d3908e6 remove some nutempo #warnings and fix up Location time domain API 2021-08-13 12:51:33 -06:00
a8f9f268b4 use integer division when computing tempo map positions from SMF data 2021-08-13 12:51:33 -06:00
97a3469972 use new Tempo API in two places where Tempo is explicitly constructed 2021-08-13 12:51:33 -06:00
888239a834 remove dual (x,y) version of AutomationLine::view_to_model_coord()
The x-axis coordinate was never transformed or modified anyway (6.x just changed it
from double to integer and back again!)
2021-08-13 12:51:33 -06:00
d131a9aa12 remove debug output 2021-08-13 12:51:33 -06:00
80f543dc17 fix missing conversions between samples & superclock for ruler display 2021-08-13 12:51:33 -06:00
068cc4135f remove another NUTEMPO #warning (see comment) 2021-08-13 12:51:33 -06:00
f321dd4dac remove NUTEMPO #warning (comment explains more) 2021-08-13 12:51:33 -06:00
87dfef28f6 allow new locations creation from playhead to use default time domain 2021-08-13 12:51:33 -06:00
874a009d76 remove NUTEMPO #warning (comment explains more) 2021-08-13 12:51:33 -06:00
9c1e88e675 remove NUTEMPO #warning (dealt with in caller) 2021-08-13 12:51:33 -06:00
e4e953df14 no need to copy-construct here 2021-08-13 12:51:33 -06:00
7e6f0ea2bb remove NUTEMPO warning 2021-08-13 12:51:33 -06:00
b39a771655 start using Editor::canvas_event_time(), initially just in the button release handler 2021-08-13 12:51:33 -06:00
6a44dcbdad add Editor::canvas_event_time()
See comments in header for more
2021-08-13 12:51:33 -06:00
0114059c9d nutempo warning removal 2021-08-13 12:51:33 -06:00
5074553f15 add Editor::default_time_domain()
Not 100% certain about the logic here, but at least the method exists now
2021-08-13 12:51:33 -06:00
6f861c63b5 nutempo #warning removal 2021-08-13 12:51:33 -06:00
c03b588011 nutempo #warning removal 2021-08-13 12:51:33 -06:00
125c20e148 manual fixups for recent rebase conflicts left in the wrong state (GUI edition) 2021-08-13 12:51:33 -06:00
d671dc0fa1 plugins use their route's automation time domain (GUI edition) 2021-08-13 12:51:33 -06:00
a81e2f9ff9 Automatable now requires (and owns) a time domain to be used by automation data (GUI edition) 2021-08-13 12:51:32 -06:00
7762dde95e remove another NUTEMPO warning by connecting AudioClock to static MapChanged signal 2021-08-13 12:51:32 -06:00
42c74932a5 fixes/improvements for meter marker drags 2021-08-13 12:51:32 -06:00
b0b346c4ac fix deadlock caused by not unlocking TempoMap when not finishing a meter-marker-drag 2021-08-13 12:51:32 -06:00
e393c5efcf manual fixups for rebase against master (timeline type changes) 2021-08-13 12:51:32 -06:00
b0725a8ab9 use new TempoMap::abort_update() API when drag does not end in map update 2021-08-13 12:51:32 -06:00
e653e61923 fix up redrawing Tempo/Meter rulers when tempo changes 2021-08-13 12:51:32 -06:00
3c857b697f fix incorrect call to Tempo constructor that reordered note type and end tempo
Probably should find a better API for the constructor that makes this impossible
2021-08-13 12:51:32 -06:00