13
0
Commit Graph

11617 Commits

Author SHA1 Message Date
82cb046fa3 if actively recording, prevent interaction between mouse and audio clock widget(s) 2017-05-31 13:04:26 -04:00
da021ef08f Credit where credit is due 2017-05-29 23:48:17 +02:00
b21c4b41a3 when creating a new session after working on one, the "Cancel" button should be a quit button.
This avoids ending up with a null Session pointer in the GUI (#7369)
2017-05-29 15:35:03 -04:00
54efcbaa35 Update Russian translation 2017-05-26 12:45:08 +02:00
af8d027fc5 Remove attempt to retrieve invalid Meterbridge properties
The property names with underscores are "normalized" to replace the underscores
with hyphens in the XMLProperty constructor from within Meterbridge::get_state
and so have always been written with hyphens.
2017-05-26 08:48:04 +10:00
3747d1688c Use correct property names in Meterbridge::get_state()
These property names have been "normalized"/changed to use a hyphen in the
XMLProperty ctor since 2008. That is before the Meterbridge existed so there
should be no files existing that contain these properties with underscores.
2017-05-26 08:48:04 +10:00
c72e3f16a1 Use correct property names for Editor transport controllable state
These are normalized in the PBD::XMLProperty ctor, which is why
Editor::get_transport_controllable_state() uses the hyphenated names to
retrieve the properties and will not result in any state format change.
2017-05-26 08:48:04 +10:00
a48f0cfd63 Pretty print control-outputs in generic-UI 2017-05-25 13:49:18 +02:00
7c6a62452d Remove unused header file in gtk2_ardour 2017-05-23 09:23:34 +10:00
29447f48eb Remove dead assignment in Editor::export_audio() 2017-05-23 09:13:27 +10:00
42441d322d Remove dead assignment in Editor::metric_get_bbt 2017-05-23 09:13:27 +10:00
3b8afbcd00 Remove dead assignment in MiniTimeline::draw_edge 2017-05-23 09:13:27 +10:00
Nil Geisweiller
8242f4f636 Support note name editing in midi list editor 2017-05-14 18:16:24 +02:00
André Nusser
77a2632e34 Fix compiler warning of unused variable. 2017-05-14 18:15:10 +02:00
Edgar Aichinger
c55c814177 one more update to german translation 2017-05-14 16:09:53 +02:00
Edgar Aichinger
278d5bdab2 update german translation 2017-05-14 15:29:27 +02:00
2fe3bac92f yet another stupid typo 2017-05-14 15:15:10 +02:00
André Nusser
092ce6dc01 Fix double "Tape" in Record Mode drop down when adding new track.
This bug probably also lead to "Tape" being shown in mixbus even
though it should not.
2017-05-14 14:28:29 +02:00
3aa3413944 Fix use-after free (signal after deleting group) 2017-05-14 12:00:19 +02:00
f806799c1c Fix typos (thanks edogawa) 2017-05-13 20:33:04 +02:00
38285d0e54 Remove cfgtool, it's not useful anymore
cfgtool was used to dump the current config defaults into ./system_config
on the system it runs. It was manually invoked (usually on Linux) and
hence produced incorrect settings for Windows and OSX variants.

Since ea4bbcf5 Ardour binaries bundle a minimal empty system_config,
and the built-in defaults are used (correct for every platform).
2017-05-12 16:35:08 +02:00
eb3f50e15c change the way ControlProtocols (control surfaces) are notified and handle Stripable selection changes
The Editor continues to notify them, but via a direct call to ControlProtocolManager, not a signal.
The CP Manager calls the ControlProtocol static method to set up static data structures holding
selection info for all surfaces and then notifies each surface/protocol that selection has changed.
2017-05-12 14:51:39 +01:00
24d5f1a624 Tweak/fix splash screen event-loop
Prevent possible endless loop in Splash::display() and handle
some related edge-cases and race conditions WRT expose_done
and is_visible().
2017-05-11 14:20:56 +02:00
26593d08ed NO-OP: whitespace 2017-05-11 14:20:56 +02:00
b4346862e1 context click on marker > loop range should set loop range 2017-05-11 13:16:07 +01:00
2b33d35e5c Remove ambiguity to keep MSVC happy
NB: Do we really need 'floor()' here?? (we seem to be multiplying integers)
2017-05-10 12:22:57 +01:00
7b0ac0e20a ArdourButton: Pick up initial action sensitivity
e.g. monitor-section show/hide button
2017-05-10 00:26:02 +02:00
0e6e6cfde6 Remember Monitor-section state (show/hide, attached/detached) 2017-05-10 00:26:02 +02:00
2c7cb9065f Limit clock displays to 30days (720hours) by default.
This prevents various edge-cases of selection-clocks (eg. unbound range
selection after start-range; and makes it near impossible to roll-over
2^63 using GUI operations)
2017-05-08 12:37:17 +02:00
7b2063d62d remove misc. debug output 2017-05-08 10:41:12 +01:00
8ddbbe427d when a Route is removed, don't bother triggering a sync-presentation-info-from-treeview because it isn't necessary
Also, don't update mixer selection unless selection actually changed
2017-05-08 10:40:27 +01:00
d51049f343 when a Route is removed, don't bother triggering a sync-presentation-info-from-treeview because it isn't necessary 2017-05-08 10:40:27 +01:00
Hiroki Inagaki
eb133dd934 Update Japanese translation 2017-05-08 11:02:24 +02:00
26decc032c -Wnon-virtual-dtor 2017-05-06 15:52:32 +02:00
69f61936ff part two of add missing files from selection development branch(es) 2017-05-05 19:26:10 +01:00
35a9facdae add missing files from selection development branch(es) 2017-05-05 19:25:35 +01:00
a84b1a375a Editor::axis_view_by_control() needs to explore child tracks, now that Selection is relying on it 2017-05-05 18:56:25 +01:00
589f6f67a3 maintain CoreSelection order in GUI track selection 2017-05-05 18:56:25 +01:00
dc0139d4af use CoreSelection for track selection 2017-05-05 18:56:25 +01:00
8335155863 fix ruler scaling -- #7226 2017-05-05 14:00:30 +02:00
95f225df8f Scaleable group-tabs: use Pango to layout text, scale with UI #7331 2017-05-04 19:15:18 +02:00
4aeb086fe3 Scale scommer and piano-keyboard width with GUI 2017-05-04 17:22:43 +02:00
ed4d17a8ff Update Tempo Tapping:
* Allow tap with keyboard (Space, Enter)
* Ignore double-clicks (2nd rapid event skewed calculation)
2017-05-04 16:13:10 +02:00
0afd18eb5d NO-OP: whitespace 2017-05-04 00:43:40 +02:00
a23ac120f2 The return of explicit exclusive solo. 2017-05-04 00:42:07 +02:00
0b189a5766 GUI update: migrate group-color into the session (not GUI state) 2017-05-03 17:53:00 +02:00
ba24f287ca Make -A open action list in a browser instead of command terminal. 2017-04-29 22:47:24 -07:00
0bb0dbad68 Time flies 2017-04-30 01:22:25 +02:00
57e9de232b Fix copy/paste typos in --help 2017-04-30 01:22:25 +02:00
73e80b4429 Set -b to open in browser. 2017-04-29 15:37:31 -07:00
dc3ae8d196 Add a "select topmost" track editor action 2017-04-29 12:38:53 +02:00
e508d41091 NO-OP: whitespace 2017-04-29 12:38:53 +02:00
820d1340d6 Missed a spot in adding -A, fixed 2017-04-28 08:44:35 -07:00
620f3b9358 Change actions to -A and use -b to output keybindings 2017-04-28 08:19:20 -07:00
cbe1f5d395 extend 3cda0e2a: Don't switch to range-mode if not needed for similar OPs. 2017-04-28 15:07:41 +02:00
3cda0e2a93 When in smart-mode, don't switch to range-mode after "set range selection"
closes #7332
2017-04-28 14:57:13 +02:00
a8b545661f Open session folder when selecting path 2017-04-28 14:33:06 +02:00
ecda1a8f55 Allow "remove from recent" only for top-level 2017-04-28 14:32:37 +02:00
1ebf35f137 Allow to hide engine dialog w/o unloading session. 2017-04-27 21:10:37 +02:00
6ece6ed407 EngineDialog: immediadely push latency changes to running backends 2017-04-27 21:10:10 +02:00
2039fc6fd0 Don't directly call into engine to stop latency detection. 2017-04-27 19:45:56 +02:00
f9f9006a90 Consistent button visibility (mixer-strips + VCAs) 2017-04-27 00:25:57 +02:00
1398dd8914 Fix nested VCA assigns and mixer-layout:
Show initial VCA assign button on all mixer-strips and VCAs if
there's no assignment.
2017-04-27 00:11:18 +02:00
0b5db91ee9 AutomationLine time-unit conversion and paste API update
This fixes copy/paste of MIDI automation (time-unit: beat) from/to
Parameter automation (time-unit: samples).

It also fixes repeatedly pasting with tempo-ramps: pre-multiply length
before converting to samples.
2017-04-26 23:37:27 +02:00
8bb26628e3 Skip script-setup if there are no parameters (and name is unique) 2017-04-26 19:45:22 +02:00
35aa4f692a Lua Dialog refinements:
* Add Heading Widget
* Swap OK/Cancel Buttons
* Update table layout (spacing + alignment)
* Some whitespace tweaks
2017-04-25 16:45:18 +02:00
f5995661d0 Lua: Action Script Dialog & MessageBox 2017-04-25 14:01:22 +02:00
a6ace9996b Expose ArdourDropdown's menu for submenu packing 2017-04-25 11:29:07 +02:00
87acc60674 Remove old special case (ArdourDialog::on_response hides the dialog) 2017-04-25 03:55:51 +02:00
1b2bc203ac Add regions at once rather than individually when restoring Selection state
This is a workaround for performance issues with the current implementation
when adding many regions to the selection one at a time.

If the Selection implementation was to change at some point and adding regions
to the selection only takes a small constant amount of time, then this
optimization may no longer be necessary.

Related to: #7274
2017-04-24 08:41:30 +10:00
68883cbb56 Changed "ardour" to PROGRAM_NAME 2017-04-22 15:32:48 -07:00
c0df127dc4 Close all dialogs when closing a session (not only at exit). 2017-04-22 23:06:22 +02:00
b81d6a6160 Set -b switch to only two columns, correct options text. 2017-04-22 08:07:35 -07:00
e54413ee46 amend be62d335ee 2017-04-22 01:06:54 +02:00
be62d335ee fix endless loop when clicking on the canvas w/o backend 2017-04-21 23:54:33 +02:00
5d5642d6ec Add HTML output for -b so that output can replace actions page in manual. 2017-04-21 12:58:59 -07:00
bdd960cd99 Update preferences when Ctrl-surfaces change with session. 2017-04-21 04:08:00 +02:00
4cda36f63f squelch "curl failed: No Error" 2017-04-21 00:12:20 +02:00
e1c4fe8edc Show the splash-screen if the engine dialog's run() hid it. 2017-04-20 23:16:09 +02:00
057bb167ca Run gtk-main iteration after hiding dialogs 2017-04-20 23:15:13 +02:00
d4f91010c3 Do not set C++ locale.
Ardour translations and GUI string formatting only depends on the C locale.
Modifying the C++ locale may produce erratic results on various systems
(in particular OSX and macOS) and cause incompatibilies with plugins.
2017-04-20 22:12:18 +02:00
9218ccb3b2 Fix crash when clicking on the canvas while un/loading a session.
GTK events are still handled while un/loading a session (e.g display
"Loading" message or showing the splash triggers an event-loop run).
Global canvas elements (e.g. Rulers) may respond to session-specific
actions.
2017-04-20 19:41:06 +02:00
39c2b544f0 Keep Dialogs which report process around.
Since 5.8-245-g3e43585fa, a response hides the dialog Window
in ArdourDialog::on_response (to prevent dialogs windows staying
around unresponsively while Ardour does background work).
This logic does not apply to Dialog Windows which implement
ProgressReporter or support dialog responses other than OK, Close.
2017-04-20 19:03:52 +02:00
24699d3be4 Changes needed for building Tim's new 'string_convert' stuff with MSVC (gtk2_ardour) 2017-04-19 17:25:53 +01:00
da8146f011 Use PBD::to_string in AutomationTimeAxis instead of boost::lexical_cast and string_compose 2017-04-19 09:37:02 +10:00
f597bb5ed7 Use PBD::to_string() from pbd/string_convert.h in VCATimeAxisView 2017-04-19 09:37:01 +10:00
b05ce6fb34 Use PBD::to_string from pbd/string_convert.h in VCAMasterStrip class 2017-04-19 09:37:01 +10:00
addbc86874 Use PBD::to_string from pbd/string_convert.h in SoundFileBox class
Numeric formatting is equivalent.
2017-04-19 09:37:01 +10:00
2889a44a33 Use PBD::to_string from pbd/string_convert.h in RouteTimeAxis
Numeric formatting is equivalent as LC_NUMERIC=C in global C++ locale
2017-04-19 09:37:01 +10:00
99ee7d7b61 Use PBD::to_string from pbd/string_convert.h in MixerStrip class
The numeric formatting is equivalent. Even though this string is being used in
the UI as a label I think this is another case where we don't want a localized
numeric string, which would only be relevant with a track count >=1000.
2017-04-19 09:37:01 +10:00
e157a84c2b Use PBD::to_string from pbd/string_convert.h in MeterStrip class
The numeric formatting is equivalent. The string is being used in a label so it
could be argued that we want localized numeric formatting in this case, but as
it is only relevant if we have >=1000 meter strip keep it the same for now.
2017-04-19 09:37:01 +10:00
31a2957700 Use PBD::to_string from pbd/string_convert.h in ExportTimespanSelector
The C++ global locale is currently set to LC_NUMERIC=C by the first instance of
LocaleGuard so this change means numeric formatting is equivalent.

As the string is being used to construct a label, perhaps we do want to
generate localized numeric formatting in this case. Anyway keep it the same for
now.
2017-04-19 09:37:01 +10:00
c149d7d64c Use PBD::to_string() from pbd/string_convert.h in ControlSlaveUI
The numeric formatting is equivalent.
2017-04-19 09:37:01 +10:00
e15524cc64 Use PBD::to_string instead of std::ostream when setting up video server url
To avoid issues with locales that use grouping/thousands separators.
2017-04-19 09:36:59 +10:00
ab30f45bba Use PBD::to_string to convert period count in EngineControl class
The functionality is the same so might as well use it.
2017-04-19 09:36:59 +10:00
0739bada9e Use PBD::to_string to convert bufsize to string in EngineControl class
string_compose uses std::ostream/stringstream which will insert thousands
separators in some locales. This was not a problem when LocaleGuard set the
global C++ locale to "C"
2017-04-19 09:36:59 +10:00
df2b0e33b9 Use PBD::string_to functions in VideoUtils::video_query_info
LocaleGuard is in use so float <=> string conversions must be expected in C
locale format
2017-04-19 09:36:59 +10:00
e7a23eaaa8 Use snprintf instead of std::stringstream when converting color values to strings
std::ostream/stringstream will use the current locale to determine the numeric
formatting. If the locale uses grouping then thousands separators will be
inserted in the output which produces an invalid color string in
UIConfiguration::reset_gtk_theme() and when converting colors to strings in
UIConfiguration::store_color_theme()

This has not been a problem so far because it appears that LocaleGuard does not
reset the LC_NUMERIC value for the global C++ locale. So if a LocaleGuard is
created at any time before these functions are called(even if it goes out of
scope) the numeric formatting used by std::streams will use the "C" locale
formatting facets.
2017-04-19 09:36:59 +10:00
71fc5b9e8b Use PBD::string_to<bool> in MidiTimeAxisView class
As the conversion was performed with PBD::to_string
2017-04-19 09:36:59 +10:00
b540817b5b Use PBD::string_to<bool> in RouteTimeAxisView class
As they were converted from bool to string using PBD::to_string
2017-04-19 09:36:59 +10:00
edb9868e76 Remove conditional checks that are always true in RouteTimeAxisView class 2017-04-19 09:36:59 +10:00
8e07e4bd68 Use AxisView::get/set_gui_property API in RouteTimeAxisView class 2017-04-19 09:36:58 +10:00
634207dd6a Use AxisView::get/set_gui_property API in MixerStrip class 2017-04-19 09:36:58 +10:00
13d2670e96 Use AxisView::get_gui_property API in AutomationTimeAxis class 2017-04-19 09:36:58 +10:00
de80767c8c Use AxisView::get_gui_property in AudioRegionView class 2017-04-19 09:36:58 +10:00
2c4e801183 Use AxisView::get_gui_property API in TimeAxisView class 2017-04-19 09:36:58 +10:00
be59503364 Use AxisView::get_gui_property API in AxisView class 2017-04-19 09:36:58 +10:00
9d2d0ddf00 Add AxisView::get_gui_property method, use PBD::string_to<T> for string conversion 2017-04-19 09:36:58 +10:00
66004a5036 Use PBD::to_string to convert non-string types in AxisView::set_gui_property 2017-04-19 09:36:58 +10:00
7fdbabcd79 Let AxisView::set_gui_property perform type conversion in TimeAxisView::set_height 2017-04-19 09:36:57 +10:00
a6d71df0d0 Use XMLNode::get_property in AudioClock class 2017-04-19 09:36:57 +10:00
1534a2a4d1 Use XMLNode::get/set_property API in VideoTimeLine class 2017-04-19 09:36:57 +10:00
47f1183a15 Use XMLNode::set_property API in VideoMonitor class 2017-04-19 09:36:57 +10:00
b00b83f95a Use XMLNode::set_property API in UIConfiguration class 2017-04-19 09:36:57 +10:00
3ba34e13b1 Use XMLNode::get/set_property API in SelectionMemento class 2017-04-19 09:36:57 +10:00
8219e3c6ee Use XMLNode::get/set_property API in Selection class
There were many possible value truncations occuring and some precision loss
with the double conversions.
2017-04-19 09:36:57 +10:00
5b97b1a191 Use XMLNode::get/set_property API in ProcessorBox and ProcessorWindowProxy classes 2017-04-19 09:36:56 +10:00
657e32290e Use XMLNode::get/set_property API in ProcessorBox class 2017-04-19 09:36:56 +10:00
5cd88fa050 Use XMLNode::get/set_property API in MeterBridge class 2017-04-19 09:36:56 +10:00
4bf8f9f1a8 Use XMLNode::set_property API in LuaInstance class
Didn't seem worth converting from XMLNode::property API to
XMLNode::get_property and there may be some ordering issues.
2017-04-19 09:36:56 +10:00
a2c1e79660 Use XMLNode::get/set_property API in LocationUI class 2017-04-19 09:36:56 +10:00
7cb78301eb Use XMLNode::get/set_property API in Keyboard class 2017-04-19 09:36:56 +10:00
5b71470449 Use XMLNode::get_property API in AutomationTimeAxis class 2017-04-19 09:36:56 +10:00
8d90723e8c Use XMLNode::set_property API in GUIObject class 2017-04-19 09:36:56 +10:00
0bfdab738b Use XMLNode::get/set_property in ExportVideoDialog class 2017-04-19 09:36:56 +10:00
a8420d4b6b Use XMLNode::get/set_property API in EditorRulers class 2017-04-19 09:36:56 +10:00
df33a6e53a Use XMLNode::get/set_property API in EditorRegions class 2017-04-19 09:36:56 +10:00
346123e619 Use XMLNode::set_property API in ARDOUR_UI class 2017-04-19 09:36:55 +10:00
41493d556a Use XMLNode::get/set_property API in ARDOUR_UI class 2017-04-19 09:36:55 +10:00
dcc21b19a9 Add AudioClock::on() method as convenience method for serialization 2017-04-19 09:36:55 +10:00
d41d612276 Use XMLNode::get/set_property API in Mixer_UI class 2017-04-19 09:36:55 +10:00
8d6df23ebc Remove unused header include in video_timeline.cc 2017-04-19 09:36:55 +10:00
a4b9014932 Use XMLNode::get/set_property API in Editor class 2017-04-19 09:36:55 +10:00
800112c3b7 Use XMLNode::get/set_property API in EngineDialog class
Fixes many of the type conversions but I doubt any would have been an issue.

LocaleGuard is no longer necessary
2017-04-19 09:36:55 +10:00
697f0ce5e1 Add PBD::to_string/string_to template specialisations for types in editing.h 2017-04-19 09:36:55 +10:00
6ee1e4d6dd Add PBD::to_string/string_to template specialisations for types in enums.h 2017-04-19 09:36:55 +10:00
2b58bbd50a Use PBD string conversion functions in PBD::ConfigurationVariable
No longer need a specialization for bool as PBD::to_string/string_to already
has specializations for bool

Remove template specialization for float as string_to/to_string handles string
representations of infinity
2017-04-19 09:36:47 +10:00
cb3c564822 Use int32_t type instead of long for font-scale UI configuration variable
long type can not be used with PBD::to_string/string_to
2017-04-19 09:36:47 +10:00
3edb6b2e1f Use PBD string conversion functions in PBD::Property class 2017-04-19 09:36:47 +10:00
fda05ac64b Use ID::to_s() in gtk2_ardour instead of ID::print() 2017-04-19 07:49:58 +10:00
18dcd4d7ff FP8: Configuration UI layout & design (add image, separators) 2017-04-15 15:19:58 +02:00
cooltehno
57dfc0ffb1 Update blueberry_milk-ardour.colors 2017-04-14 13:22:18 -07:00
a8858ad311 Fix toggle-processors: operate on plugins only 2017-04-14 00:53:45 +02:00
d43a23fe28 Faderport8 control surface support 2017-04-13 21:21:59 +02:00
bcab83205b Keep the RhythmFerret dialog window around after using an action.
Since 5.8-245-g3e43585fa, a response hides the dialog Window
in ArdourDialog::on_response (to prevent dialogs windows staying
around unresponsive while Ardour does background work).

The RF is special, and also the only dialog using explicit
add_action_widget().
2017-04-07 00:29:21 +02:00
43a07bab51 mini-timeline: show labels for outside range markers 2017-04-03 16:14:01 +02:00
54bab5153f don't set region selection on loading a session 1 by 1, but just once after they should all exist 2017-04-03 00:33:44 +02:00
f201726286 NO-OP: whitespace 2017-04-03 00:33:44 +02:00
907fbdd19e Minitimeline: show markers immediately left/right of viewpoint 2017-04-02 22:20:12 +02:00
77e8c0c4df GUI options for rec-only metronome 2017-04-01 23:56:27 +02:00