ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity
34,721 Commits 90 Branches 19 Tags 258 MiB
Commit Graph

34721 Commits

Author SHA1 Message Date
Robin Gareus e6a7f302e7
Skeleton for new backend 2022-02-28 15:06:08 +01:00
Ben Loftis 3280523e90 trigger_ui: pixel pushing for mac 2022-02-26 13:09:41 -06:00
Todd Naugle dd1156e900 Improved reporting of glib throw errors during session creation 2022-02-23 17:32:09 -06:00
Todd Naugle 2217e8d9ce Log text passed to a dialog needs escaped to avoid markup errors 
For example, the following log text creates a markup error that results in
the session loading dialog being completely empty.

WARNING: VST3<C:\Program Files\Common Files\VST3\Plugins.VST.Someplugin.vst3\Contents\x86-win\Plugins.VST.Someplugin.vst3>: Invalid Module Path
...

Gtk-WARNING **: 16:46:28.447: Failed to set text from markup due to error parsing markup: Error on line 7 char 40: ?Files\Common? is not a valid name: ?\?
 2022-02-23 10:25:46 -06:00
Paul Davis 8408d5916c triggerbox: if we find a cue marker, we are no longer locate armed 2022-02-22 22:00:11 -07:00
Paul Davis 4048118926 triggerbox: stop-all-cues cue event now stops all running triggers 
This is done regardless of whether or not the trigger was started by a cue or individually
 2022-02-21 21:06:17 -07:00
Paul Davis e8dc95ded5 NOOP: whitespace conventions 2022-02-21 16:13:48 -07:00
Paul Davis 2eda6d1865 initialize sync mark/line in Region copied from another region 2022-02-21 16:13:30 -07:00
Paul Davis 20d4a9b935 remove debug output 2022-02-21 15:02:08 -07:00
Paul Davis 11fd0b84b1 derive TriggerUI from sigc::trackable so that it can be automically disconnected from signals 
The explicit disconnect in the destructor prevents any more signal->connection firing, but the invalidator
is required to remove existing queued slot calls in the receiving thread
 2022-02-21 15:01:36 -07:00
Paul Davis 87bcd4d83b Revert "derive TriggerUI from sigc::trackable so that it can be automically disconnected from signals" 
This reverts commit 06eb154db2.
 2022-02-21 13:40:56 -07:00
Paul Davis 06eb154db2 derive TriggerUI from sigc::trackable so that it can be automically disconnected from signals 
Note: this still seems suspicious: we explicitly disconnected from signals in the destructor. However,
it is better form to be able to use invalidator() in the connection call
 2022-02-21 13:28:17 -07:00
Paul Davis 28db0c1d2b triggerbox: fix logic error in handling of locate-while-playing-triggers 2022-02-21 12:45:13 -07:00
Paul Davis 92d82866e0 temporal: add some basic BBT time tests 
Some of the subtraction tests may need revising because it is not immediately clear that the
current answers are correct.
 2022-02-21 11:55:44 -07:00
Paul Davis 47bf18101b triggerbox: don't set transition times when we are not transitioning 
At some point during code refactoring, we ended up setting up the 3 transition times, intedned
to define when the *previous* transition occured, as we checked to see if a transition
would occur during this ::run() call. This led to (in particular) MIDI clips ending early,
because the transition_beats value was set to the *next* (upcoming) transition, and we used
this to define the timeline position of MIDI events
 2022-02-20 11:00:01 -07:00
Paul Davis 685a3ebc7e do not use a write copy of the tempo map when not planning to modify the map 2022-02-20 09:31:23 -07:00
Paul Davis b9de15d285 triggerbox: split apart semantics of WaitingToStop 
This allows for a different quantization to be used when WaitingToSwitch,
used when we explicitly start a different Trigger. When "just stopping"
we continue to use 1 bar quantization; when switching to a different
Trigger we use the quantization of the next Trigger
 2022-02-20 09:20:47 -07:00
Paul Davis 61b728bdcc more avoidance of double initialization 2022-02-19 16:42:03 -07:00
Ben Loftis 08768e8185 draw the Stop All Cues marker as a square 2022-02-19 13:39:59 -06:00
Ben Loftis c7dbfb9961 trigger_ui: add a hint re: randomness of selections in the Multi-Jump dialog 2022-02-19 12:34:45 -06:00
Ben Loftis ee9e7589ee trigger_ui: add more tooltips 2022-02-19 12:12:43 -06:00
Ben Loftis ab44c9a750 trigger_ui: add some tooltips 2022-02-19 11:49:01 -06:00
Ben Loftis 5f0c7fe3d6 move cue-behavior to session config (gtk part) 2022-02-19 11:49:01 -06:00
Ben Loftis b506a243a2 move cue-behavior from rc_configuration to per-session config 2022-02-19 11:48:56 -06:00
Paul Davis dcdfd3ff0f no need to repeat initialization 2022-02-19 09:03:48 -07:00
Paul Davis 4ae5c04fd7 remove duplicate sync_mark member in AudioRegionView (decl'd in RegionView) 2022-02-19 09:03:36 -07:00
Paul Davis 3bfcfe178d triggerbox: some work towards keeping GUI state in sync with "Play Cues" 
This still needs some mechanism to request a fast-forward when "Play Cues" is enabled
in a (G)UI thread
 2022-02-19 08:53:30 -07:00
Paul Davis a01325c693 triggerbox: NOOP: whitespace cleanup 2022-02-18 18:02:56 -07:00
Paul Davis 1e7ca734d6 triggerbox: reapply change in 9abc4642 with more explanatory comments 2022-02-18 18:01:52 -07:00
Paul Davis 00185aadcf triggerbox: leave a possibly helpful comment 2022-02-18 12:57:14 -07:00
Paul Davis f5ef5f44a3 triggerbox: include change intended to be in cb815bf8d 
This properly splits the condition into "before final beat" and
"after final beat"
 2022-02-18 12:57:14 -07:00
Paul Davis 66b9bc5c40 triggerbox: alter several DEBUG_TRACE statements 2022-02-18 12:57:14 -07:00
Paul Davis fe76432061 triggerbox: help MIDITriggers find their ends consistently 2022-02-18 12:57:14 -07:00
Paul Davis 19f6a6a739 triggerbox: during fast-forward, if there's nothing to do, set_currently_playing to null 
if left non-null, the next TriggerBox::run() method will start the transport
rolling.
 2022-02-18 12:57:14 -07:00
Paul Davis 8a36f9fce8 triggerbox: reset _loop_cnt to zero on shutdown 
This helps with preventing _loop_cnt incrementing to unintended values.
 2022-02-18 12:57:14 -07:00
Paul Davis 0762ef4f35 triggerbox: remove Playout enum from enums registation 2022-02-18 12:57:14 -07:00
Paul Davis 401e5a572c triggerbox: clean up comments for Trigger state decls 2022-02-18 12:57:14 -07:00
Paul Davis 4b7c0448e4 triggerbox: remove Playout as a possible state and use a separate bool 
A trigger can be in a playout state when we decide to change its
state to WaitingToStop (e.g. due to a cue marker). This design
leaves the playout condition "in effect" despite the state changing.
 2022-02-18 12:57:14 -07:00
Ben Loftis fbbe74a530 triggerbox: revert gain() as a queued UISTate value 
It's impractical/impossible to set the gain if you have to wait for a retrigger
 2022-02-18 11:15:43 -06:00
Paul Davis c09ffd4fcd triggerbox: consolidate ::start_and_roll_to() across Audio & MIDI triggers 
This uses a mild trick to pass both the object and ptr-to-member-function from the child class
to the parent class.

Note: before this commit, both instances of ::start_and_roll_to() were identical.
 2022-02-15 16:24:01 -07:00
Paul Davis e75a8ab77c triggerbox: clarify handling of end-of-clip conditions 
This doesn't enter Playout state, when the final event matches the predicted
final beat, but also returns the correct number of frames covered
 2022-02-15 15:28:01 -07:00
Ben Loftis 9abc4642ed triggerbox: fix midi timing in the case where a note-off arrives exactly at the end of the clip (amends cbbe5) 2022-02-14 21:30:23 -06:00
Ben Loftis 5a19a4fb4a tempo ruler: remove unused _name_flag for tempo markers 2022-02-14 21:22:36 -06:00
Ben Loftis 1ce0641172 trigger_ui: Stop All Cues can be queued just like the Cues can. So color it like a timeline marker(?) 2022-02-14 21:22:36 -06:00
Ben Loftis 8c41fc7dd0 meter ruler: match look of meter markers to tempo markers 2022-02-14 21:22:36 -06:00
Ben Loftis 49e792868f cue ruler: potential crash fix 2022-02-14 21:22:36 -06:00
Ben Loftis f5142fb19a tempo ruler: increase the size of tempo markers. 6pix is too small a target 2022-02-14 21:22:36 -06:00
Ben Loftis daf56ccf0a tempo ruler: do not resize marker (a grabbable object) due to tempo changes 2022-02-14 21:22:36 -06:00
Ben Loftis 111054812a mini-timeline: yet another tweak to draw Stop Cues nicely 2022-02-14 21:22:36 -06:00
Paul Davis 8741c4cc5d triggerbox: NOOP - rename template parameter for *_run<bool> to be more clear about its purpose 2022-02-14 18:13:06 -07:00