2abd8b8f06
Add a newly introduced header file to our MSVC project (libevoral)
...
This change is MSVC specific and shouldn't affect the other builds.
2015-01-10 11:58:58 +00:00
f598105966
Add support for the C99 function 'log2()' which is newly needed by 'gtk2_ardour/tempo_lines.cc' (but isn't available from MSVC).
...
These changes are MSVC specific and shouldn't affect the other builds.
(incidentally, libpbd already offers a function called 'fast_log2()'. Not sure if that could have been used instead...)
2015-01-10 11:56:24 +00:00
0367aa5825
remove cruft (old unused pre-git version files)
2015-01-09 06:11:57 +01:00
7f72e7d879
fix LTC alignment.
...
LTC-slave: offset the parsed LTC-frame instead of changing the
frame's timestamp. This fixes an issue with freewheel timeout and
delta-calculation. Align transport-time with output to match
capture alignment: "with existing material".
LTC-generator: follow suit. align clock with master-bus out.
This is a semi-permanent workaround. Once [tracks feeding] the
master-bus is/are delayed to align to output. The generator
needs to use (worst_track_latency not worst_playback_latency)
2015-01-09 06:08:15 +01:00
2132b917cc
Fix offset events when consolidating MIDI range.
2015-01-08 23:28:02 -05:00
ec17b5388f
Fix bounding box of rectangles with wide outlines.
2015-01-08 18:36:10 -05:00
659c0d093d
remove hardcoded major version in build scripts
2015-01-08 17:59:41 +01:00
7985624037
Close polygon borders (fix partially drawn hits).
2015-01-08 11:09:38 -05:00
0fba29a67a
tweak boot message so the final message makes more sense
2015-01-08 07:38:08 -06:00
2a251b4570
MusicalTime => Beats.
2015-01-07 00:12:07 -05:00
4d202d9157
Add modulus operator to MIDI transformer.
...
Useful for doing things like making alternating bowing patterns.
2015-01-06 23:04:28 -05:00
17dfebf611
Only restore plugin state (of first instance) once.
2015-01-06 20:29:39 +01:00
b56905b9a7
Fix MIDI file descriptor leaks.
...
Pretty sure this is the cause of MIDI data going missing on save for optimized
builds. Introduced in 294b99aabf
2015-01-05 15:50:30 -05:00
c16d520338
prepare for 'ardour4'
2015-01-05 19:07:24 +01:00
5584f46003
update windows user_cache_directory(): same pattern as config dir
2015-01-05 18:29:33 +01:00
6e3e1738dd
removed hardcoded ".ardour" suffix
2015-01-05 17:48:42 +01:00
7f486e146d
Accommodate some newly introduced source files for building with MSVC (libpbd)
2015-01-02 15:31:39 +00:00
d606a37204
Add PBD debug macros for recording timing data
2015-01-01 19:04:14 +07:00
1da30faf7f
Add tests that show the timing differences between the Glib/mm based timeouts
...
This shows that PBD::Timer is pretty much identical in terms of timing and CPU
usage as Glib TimeoutSources.
They also show the differences on Windows when setting the minimum Multimedia Timer
resolution using timeBeginPeriod
2015-01-01 19:04:09 +07:00
b959b3fb87
Add PBD::Timer/StandardTimer/BlinkTimer classes for convenient timeouts
2015-01-01 18:59:01 +07:00
770c190ccf
Add Timing, TimingData and Timed classes for time measurement to pbd/timing.h
2015-01-01 18:58:57 +07:00
2558e52e22
Fix alleged use of uninitialized variable.
...
Looks like a guaranteed else branch to me, but who am I to argue with gcc?
2014-12-31 17:32:21 -05:00
0274c93eac
Add missing Variant => LV2 Atom case.
...
(Not likely to actually be used any time soon but fixes warning and does
something reasonable if lossy).
2014-12-31 17:16:28 -05:00
07c08e4673
fix incorrect test for valid MIDI events.
...
Only channel messages have the form <statusbyte>{<nonstatusbyte>..}
2014-12-31 10:32:50 -05:00
e4f61de52f
Fix range "arithmetic"
...
Subtracting anything from an empty range should return an empty range, not an assert() failure
2014-12-31 07:43:43 -05:00
168d187994
Load what we can from broken/truncated MIDI files.
...
We're still a very long way from tolerant of weird SMF files (libsmf takes a
"crash if input is not exactly perfect" philosophy, if we're going to be polite
and elevate such a thing to "philosophy"), but at least we'll get what's there
from files truncated by old broken versions of Ardour or other situations.
2014-12-30 23:10:11 -05:00
f499f4cfd2
don't take temporary copy of MIDI sequence
...
fixes potential boost shared_ptr double free.
2014-12-31 03:19:00 +01:00
805d4dd731
add a MIDI loopback mode to the Dummy Backend
2014-12-30 22:55:14 +01:00
97d344f740
Fix MIDI CC record/playback crash.
2014-12-30 14:45:11 -05:00
c35e94a3c8
Fix some mangled whitespace (noop).
2014-12-30 14:41:22 -05:00
a85827da1c
Revert "Fix occasional MIDI read crash."
...
This reverts commit ec947ff8fd
2014-12-30 13:03:22 -05:00
54c085d931
Fix occasional crash when saving MIDI.
...
I can't figure out why a change has a NULL note; that shouldn't happen, but it
does. Worse case scenario is some undo loss, so better to print something
informative and soldier on than crash. Hopefully this will help track down the
real cause with more testing.
2014-12-29 22:01:41 -05:00
2e62ca9631
Fix off-by-one MIDI note names.
...
Much like everything else in midnam, it's not specified whether the numbers are
0 or 1 relative, but everything out there seems to be 0 relative and this
matches the canvas, so go with that.
2014-12-29 20:20:16 -05:00
a42b9ff86e
fix a few compiler warnings
2014-12-29 18:17:26 -05:00
9b8760cf69
Avoid another potential deadlock for good measure.
...
Firing these signals while locked is not a good idea, Sequence/ControlList need
a better design for this that accounts for recording and lockedness.
2014-12-29 17:56:53 -05:00
cf6e9d3412
Blind fix for MIDI iteration bug.
2014-12-29 15:12:10 -05:00
190ac88248
Fix deadlock while recording MIDI controllers.
2014-12-29 11:34:18 -05:00
47d083d02d
update numbering of midi-test sequences
2014-12-29 14:36:39 +01:00
95fcf18245
add a midi-CC sustain-pedal test sequence
2014-12-29 14:32:03 +01:00
6e38d3777e
add 'size' field to midi-sequences
2014-12-29 14:09:46 +01:00
c3c6f619c3
make it easier to add new midi sequences
2014-12-29 13:58:15 +01:00
f4e89d75fd
Add some newly introduced source files to our MSVC project (libardour)
2014-12-29 11:06:41 +00:00
541705e1ee
Demote message about empty MIDI tracks to info.
2014-12-28 19:21:46 -05:00
4c0cebf7f9
MIDI transform dialog.
2014-12-28 16:06:44 -05:00
ec947ff8fd
Fix occasional MIDI read crash.
...
Locking should prevent this from being a problem, but taking a reference to the
cached iterator and mutating it directly causes occasional crashes for me for
reasons I can't quite figure out.
This fixes the issue and is arguably more sane anyway, so whatever.
2014-12-28 16:06:44 -05:00
e735d4035f
Clean up note delta command code.
...
Use Variant to store the value and the same code path for all properties.
Factor out getting the value of whatever property instead of special casing the
handling.
Towards using this stuff for some fancy things...
2014-12-28 16:06:44 -05:00
962be01ae8
Fix typo.
2014-12-28 16:06:44 -05:00
f3604814a4
use ldflags for wine linking
...
fixes issue with eg. wine-unstable:
--also-libdir=/usr/lib/i386-linux-gnu/wine-unstable/
2014-12-28 15:18:39 +01:00
4e2673ca2c
add explicit chmod for good measure
2014-12-28 10:20:46 +01:00
28fb110dd3
fix [rare] concurrent build issue:
...
[709/779] subst: headless/hardev_common.sh.in -> build/headless/hardev_common_waf.sh
[710/779] hardev_common_waf.sh: -> build/headless/hardev_common_waf.sh
chmod: cannot access `headless/hardev_common_waf.sh': No such file or directory
2014-12-28 10:20:25 +01:00
e427724bd7
Some of libardour's istream and ostream operators are needed outside of libardour - so let's make them exportable
...
(currently, only the istream operators are needed but we might as well do them both)
2014-12-26 09:21:23 +00:00
6c50971eba
Remove the source files which got transferred to libpbd
2014-12-26 09:18:23 +00:00
46d08595ff
class 'PBD::Configuration' doesn't actually get exported from libpbd - so make sure we don't decorate it with LIBPBD_API
2014-12-26 09:16:58 +00:00
8eba7c5c0a
Add some newly introduced source files to our MSVC project (libpbd)
2014-12-26 09:15:17 +00:00
7e25f21595
Conditionally remove possibly unused functions.
2014-12-25 20:07:57 -05:00
129cc4689a
Remove warning when adding MIDI model controls.
...
This is fine, unlike the other cases, MidiTrack is not the only thing that can
have a MIDI automation control.
2014-12-24 20:41:14 -05:00
86242348ec
Fix crash when getting width of item with no bbox.
2014-12-24 16:02:56 -05:00
b0f1c16e20
Support fancy controls for some AU units.
2014-12-24 13:00:32 -05:00
2e7cfe081f
Add --no-lrdf configure option.
2014-12-24 13:00:32 -05:00
8c8bc51034
Fix OSX build.
2014-12-24 13:00:32 -05:00
0b471df0c3
fix clang compilation
...
error: call to function 'operator>>' that is neither
visible in the template definition nor found by argument-dependent lookup. 'operator>>' should be declared prior to the call site.
IOW. types.h must be included before using ‘ss >> (T) value’ in
template in pbd/configuration.h
2014-12-24 05:00:39 +01:00
bec521c6a7
proper default setup and fallbacks for video on windows
2014-12-24 01:36:46 +01:00
f5f89d8c7e
fix for case-sensitive FS - aa80515f3
2014-12-23 23:43:25 +01:00
96ee33aa5f
fix and cleanup c404ef98 (windows config dir)
2014-12-23 23:43:25 +01:00
Greg Zharun
aa80515f3f
[Summary] Fixed audio export on Windows. Added support of windows platform for the function that calculated hardware concurrency.
...
Because there was no implementation for this function on windows it used to return 0. This meant that no thread was created to process the data.
2014-12-23 12:55:35 -05:00
6b6d78c41f
indent cleanup
2014-12-23 12:35:58 -05:00
280910fd53
new file, derived from old libs/ardour/configuration.cc
2014-12-22 19:48:30 -05:00
d854c5d93c
move ARDOUR::Configuration and ARDOUR::ConfigVariable into libpbd
2014-12-22 19:48:30 -05:00
c404ef9856
don't append .config to %LOCALAPPDATA%\<ProgramName>\
...
::user_config_directory() could use some general cleanup
an x-platform consolidation, but today is not the day.
2014-12-22 23:04:44 +01:00
64fa63212f
move all (G)UI related configuration parameters into UIConfiguration, not RCConfiguration
2014-12-22 13:39:46 -05:00
795c5c16f1
no use of GUI parameters in libardour
2014-12-22 13:39:46 -05:00
76d42ab644
change SessionEvent::Immediate to -1, and ensure that clear_events() uses it rather than a hard-coded value
...
This fixes a design error of using zero as the flag for an "Immediate" event's action frame. Zero
is a perfectly legitimate action frame for an event (e.g. a Skip event), and using zero was causing
skip events with action-frame == 0 to be treated as immediate, not scheduled.
2014-12-21 11:45:53 -05:00
dafcaec023
Limit Wiimote surface discovery to 5 connection attempts
...
If you don't connect a Wiimote then the connection attempts were
endless.
2014-12-21 12:53:00 +07:00
282c563fce
fix newly introduced deadlock when cloning MIDI regions
2014-12-20 14:09:39 -05:00
David Robillard
5d8021bf44
Maintain correct tracker state on MIDI overwrite.
...
This is a little hard-edged in that edits while rolling will prematurely chop
off any playing notes, but at least the state of things actually reflects
reality. More sophisticated solution hopefully to come...
2014-12-20 01:13:25 -05:00
db92d62c95
Revert "Change default for region selection after split on Mixbus"
...
This shouldn't be necessary: Mixbus should probably just have a different
value for the default in their source tree instead.
This (partially) reverts commit 631467f0bb
2014-12-19 21:16:02 +00:00
631467f0bb
Change default for region selection after split on Mixbus
...
Mixbus prefers that both the newly-created regions as well as the existing
selection are selected after splitting selected regions: make this the
default on Mixbus.
2014-12-19 17:12:05 +00:00
d4a3141927
Add a config option to control region selection after split.
...
Add a configuration variable to choose the behaviour of the region
selection after splitting selected regions.
Add options to choose between all eight possible combinations of 'existing
unmodified selected regions', 'newly-created regions to left of split',
and 'newly-created regions to right of split', but comment out all but the
three least crazy ones for now. If anyone wants them, they're there.
2014-12-19 17:12:04 +00:00
a494211e73
add ArdourCanvas::change_alpha()
...
Time to move away from rgba macros
2014-12-19 09:53:26 -05:00
Valeriy Kamyshniy
1b89055526
[Summary] Bug fix: mistakenly set states of freewheeling thread.
2014-12-18 17:07:37 -05:00
74be550698
change Item::visible() to Item::self_visible(); add Item::visible() which returns accurate visibility
...
Child items will be hidden when their ancestors are hidden. The old ::visible() implementation didn't reflect this. In addition,
when changes are made to hidden items (new definition of visible/not visible), don't bother to request redraws, since this will
be done when the item becomes visible again.
2014-12-18 10:30:38 -05:00
7eab4c6f33
Don't assume compiler can avoid copy to const ref.
2014-12-18 04:03:39 -05:00
e584ae0bf9
Mute automation via normal mute button.
2014-12-18 02:26:51 -05:00
64490e88e4
No need to yell.
2014-12-18 02:26:34 -05:00
0f759e9a93
MIDI bounce.
2014-12-17 21:48:09 -05:00
d2cafbe95a
Remove some aborts that don't really need to be.
...
Enforce PatchPrimaryKey sanity at the type level rather than attempting to
check for it everywhere.
Remove dead file.
2014-12-17 19:43:09 -05:00
a706755710
Fix various MIDI locking issues.
...
Attempt to make mistakes much less likely in the future by statically requiring
caller to pass scoped locks where necessary.
2014-12-17 16:07:29 -05:00
ec6626f06a
Fix oops in previous commit.
...
Professionalism is overrated.
2014-12-17 02:10:01 -05:00
0c3f4bd995
Fix occasional crash when recording MIDI.
2014-12-17 01:49:46 -05:00
12803c4255
use new parameter to limit minimum length of any range location
2014-12-16 13:06:13 -05:00
94e2b61a86
add new parameter for minimum value of any range location
2014-12-16 13:06:05 -05:00
0fdb846625
try alternate Glib:: API for conversion from UTF-8 to ascii in Mackie support code
2014-12-15 15:06:10 -05:00
e3f376107e
nominal fix for sending UTF-8 text to Mackie surface
2014-12-15 14:44:05 -05:00
9831006c8e
add getters for SVAModifier
2014-12-15 12:06:53 -05:00
995bcd3aa0
fix typo
2014-12-15 09:29:04 -05:00
aa57e9e032
more fixes to SVAModifier constructor(s)
2014-12-15 09:03:52 -05:00
9a454ab3d4
Add a newly introduced header file to our MSVC project (libpbd)
2014-12-15 10:26:06 +00:00
3fa4063d9b
fix up SVAModifier constructors
2014-12-14 23:41:31 -05:00
427b93055f
add SVAModifier to ArdourCanvas color code
2014-12-14 23:34:36 -05:00
0fa5643d20
move ScopedFileDescriptor into libpbd and use it
2014-12-14 12:26:00 -05:00
1b3fb142f0
Only attempt to close our peakfile '_fd' if we have a valid handle
...
(yesterday's fix was needed in a 2nd place)
2014-12-14 10:39:29 +00:00
90010d098f
Only attempt to close '_peakfile_fd' if we have a valid handle
2014-12-13 12:46:24 +00:00
ee38c44109
Structure MIDI device selector by manufacturer.
...
Unfortunately we store the state of models as simply model, so if there's ever
duplicate model names, we're somewhat screwed, but this makes the (previously
unmanageably huge) menu usable, while retaining the "model name as global
identifier" state unmodified.
2014-12-13 00:37:34 -05:00
ec0a74276a
Remove (no longer needed) sources from our MSVC project (libpbd)
2014-12-12 09:08:16 +00:00
050d46a33e
Merge branch 'nofilemanager'
2014-12-10 18:29:41 -05:00
a4273ee224
Revert "fix some cast warnings"
...
This reverts commit 17707b9674
2014-12-10 18:29:00 -05:00
294b99aabf
remove file manager LRU cache from code.
...
This was a very clever attempt to fix a non-problem. If the platform doesn't have enough file descriptors available
then the platform is broken and we're not going to hack around trying to fix it.
2014-12-10 18:28:55 -05:00
a25d945c3e
fix some cast warnings
2014-12-10 18:27:11 -05:00
17707b9674
fix some cast warnings
2014-12-10 18:13:12 -05:00
3e27a71c71
simpler approach for Apple setrlimit() compatibility issue
2014-12-10 15:59:11 -05:00
b91c7836de
try some alternate, hard numbers when resetting open file limits on OS X
2014-12-10 15:27:32 -05:00
a0fcf2fc66
remove ugly and unnecessary debugging output
2014-12-10 13:37:03 -05:00
2f300085ea
Use DEBUG_THREAD_SELF when using DEBUG_TRACE with pthread IDs
...
(supports both normal pthreads usage and PTW32)
2014-12-10 16:56:33 +00:00
635578b30b
use correct conditional to choose between different DEBUG_THREAD_SELF macros
2014-12-10 11:07:18 -05:00
c06c15596b
add DEBUG_THREAD_SELF to allow use of DEBUG_TRACE with thread IDs on both normal pthreads platforms and PTW32
2014-12-10 09:34:32 -05:00
e66752cec1
add set-session-extents-from-edit-range
2014-12-09 16:18:47 -06:00
1e0c1751a5
more DEBUG::Butler output, formatting corrections, and a warning on cerr if capture/playback buffers are too full/empty
2014-12-09 16:36:52 -05:00
724febc82c
remove superfluous PBD/ARDOUR:: init calls
...
this reverts 339670b
2014-12-09 19:41:53 +01:00
8e44a0bff7
add DEBUG::Butler and use it
2014-12-09 10:18:29 -05:00
246a4f3018
correct install location for .mo files (i18n) and cleanup LOCALEDIR use a bit
2014-12-09 08:19:11 -05:00
624a86c39d
lots more color work, closer and closer to being ready for ... being taken apart again
2014-12-08 22:02:38 -05:00
9ac7ddb31d
remove all explicit button text colors; use contrasting_text_color() instead.
...
Also, use a slightly off-white rather than pure white, which should really be configurable
2014-12-07 13:55:40 -05:00
a81a79adce
Add some newly introduced source files to our MSVC project (libardour)
2014-12-07 13:31:41 +00:00
bfbb0f6178
Add legatize and remove overlap MIDI operations.
...
We're going to need the ability to apply MIDI edit operations to a note/control
selection soon...
2014-12-06 23:42:11 -05:00
e1e2b919c3
Remove unnecessary includes.
2014-12-06 22:43:06 -05:00
eb86971d2d
Invalidate iterator whenever model changes.
...
I suspect this is an underlying cause of several tricky to reproduce bugs, but
we'll have to wait around and see...
2014-12-06 22:43:06 -05:00
6f7ee67c71
midnam test: don't clutter up output.
2014-12-06 23:51:45 +01:00
60f4f5b9d8
Fix inappropriately massive flag font.
2014-12-06 16:07:32 -05:00
f9c74319a2
Fix seek in linearly interpolated control lists.
2014-12-06 15:44:10 -05:00
4650912ae3
Adapt range when copying between automation types.
...
For things like copying from pitch bender to a CC.
Also things like fader to pan, but that seems a bit funny. The conversion
probably needs to be a bit smarter here, perhaps taking the normal into
consideration...
2014-12-06 13:40:35 -05:00
82be2325d9
Fix uninitialized members.
2014-12-06 12:06:48 -05:00
ddb7cc6d66
More potential SMF crash fixes.
2014-12-06 11:19:48 -05:00
2e92ae90a6
Possible half-fix for SMF crash.
2014-12-06 10:37:08 -05:00
9266e7524a
experimental drawing optimization.
...
Q: is bounding_box(); etc more complex than queuing draw?
either way, canvas should eventually switch to
use an optimized OptimizingLookupTable.
2014-12-05 22:40:26 +01:00
587dc283ea
Fix stuck faders on very fine adjustments.
...
I attempted to preserve the "don't draw unless different" by ditching rounding for more
precise display_span, but that didn't work. An alternative solution would be
to draw on adjustment change if there's text, since then we need to redraw
regardless of slider position, but it seemed weird even just with respect to
the slider, so I opted for this, which really definitely redraws when the
adjustment changes, period.
If this proves to be a performance issue we'll have to figure that out.
2014-12-05 15:19:43 -05:00
fb406e5b36
fix small memory leak in the tests
2014-12-05 20:57:07 +01:00
8714fab1bc
update to 'new' ControlList API
...
add (double when, double value, bool with_guards=true, bool with_default=true);
2014-12-05 20:57:07 +01:00
91d3e8ead0
if a Route's processor lock cannot be taken, fill buffers with silence (causing click) rather than abort()
2014-12-05 14:49:30 -05:00
cf3faf1b42
fix "expected" <> "actual" semantics in test-util
2014-12-05 18:32:16 +01:00
207fd04587
include alpha-delta computation in HSV::delta()
2014-12-05 09:01:55 -05:00
17ad6a5078
Add 'pbd/crossthread.cc' to the MSVC build
2014-12-05 08:40:47 +00:00
0bf778c847
Make recorded MIDI controls discrete, take 2.
...
Hopefully-desired behaviour is that controls created in the GUI are linear, so
clicking in stuff works like other automation, but controls that originated
from recording are set to discrete so Ardour plays back the input exactly,
instead of doing crazy things like linear interpolation of already high-rate
user input, hold pedals, and so on.
Hopefully that remains the desired behaviour, because we're basically screwed
for ever making any control discrete by default, since we only save the mode to
XML at all if it's not the default, which is currently linear.
2014-12-05 00:15:40 -05:00
ad340333f4
Revert "Create discrete lists for recorded MIDI controls."
...
This broke saving/restoring interpolation style.
This reverts commit 07a381a8f5
2014-12-05 00:03:47 -05:00
124e54f01b
Fix crash when twiddling MIDI controllers ( #6050 ).
2014-12-04 22:23:16 -05:00
59af923b77
Fix steps for log controls with wide range.
2014-12-04 21:22:31 -05:00
55c4889c9a
fix windows compilation
2014-12-04 17:13:43 +01:00
b996f07122
add required header
2014-12-04 11:05:33 -05:00
697c397f37
move WSAStartup() and WSACleanup() out of per-object methods into per-library init/cleanup methods
2014-12-04 10:07:11 -05:00
4e8dfda880
clean up whitespace
2014-12-04 09:11:46 -05:00
5f9e81b105
Include pbd/crossthread.cc in the mingw build
2014-12-04 16:16:06 +07:00
12acce0d0e
Use correct name for windows.h
2014-12-04 16:15:07 +07:00
24727e65be
Make gain controls step by roughly 1.0/0.1 dB.
...
Shoot for roughly 30 steps for all controls.
Always keep sensible step information in ParameterDescriptor and just convert
for the UI.
This is a little weird, but it's less weird than it was before, and works.
2014-12-04 00:30:47 -05:00
9b770c7aff
actual expected test results:
...
We should not add an initial implicit value
at time ‘0’ to automations.
2014-12-04 03:55:03 +01:00
b437de714f
make all tests pass
2014-12-04 03:53:26 +01:00
fb63b3ffc3
fix to follow changes to evoral/libardour split
2014-12-03 21:22:53 -05:00
602e390649
changes to Mackie Control support for new crossthreadchannel implementation
2014-12-03 21:22:34 -05:00
2f0c998210
adapt changes to async MIDI port to use new evoral/libardour split
2014-12-03 21:11:24 -05:00
7ab3da66b5
fix up BaseUI to use crossthreadchannel on all platforms
2014-12-03 21:11:02 -05:00
d3e2de8b4e
modify Mackie surface code to use crossthreadchannel on all platforms
2014-12-03 20:57:58 -05:00
f4726cc6fa
modify MidiUI code to use crossthreadchannel on all platforms
2014-12-03 20:55:44 -05:00
d762ed8c22
alter Async MIDI port implementation to use crossthreadchannel on all platforms
2014-12-03 20:53:49 -05:00
f72b87b448
new platform specific crossthreadchannel files
2014-12-03 20:47:59 -05:00
5c51b302ce
manually merge new CrossThreadChannel implementation for windows from Tracks
2014-12-03 20:47:27 -05:00
888bf2d551
Test: update AutomationList properties for v3.5
2014-12-03 23:37:27 +01:00
40087eb378
Test: print assert message if XML property mismatch
2014-12-03 23:27:14 +01:00
b52d8e5151
fix audioengine use in unit-tests.
2014-12-03 20:47:29 +01:00
89d48f4459
fix MTDM test
2014-12-03 20:45:27 +01:00
339670b6fa
Tests: ensure that libardour is initialized
2014-12-03 20:45:01 +01:00
32269f0c5a
fix audio-engine dtor.
...
backends - once instantiated - keep a reference to the engine.
when audioengine is destroyed, the backends must be deinstantiated.
This fixes various unit-test cases.
2014-12-03 20:44:47 +01:00
9268d2e699
allow to auto-start dummy backend (needed for tests)
2014-12-03 18:24:56 +01:00
d45e19eda5
fix test segfault
...
whe XMLTree goes out of scope, the root-node is deleted
2014-12-03 16:03:57 +01:00
0d677f70b4
use Dummy backend for tests
2014-12-03 16:03:19 +01:00
0ec85a4164
Fix running libpbd unit tests when $TOP(in test scripts) is set as relative path
...
Add test for PBD::canonical_path that was used to track down silly mistake
in test code
2014-12-03 17:44:48 +07:00
dd976d8c7a
Add DEBUG_TRACE output to PBD::canonical_path
2014-12-03 17:31:05 +07:00
81d47f5b8c
Call PBD::init() from libmidi++ test runner
...
This is mostly just to be able to set PBD_DEBUG for testing if
necessary
2014-12-03 17:31:05 +07:00
d360bc3906
Add ability to set libpbd debug options via PBD_DEBUG environment var
2014-12-03 17:31:05 +07:00
9eb8b73b43
Call PBD::init from evoral testrunner
...
This is needed to set _fmode = O_BINARY for libsmf/fread and
fixes takeFiveTest on windows
2014-12-03 17:31:05 +07:00
4b751f9e87
Move setting _fmode flag on windows into PBD::init
...
This moves setting of _fmode slightly later in the initialization
of the application via Ardour::init.
2014-12-03 17:31:05 +07:00
dc4d76b1d4
Remove references in pbd test script to libs no longer in source tree
2014-12-03 17:31:04 +07:00
01a17f296f
Make pbd test script consistant with other test scripts
...
remove running script from pwd limitation
2014-12-03 17:31:04 +07:00
4fe6bf3530
export MIDIPP_TEST_PATH in midi++ test script so test files can be located
...
Modify formatting of script to be consistant with other test scripts
2014-12-03 17:31:04 +07:00
23c0452e05
Add test_search_path to find test files in MidnamTest
2014-12-03 17:31:04 +07:00
aed58d6f39
Use test_output_directory() in pbd filesystem test
...
This prevents directory being created in pwd and means deletion of
directory is unnecessary
2014-12-03 17:31:04 +07:00
61f9ca9f3c
Use test utility function to find evoral test files
...
either via EVORAL_TEST_PATH env var or on windows via directory relative
to dll
2014-12-03 17:31:04 +07:00
f6e15a3b6b
Use PBD::tmp_writable_directory to write evoral test file into
...
no need to remove directory as it is temporary
2014-12-03 17:31:04 +07:00
929fc3d235
Use PBD::tmp_writable_directory in libardour test_util.cc
2014-12-03 17:31:04 +07:00
376340a29f
Remove unnecessary comma in pbd wscript file
2014-12-03 17:31:04 +07:00
1c1eff8845
Use PBD::tmp_writable_directory in test_output_directory
2014-12-03 17:31:04 +07:00
1abe8f4e42
Add PBD::tmp_writable_directory utility function to pbd/file_utils.h/cc
2014-12-03 17:31:04 +07:00
2b03521ef9
Fixes for AudioEngine test
2014-12-03 17:31:04 +07:00
e83bb2f4e2
Remove unused test_common.h/cc files
2014-12-03 17:31:04 +07:00
f1b66b86b4
Move libardour test utility code into one source file
2014-12-03 17:31:04 +07:00
b9567b6d46
Use ardev_common.sh to setup environment for running libardour tests
2014-12-03 17:31:03 +07:00
7a3c54f031
Fix evoral test suite.
2014-12-02 23:30:16 -05:00
25efe5953c
Fix range of pan controls.
...
Set default range to [0,1] since [0,0] is problematic and useless anyway.
2014-12-02 19:02:03 -05:00
94b26cd9af
Make 'ARDOUR::ParameterDescriptor' exportable, so that it can get used outside of libardour
2014-12-02 18:59:43 +00:00
a13ff7b604
Remove accidentally committed file.
2014-12-02 12:15:54 -05:00
7aab4be5e4
alsa-backend: drop midi during freewheel processing.
2014-12-02 17:03:29 +01:00
db3d42d551
first pass at optimization for low-level canvas code
2014-12-02 05:32:34 -05:00
cf47d71761
Fix lost MIDI events due to broken range check.
2014-12-02 03:36:33 -05:00
07a381a8f5
Create discrete lists for recorded MIDI controls.
2014-12-02 00:21:52 -05:00
86de0386c9
Fix automation write/touch.
2014-12-01 23:35:24 -05:00
2b69fa6edf
Factor out copy-paste code.
2014-12-01 23:35:24 -05:00
767c0238a3
Replace half-baked param metadata with descriptor.
...
Among other things, this means that automation controls/lists have the actual
min/max/normal/toggled of parameters, and not those inferred from the Parameter
ID, which is not correct for things like plugin parameters.
Pushing things down to the Evoral::ParmeterDescriptor may be useful in the
future to have lists do smarter things based on parameter range, but currently
I have just pushed down the above-mentioned currently used attributes.
2014-12-01 23:35:24 -05:00
Julien de Kozak
cb8abbe8d2
Make it compile with C++11 support.
...
Reference : https://bugs.webkit.org/show_bug.cgi?id=59249
2014-12-01 23:18:11 +01:00
43cc295a58
Tidy up comments in Evoral::coverage
...
Remove old (already #if 0'ed) implementation of Evoral::coverage() and its
comments.
Tidy up the comment enumerating all the possible ways in which two ranges
can overlap, note the Evoral::OverlapType corresponding to each one, and add
comments to the if()s in coverage corresponding to the cases in the list of
overlap types.
Remove some commented-out assert()s that actually do happen, and re-instate
one that really shouldn't.
Fix a small typo (with -> within)
2014-12-01 20:13:04 +00:00
dd5fc9432f
Simplify Evoral::RangeList::subtract(), and make it pass amended tests
...
The various conditionals in Evoral::RangeList::subtract() appear to have
been there to work around
(a) coverage() not always returning the correct value, &
(b) the test suite assuming that the ->to point lies outside the range
Now that these are both fixed, the implementation of subtract() becomes
quite a bit clearer. I replaced the if()s with assert()s for now, but these
shouldn't trip if coverage() is working as I expect.
Also (attempt to) clarify the comments in subtract.
2014-12-01 20:13:04 +00:00
30a9c2d05b
Comments in various call-sites of coverage()
...
Comments in various call sites of Evoral::coverage() marking things I think
are dubious (with XXX). Also straightened up the alignment of some ASCII
art in libs/ardour/diskstream.cc
2014-12-01 20:12:51 +00:00
d7cc7775f3
Rework Evoral::coverage() to pass unit tests
...
Rewrite Evoral::coverage() to (hopefully) do what it's supposed to.
Return OverlapNone for invalid ranges: if either of the ranges passed to
Evoral::coverage() have negative length (i.e. start > end), return OverlapNone
- it seems reasonable to say that a negative-length range can't overlap
anything. Also return OverlapNone from the fallthrough case, though this should
never happen.
2014-12-01 20:03:22 +00:00
47d329ca40
Make tests of Evoral::Range functions include both endpoints in Range
...
Some of the tests for Evoral::RangeList::subtract() assume that ranges
don't contain their end (->to) point. This appears inconsistent with how
they are used elsewhere.
Add some ASCII art comments to the tests to try to clarify what they're
really testing for, and amend subtractTest1, subtractTest4, & subtractTest5
to incorporate the assumption that ranges include their end points.
2014-12-01 16:52:58 +00:00
0c7dd82239
exclude fader-reserve from range
2014-12-01 17:45:27 +01:00
0ffeaa6d6a
Remove braindead Parameter inheritance abuse.
2014-11-30 23:56:20 -05:00
7eb4e5d22b
Replace thinning static state with parameter.
2014-11-30 23:56:20 -05:00
b68fd1cc25
Remove dead code.
2014-11-30 23:56:20 -05:00
0b48eb68f8
Remove bogus test and noisy output.
2014-11-30 23:56:19 -05:00
2588b1cac9
Trim the include tree.
2014-11-30 23:56:19 -05:00
1693e57e0e
Move EventRingBuffer to libardour.
...
This is not used anywhere in Evoral and is just a wrapper around the PBD
RingBuffer anyway. Towards a (once again?) independently buildable/testable
Evoral and fewer cross-dependencies.
2014-11-30 23:56:19 -05:00
cf537b97f5
Add missing namespace qualifiers.
2014-11-30 23:56:19 -05:00
008bfceb77
Clean up state tracking of raw MIDI.
2014-11-30 23:56:19 -05:00
a0deb7c3bf
Save mute automation state.
2014-11-30 23:56:19 -05:00
272c93db12
CLA approved consistent fine-grained scale modifier
2014-11-30 21:27:31 +01:00
2996e677c4
Process 'default_ui_config.in' when building with MSVC
2014-11-30 17:57:44 +00:00
18efe8f446
consistent step+page sizes for fader+spinbox
2014-11-30 15:05:40 +01:00
fb3f9033cf
use update_steps() instead of custom function
2014-11-30 15:05:39 +01:00
0622fc9d4b
update_steps(), properly handle integer ranges
2014-11-30 15:05:39 +01:00
bd85c8ec43
fix ladpsa default value.
...
because get_parameter_descriptor() is const, also wrap
default_value() in a const function.
2014-11-30 15:05:39 +01:00
cf859270e0
fix LV2 default port value.
2014-11-30 15:05:39 +01:00
77d5fb7a35
Fix write for boolean automation.
2014-11-29 14:32:12 -05:00
c77f4b7a18
don't move faders on click.
...
for one, it can mess up the value when switching to
numeric-entry. It is also rather useless and not
Fader-like (faders are not scrollbars).
Besides, "stepvalue" is way to large and causes jumps
(sometimes step-value is even negative, see
"fast lookahead limiter", "release time"
-> some other bug)
2014-11-29 17:31:41 +01:00
58663db374
change ownership of processor window-proxy
...
fixes crashes:
* If the Editor-Mixer shows a channel with a plugin that
has been edited in the Mixer, double-clicking the plugin
will try to bring up a 2nd instance of the plugin-UI.
* When closing Ardour both the Mixer and the Editor-Mixer try to delete the underlying plugin, resulting in a double free.
2014-11-29 10:06:25 +01:00
784b96e255
Set discrete by default for boolean parameters.
2014-11-29 01:40:23 -05:00
ed1bbefd19
Somewhat working gain automation.
...
This probably isn't correct in several ways, but it works more than it did, so
I figure it's push worthy.
Still not working:
* Saving mute automation list
* Dragged control points are not snapped to model restrictions
(boolean, in this case, but general problem)
* Line goes funny if you record mute automation
(as opposed to drawing it which works)
2014-11-29 01:25:27 -05:00
f190e630ab
Show discrete/toggled automation as stepped line.
2014-11-28 21:15:28 -05:00
e55b68298b
Fix crash when deleting all points from a line.
2014-11-28 20:04:57 -05:00
358ebde106
Set the toggled default metadata of parameters.
...
This is so generic code looking at the Parameter for gain, solo, and
rec-enable will get the correct value for toggled.
2014-11-28 18:04:51 -05:00
ea35595370
Add some newly introduced source files to our MSVC project (cairocanvas)
2014-11-28 14:42:17 +00:00
16947f751b
Remove dead code.
2014-11-27 04:17:15 -05:00
3d4b1d324e
Fix calculation using uninitialized value.
...
Implicit "this" is the devil.
2014-11-27 04:15:30 -05:00
25e1eddc50
remove "port sources" management from MidiControlUI and Mackie support.
...
This was necessary due to a bug/design issue between Glibmm and Glib (see https://bugzilla.gnome.org/show_bug.cgi?id=561885 )
but the problem needs to be managed by the *creator* of the IOSource and that has now moved inside CrossThreadChannel.
2014-11-26 18:22:22 +02:00
6edd81e4f6
get correct ::distance() and ::delta() implementations for cases involving achromatics
2014-11-26 18:22:22 +02:00
318a9edab9
massive reworking of color selection implementation
2014-11-26 18:22:22 +02:00
c927eeb9ee
ensure that Ardour recognizes its own MMC device ID as "all-call" when set to 0x7f (127)
2014-11-26 18:22:22 +02:00
b9be8d2652
Replace individual waf options for enabling backends with one --with-backends option
2014-11-26 22:47:05 +07:00
4358b8db79
Add test for Evoral::coverage()
...
Add a test function to test Evoral::coverage() with all possible overlap
types. The first test (line 161) that expects OverlapExternal will fail
with the current implementation of coverage().
There's possibly still a discussion to be had about what the overlap type of
ranges with negative lengths should be: there are currently places in the main
Ardour code base where coverage() is called with ranges where start > end.
2014-11-25 17:49:51 +00:00
3a6c9e3bb9
Fix build of evoral tests
...
Fix compile errors in libs/evoral/test/, by explicitly calling
Evoral::MusicalTime::to_double() wherever a double value is required of a
MusicalTime.
Some of the double variables should probably really be made into MusicalTime
ones instead, but I don't want to mess with this too much.
takeFiveTest still fails for me after this, but a failing test is probably
more informative in the long run than a test that won't even compile.
2014-11-25 14:59:48 +00:00
1f58f81aa6
Fix order of parameters to stop_touch() in Mackie::Control
...
Reverse the parameters of Mackie::Control::stop_touch() to make them
consistent with AutomationControl::stop_touch(), and fix up the call to
AutomationControl::stop_touch() to have the parameters in the correct
order.
Unfortunately, I don't possess any devices that speak the Mackie protocol, so
though the patch seems logical and correct to me, I have no way of testing it.
If anyone has a device with touch faders that speaks Mackie, I'd be glad of any
confirmation that it at least doesn't break anything.
2014-11-25 14:59:48 +00:00
ea5876b836
Remove dead code.
2014-11-25 02:11:44 -05:00
78218e8c07
fix OSX open URL in browser
2014-11-24 20:35:38 +01:00
c7ddedc5b8
Simulate 'trunc()' which isn't available in MSVC
...
(needed by 'gtk2_ardour/editor.cc')
2014-11-24 12:56:07 +00:00
018f559aad
Remove a commented out line in 'pbd/stacktrace.h'
...
(was probably just needed for testing at some stage)
2014-11-24 12:53:24 +00:00
25745758aa
Changes needed to accommodate building libevoral with MSVC
...
Note that class 'MusicalTime' needn't be exportable (with a little work, this could be reverted if it affects the other builds)
2014-11-24 12:51:54 +00:00
c0e8647806
amend c4533939b9
2014-11-24 00:04:45 +01:00
cd91fa0046
hotfix windows-compilation (unfinished bfe49540b9)
...
..at least it compiles and starts. Mackie support etc
is probably still broken.
2014-11-23 23:57:56 +01:00
8ddeb712f6
make debug message more useful
2014-11-23 23:57:55 +01:00
5aba4df252
fix/silence various compiler warnings.
...
* ifdef unused static functions
* brackets around assignment and comparision
* no return statement in function returning non-void
* boost concept_checks.hpp unused-local-typedefs
2014-11-23 23:57:55 +01:00
f1926dc863
Fix build with a certain awful broken compiler.
2014-11-23 16:31:59 -05:00
ec01682714
-Wunused-function on windows
2014-11-23 21:01:39 +01:00
40764f4cb3
use NULL not 0 for c-functions (even in c++ code)
...
4.3 KBytes less compiler warnings.
2014-11-23 21:01:39 +01:00
bfe49540b9
remove use of CrossThreadChannel::selectable() to allow cross-platform implementation of CrossThreadChannel via Glib::IOSource
2014-11-23 17:37:13 +02:00
57c1b6e261
Fix quantization and other time-related ops.
2014-11-22 21:49:42 -05:00
231e0009b4
Max is max and min is min and I am dumb.
2014-11-22 16:33:32 -05:00
42b5ed3904
Fix clang and MSVC build.
2014-11-22 15:26:41 -05:00
c1cfa12d6e
Wrap MusicalTime in a class.
...
This lets us get a more explicit handle on time conversions, and is the main
step towards using actual beat:tick time and getting away from floating point
precision problems.
2014-11-22 04:05:42 -05:00
cae74309a5
Fix assert failure in control list interpolation.
...
How we never hit this before is beyond me, it's in some ooooold code.
2014-11-22 00:46:15 -05:00
01493b14cf
Fix const violation warnings in tempo.cc.
2014-11-22 00:46:15 -05:00
4bc0d1c475
Fix lost MIDI note offs and controllers.
...
Fix initial read of discrete MIDI controllers.
Fix spurious note offs when starting to play in the middle of a note.
Faster search for initial event when cached iterator is invalid.
So much for dropping the cached iterator. The iterator is responsible for
handling note offs, so that doesn't work. This design means we have some stuck
note issues at the source read level, but they should be taken care of by the
state tracker anyway.
2014-11-20 15:36:11 -05:00
8bba63282a
Reduce unnecessary non-const MIDI buffer access.
2014-11-20 15:32:06 -05:00
8f8a4878f3
Clean up some MIDI code.
2014-11-20 11:31:31 -05:00
0c4869dc35
debug trace lost midi-messages
2014-11-20 02:46:30 +01:00
a9936205b1
Fix dropped MIDI events, especially with record enabled.
...
I am not precisely sure why the cached iterator was causing this problem, it
shouldn't be invalidated, and the times make sense. It may be some lock
related issue since the iterator holds a lock on the source.
In any case, this cached iterator was just to avoid repeated linear search of
the model, but since the model has a logarithmic search, instead just scrap all
this problematic persistent state and search for the appropriate start time
every read. No need to be careful about invalidating when anything changes.
2014-11-19 19:24:16 -05:00
e3e85a92db
some const'ness and hints for clang
2014-11-19 20:38:50 +01:00
0fb91e10b4
allow dummy backend for any product
2014-11-18 17:04:23 -06:00
bd577a0663
Avoid possible use of uninitialized values.
...
This could only happen with a broken widget, but it shuts up clang and doesn't
hurt.
2014-11-18 02:55:03 -05:00
976a150e6b
Remove obviously dead/redundant code.
2014-11-18 02:55:03 -05:00
07d4f50689
Clean up funny code and initialize variables.
2014-11-18 02:55:03 -05:00
881d77f1e5
Constrain variable scopen and avoid uninitialized values existing at all.
...
Note: dead assignments trigger scan-build dead code warnings, which
initializations do not.
2014-11-18 02:55:03 -05:00
6e482b3488
Remove unused variable and redundant arithmetic.
2014-11-18 02:55:03 -05:00
8dde26da7b
Gracefully avoid importing audio that somehow has 0 channels.
2014-11-18 02:55:03 -05:00
e5d9fd1aac
Fix potential use of uninitialized value.
2014-11-18 02:53:28 -05:00
fed4e8446b
Fix NULL pointer dereference on malformed Playlist XML.
2014-11-18 02:53:28 -05:00
afd67800b9
Avoid potential division by zero.
2014-11-18 02:53:28 -05:00
c4c7598adb
Fix broken logic and possible NULL pointer dereference for Bundle XML.
2014-11-18 02:53:28 -05:00
26f6f80a53
Fix incredibly unlikely NULL pointer dereference.
2014-11-18 02:53:28 -05:00
9aec0c627d
Fix Region::verify_length() so it actually does something.
2014-11-18 02:53:27 -05:00
b6db707989
amend 484e38053
2014-11-18 05:28:27 +01:00
484e380536
silence clang "dead assignment" warnings
2014-11-18 04:46:37 +01:00
37937d9c69
synchronize preferences and monitor-section
2014-11-18 03:49:20 +01:00
5e90b97c42
files should have at least one channel.
2014-11-18 02:15:07 +01:00
f2273dc3b6
remove dead assignment
2014-11-18 02:15:06 +01:00
c194e4df18
remove superfluous if-branch (_session is checked a few lines above)
2014-11-18 02:15:06 +01:00
f7ebae85a7
Fix "maybe" rounding bug.
...
Introduced in d63161426f
2014-11-17 19:53:30 -05:00
02d735ff00
waves/coreaudio PPC support
2014-11-17 09:07:39 +01:00
bd46de779f
check alsa midi ringbuffer
2014-11-17 06:50:48 +01:00
b4fcdbb100
Don't add origin value to MIDI controller regions on initial insert.
...
This should probably hijack the same modifier as the guard points and work the
same on all automation tracks, but I did it this way to not change behaviour of
track automation where a default is much more reasonable.
2014-11-16 22:35:45 -05:00
d63161426f
Add "maybe" rounding modes for rounding only if necessary.
2014-11-16 22:35:45 -05:00
fd9ccc7058
Use an enum for RoundMode instead of magic numbers.
...
No functional changes in this one (for easier auditing), but towards having
round up/down only if necessary modes, rather than kludging around that
situation with a double round as we do currently.
2014-11-16 22:35:45 -05:00
9d4f43fa7d
Make ControlList::paste const-correct.
2014-11-16 22:35:45 -05:00
df40782b62
prevent segfault if in/out property is missing
2014-11-17 04:05:00 +01:00
ad739cd018
add some assert() messages.
...
as hints clang static analyzer "Called C++ object pointer is null"
2014-11-17 03:49:19 +01:00
333c776e0e
Fix MIDI region keyboard editing (add key handling to canvas).
2014-11-15 02:04:28 -05:00
b52407043c
Fix crash when copying MIDI regions with midi-copy-is-fork is on ( #6002 ).
2014-11-14 23:53:59 -05:00
94954f852e
Fix out of order event errors on save with overlapping notes.
...
Another consequence of fuzzy Sequence timing, but if the difference is less
than a tick this should handle things correctly. If the difference is more
than a tick, something's wrong, and it might be okay to just bump forward
anyway, but I can't reproduce this and it could lead to corruption so I'm
leaving that case noisy.
2014-11-14 21:19:09 -05:00
6b3a8915f3
add abort() to non-reached code
...
This cleans up a lot of false-positives in static analysis
and also helps compilers to optimize code paths in general.
(tagging the fatal stingstream operator as ‘noreturn’ is
far less trivial)
2014-11-14 11:30:08 +01:00
8907477271
Fix crashes on various MIDI editing operations.
...
Assertions assumed old strict ordering, no longer reflecting reality of fuzzy
time comparison (introduced in 86f1b8).
2014-11-13 22:34:20 -05:00
4ba4677b45
yet another copy/paste typo :(
2014-11-13 22:19:22 +01:00
9301ffafab
fix typo in b9fc616538
2014-11-13 21:46:30 +01:00
b376f6bc45
auto-initialize weak-jack
...
(not needed with ardour - but keep code in sync with
https://github.com/x42/weakjack )
2014-11-13 21:31:09 +01:00
b9fc616538
prepare for JACK meta-data API
2014-11-13 21:30:13 +01:00
65fa38103d
make new jack thread API functions optional
2014-11-13 21:29:34 +01:00
7b39e0893a
add symbol debug information to weak-jack
2014-11-13 21:28:33 +01:00
cb38034334
install all additional binaries in $libdir
2014-11-13 19:57:40 +01:00
9a9a8f78ef
fix define
2014-11-13 19:05:58 +01:00
0689a2976e
Don't iterate in 'ARDOUR::Route::get_control()' unless a ReaderLock was successfully obtained
2014-11-13 13:07:34 +00:00
e59e8f6ab9
Make sure we can't execute 'ARDOUR::Route::meter()' unless a ReaderLock was successfully obtained
2014-11-13 12:13:16 +00:00
3e702c5520
yet another build fix
...
on x86_64 weak_libjack.c needs -fPIC which needs cflags which need 'c' :)
2014-11-13 01:02:09 +01:00
533b545295
add popup message and error log for AU crash reports
2014-11-12 13:35:15 +01:00
5624301a31
Prepare AU-discovery crashlog.
...
stopgap solution to allow a user to detect which plugin caused a crash during discovery.
2014-11-12 13:34:46 +01:00
1bc04ae351
failsafe AU scanning part one:
...
Don’t scan for AU plugins unless users explicitly starts a
plugin scan. Disable automatic scanning if Ardour crashes
during AU plugin discovery.
2014-11-12 04:58:53 +01:00
9254e80c39
refactor MIDISceneChange color property addition by moving it into SceneChange to anticipate other types of SceneChange objects (e.g. OSC)
2014-11-10 23:17:27 -05:00
e27651d315
when creating a new MIDI scene change, check existing scene changes for equality and reuse their color (which may or may not be set)
2014-11-10 23:17:19 -05:00
0f243d5f7c
serialize/deserialize MIDISceneChange color; put out of bounds color into static const
2014-11-10 23:17:08 -05:00
70960a5a00
add color property to MIDISceneChange
2014-11-10 23:16:59 -05:00
3d0efb8bf7
add operator== to ARDOUR::MidiSceneChange
2014-11-10 23:16:53 -05:00
12b715e6fa
tweak canvas on_expose_event() handler to avoid unnecessary save/paint/restore
2014-11-10 20:34:20 -05:00
fdcb792358
further work on new color manipulation code
2014-11-10 20:33:54 -05:00
929d3fe6ed
fix signed/unsigned compiler warning
2014-11-10 22:21:39 +01:00
a37ffd1f0c
improve random seed (for dummy generators)
2014-11-10 22:20:36 +01:00
1317b57221
add required header for compilation
2014-11-10 11:46:17 -05:00
ef56948d4a
add background color property to Canvas::Canvas ; rearrange expose handling and include background fill
...
Conflicts:
libs/canvas/canvas.cc
libs/canvas/canvas/canvas.h
2014-11-10 10:43:25 -05:00
9cf5b23392
Modifications needed to build ReasonableSynth with MSVC
2014-11-09 08:11:46 +00:00
373caeede8
Add some newly introduced source files to our MSVC project (cairocanvas)
2014-11-08 10:48:26 +00:00
bb12c750bb
Just rename problematic Variant::VOID type.
2014-11-07 17:21:43 -05:00
4260d0ca0e
use new canvas colors header as necessary
2014-11-07 14:24:27 -05:00
69fd25f6f4
move canvas colors code into its own file(s)
2014-11-07 14:24:13 -05:00
a441de1a18
when drawing only part of a Canvas::Rectangle outline, we only need to do the cairo-pixel alignment math for the axis perpendicular to the edge
2014-11-07 12:58:56 -05:00
87cd481a7d
VOID is a windows define (not MSVC specific)
2014-11-07 17:04:11 +01:00
0fedfab593
tentative fix for canvas background/image surface
2014-11-07 16:50:21 +01:00
159cb4d2f9
another hack for windows timers, DSP load calculation
2014-11-07 12:17:15 +01:00
7670e463cc
add API to extract color from ArdourCanvas::Text and tidy up member declarations
...
Conflicts:
libs/canvas/canvas/text.h
2014-11-06 20:38:02 -05:00
787f9748b6
changing the clamp_width of an ArdourCanvas::Text needs to potentially provoke an entire redraw
...
This fixes missing range marker text in sessions where the initial zoom value causes an initial clamp_width of zero
2014-11-06 20:38:02 -05:00
6cda13fad4
possible fix for DSP load calculation on windows
2014-11-06 17:29:35 +01:00
c9c4a5c29d
raising/lowering canvas items should trigger a redraw
2014-11-06 10:58:37 -05:00
ecd618c343
correct the rendering of Rectangle outlines, and the computation of their bounding box
2014-11-05 19:45:23 -05:00
857719f2e1
add Rect::shrink(Distance) even though it arguably should be handled by Rect::expand()
2014-11-05 19:45:23 -05:00
f3d349bc9a
add some more outline enums to ArdourCanvas::Rectangle
2014-11-05 19:45:23 -05:00
589e59d7a1
allow derived classes to access Item::{scroll,position}_offset(), mostly for debugging purposes
2014-11-05 19:45:23 -05:00
98b66b9f3d
catch up with waves/tracks version of MIDI scene changer code
2014-11-05 19:45:23 -05:00
b02ea3d435
alter implementation of ArdourCanvas::contrasting_text_color() to use gamma-adjusted luminance values rather than simple contrast
2014-11-05 11:13:28 -05:00
70e95f951d
add ArdourCanvas::Fill::set_pattern() to allow any filled canvas item to be filled using an arbitrary Cairo Pattern
2014-11-05 11:13:09 -05:00
4eac2a76da
fix insane design for Location::next_available_name() so that it has no effective limit (other than UINT32_MAX)
2014-11-05 07:41:43 -05:00
f018f3d37a
Add some newly introduced header files to our MSVC project (libs/ardour)
2014-11-04 15:44:27 +00:00
227732d15b
When building with MSVC undef type VOID if we're declaring an enum called VOID
2014-11-04 15:42:04 +00:00
04bda495c2
When building with MSVC, guard a declaration of 'strdup()' which conflicts slightly with the MSVC declaration
...
(maybe we should just #include <string.h> ?)
2014-11-04 13:23:15 +00:00
5e8c39ff47
When running an (MSVC built) VST scanner app, make sure we can utilise debuggable versions if we need to
2014-11-04 13:23:14 +00:00
f1e6b28ab7
use ArdourCanvas::TimeRectangle for regions, notes, markers
2014-11-03 21:48:08 -05:00
56994e785e
add new TimeRectangle to ArdourCanvas
2014-11-03 21:48:08 -05:00
a54f8141dc
Use format string even for units we understand (print Hz units).
2014-11-03 20:52:14 -05:00
9f3f017736
Check whether frequency controls are audible or low and provide appropriate controls.
...
Always clamp set value to controller range.
2014-11-03 18:41:57 -05:00
ef16fdcd89
Fix parameter descriptors for one control leaking into another.
2014-11-03 18:40:17 -05:00
6e16f69c26
Add menu to set frequency controls in beats, and half or double current value.
...
Test with e.g. fomp:cs_phaser1_lfo LFO frequency.
2014-11-03 17:29:11 -05:00
7204702c3f
Reduce coupling between Plugin and PluginInsert.
2014-11-03 13:40:50 -05:00
68507badd9
Fix compilation with old LV2. Maybe.
2014-11-03 11:54:35 -05:00
6e8e3856cb
Show 3 decimal digits when printing values.
2014-11-02 18:47:22 -05:00
bb4e3a2916
add Gtkmm2ext::event_inside_widget_window()
2014-11-02 08:57:47 -05:00
d02d8337a9
Support pretty display of arbitrary plugin parameter units.
...
Try e.g. fomp:cs_chorus1 which has Hz and ms controls.
2014-11-02 02:10:24 -05:00
47c4929bc2
Display gain and midiNote plugin parameters/properties nicely.
...
Show fancy values on generic GUI controls, automation lane controls, and automation lane verbose cursor.
Fix text display of midiNote values.
Make bigstep of midiNote parameters 12 (one octave).
Add ARDOUR::value_as_string() as a stateless one-stop-shop for value printing.
2014-11-02 02:10:24 -05:00
8a128b33d3
Automation of LV2 plugin properties.
...
Work towards ParameterDescriptor being used more universally to describe control characteristics.
2014-11-02 02:10:24 -05:00
6dfb11c2d0
Move ParameterDescriptor from Plugin to its own header.
...
This fixes circular dependency issues that arise when using ParameterDescriptor more widely.
2014-11-02 02:10:24 -05:00
bd6ba1717e
Decouple ControlUI from port index.
2014-11-02 02:10:24 -05:00
b6d8805961
properly initialize variable (amend cffd18d2d8)
2014-11-02 02:50:28 +01:00
cffd18d2d8
implement spin-button internal<>interface bridge
...
Widgets were written to use "[User] Interface" values, but the
spinbutton in a Bar-controller should allow to directly access
the "Internal Value".
2014-11-01 18:24:31 +01:00
049c11de58
Slider Controller API Change
...
Prepare to allow BarController (with Spinbutton) to translate
internal/interface values for the SpinBox.
(The change is irrelevant for the fader/slider itself which
always use the [user-]interface value)
2014-11-01 18:22:29 +01:00
d948e4cc91
Add a newly introduced header file to our MSVC project (libardour)
2014-11-01 13:53:55 +00:00
660e8c4425
don't print error when announcing property values for plugins that have none
2014-11-01 07:27:36 +01:00
002ebcc4ea
increase fine grained control (Ctrl+Alt+[drag|scroll])
2014-11-01 07:27:35 +01:00
c855d17e09
Fix compilation against older LV2.
2014-10-31 21:03:12 -04:00
5de6c21ec1
More generic RT-safe implementation of LV2 properties.
2014-10-31 20:46:43 -04:00
324ab35abc
Use precise define names for LV2 version configure checks.
2014-10-31 20:46:09 -04:00
0a60077a61
Fix spelling error.
2014-10-31 20:46:09 -04:00
8d4cbc4cc1
fix Dummy DSP load on win32 & low-pass filter load
...
g_get_monotonic_time() has millisecond granularity,
use performance Counter if available
2014-10-31 22:51:47 +01:00
f02610b47c
LV2 patch amends:
...
* fix Label (user readable key)
* check if patch range is a file Path
* free some lilv-nodes (plug small mem leak)
2014-10-31 19:42:28 +01:00
90872c2b31
more changes for rectangle outlining
2014-10-31 10:56:08 -04:00
a942493565
comment fix and expansion re: Canvas::Rectangle outline
2014-10-31 10:56:08 -04:00
b8cea19b95
prototype [LV2]patch-change support for generic plugin UIs.
2014-10-31 03:26:47 +01:00
973d40e3ac
Add support for USE_CAIRO_IMAGE_SURFACE when building with MSVC
...
(new preprocessor directive - greatly improves CPU loading)
2014-10-29 17:36:30 +00:00
dc39448a22
turn pixfader into a cairowidget
2014-10-28 02:18:46 +01:00
b04414d170
allow to use cairo-image/software surface for canvas & cairowidgets
2014-10-28 02:15:10 +01:00
6dc3a4bf61
remove unused old API
2014-10-28 01:27:14 +01:00
e02efddb21
skip meter re-draw when no pixels are changed.
2014-10-25 17:28:14 +02:00
a6ceff61dd
proper solution for variable-args jack_client_open()
2014-10-25 17:28:13 +02:00
9239a49a32
Add some newly introduced source files to our MSVC project (gtkmm2ext)
2014-10-24 18:45:53 +01:00
85eda0a5f3
Add some newly introduced source files to our MSVC project (jack_audiobackend)
2014-10-24 18:45:52 +01:00
3d39689769
Some minor bits of casting to keep MSVC happy when building 'backends/jack/weak_libjack.c'
2014-10-24 18:45:51 +01:00
f900711136
port changes to ARDOUR::Location and ARDOUR::Locations APIs from Tracks to Ardour.
...
Fixes deadlocks caused by mutex on Locations list, and clarifies the purposes and uses of the class-level and
object-level change-related signals.
2014-10-24 12:18:46 -04:00
2f4a8cf693
avoid const cast warning
2014-10-24 12:18:46 -04:00
65036cf3eb
add #include that had gone unnoticed before
2014-10-24 12:18:46 -04:00
b52304661f
fix screwup in prev commit-diff
2014-10-24 17:19:28 +02:00
5e7f935a27
add explicit construction (for MSVC) and some debug messages
2014-10-24 17:15:03 +02:00
25a6aa57a3
fix jack transport return value
2014-10-24 16:19:44 +02:00
e025cc008c
use x-macros to simplify weak-jack implementation
2014-10-24 15:18:38 +02:00
ad09be8c78
fix libjack names
2014-10-24 14:36:04 +02:00
1e357b5109
fix 64bit compile with old gcc
2014-10-23 20:42:02 +02:00
2bc3ec6ab3
add new Gtk2mmext::EmScale class for measuring font-based sizing
2014-10-23 13:21:04 -04:00
9a60bb58b2
skip unavailable backends early on.
2014-10-23 16:53:14 +02:00
d991bb10ca
add 'available' interface to the AudioBackendInfo
...
If a backend can be loaded, it does not mean that it can be used;
e.g. weak-linked jack-backend if libjack is not available.
2014-10-23 16:53:14 +02:00
f3ff1b9669
weak/runtime jack linking: load libjack dynamically at runtime
2014-10-23 16:53:13 +02:00
730e09ce65
another round of compiler warning fixes
2014-10-23 05:31:40 +02:00
c6a3d6bc48
small round of compiler warning fixes
2014-10-23 03:43:04 +02:00
f7211ff8f7
fix jack/mingw compilation
2014-10-22 23:57:55 +02:00
679356c5ee
fix delivery of MMC events under split process cycle conditions
2014-10-22 17:07:11 -04:00
e32a8e8260
require a timestamp on MIDI::MachineControl::send()
2014-10-22 17:07:11 -04:00
a289947b4f
fix timestamps for immediate MIDI events to deal with split process cycle conditions
2014-10-22 17:07:11 -04:00
bd97450ef8
error/debug output when dropping MIDI event due to timing now shows MIDI bytes
2014-10-22 17:07:11 -04:00
aafd1d77e9
remove unused code
2014-10-22 17:07:11 -04:00
68458cde69
fix all 4 backends' failure to include the main "backend" thread when computing ::in_process_thread()
2014-10-22 17:07:11 -04:00
aa0effb4cb
ignore negative value locates and MMC locate commands
2014-10-22 17:07:11 -04:00
3ddd797e46
remove obsolete jack includes in libardour
2014-10-22 16:56:12 +02:00
fbaae45eb1
stopgap solution for VST plugins that call audioMasterWantMidi during effOpen
...
audioMasterWantMidi needs plugin _info, but _info is currently only
available after instantiating the plugin in LXVSTPluginInfo::load().
vstfx_instantiate() -> effOpen -> [plugin] -> vst_callback(..,opcode=6,..) -> crash
2014-10-20 23:30:49 +02:00
825e2c823c
add support for VST plugins without any parameters
2014-10-20 23:30:48 +02:00
ffde2fb5f9
OS 10.10 compile fixes
...
* fix clang pickiness regarding boolean
* ignore ‘verify’ macro
* tested with Apple LLVM version 6.0 (clang-600.0.51) (based on LLVM 3.5svn)
2014-10-19 23:15:13 +02:00
ab445a0e28
windows: don’t popup message box when libjack is not found
2014-10-17 10:58:49 +02:00
d34bd9e6a0
fix midi automation sliders
...
Allow controls to work without a list. see also 34c1465b469cd2
2014-10-16 21:21:45 +02:00
0477d11476
when cancelling an import, call DropReferences so that the Session forgets about the new sources.
...
Not doing this leaves the sources in the session list and then the session fails to open on next load
because the files are not there.
Arguably we should not announce the new files until they are complete, but this is a simpler fix for now.
2014-10-15 21:12:35 -04:00
49b9d22217
remove debug output
2014-10-15 19:08:46 -04:00
5d53335300
when flushing notifications/signals from an ARDOUR::Playlist, emit the RegionAdded/ContentsChanged signals first so that when LayersChanged is sent, the receivers know about all the new regions
2014-10-15 18:44:22 -04:00
ab658d7ca1
add mutex/lock to all Evoral::SMF methods that use _smf/libsmf, to avoid inadvertent corruption via multithreaded access.
...
Serialization of Session::save_state() will already protect against most of this, but there is really no
good reason why Evoral::SMF's API should require single-threaded/explicit serialization.
2014-10-15 18:44:22 -04:00
7e764ea405
allow internal generators to make noise, even if we are not rolling, and using auto-input
2014-10-15 11:09:00 -05:00
8dc4187f1a
allow zero-latency sessions
...
e.g. sessions with disconnected master-out,
or Dummmy (both jack and ardour) with no latency.
2014-10-15 15:49:49 +02:00
76edbdf5dc
make backend selection by product name more explicit
2014-10-14 16:58:11 -04:00
d3a4a92bd5
Containers should not consider the size of invisible items when computing their own bounding boxes.
...
This fixes issues related to the rulers container believing it was taller than it actually is, and possibly other issues also
2014-10-13 22:40:08 -04:00
b945fa69ba
remove default/testing tooltips from the canvas
2014-10-13 13:53:07 -04:00
7263877f06
tweak implementation of Session::audible_frame() to be a little more defensible, and correct problems with record align/playhead position while disconnected from physical outputs
2014-10-12 23:09:35 -04:00
848db8fbd5
fix scanning of VST shell plugins
2014-10-11 22:19:23 +02:00
250ea066ef
revert 8ca546e - original version was correct (note added)
2014-10-11 15:00:52 +02:00
8525a0b258
add a Dummy Backend Loopback mode:
2014-10-11 14:47:35 +02:00
8ca546ec88
fix LTC generator latency compensation.
2014-10-11 11:15:08 +02:00
fa9780ba67
subtle changes to accomplish two goals (1) playhead should stop where the user pressed stopped (2) captured regions should end where the playhead ends
2014-10-10 13:22:50 -04:00
d1e303247b
ensure registration of all SessionEvent types
2014-10-10 13:22:50 -04:00
446a8b69d9
make output of SessionEventManager::dump_events() a bit more readable
2014-10-10 13:22:50 -04:00
472900f4ff
cleanup unused nested regions:
...
This and two previous commits fixes #5979
2014-10-10 14:12:48 +02:00
5b25dbba03
Properly count nested regions
2014-10-10 14:11:43 +02:00
9df1d1ef2e
re-reference regions during uncombine - #5979
2014-10-10 14:05:49 +02:00
b4cf5e279b
fix dup free in waves/midi:
...
The PortMidi queue just holds a pointer to the midi events.
The same Midi events are free()d during WavesMidiBuffer::clear()
which is called at cycle start for every buffer and in the dtor
of the WavesMidiBuffer.
2014-10-09 09:48:54 +02:00
4af4938c25
fix wavesbackend midi timing
2014-10-09 09:43:53 +02:00
aac3ca5521
initialize some uninitialized vars - closes #5974
2014-10-08 19:16:21 +02:00
8d12ebd972
MSVC - add support for 'HAVE_NEW_LV2'
...
(after updating to the latest versions of serd, sord, sratom and lilv)
2014-10-08 15:11:27 +01:00
50ab3db0ca
When building 'libs/pbd/cpus.cc' (with MSVC) make sure we know what 'PTW32_VERSION' is
2014-10-08 15:11:26 +01:00
2d04ac9796
Add a newly introduced header file to our MSVC project (dummy_audiobackend)
2014-10-08 15:11:25 +01:00
000609901b
add correct copyright statements to all files in Waves backend except those derived from portaudio/portmidi
...
This follows the letter sent from Waves Audio Ltd. to Paul Davis dated February 20th 2014 agreeing to release this code
under the GNU Public License, version 2, with copyright owned by Waves Audio Ltd
2014-10-07 16:17:34 -04:00
118adc286b
fix crashes for plugin using maxBlockLength during latency compute.
2014-10-07 21:48:04 +02:00
ce818efe37
avoid a set of calls to gettext() and/or cousins from global constructor scope
2014-10-07 14:27:12 -04:00
a7da906a79
NOOP, proper label for flat carbon header includes
2014-10-07 16:53:10 +02:00
7bfa25777b
OSX 10.9.5 compile fixes - part one
2014-10-07 14:46:06 +02:00
94e7015c70
64bit windows VSTs
2014-10-05 18:11:11 +02:00
114296d958
fix VST user cache typo: info/blacklist
2014-10-05 02:57:14 +02:00
adefca9dd2
use single newline char in VST info files.
...
windows writes \r\n to non-binary files and the VST
info parser does not handle that case.
2014-10-04 18:01:43 +02:00
29d89f0128
update VST scanner lookup (prepare for moving to BINDIR)
2014-10-04 17:57:05 +02:00
0af091edf3
fix ming32 build&install for asio backend
2014-10-03 00:46:34 +02:00
b376042166
Add UK English translation for libardour
2014-10-02 18:03:19 +01:00
44f71ce599
Text tweaks and typo fixes
2014-10-02 18:03:19 +01:00
8fe3360c35
fix clock_gettime detection
...
fixes compilation with mingw64 gcc-4.9.1
2014-10-02 02:53:35 +02:00
aeda6cbea9
add --with-wavesbackend config option (disabled by default)
2014-10-01 18:28:47 +02:00
3d12a4da82
fix deep obscure problem with loading multiple backends on OS X
...
all backends export a symbol declared as "extern "C" ARDOURBACKEND_API ARDOUR::AudioBackendInfo* descriptor ()".
dlopen'ing the backend apparently pushes the symbol "descriptor" into the single flat global namespace that we use
to be like other unix-like systems. this means that if a backend calls its OWN function named "descriptor", it
is indeterminate which one it will be, since the symbol will refer to the function first loaded by the runtime
linker. If the backend is not the first one discovered, this call to its own "descriptor" function will invoke
the function defined by another backend, even though these are supposed to have local scope only according
to our arguments to dlopen().
This fix doesn't try to fix the linker or namespace - it just makes sure that the WavesAudio backend doesn't
invoke its own descriptor() function, which it never really needed to do anyway.
2014-09-30 22:57:05 -04:00
cd60fd9dfe
untested fix for compiling waves audiobackend on case-sensitive FS with mingw.
2014-10-01 04:02:30 +02:00
9838616679
NOOP, re-indent
2014-10-01 03:25:03 +02:00
32e05fa640
update backends for API change in 8d59afb048
2014-10-01 03:24:54 +02:00
a927b79c26
Implement the new pthread macros (for the Waves audio backend)
2014-09-30 21:00:35 -04:00
3033c1cc54
Re-introduce our pthread macros (after fixing an earlier typo)
...
these are so we can differentiate between 'libpthread' and 'libpthread-win32' (whose implementation is subtlely - though annoyingly! - different)
2014-09-30 21:00:35 -04:00
8d59afb048
copy over current Waves version of their backend, along with minor changes in libs/ardour and libs/backend/jack to fit with API changes
2014-09-30 21:00:34 -04:00
38e975d6b1
tweak backends wscript for cross-compiling with mingw
2014-09-30 21:00:34 -04:00
8e01b411b2
copy over current Waves version of their backend, along with minor changes in libs/ardour and libs/backend/jack to fit with API changes-a
2014-09-30 20:23:45 -04:00
fdf83c620d
use .exe suffix for VST pluin scanner app on windows
2014-10-01 00:12:45 +02:00
5b4c3aa226
win32_pthread is relevant for both: MSVC & MINGW
2014-09-30 19:08:16 +02:00
1bde96be09
there's no random() on window, but no matter
2014-09-30 19:08:16 +02:00
822b5443fe
add missing header include (for snprintf)
2014-09-30 19:08:16 +02:00
f44501504c
partial fix for #5973 (multi-track midi file import)
2014-09-28 20:36:04 +02:00
56f5bcffce
copy plugin-state from template on session creation (amend 3353b48)
2014-09-28 19:25:40 +02:00
3353b48646
fix templates: copy plugin state
2014-09-28 18:24:08 +02:00
6fbd0a62e4
recursive file copy function
2014-09-28 18:24:08 +02:00
b4438942ca
fix compiler warning from missing default statement in switch
2014-09-27 18:09:22 -04:00
2a53154892
end tooltip timeout and display for relevant leave notify events
2014-09-26 17:06:38 -04:00
df5a188825
further tweaks to canvas tooltip mechanism
2014-09-26 12:24:47 -04:00
bb68d83e43
display and position canvas tooltip window
2014-09-26 11:05:24 -04:00
d0dafc171c
basic design of Canvas item tooltip mechanism.
...
No window yet to actually display the tooltip.
2014-09-25 21:43:15 -04:00
3ec0f367c1
next (final?) part of handling missing MIDI files.
...
If an external-to-session file is missing, consider it a fatal error in session loading.
If an internal-to-session file is missing, just create a new MIDI source with the same path and ID, and use that instead.
2014-09-24 19:04:05 -04:00
186493687b
DummyBackend: symmetric freq sweep: up/down
2014-09-24 18:46:54 +02:00
6dfb8c5c8a
DummyBackend: add sine-sweep generators
2014-09-24 17:24:25 +02:00
86672a5c5c
fix some double promotion
2014-09-24 17:18:20 +02:00
3f9e916fe2
DummyBackend: two more audio-signal generators (useful for waveform check)
2014-09-24 01:26:51 +02:00
b355f01aa5
DummyBackend: MIDI Event Generators
2014-09-24 01:26:51 +02:00
99a484f193
ALSA backend: initial device selection
2014-09-24 01:26:51 +02:00
a72536dbb0
fix typo that selected wrong sample rate for 22050Hz export
2014-09-22 14:31:06 -04:00
2e2390d053
alter the way the border of Canvas::Rectangle is drawn to meet the intent that a single pixel border passes through the corner coordinates
2014-09-22 11:36:04 -04:00
45fd3593eb
Fix finding session templates
...
Session templates are directories: use find_paths_matching_filter() rather
that find_files_matching_filter() to search for them. Fix a tiny comment
typo I spotted along the way too.
2014-09-22 13:21:14 +01:00
5c7d6ae004
add Location::set_skip() to allow toggling of skip-functionality for a given Location
2014-09-19 23:21:31 -04:00
5bdc9a9a23
duplicate all ARDOUR::Location signals so that we have one static signal that identifies the subject location and one member signal that does not
2014-09-19 22:51:27 -04:00
ceff2e3a62
plugin widgets were written to use Internal values, so use that for now
2014-09-18 17:25:11 -05:00
41f13c0109
Fix some inconsistent usage of a Controllables Interface value.
...
This breaks a lot of controls, because they are misusing it as well.
2014-09-18 16:35:03 -05:00
cfc658de04
do not mark session dirty during loading process; sync with loaded locations state using standard method
2014-09-17 12:28:09 -04:00
69bfc841a2
use Config->get_skip_playback() when handling Skip events
2014-09-17 12:27:21 -04:00
dd4d7cf8be
new Config var to control whether skip playback is used or not
2014-09-17 12:26:52 -04:00
7021ac07d8
add IsSkip enum to enums.cc
2014-09-17 12:26:28 -04:00
ebd7bc7447
add new Skip event to SessionEvents
2014-09-17 10:31:33 -04:00
73f2baf5c6
Locations::clear_ranges() leaves punch/loop/session ranges intact if they exist
2014-09-17 09:38:42 -04:00
2e81bab899
add new type of location, with _flags & IsSkip being non-zero
2014-09-16 21:40:12 -04:00
99ac4755af
header file part of initial attempt to push certain kinds of Locations into LocateRoll events on the timeline for skip lists
2014-09-16 21:33:18 -04:00
80c0400cda
initial attempt to push certain kinds of Locations into LocateRoll events on the timeline for skip lists
2014-09-16 21:32:58 -04:00
b592ce3e44
Locations should listen to location changed signals, and emit its own changed() signal
2014-09-16 21:31:19 -04:00
78f55f2e4d
change Location "change" signals of various kinds to be static
2014-09-16 21:30:16 -04:00
9be64f2648
add a focus handling callback so that all button press events on CairoWidgets will cause a focus reset.
2014-09-16 12:42:39 -04:00
b3c78e906c
if a (file) source really cannot be found, differentiate between audio & MIDI.
...
For now, recovering from missing MIDI is a no-can-do situation (because MIDI is inherently data-editable).
2014-09-15 14:09:12 -04:00
9a3cf7a10b
fix up condition where a MIDI filesource is marked empty, not found, and its _path member is not set correctly
2014-09-15 14:09:12 -04:00
596a9247bd
FileSource should not generate its own error message when a file is missing
2014-09-15 14:09:12 -04:00
c96ec968c7
tentative fix for losing (empty) MIDI files. Incomplete because testing shows issues with some workflows
2014-09-15 14:09:12 -04:00
dbc34ab4da
fix compiler warning
2014-09-15 14:09:12 -04:00
076bb0b488
change dummy backend to default to _("Silence").
2014-09-13 22:51:42 +02:00
d8e64103a6
fix CPI window handling:
...
Move control-surface editor-window management to the control surface.
The Preferences-Dialog is not aware of session specific or surface
specific actions and cannot properly manage the window.
2014-09-13 16:59:02 +02:00
c3a5cd487a
Return playhead to last start position when aborting capture
2014-09-13 15:27:30 +01:00
6549fcbd86
Fix spurious 'You cannot put a CD marker at this location' error
...
Fix the spurious error that occurs when loading a session where any marker
(not necessarily a CD marker) is located at 0 on the timeline.
2014-09-13 15:27:30 +01:00
982b95fb47
Be sure to initialise ExportFormatSpecification::_soundcloud_upload
...
Initialise _soundcloud_upload in all constructors of
ExportFormatSpecification.
2014-09-13 15:27:30 +01:00
e5a20e1f9e
Add 2 new source files to our 'gtkmm2ext' project (MSVC)
2014-09-13 09:56:58 +01:00
3da9c3b740
NOOP, remove trailing whitespace
2014-09-13 01:48:10 +02:00
aa83f1a8c7
waveform drawing details:
...
* proper y-pixel alignment (+.5px offset)
* outline: draw dots (not 1px lines)
* shape: round towards peak (use signal, not top/bot)
* honor 2px red selection border
* work-around canvas rect +1 issue
* always draw clipping line towards center
* draw at most one clip-line at either side of 0.
* exact 1px wide zero line
* fix spread calculation for rectified view
2014-09-13 01:48:10 +02:00
e3d063004b
add required visibility macros to Gtkmm2ext::CursorInfo
2014-09-12 14:33:36 -04:00
878797d13e
waveform: really draw 1px lines.
2014-09-12 16:43:20 +02:00
98249a2563
update waveform drawing for zoomed-in, non-overlapping min/max peaks
2014-09-12 16:42:55 +02:00
f3f80900f1
fix crash at session close/exit if a midi-control-surface is used
...
The "real" problem was that MidiControlUI is destroyed
while there are still MIDIControllables around that
still have a signal connection to a Controllable:
controllable->Destroyed(..., MidiControlUI::instance())
If a Contrallable is deleted after the MidiControlUI
event loop is gone, the Destroyed() signal can create odd
situations...
2014-09-11 19:30:33 +02:00
01974b5769
API flush static cairo pattern cache
...
(should probably be cleaned regularly
e.g. meterbridge resize)
2014-09-11 19:30:33 +02:00
56f4e1513e
provide compile-time-enabled/disabled debugging of connections being made to PBD::Signal via PBD::SignalBase::set_debug_connection()
2014-09-11 12:04:14 -04:00
5dd5bb7830
make valgrind output a bit more readable.
2014-09-11 03:04:12 +02:00
bfcd96533c
fix memory leak, changing semantics of PatchManager (needs x-check)
2014-09-11 03:04:12 +02:00
df19c576c7
fix a bunch of memory leaks
2014-09-11 03:04:11 +02:00
c4a7d25b34
properly retain LV2PluginInfo
2014-09-11 03:04:11 +02:00
7449de6e8f
fix/improve/test hotspot file parsing
2014-09-10 19:39:52 -04:00
13cd2110e6
add copyright header comments
2014-09-10 18:50:58 -04:00
90059a9504
move CursorInfo members into public access
2014-09-10 18:38:30 -04:00
c4f7aae7d5
add new (mostly) static class to permit lookup of cursor image hotspots
2014-09-10 16:50:10 -04:00
6f59288f9e
print "Scanning folders for bundled LV2s" only once.
2014-09-10 20:44:17 +02:00
f6766d4a2f
delete route-groups before flushing routes.
2014-09-10 20:43:30 +02:00
2498495523
disable Midi Audition Synth if it cannot be found
...
no repetitive messages.
2014-09-10 16:55:49 +02:00
d383205fe7
better safe than sorry.
2014-09-10 13:11:22 +02:00
b26ecdda63
fix d421602c24
2014-09-10 12:49:21 +02:00
d421602c24
delete session XML object after loading and setting state.
2014-09-10 05:18:09 +02:00
cab09d87b8
free LV2 world after initial scan
2014-09-10 03:31:03 +02:00
a361781e08
plug a major mem hog.
...
(default empty session is now ~140MB RSS, was 280MB)
libXML memory was only free() at exit
2014-09-09 23:53:27 +02:00
e60f03c54c
fix scoomer scroll-wheel max value
2014-09-09 14:35:06 +02:00
2967226317
Add 'libs/pbd/pbd/pthread_utils.h' to our pbd project (msvc)
2014-09-09 12:06:47 +01:00
16b25a3028
Implement the new pthread macros (for the Waves audio backend)
2014-09-09 12:05:14 +01:00
61e0705a94
Re-introduce our pthread macros (after fixing an earlier typo)
...
these are so we can differentiate between 'libpthread' and 'libpthread-win32' (whose implementation is subtlely - though annoyingly! - different)
2014-09-09 12:03:52 +01:00
83b6825bd0
Revert "Add a couple of pthread helper macros"
...
This reverts commit 8d0ec2403f
2014-09-09 08:26:26 +01:00
1c6c3514ba
don't start track-resize on scroomer click
2014-09-08 18:43:28 +02:00
b1da9af8de
ALSA|Dummy: ignore port unregistration when engine is stopped
...
When changing Engine parameters, ardour first stops
the engine and only later when re-etablishing ports
unregisters/re-registers them.
ALSA: silently ignore port unregs and silently accept registrations
Dummy: print a PBD::info message,
2014-09-08 01:25:56 +02:00
dc318e6e74
ALSA|Dummy Backend: do as jack does:
...
when the backend is closed, unregister all ports.
2014-09-07 22:50:57 +02:00
330f5fdf2e
fix midi audition port-connect warning
2014-09-07 22:21:12 +02:00
a780e70f2a
add Session::record_location()
2014-09-07 11:33:47 -04:00
9ad3feaba0
rename system and user config files with product-neutral names
2014-09-07 10:20:29 -04:00
94adde7ebb
add Canvas::Ruler::set_metric() to allow ruler metrics to be changed dynamically
2014-09-07 10:19:42 -04:00
1a6136e1e3
change Metric element of a Canvas::Ruler item into a pointer internally
2014-09-07 10:19:31 -04:00
d68275cefc
one less annoying compiler warning.
2014-09-06 21:18:08 +02:00
404a77adb8
get installdir for libardouralsautil correct
2014-09-06 14:42:25 -04:00
a686374b9d
check for _port_handle == null throughout Port:: methods
2014-09-06 12:36:57 -04:00
d63a4edfbf
pass-though PixFader tweaks API for scroll events
2014-09-06 12:46:03 +02:00
6af935a3b8
updated .po files
2014-09-04 22:24:41 -04:00
48a851011b
add pixfader tweaks API:
...
* change API to hide unity/default value line
* allow to override vertical scroll [1]
* allow changing button event forwarding [2]
[1] override scrolling in track-headers
[2] dbl-click is needed for BarControllers -> switch to SpinBtn
but a plain Slider on a track-header should not forward
these events to the TAV (they may trigger name-edit)
2014-09-05 02:24:19 +02:00
6408d90258
fix waf thinko in backends wscript
2014-09-03 18:44:34 -04:00
f2c0b2e318
revert pixfader to sane state (reverts parts of bb70d426)
2014-09-03 20:48:20 +02:00
bb70d426ba
bring back old pixfader outline radius to demonstrate its issues
2014-09-03 15:35:11 +02:00
73357c1923
revert pixfader radius to default
2014-09-03 15:09:54 +02:00
07a651d2ec
release shared route pointer kept by InternalSend when dropping refs.
...
fixes "SessionHandleRef exists across session deletion"
when using AuxSends
2014-09-03 05:20:28 +02:00
f684cc24ec
allow to set gtk style for BarController's pixfader.
2014-09-03 02:40:27 +02:00
1cd366b606
pixfader bg has reverse gradient from fg
2014-09-02 15:58:55 -05:00
9ecdb765aa
don't show 'unity-line' (default value) for barcontrollers
2014-09-02 16:05:54 +02:00
3b9b65879a
Barcontroller: no double expose when text chages
2014-09-02 16:05:21 +02:00
ecf5d5f137
tweak pixfader:
...
* update reserve so that round corners don't overlap
* draw complete 1px outline
* add API to hide/show the unity line
* don't show unity line at either end
* allow to shrink when the font-scaling changes
2014-09-02 16:00:24 +02:00
efb03f4596
unify BarController with Slider/Pixfader.
2014-09-02 05:14:19 +02:00
41ccf6a806
clean up pixfader API, prepare for merge w/BarController
2014-09-02 05:14:14 +02:00
3bfe91c010
remove cruft from SliderController
2014-09-02 05:14:06 +02:00
9f0caacc5c
rework pixfader:
...
* re-introduce static pattern cache
(cairo's cache is not nearly large enough for A3 + plugins)
* only use cairo_clip on rectangles (not arbitrary paths
-> major performance boost
* re-add fader pixel reserve
* fix mouse + scroll interaction
* fix unity line display (1px wider, brighten by 150%)
* cache text size
* fix various other issues and consistent whitespace
This reverts large parts of commit d439e93b1e
2014-09-01 22:02:51 +02:00
158037bba2
Match canvas outline to rectangle
...
It looks like we're currently [consistently] off by 1px
everywhere. The width-1 is compensated by
TimeAxisViewItem::RIGHT_EDGE_SHIFT = 1
2014-09-01 18:05:09 +02:00
34c1465cf9
Fix crash when changing automation mode for MIDI track control automation.
...
Also some work towards tolerating automation controls with no automation list,
towards actually doing something for these cases, though not required just to
fix this crash (MidiTrack::set_parameter_automation_state() avoids those
paths).
2014-08-31 18:57:22 -04:00
885f1c71ec
Remove unused variables (fix warnings).
2014-08-31 17:54:16 -04:00
c95c221493
Fix mismatched initialisation order.
2014-08-31 17:54:16 -04:00
154621978a
track-header fader tweaks:
...
* align height to button-height.
* align width to label text-entry
* increase min width
2014-08-31 21:32:22 +02:00
758c988e51
shadow-less Frame: explicitly draw background colored border.
2014-08-31 20:07:17 +02:00
50c3177a5e
remove frame from barcontroller
2014-08-31 19:36:41 +02:00
db34d9a556
proper round corners on focused TextEntry
...
IFF [xy]thickness is set > 2 for given Entry.
It seems gtk draws a base-color rectangle on
top, after clearlooks_draw_entry() is called.
This fills the complete area and voids previous
rounded rectangles in clearlooks_draw_entry().
setting [xy]thickness decreases the size of the
base rectangle.
2014-08-31 12:46:45 +02:00
7d3f0bfd75
prepare for clang static analysis of RT-functions:
...
see: https://github.com/fundamental/stoat
eventually more functions should be annotated, and
a common header file should be used to
#define REALTIME __attribute__((annotate("realtime")))
2014-08-31 07:50:17 +02:00
ca97569c55
disconnect pixfader style-change signal in dtor (amend 5a688b672)
2014-08-30 20:58:03 +02:00
5a688b672c
pixfader: use parent's background color
2014-08-30 04:19:42 +02:00
f5533213c0
fix some compiler warnings
2014-08-30 02:26:36 +02:00
585fa45b62
fix cairo widget background
2014-08-30 01:43:10 +02:00
40c3e4122c
try a different method of text display on automation bars
2014-08-29 16:35:20 -05:00
b0477f7f1e
fix plugin bypass button action
2014-08-28 15:29:18 -05:00
3f297f7dab
Fix ArdourButton event sequence.
...
Always give ArdourButton a chance to handle Press or Release events if you override them.
This allows ArdourButtons to do the "Pressed" animation
And it now correctly eats the event so button clicks don't select the channelstrip.
2014-08-28 10:31:57 -05:00
670f55f5e4
Add an extra folder to get searched (on Windows only) when looking for config files.
...
This is a preliminary test to find out if 'All Users' would be a better place for our (writable) config files, as opposed to the user's personal 'AppData' folder (which we used in Mixbus2). N.B. this should not effect any previous operations on Windows or non-Windows platforms.
2014-08-28 08:08:43 +01:00
65715dd298
Make sure all our VC projects agree that the product is called 'Mixbus3' (as opposed to just 'Mixbus')
...
It'd be nice if we could use 'ARDOUR::config_dir_name' for this purpose (or perhaps 'PROGRAM_VERSION'). However, neither is implemented widely enough at present to make this practical. Keep an eye on them though, as possible future strategies.
2014-08-28 07:57:20 +01:00
d439e93b1e
Standardize drawing of PixFader and BarController; implement flat_buttons and prelight.
...
Prepare for using Controllable interfaces, instead of passing in Adjustments.
ToDo: reimplement image caching in a standardized way across widgets
2014-08-27 11:58:09 -05:00
e7a15027e8
refactor flat_buttons into cairowidget, and add a canvas-like convenience function for setting cairo color with a Gtk::Color
2014-08-27 10:55:01 -05:00
a7226133a9
refactor _grabbed into cairo_widget
2014-08-22 11:49:59 -05:00
nick_m
7099f0ec4e
Add backwards compatibility for instant.xml changes.
2014-08-14 03:19:40 +10:00
nick_m
34bf7457c6
Move ExportProfile xml from Session instant.xml to session file.
2014-08-14 02:52:42 +10:00
126d6d3aae
fix new backends wscript to work correctly in the Ardour case
2014-08-08 11:00:30 -04:00
16e37d975f
use some structured code to decide which backends to build (should have cherry picked from waves' code but ...)
2014-08-08 10:57:20 -04:00
1873bcfa9d
More fixes for range-based automation editing.
...
-Remove redundant start_grab calls.
-Show gain curves in Range mode, so you can see the curves you are selecting
2014-08-06 14:43:40 -05:00
16ca4e0f9a
Initial steps towards usable range-based automation editing.
...
TODO: needs undo. only works in top quarter of automation lane. selection model feels weird sometimes. needs to show gain curve when you are using Range tool
2014-08-05 15:42:06 -05:00
45afed5e9a
Modify our VC project files to work with msvc32-fixup.pl
2014-08-04 09:02:17 +01:00
f296389fe0
Enforce mixer strip widths, more case fixes, and minor theme changes
2014-08-01 15:44:42 -05:00
b128271f29
consistently use mixed-case labels
2014-08-01 14:31:18 -05:00
b75b88a1eb
Use text to specify combo box padding for better font/display tolerance.
...
Consistent mixer strip button height.
The latter works by setting all the button size request heights to the
calculated height of the alphabet. Thus, all buttons of the same class will be
the same height regardless of their actual text.
2014-07-30 18:30:42 -04:00
21ea94c000
grouped faders should have relative gain by default
2014-07-28 16:20:24 -05:00
ed07c53210
clean up cruft in some config variables
2014-07-28 15:55:20 -05:00
df2a8fccc7
disallow selection of the fader and meter processor entries
2014-07-28 10:08:26 -05:00
966ed85005
Add provision for 'PROGRAM_VERSION' (MSVC libardour project)
2014-07-27 11:37:04 +01:00
59822e8dd2
Minor change to 'pbd/controllable.h'
...
(in MSVC, 'min' & 'max' are not in namespace std)
2014-07-27 11:28:23 +01:00
576f39d6a0
Add the MSVC project file for building libs/surfaces/osc
2014-07-27 11:26:41 +01:00
e85ff4dad2
Cut and Copy should remember the white space at the end of a range.
...
This will be used when you paste with Ripple; it maintains the whitespace that you chose in the selection.
Also fix default setting of Dim contol by storing the default(normal) value for MPControl Controllables.
2014-07-23 14:36:21 -05:00
7984cd2321
Changes needed for building surfaces/osc (control surface protocol) with MSVC
...
(for testing on the non-Windows platforms)
2014-07-22 22:19:46 +01:00
fdaa6a151a
3 monitor tweaks for the_CLA. shift+click to default, and new preset vals
2014-07-22 16:05:51 -05:00
5424119b55
Merge branch 'waveview_hacks' of https://github.com/nmains/ardour into cairocanvas
2014-07-18 10:46:22 -04:00
5044feec95
more canvas debugging for current item tracing
2014-07-18 10:43:52 -04:00
b2b736d596
tweaks for the monitor section. refactoring of some buttons, using new ArdourKnob instead of VolumeController. New ArdourDisplay shows a controllables user value, and provides support for preset values (hardcoded at present). Further refactoring to come, so that ArdourWidgets are derived from a common class. Controllable now has more responsibility for scaling between internal, user, and interface (knob percent) values. This also needs more refactoring and might have some unintended consequences. tested with audio and nothing seems amiss, yet.
2014-07-18 08:47:45 -05:00
ac9219a3c8
LV2: don't leave active plugins deactivated after latency-compute-run
2014-07-16 17:08:42 +02:00
692f69ba14
parameterize the version number used to define the config directory name
2014-07-16 08:15:18 -04:00
67788b7136
monitor knobs tweaked to better match the theme of other buttons
2014-07-15 14:58:43 -05:00
928881b24a
Update vcproj files for changed LILV config define.
2014-07-15 15:50:12 -04:00
9869e2704a
Support saving LV2 presets multiple times ( fix #0005949 ).
2014-07-15 15:49:47 -04:00
fe9f2b15b1
Support midnam files with a channel (not patch) NoteNameList.
2014-07-15 15:18:18 -04:00
nick_m
d3408844be
Render waveview components onto alpha masks to simplify drawing.
...
Reduce user panic by removing ! from missing file dialog title.
Use justify left in missing file dialog.
2014-07-15 21:59:22 +10:00
849d80bfcc
Group the Rec and Monitor buttons together. Group the Solo Isolate and Lock buttons together. And add a method to show/hide each group in the Preferences
2014-07-14 10:08:55 -05:00
4af088c251
DummyBackend: add Uniform White Noise Generator.
2014-07-11 18:05:59 +02:00
12025d4ffa
possible fix for win SystemExec::wait()
...
if it does not help, use CREATE_NO_WINDOW and/or peek/pump messages :(
2014-07-11 17:03:55 +02:00
c83b7ebc3c
fatal error if vfork-exec-wrapper cannot be found (on unix systems).
2014-07-11 16:43:50 +02:00
6990c31ed5
Merge branch 'cairocanvas' of git.ardour.org:ardour/ardour into cairocanvas
2014-07-11 09:59:59 -04:00
94e0841625
catch null vfork_exec_wrapper before it is too late
2014-07-11 09:58:45 -04:00
15de7aa433
Make our 'libs/timecode' project dependent on libpbd
...
This is needed because one of its source modules now references 'rint()' (which isn't available in MSVC, although we already simulate it in libbd).
2014-07-11 12:56:18 +01:00
c81604bc18
Add newly introduced (MD5) sources to our MSVC project (also, add visibility stuff to the new MD5 class)
2014-07-11 12:56:17 +01:00
8859ebe56e
add Gtkmm2ext::Keyboard::reset_bindings()
2014-07-10 11:04:04 -04:00
0622a0cc30
add libardour infrastructure for "fade range" edit operation
2014-07-10 08:16:55 -04:00
94c8b672c4
do not call basename_nosuffix() before using matching_unsuffixed_filename_exists_in() because the latter does that call itself.
...
As the code used to be, if we are testing for a candidate filename of aaa.bbb.ccc, the call strips .ccc and matching_... strips .bbb
resulting in a match with aaa, which is not intended at all.
2014-07-10 08:16:27 -04:00
b9c53ea395
add std::string variant of set_size_request_to_display_given_string()
2014-07-09 16:48:36 -04:00
9f4a00fa89
add mixbus profile which removes the tearoffs
2014-07-09 15:12:05 -05:00
cfca056f19
make sure that copy constructors and operator= for ControlList pass along the _interpolation value
2014-07-09 14:30:38 -04:00
9e8b50f075
make AutomationList::operator==() private and abort() as its core, because it should never be called/used.
...
Also make AutomationList::operator=() use ControlList::operator=() rather than try to reimplement it
2014-07-09 14:30:38 -04:00
9bfe716239
remove debug output
2014-07-09 12:06:36 -04:00
3fae5f15af
fix crash initiated by never configuring track write sources when reloading a session, caused by earlier commits to avoid unnecessary write source resets
2014-07-09 12:03:22 -04:00
f2699194d3
do not return auditioner as part of Session::get_tracks()
2014-07-09 12:02:22 -04:00
73d98df3d2
add Session::get_tracks()
2014-07-09 11:29:26 -04:00
1fd4d40dbb
add mutex to prevent concurrent session state saves.
...
Why wasn't this done 10 years ago?
2014-07-09 10:18:28 -04:00
7364ca213a
do not attempt to save undo history if it is empty, and do not do any part of history save if we're not going to write a new file
2014-07-09 10:10:44 -04:00
0e5d86a825
don't save state when removing sources during session loading (though this should no longer happen)
2014-07-09 10:09:49 -04:00
