13
0
Commit Graph

32166 Commits

Author SHA1 Message Date
b35a8f6626
Fix Wsign-compare, consistently use microseconds_t 2021-06-29 02:04:02 +02:00
1c0bef3f85
Remove redundant checks
update_ghost_note() can only be called with a valid, non-null
_ghost_note. Explicit checks trigger clang static analyzer to
report false positives, since _ghost_note is unconditionally
used in this method as well.
2021-06-29 01:53:56 +02:00
bd6fb8f172
Fix issue when importing m4a
PBD::RingBuffer<>::rw_vector can return a NULL pointer
for the 2nd buffer, which can lead to undefined behavior:
`memcpy (NULL, src, 0);`
2021-06-29 00:11:17 +02:00
f8a5d45b7a GUI side of microseconds_t => int64_t 2021-06-28 14:47:48 -06:00
b20a541d7e change PBD::microseconds_t to a signed type and check for -1 in TimingStats::update
This may help a Windows issue with the return value of QueryPerformanceCounter
2021-06-28 14:47:48 -06:00
45c8944789
Fix mac builds - amend b01fe8b0e 2021-06-28 20:58:36 +02:00
558d9d4897 russian translation updates (GUI) from alexandre prokoudine 2021-06-28 09:51:20 -06:00
5c3e5f9afb fix handling of SMF files with consecutive noteOn events
We no longer store nascent notes when noteOn is received, but wait till noteOff arrives. We also
ignore all other noteOn events between the earliest received and the noteOff.

Potentially we may want to use the _overlap_pitch_resolution member at some point
to offer control of this behavior.
2021-06-28 08:30:38 -06:00
f715edf7bc
Yet Another Splash Push/Pop Fix
Don't explicitly `show()` the splash when a message arrives.
On macOS and Windows the splash is not z-axis re-stacked but
hidden. Calling show() makes it visible again.
2021-06-28 15:52:32 +02:00
b01fe8b0e4
Fix crashes when unloading mac VST2 plugins
CFBundleRef is reference counted, so we need to retain
a reference. Previously it went out of scope at the end
of mac_vst_load().
2021-06-28 15:46:27 +02:00
5e54425a35
VST2: Consolidate support methods (close, unload) 2021-06-28 15:42:57 +02:00
John Emmas
09589c3c94 Add/remove source(s) in our MSVC project (libpbd) 2021-06-28 10:37:54 +01:00
537b8ff12d fix crash when context-clicking on a region/source cue marker 2021-06-27 22:13:54 -06:00
fe6e3615c7 changes to performance meter update code to allow for i18n 2021-06-27 13:32:46 -06:00
4fd639eca9 NOOP: remove incomplete comment 2021-06-27 12:48:29 -06:00
a261d399e0 microsoft docs say that only windows.h is required for QueryPerformance* 2021-06-27 12:17:51 -06:00
e2f2d0cb0f fix inadvertent typo that would cause compilation failure on windows 2021-06-27 10:53:31 -06:00
857a9b14d7 more macOS cleanup for microseconds.cc 2021-06-27 10:39:51 -06:00
347ca5c2fe clean up locally-created mess in libs/pbd/microseconds.cc 2021-06-27 10:28:53 -06:00
412b6a922d macOS: slight speed up for ::get_microseconds()
Move timebase initialization into microsecond_timer_init() and drop conditional
2021-06-27 10:23:44 -06:00
cce703bc9a
Resolve microseconds_t ambiguity #3 2021-06-27 17:49:31 +02:00
bcab07af63
Resolve microseconds_t ambiguity 2/2 2021-06-27 17:33:06 +02:00
b58dfc7f0f
Resolve microseconds_t ambiguity 1/2
This resolves a PBD vs ARDOUR namespace error for some compilers:
```
error: reference to 'microseconds_t' is ambiguous
libs/pbd/pbd/microseconds.h:29:19: error: candidates are: typedef uint64_t PBD::microseconds_t
libs/ardour/ardour/types.h:81:29: error:                  typedef PBD::microseconds_t ARDOUR::microseconds_t
```
2021-06-27 17:33:05 +02:00
6077cf1f7b Playlist UI Tweaks: only trigger playlist changes on a user-selection, not libardour
* avoid redundant updates when the user selects a playlist
* every track potentially has a playlist selector so avoid recursive updates
2021-06-27 09:54:06 -05:00
7b5d61b7a5
Fix transport master crash when switching backends
Port registration happens asynchronously. During the first process
callbacks the timecode/clock input ports may not have been
re-established.
2021-06-27 16:37:33 +02:00
db0691d236 macOS: fix compilation warnings on macOS versions where clock_gettime() is finally implemented 2021-06-27 08:24:59 -06:00
738b0ad21b
Fix OSX builds (amend 04df26244, a2b5962b6) 2021-06-27 05:09:07 +02:00
b904fdea5d switch PBD::Timing* to use PBD::get_microseconds() 2021-06-26 20:15:12 -06:00
31a2d6f555 window compilation fix 2021-06-26 19:09:07 -06:00
c2f7b12b0d window compilation fix 2021-06-26 19:02:47 -06:00
fb562ddb61 window compilation fix 2021-06-26 19:02:13 -06:00
74538b7114 window compilation fix 2021-06-26 18:58:23 -06:00
2678366555 window compilation fix 2021-06-26 18:53:28 -06:00
228231d914 window compilation fix 2021-06-26 18:47:08 -06:00
5c8df87205 window compilation fix 2021-06-26 18:43:17 -06:00
5289d44821 window compilation fix 2021-06-26 18:40:44 -06:00
d1967827ca compilation error fix for windows 2021-06-26 18:35:14 -06:00
b9a85c7dcd compilation error fix for windows 2021-06-26 18:34:46 -06:00
4c1dcb70bb compilation error fix for windows 2021-06-26 18:33:27 -06:00
a2b5962b6c add new files for PBD::get_microseconds() 2021-06-26 18:30:11 -06:00
6b6114eb75 GUI fix for get_microseconds() move to libpbd 2021-06-26 18:27:54 -06:00
9cbaa31c7e libs fix for get_microseconds() move to libpbd 2021-06-26 18:27:39 -06:00
04df262447 tweak libardour to reflect get_microseconds() move to libpbd 2021-06-26 18:26:13 -06:00
9e598548f7 put get_microseconds() into PBD namsepace
This implementation is a blend of the two previously in libs/ardour/globals.cc
and libs/pbd/window_timer_utils.cc
2021-06-26 18:25:02 -06:00
a2974b0c0b portaudio: improved compilation error fix 2021-06-26 12:56:49 -06:00
8bc4464309 portaudio: compilation error fix 2021-06-26 12:51:54 -06:00
7e858b9bda portaudio: add standardized DSP statistics to portaudio backend (uncompiled) 2021-06-26 12:32:23 -06:00
74c93f3ff3 coreaudio: fix dsp stats collection 2021-06-26 11:42:18 -06:00
a05bf30ccb CoreAudioSource: fix formatting error 2021-06-26 11:28:15 -06:00
c7bed1320e adding DSP stats to coreaudio backend (uncompiled) 2021-06-26 11:25:07 -06:00