ardour/livetrax
13
0
Fork 0
Code

Remove redundant checks

Browse Source 
update_ghost_note() can only be called with a valid, non-null
_ghost_note. Explicit checks trigger clang static analyzer to
report false positives, since _ghost_note is unconditionally
used in this method as well.
This commit is contained in:
Robin Gareus 2021-06-29 01:53:56 +02:00
parent bd6fb8f172
commit 1c0bef3f85
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gtk2_ardour/midi_region_view.cc
View File

@ -3934,6 +3934,7 @@ MidiRegionView::selection_as_notelist (Notes& selected, bool allow_all_if_none_s
void
MidiRegionView::update_ghost_note (double x, double y, uint32_t state)
{
assert (_ghost_note);
x = std::max(0.0, x);
MidiTimeAxisView* const mtv = dynamic_cast<MidiTimeAxisView*>(&trackview);
@ -3959,14 +3960,13 @@ MidiRegionView::update_ghost_note (double x, double y, uint32_t state)
}
/* ghost note may have been snapped before region */
if (_ghost_note && snapped_beats.to_double() < 0.0) {
if (snapped_beats.to_double() < 0.0) {
_ghost_note->hide();
return;
} else if (_ghost_note) {
_ghost_note->show();
}
_ghost_note->show();
/* calculate time in beats relative to start of source */
const Temporal::Beats length = get_grid_beats(unsnapped_sample + _region->position());