4b26ce3f5f
remove assert(video_timeline)
...
The idle visual changer can run after the video timeline has been deleted, and this
is not an error.
2021-12-15 16:09:28 -07:00
7ade2099ce
move point of deletion of video timeline
...
The "ask about deletion" dialog will run a recursive main loop
which will call idle handlers, which could call the visual change
handler if the playhead is rolling. VTL is assumed to stoll
exist when this is called
2021-12-15 15:52:15 -07:00
40c1a7016a
triggerbox: NOOP - add explanatory comment
2021-12-15 15:39:28 -07:00
ca7b418281
triggerbox: NOOP - commented out extra debugging info
2021-12-15 14:58:24 -07:00
1ecdc5c515
triggerbox: try to avoid tempo that results in fractional bar cnts
...
If minibpm's estimate of tempo implies that the clip has a duration measured in
fractional bars, use the estimate as a starting point to get to a tempo that
will lead to an integer number of bars (and quarters)
2021-12-15 14:58:03 -07:00
ed6121d76e
triggerbox: continued work on Repeat trigger mode
2021-12-15 12:26:46 -07:00
8b1f7a696d
triggerbox: TriggerMaster widget: better loop-progress indication
2021-12-15 12:27:56 -06:00
2688c02e0e
triggerbox: do not use follow action if Trigger::_use_follow is not set
2021-12-15 11:19:36 -07:00
347a17cdb2
triggerbox: telling a Toggle/Gate/Repeat launch mode slots to not use a follow action when stopped
2021-12-15 11:03:53 -07:00
abf0eecca3
triggerbox: cont'd work on TriggerMaster widget
2021-12-15 11:45:17 -06:00
ab03e09a79
triggerbox: publish the loop_cnt for the gui
2021-12-15 11:43:48 -06:00
71f7f7a09b
triggerbox: add stretching property, virtualize computation of expected end sample, maybe fix position_as_fraction()
2021-12-15 10:21:28 -07:00
da00c50271
disambiguate Rectangle for win/macOS
2021-12-15 09:38:10 -07:00
8b600d0080
disambiguate Rect for win/macOS
2021-12-15 09:32:58 -07:00
97eb164b91
triggerbox: clean up part of the state machine for audio triggers
2021-12-14 21:59:33 -07:00
91f38f9c4e
remove Session::bbt_time() and use TempoMap::use()->bbt_at() explicitly everywhere (GUI edition)
2021-12-14 21:59:33 -07:00
12847b0125
remove Session::bbt_time() and use TempoMap::use()->bbt_at() explicitly everywhere
2021-12-14 21:59:33 -07:00
66a114a892
triggerbox: draw icons for follow-actions (for testing)
2021-12-14 20:40:15 -06:00
142ca9fd07
Allow DnD to TriggerBox from Editor's sidebar
2021-12-14 21:34:21 +01:00
8d137b1514
Add API to support Editor sidebar DnD outside of the editor
2021-12-14 21:33:24 +01:00
56605c48da
Prevent editor to grow vertically > 1080px (temp. workaround)
...
This will require some overhaul and re-layout of the selection
sidebar.
2021-12-14 21:09:32 +01:00
509c247bfe
Add strip dialog to blank Trigger Page
2021-12-14 21:03:48 +01:00
36e995b2e4
triggerbox: rough-in sliders for velocity and probability
2021-12-14 13:11:11 -06:00
3335757276
triggerbox: add Properties for velocity and probability
2021-12-14 13:11:08 -06:00
4d4fdc2b55
trigger_ui: remove dynamic widget allocation (leftovers from canvas)
2021-12-14 10:40:37 -06:00
f8e9ac893e
trigerbox: de-sensitize follow-action widgets when FA is off
2021-12-14 10:40:37 -06:00
f632a57aaf
Triggerbox: add a widget for follow_count (ToDo: need ArdourSpinner?)
2021-12-14 10:40:37 -06:00
977f6aec94
Triggerbox: save and recall the follow_count property (lib part)
2021-12-14 10:40:37 -06:00
a07750faa1
Clip Properties: remove Loop buttons (we will use Follow action instead)
2021-12-14 10:40:37 -06:00
58796e6b19
fix likely crash in faderport8 support, from calling TempoMap::use() and not TempoMap::fetch()
2021-12-13 21:07:18 -07:00
Marijn Kruisselbrink
0e799357a8
Fix crash in mackie strip code.
...
Strip::notify_property_changed accesses _stripable without verifying
that is not null. However it is possible for this to be null, so
add a null check.
2021-12-13 21:03:38 -07:00
d04d25e7c7
Mackie Control: Clean up detection of QCon master display and meter.
...
Only enable the master display and meter modes for Qcon devices if this
surface is in the master position. Extenders don't have master meters
or master displays.
2021-12-13 21:26:45 -06:00
d60a5187bd
Mackie Control: Fix detection of QCon Extenders so 2nd LCD is correct
...
Logic to detect an extender has to be based on if this surface object is
the master position. Has master fader is true for all surfaces in this
"device".
2021-12-13 21:25:07 -06:00
fde1b3d27e
Highlight Drop Trigger Slot
2021-12-14 03:10:03 +01:00
5f810843bb
triggerbox: only require a MIDI output if the data type is MIDI
...
This was a thinko that occured when I added the sidechain for audio tracks to handle
trigger input
2021-12-13 16:50:31 -07:00
0fcc873ec5
correctly hide/show/position triggerbox in route processors
2021-12-13 16:24:13 -07:00
2a9ab18f7b
triggerbox: not visible by default in processor box
2021-12-13 15:27:58 -07:00
237dfb53e7
remove add trigger check box from add route dialog (always use triggers)
2021-12-13 15:12:36 -07:00
087bdaa87b
triggerbox: remove static signal added in dd842fdc5c
...
Bad design idea. Signal would be emitted from the triggerbox thread, and cannot
return a value from the GUI. Would also be problematic for clip loading
initiated from a control surface
2021-12-13 15:12:36 -07:00
5e38da36c6
Allow to drop file into dedicated Triggerbox slot
2021-12-13 23:05:03 +01:00
4f89834e7b
Remove comments that clash with git merge markers
2021-12-13 22:51:42 +01:00
28410ebb9a
Triggerbox accept file DnD
2021-12-13 22:51:16 +01:00
4720a45868
Make convert_drop_to_paths() reusable
2021-12-13 22:50:13 +01:00
a9e1a8a885
fix compilation on macOS (usual conflicts over "Rect" typename)
2021-12-13 12:02:57 -07:00
a0db260daa
audio clip editor: hide ruler if we do not know the tempo, since we can't draw it under such circumstances
2021-12-13 09:21:06 -07:00
dd842fdc5c
triggerbox: add static signal to let the GUI do something when we cannot determine tempo
2021-12-13 09:20:32 -07:00
3e5606415f
Trigger Cues: implement Stop button (gtk part)
2021-12-13 07:27:16 -06:00
e7569eabe7
Trigger Cues: implement master Stop button (libardour part)
2021-12-13 07:26:47 -06:00
c862b604e1
TriggerBox: change highlight behavior and experiment with black borders
2021-12-13 07:02:51 -06:00
f5049cda74
audio clip editor: restore ruler removed during merge conflict resolution; incrementally improve its behavior
2021-12-12 22:49:29 -07:00
