13
0
Commit Graph

16783 Commits

Author SHA1 Message Date
da9140a390 polish the way we print tempo numerics in tempo ruler 2023-08-31 10:34:48 -06:00
43d6d4187c display tempo with only 1 digit of decimals 2023-08-31 10:34:48 -06:00
b5b4be96e3
Use "Arrangement" in GUI instead of Section (amend 2f6a0abf) 2023-08-31 16:12:50 +02:00
1bc795509b
Use "Arrangement" in GUI instead of Section (amend 2f6a0abf) 2023-08-31 05:29:29 +02:00
b162ffbca8
Clear Arrangement rects when closing a session 2023-08-31 00:58:51 +02:00
8209cb0ab5 launchpad pro: remove color map; implement note/x,y mapping 2023-08-30 16:06:13 -06:00
9d153af72d image for launchpad pro "gui" 2023-08-30 16:06:13 -06:00
3fa15d9162 skeleton for launchpad pro support 2023-08-30 16:06:13 -06:00
7997c83b01
Allow to edit arrangement label in sidebar 2023-08-30 23:04:39 +02:00
44e1de4261 no warning dialog about tempo map cut/copy/paste
Left in place since it may come back in a different form
2023-08-30 14:16:21 -06:00
076320430a assert() that the tempo & Meter markers associated with a BBT marker exist 2023-08-30 14:16:21 -06:00
797c362500
Fix segfault when undoing marker deletion
find_location_markers() may return NULL.
This also consolidates code from acc55083e5
2023-08-30 20:46:20 +02:00
aaff022fd2
Fix typo in dbda07f6b7 2023-08-30 19:40:19 +02:00
affea2b83b
NO-OP: remove reducant code 2023-08-30 18:31:13 +02:00
dbda07f6b7
Update Markers when Location flags change
Since b66e12610 there is a dedicated Marker type for
Section/Arrangement so changing location flags may need to
update the Marker type.
2023-08-30 18:27:21 +02:00
366e84e10e arrangement ruler: theme tweak 2023-08-29 23:06:42 -05:00
54c713c794 remove another instance of time-domain icon 2023-08-29 23:02:05 -05:00
acc55083e5 arrangement ruler: aesthetic changes 2023-08-29 23:02:05 -05:00
b66e12610b arrangement ruler: create Section marker type, so we can customize it a bit 2023-08-29 23:02:05 -05:00
14792a0aee arrangement ruler: move arrangement ruler to the bottom 2023-08-29 23:02:05 -05:00
2e9432e281 amend 2f16: cue markers should be reparented to their own ruler lane 2023-08-29 23:02:05 -05:00
c5d4a0c172
Amend previous commit (initial marker group) 2023-08-29 22:03:16 +02:00
2f16f87e4f
Do not re-parent ruler markers depending on ruler visibility
Previously CD-markers and Arrangement-markers were shown
in the default Maker ruler when CD or Arrangement ruler
were hidden.

This also fixes a bug that could result in marker-labels
being cut short. Editor::update_marker_labels calculates
overlap with other markes in the same group; but re-parenting
did not update the sorted_marker_lists[group] index.
2023-08-29 21:53:50 +02:00
24ae92ce1e
Consistently use Mark (not Range) for Arrangement markers
Otherwise changing the marker type will cause inconsistently
rendered marks
2023-08-29 17:00:24 +02:00
a14f216f3e
Highligh ranges in arrangement ruler 2023-08-29 00:34:29 +02:00
2f6a0abf04
Use "Arrangement" in GUI instead of Section
Reserve Section for time-selection without track selection
2023-08-28 21:02:43 +02:00
498c113750
Increase blueberry-milk tooltip contrast 2023-08-27 20:46:39 +02:00
32b18073e8 more enforcement of left->right freehand drawing (fixes velocity drawing) 2023-08-27 10:43:47 -05:00
40719ec67d
Section Arranger: overhaul selection and keyboard interaction
* clear treeview selection when time selectoin changes
* act on key-down for consitency, also helps with properly
  prpagating shortcuts
2023-08-27 16:50:28 +02:00
b92e3e6695 move Range Properties to bottom of sidebar, to avoid juggling the Section items around 2023-08-27 08:38:07 -05:00
1f6db3a865
Add context menu to Section Arranger 2023-08-27 15:20:54 +02:00
1f772d30d3
Update Location UI to include section marker flags 2023-08-26 15:10:40 +02:00
3aadf2daf0
Add Section Arranger to Editor sidebar 2023-08-26 14:09:54 +02:00
9c984fc2ad
Add dedicated Section Ruler and UI for section boundary markers 2023-08-26 14:09:53 +02:00
c084c9dbfa
NO-OP: clang-format utils.cc 2023-08-26 14:06:33 +02:00
09e82c1607
Move format_position to utils
This will allow other places to reuse this method.
2023-08-26 14:06:33 +02:00
8dbd76e81c
UF8: add ctrl surface icon for SSL/UF8 2023-08-24 19:18:44 +02:00
30ed0669c0
Redraw markers when moving them between rulers
When un/setting the CD-marker flag the marker vanished
until the GUI forced a redraw of the ruler.
2023-08-23 03:18:42 +02:00
6c96c9bd4a
Add workaround for blank engine-dialog with some XWayland installs 2023-08-22 20:57:43 +02:00
b15fa57017 freehand draw; use ensure_snap to force non-magnetic snap during drag (if snapping) 2023-08-19 13:39:27 -06:00
c8819d73c8 freehand draw: require left-to-right drawing 2023-08-19 13:39:27 -06:00
5c423d3dda freehand draw: slight logic improvement for first move 2023-08-19 13:39:27 -06:00
3b9c63fbac editor: add additional parameter to ::snap_to_with_modifier()
Allows passing ensure_snap value through to ::snap_to_internal
2023-08-19 13:39:27 -06:00
c578695a64 in draw mode, mouse drags in automation tracks are always freehand drawing 2023-08-18 17:42:51 -06:00
Albert Graef
b354f41fc2 Fix compile error introduced in rev. 7c029f5f. 2023-08-17 17:17:41 +02:00
23c7c0b4fd no more beamed 1/8th note symbol in marker text
All locations use the same domain now, so it is redundant
2023-08-16 16:32:03 -06:00
bb8858be81 remove debug output from editor mouse -> tempo dragging startup 2023-08-16 09:06:43 -06:00
e53a70722a fix ordering of reversible command initiation and tempo mapping ops 2023-08-16 09:05:18 -06:00
7c029f5f6a next iteration of changes to handle time domain bounces as undoable (GUI) 2023-08-14 23:42:08 -06:00
36de312324 Update Russian translation 2023-08-11 05:03:52 +02:00
a7a24def36
region groups: prioritize explicitly grouped and ungrouped regions 2023-08-10 16:55:25 +02:00
8818d8484e
region groups: allow the user to explictly group and ungroup regions 2023-08-10 16:55:25 +02:00
fe2473b0cc
region groups: some actions must retain a group-id for the life of the op 2023-08-10 16:55:25 +02:00
b3a5e0b2b1 API change for the start of making tempo mapping undoable (GUI) 2023-08-07 16:33:16 -06:00
afe5331a0b pbd: fairly unconscionable that Command in libpbd is not namespaced, so now it is 2023-08-07 16:33:16 -06:00
1f5db4234c markers: no tooltips for metric markers 2023-08-02 15:23:43 -06:00
16dfb95617 tempo/meter edits: no position fields if marker is part of a BBT marker 2023-08-02 15:23:43 -06:00
f9e1357fed editing a MusicTimePoint as a TempoPoint (from GUI) now operates as it should (or closer) 2023-08-02 15:23:43 -06:00
e36dfa1f09 change display and interaction for BBT Markers
Draw regular tempo/meter markers for BBT markers, and move them when BBT marker is dragged

This will (does) allow regular editing workflow for the tempo/meter at at BBT marker
2023-08-02 15:23:43 -06:00
e051b0cad0 remove time domain items from track header menu (reason in comment) 2023-08-02 15:23:43 -06:00
7609df4418 hide tracks-follow-session option
Until we can do elastic-audio and audio-timed MIDI, this option needs to remain hidden
2023-08-02 15:23:43 -06:00
bd341bdd0b expose new-tracks-follow-session time in session properties editor 2023-08-02 15:23:42 -06:00
908c530834 region property editor uses clock mode based on region time domain
Still needs to track changes
2023-08-02 15:23:42 -06:00
a4b43a6f69 gui support for changing tracks' time domain 2023-08-02 15:23:42 -06:00
9461911a86 editor uses the session default time domain as its default time domain 2023-08-02 15:23:42 -06:00
d14a3b924e locations now follow session time domain, always (probably) (GUI edition) 2023-08-02 15:23:42 -06:00
693bdbeed7 add time domain menu to track header menu 2023-08-02 15:23:42 -06:00
6fb57e0213 slightly reorganize Session properties dialog and add default time to Misc 2023-08-02 15:22:52 -06:00
e9585ad530 objects don't have a time domain, they have a time domain provider (GUI) 2023-08-02 15:22:52 -06:00
e430b54554 class name change to clearly disambiguate Evoral::ControlList (a list of time/value pairs) from lists of Controls in libardour (GUI edition) 2023-08-02 15:22:52 -06:00
30d2d7824e selection-as-group is not an option 2023-08-02 14:11:06 -06:00
1f5a9c4444 correctly redraw marker lanes
Old code just redrew them at the same timeline position (which may
or may not be a different pixel position). They need to be updated
with the underlying position of the marker they represent
2023-08-02 14:11:06 -06:00
darless
9f4a0b444e
Fix #9421: F7 tied to velocity 96 but it was not present in the velocity menu 2023-08-01 22:19:24 +02:00
1d31ace29d adjust GainMeter* API and design to handle stripables, not just routes for selection/group behavior 2023-07-31 21:12:00 -06:00
200194b134 use identical logic for gain/trim controls as others when it comes to group/select stuff 2023-07-31 18:31:03 -06:00
b338b946b8 remove ill-though assert() - VCAs have gain-faders too 2023-07-31 13:54:00 -06:00
fa38a14120 GUI changes to support new selection/group logic 2023-07-31 13:36:25 -06:00
d1fe9f2846 fold solo-safe and solo-isolate controls into selection-is-group logic 2023-07-31 10:58:56 -06:00
2cf18120c6 use selection-as-group logic for monitoring choice control 2023-07-31 10:58:47 -06:00
78e023fcc2 deselecting a grouped track no longer deselects the entire group
I believe this to be more useful behavior than the previous state of affairs
2023-07-28 17:13:29 -06:00
16e1188a2f move logic for use-selection-as-group into ARDOUR_UI and use it everywhere 2023-07-28 09:50:23 -06:00
639c206432 fix thinko with selection-as-group for GainMeter 2023-07-27 13:31:12 -06:00
fe7c36c04b allow selection-as-group control of trim controls 2023-07-27 13:30:50 -06:00
c4838f5d87 remove RouteGroup method from RouteUI::maybe_use_select_as_group()
No longer necessary, after logic change.
2023-07-27 13:28:51 -06:00
8f70356b81 fix group action disposition for solo/mute/recenable 2023-07-27 11:44:11 -06:00
f400c166cc change for logic for when to use selection-as-group 2023-07-27 11:43:43 -06:00
c9a58bfae1 consolidate rules for selection-as-group and extend to solo/mute/recanable 2023-07-26 21:06:19 -06:00
e0a491f0ee NO-OP: add braces mandated by coding style guide 2023-07-26 21:05:35 -06:00
d79e0e9039 add preferences dialog item to control selection-as-group 2023-07-26 18:54:09 -06:00
70e97e2724 move region information preferences into Appearance
This makes some space on the Editor tab/page, and they were more appearance
related anyway
2023-07-26 18:39:48 -06:00
acac9ac006 add and use UI config variable to decide whether selection-as-group is allowed 2023-07-26 18:30:59 -06:00
bc407151cd fix thinko with selection-based gain control 2023-07-26 18:15:42 -06:00
5497c4e74e extend use-selection concept to solo control on mixer strip 2023-07-26 18:09:26 -06:00
e60c1840cb remove modifier for use-selection on gain controls
The condition is now: use selection if route is not in a group that shares gain
2023-07-26 18:09:04 -06:00
6ba69cfd57 gain slider: correctly new push/pop group for use selection 2023-07-26 16:42:12 -06:00
d7ed491f75 gain controls: tenatively use new "use selection" feature 2023-07-26 13:39:05 -06:00
3c2112abf5 widgets & GUI: Start/StopGesture signals should pass on GDK event state 2023-07-26 13:11:52 -06:00
darless
e28eaa843d Fix #8857: Remove snap from decision making about number of divisions 2023-07-25 08:51:35 -06:00
dfc52fd5fb
Plugin analysis: cairo coordinate system fixes 2023-07-18 18:13:34 +02:00
ec7d502959 cairo single pixel line offset fix, part 2
This will need careful visual inspection of the items drawn by the
affected code to make sure they are still precisely as intended
2023-07-17 20:55:13 -06:00
b8af596a92 update all marker positions after a tempo map change 2023-07-15 11:08:45 -06:00
460266de13 NOOP: whitespace fix 2023-07-15 11:08:45 -06:00
John Emmas
35c04d0ee7 Add a missing namespace specifier 2023-07-15 12:55:30 +01:00
509efdb290 temporal: refactor ::get_grid() for performance reasons
the API now provides the option to call ::get_grid() with an iterator which may
be re-used on subsequent calls. This avoids unbounded O(N) "walks" from the
marker preceding the start point of the grid to the start point.

This commit also includes "fast-path" code for the common case of a single
tempo and single meter
2023-07-14 13:03:36 -06:00
ae5755dbe5 do not mark sections of menu/action paths as translatable, since they are not 2023-07-14 13:03:36 -06:00
ed869da97e reserve space for tempo map grid (GUI side) 2023-07-14 13:03:36 -06:00
f41505a8c6 add Editor::count_bars() after removing it from libtemporal 2023-07-14 13:03:36 -06:00
df52c39ce0 freehand line drawing: automation & velocity share the same basic code 2023-07-14 13:03:26 -06:00
2c48aabe08
Handle race condition when removing route before routeUI
This fixes a crash when removing the monitor section.
The monitor route goes away, but the GUI remains. The
IOButton may still process previously queued
cross-thread signals.

In many cases this was not an issue since the route's
memory was not immediately released or shared_ptr
destruction only happened a short time later.
2023-07-14 19:03:32 +02:00
bedab69338
Pin Dialog: hide send polarity invert 2023-07-14 16:59:54 +02:00
8145e92b43
Clarify Control point edit dialog messages, add tooltip 2023-07-11 01:16:58 +02:00
4c8b414fb6
Allow to numeric ctrl point edit to apply to all selected points 2023-07-11 00:53:48 +02:00
ac68fcb880 automation drawing: fix right-to-left free drawing 2023-07-10 14:39:23 -06:00
f6f1f3393d automation drawing: fatter line 2023-07-10 14:38:58 -06:00
d12aa315fc automation drawn: ensure the right-to-left drawn lines are ordered correctly 2023-07-10 14:23:39 -06:00
9d5b6a78d5 automation drawing: better line color 2023-07-10 14:16:59 -06:00
25d17e857f when free-drawing straight lines, allow retrograde motion 2023-07-10 13:42:25 -06:00
57167dafbe use configurable thinning factor, not a hard-coded constant 2023-07-10 13:42:06 -06:00
67d9fa885a use mid-drag key events to allow Alt to force a line break 2023-07-10 12:22:16 -06:00
a14c534d16 dragging: add possibility of handling key events mid-drag
Currently only called from a canvas automation track event handler.
2023-07-10 12:21:27 -06:00
6453049c0a automation drawing: add point at grab start & use new ControlList API for speed 2023-07-10 11:20:47 -06:00
7f653de3e2 automation drawing: don't draw staircases when there are no staircases 2023-07-09 22:14:38 -06:00
c584bfd374 automation drawing: thinning does not work well with snapped-drawn lines
Also, adding points to a ControlList can fail and that's OK
2023-07-09 22:10:18 -06:00
caa278ae55 fix reverse drags and a compiler warning
Not quite sure what to do if we fail to add a point, yet
2023-07-09 21:01:22 -06:00
0a0a882f5a snapping, straight lines, and merge drawn points to list for auto draw 2023-07-09 20:42:09 -06:00
e0c24f5bcf automation drawing: stay in your lane and keep moving in the same direction 2023-07-09 18:12:08 -06:00
86d5e2472c automation drawing: we have the squiggly 2023-07-09 17:39:32 -06:00
78bca64a81 fix (and maybe break) two Drag classes that used the wrong name for setup_pointer_offset()
This might have unexplored consequences
2023-07-09 17:39:11 -06:00
6743c09b4a change return type from ptr to reference for AutomationTimeAxis::base_item() 2023-07-09 17:37:22 -06:00
94f413c399 basic empty skeleton for automation draw drag 2023-07-09 16:33:16 -06:00
0c8fd48d6f velocity lane: appropriately hide automation controls until we have line automation 2023-07-08 17:18:14 -06:00
2a1d4ffce9
Add note about LuaSignal for windows 2023-07-05 19:38:51 +02:00
9b8040a9f4
Add Lua signal emitted when editor selection changed 2023-07-04 21:13:52 +02:00
b757dd9fd8
Vertically center markers
see also 64d633cd26
2023-07-03 18:35:56 +02:00
7e121f4e13
Fix alloc-dealloc-mismatch (malloc vs operator delete) 2023-07-02 23:54:16 +02:00
168b67bd17
Allow to initiate Rubberband-drag on blank Trackview 2023-07-02 21:19:46 +02:00
1f4490fff9
Allow to select region-gain points via rubber-band drag 2023-07-02 20:47:41 +02:00
64d633cd26 amend/fix b490f7d2a1 to correctly (?) place marker text 2023-07-01 21:07:25 -06:00
d688af76c0 clean up mapping bar context menu, extend with clear tempos 2023-06-30 15:50:47 -06:00
bfa13ad714 temporal: reference time for BBT_Argument is always superclocks (GUI) 2023-06-30 12:10:50 -06:00
e756786a13 bbt markers: remove tempo&meter marker on deletion 2023-06-28 18:05:34 -06:00
ac491fce0e bbt markers: now have an (insensitive) tempo and meter marker visible
probably needs more work for event handling on the tempo and
meter markers.
2023-06-28 18:03:38 -06:00
b490f7d2a1 markers: fix position of BBT marker text (tiny tweak) 2023-06-28 18:03:38 -06:00
c53a476f15 allow drawing automation control points in mouse object mode
This is a tentative change and if it proves unwise we can back it out.
I just find it awkward to have to change modes to draw when it is
completely obvious whether I am drawing or not.
2023-06-28 13:44:59 -06:00
99c87e0614 no smart mode behavior for automation region views (it makes no sense) 2023-06-28 13:44:59 -06:00
36769dd94c part 2 of showing region selection in MIDI CC (automation) tracks 2023-06-28 13:44:59 -06:00
64b08a1c70 when a parent (audio/MIDI) regionview is selected, raise matching AutomationRegionView
Currently, we only use AutomationRegionView to show MIDI CC data
2023-06-28 13:44:59 -06:00
78037a532c when displaying region selecting, compare regions not regionviews
This worked before because nothing happened to AutomationRegionViews
when an AudioRegionView or MIDIRegionView was selected, and so
testing based on the regionview worked (the potential RV could
be the actual RV).

But when displaying region selection (in any way) on other TimeAxisViews,
the correct test is whether the RegionView shows the same region
as the selected region(view).
2023-06-28 13:44:59 -06:00
ed48758fb6 NO-OP: add comment 2023-06-28 13:44:59 -06:00
e54e24a7a0 no need for two raise-to-top; set_velocity_mode() will do it 2023-06-27 14:07:47 -06:00