ardour/livetrax
13
0
Fork 0
Code

region groups: some actions must retain a group-id for the life of the op

Browse Source
This commit is contained in:
Ben Loftis 2023-08-07 09:11:25 -05:00 committed by Robin Gareus
parent fd5dfe27c5
commit fe2473b0cc
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gtk2_ardour/editor_audio_import.cc
View File

@ -1059,6 +1059,7 @@ Editor::finish_bringing_in_material (std::shared_ptr<Region> region,
std::shared_ptr<Playlist> playlist = existing_track->playlist();
std::shared_ptr<Region> copy (RegionFactory::create (region, region->derive_properties ()));
copy->set_region_group(false);
playlist->clear_changes ();
playlist->clear_owned_changes ();
playlist->add_region (copy, pos);

12
gtk2_ardour/editor_ops.cc
View File

@ -199,6 +199,9 @@ Editor::split_regions_at (timepos_t const & where, RegionSelection& regions)
return;
}
/* the Split action will likely create new regions; we want them all assigned to the same region-group */
Region::RegionGroupRetainer rgr;
begin_reversible_command (_("split"));
@ -3325,6 +3328,9 @@ Editor::separate_regions_between (const TimeSelection& ts)
std::shared_ptr<Playlist> playlist;
RegionSelection new_selection;
/* the Separate action will likely create a lot of regions; we want them all assigned to the same region-group */
Region::RegionGroupRetainer rgr;
TrackViewList tmptracks = get_tracks_for_range_action ();
sort_track_selection (tmptracks);
@ -4514,6 +4520,9 @@ Editor::cut_copy (CutCopyOp op)
string opname;
/* the Cut action can create a lot of regions; we want them assigned to sensible region-groups */
Region::RegionGroupRetainer rgr;
switch (op) {
case Delete:
opname = _("delete");
@ -5229,6 +5238,9 @@ Editor::paste_internal (timepos_t const & pos, float times)
return;
}
/* the Paste operation will result in one or more new regions, and we want them to share a region-group-id */
Region::RegionGroupRetainer rgr;
if (position == timepos_t::max (position.time_domain())) {
position = get_preferred_edit_position();
DEBUG_TRACE (DEBUG::CutNPaste, string_compose ("preferred edit position is %1\n", position));