df95ec6b43
partial response to note name display option
2023-09-10 18:20:35 -06:00
2f0bfedb58
include "Channel" in text for MIDNAM display channel selector
2023-09-10 18:20:35 -06:00
090b9d4f60
remove MIDI scroomer from code
2023-09-10 18:20:35 -06:00
605fd136e0
add preferances item for note name display
2023-09-10 18:20:35 -06:00
8f41576491
add enum declarations
2023-09-10 18:20:35 -06:00
71f168834d
obey note name display preference
2023-09-10 18:20:35 -06:00
b81da94fa2
add UI config var for note name display
2023-09-10 18:20:35 -06:00
b4f684e02f
missing enum convert
2023-09-10 18:20:35 -06:00
6966a2b7d8
add basic Editing enums/types for note name display options
2023-09-10 18:20:35 -06:00
5611e7eeed
tweak gradient width in scroomer area
2023-09-10 18:20:35 -06:00
0b9a54ac32
fix scope of a char* [] buffer
2023-09-10 18:20:35 -06:00
a3838f0c66
alex mitchell's piano roll header: add correct motion event handler
2023-09-10 18:20:35 -06:00
baa32aa5bd
merged commit from alexander mitchell, implementing a new piano roll header
2023-09-10 18:20:35 -06:00
d37f85f9d2
Emit selection RegionsChanged
when region is removed
...
This is required to properly update the selection.
Previously deleting a region did not update selection
markers and other selection displays that depend on
Editor::get_selection_extents (which includes region selection).
This fixes a crash: Select a region (this sets a time-selection).
Delete the region, click on the time-selection markers (red triangles).
2023-09-10 15:25:12 +02:00
c0287cb0de
Fix thinko in e81b2353cc
, selection may not start at a marker
...
This fixes a crash when selecting a section, and then changing
the time-selection. Previously it was assumed that the section
context menu can only be shown for sections. But it applies to
any time[line]-selection.
2023-09-09 21:27:11 +02:00
Asahi Lina
d1cc71150f
Adjust interpretation of swing amount
...
Previously,
0 -> no swing (1:1, 50%)
50 -> triplet swing (2:1, 66%)
75 -> hard swing (3:1, 75%)
100 -> sextuplet swing (5:1, 83%) (default!)
150 -> absolute maximum (inf:1, 100%)
This is rather confusing...
One common interpretation uses percentages of the beat, where triplet
swing is 66%. However, that causes precision issues since it's really
66.666...
Since we already default to 100 and take "no swing" as zero, let's make
that reference point triplet swing. Then the scale becomes:
0 -> no swing (1:1)
100 -> triplet swing (2:1)
150 -> hard swing (3:1)
200 -> sextuplet swing (5:1)
300 -> absolute maximum (inf:1)
300 doesn't make any sense, so let's change the range to -250 .. 250
which covers all useful values.
Also remove the division through 100 and back, to avoid rounding issues.
Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Asahi Lina
ca25b5c841
Fix quantize threshold setting
...
Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Asahi Lina
577918dc07
Fix quantize beat divisions
...
Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
aca5d7d988
place lollipops in correct location on timeline
...
It is not immediately clear to me why the + radius expression is reqired
2023-09-08 16:16:15 -06:00
503e6249f4
remove GridTypePlayhead
2023-09-08 15:27:04 -05:00
d57676b9c7
Maybe clear time-selection when switching to draw tool
2023-09-08 14:50:43 +02:00
e81b2353cc
Indicate arrangement section selection on canvas
2023-09-08 03:26:00 +02:00
b243b93072
Allow to reuse range context menu w/o track/region selection
2023-09-08 03:25:59 +02:00
019a3a1976
Allow to select Arrangement sections
...
This also adds interaction with sections in the
Arrangement Ruler.
Note that selecting a range switches to the Range tool.
This is enforced because time-range selection is only meaningful
with tools that perform edit operations on the whole timeline.
2023-09-08 03:25:59 +02:00
b6e9f37007
Arrangement Sidebar: follow-edits locates to selected section
2023-09-08 03:25:59 +02:00
d2b083f385
Arrangement Sidebar: allow name edit by double-click
2023-09-08 03:25:59 +02:00
78db634321
Unconditionally show time-selection in info box with object tool
...
Arrangement Section can be selected with the object tool,
and should be indicated even when not using Smart mode.
2023-09-08 03:25:59 +02:00
20b646e962
Handle MouseGrid cursor (fix -Wswitch, amend 784d2ecc
)
2023-09-08 03:25:59 +02:00
250174b16e
don't bother locating at end of no-motion marker drag if using external sync
2023-09-07 14:23:08 -06:00
f9a121ce9c
click (no drag) on markers locates there, unless using marker as edit point
2023-09-07 14:23:08 -06:00
3f14b27ee3
remove (unimplemnted) Stretch MIDI checkbox
2023-09-07 15:18:36 -05:00
cc47b5fe3c
Only allow grid-tool with musical grid
2023-09-06 23:56:10 +02:00
966dce5516
remove now-invalid tempo edit menu items
2023-09-06 15:29:55 -06:00
da4d2a645f
remove tempo-mapping bar, tempo_meta group. this reverts 8fbf2c and related
2023-09-06 19:31:00 +02:00
784d2ecce4
Add the tool for Grid, and accompanying buttons and event-handling
2023-09-06 19:30:56 +02:00
268d1d33c7
Add invisible Rectangle to initiates Tempo(grid) drags
2023-09-06 19:14:14 +02:00
80a813ff1c
Fix use-after-free when undoing marker creation
...
Create a marker by ctrl-click, hover over it and then ctrl+z
undo. This used to crash in Editor::get_preferred_edit_position()
gtk2_ardour/editor.cc:5179, checking for entered_marker->position()
2023-09-06 17:37:11 +02:00
3851a93e39
Update selection-markers on track and time selection
2023-09-06 00:02:36 +02:00
10ff5ad599
Use section delete for Editor::Delete operation
2023-09-06 00:02:31 +02:00
6e87a46ba4
convention for selection (as used on track headers) is red border, red tint
2023-09-05 23:08:30 +02:00
29430ac550
NO-OP: clang-format
2023-09-05 23:08:30 +02:00
68ccbc8ac3
Arrangement: locate on double-click
2023-09-05 23:08:30 +02:00
e5e40c751f
if user moves selection markers, convert selection to a timeline section
2023-09-05 23:08:30 +02:00
4217a68852
Arranger: implement bi-directional selection
2023-09-05 23:08:30 +02:00
5ceb66c902
Arranger: allow renaming by context-menu
2023-09-05 23:08:29 +02:00
cf9f9db48b
Set length of new percussive hits to 1 tick
...
This prevents overlap of successive hits.
Ardour 7 added a new duration select drop-down menu,
which defaults to "Auto" (musical grid) and removed
the special case when drawing percussive notes.
It was possible to accidentally create overlapping notes,
without the user being aware of doing so.
2023-09-04 23:26:54 +02:00
7d95334c0d
fix thinko in e53a7 which resulted in unmatched tempo-map UNDO transactions
2023-09-04 08:48:49 -05:00
774adfb33c
Fix rounding of arrangement markers
2023-09-01 21:53:26 +02:00
a6844279ad
arranger-treeview 'search' function was stealing keybd events
2023-09-01 07:18:22 -05:00
0d89bc5789
fix height of tempo ruler curve elements
...
These were being drawn in a way that failed to really convey relative
tempos very well. This is now better, though perhaps there are other
improvements possible
2023-08-31 18:25:18 -06:00
da9140a390
polish the way we print tempo numerics in tempo ruler
2023-08-31 10:34:48 -06:00
43d6d4187c
display tempo with only 1 digit of decimals
2023-08-31 10:34:48 -06:00
b5b4be96e3
Use "Arrangement" in GUI instead of Section (amend 2f6a0abf
)
2023-08-31 16:12:50 +02:00
1bc795509b
Use "Arrangement" in GUI instead of Section (amend 2f6a0abf
)
2023-08-31 05:29:29 +02:00
b162ffbca8
Clear Arrangement rects when closing a session
2023-08-31 00:58:51 +02:00
8209cb0ab5
launchpad pro: remove color map; implement note/x,y mapping
2023-08-30 16:06:13 -06:00
9d153af72d
image for launchpad pro "gui"
2023-08-30 16:06:13 -06:00
3fa15d9162
skeleton for launchpad pro support
2023-08-30 16:06:13 -06:00
7997c83b01
Allow to edit arrangement label in sidebar
2023-08-30 23:04:39 +02:00
44e1de4261
no warning dialog about tempo map cut/copy/paste
...
Left in place since it may come back in a different form
2023-08-30 14:16:21 -06:00
076320430a
assert() that the tempo & Meter markers associated with a BBT marker exist
2023-08-30 14:16:21 -06:00
797c362500
Fix segfault when undoing marker deletion
...
find_location_markers() may return NULL.
This also consolidates code from acc55083e5
2023-08-30 20:46:20 +02:00
aaff022fd2
Fix typo in dbda07f6b7
2023-08-30 19:40:19 +02:00
affea2b83b
NO-OP: remove reducant code
2023-08-30 18:31:13 +02:00
dbda07f6b7
Update Markers when Location flags change
...
Since b66e12610
there is a dedicated Marker type for
Section/Arrangement so changing location flags may need to
update the Marker type.
2023-08-30 18:27:21 +02:00
366e84e10e
arrangement ruler: theme tweak
2023-08-29 23:06:42 -05:00
54c713c794
remove another instance of time-domain icon
2023-08-29 23:02:05 -05:00
acc55083e5
arrangement ruler: aesthetic changes
2023-08-29 23:02:05 -05:00
b66e12610b
arrangement ruler: create Section marker type, so we can customize it a bit
2023-08-29 23:02:05 -05:00
14792a0aee
arrangement ruler: move arrangement ruler to the bottom
2023-08-29 23:02:05 -05:00
2e9432e281
amend 2f16: cue markers should be reparented to their own ruler lane
2023-08-29 23:02:05 -05:00
c5d4a0c172
Amend previous commit (initial marker group)
2023-08-29 22:03:16 +02:00
2f16f87e4f
Do not re-parent ruler markers depending on ruler visibility
...
Previously CD-markers and Arrangement-markers were shown
in the default Maker ruler when CD or Arrangement ruler
were hidden.
This also fixes a bug that could result in marker-labels
being cut short. Editor::update_marker_labels calculates
overlap with other markes in the same group; but re-parenting
did not update the sorted_marker_lists[group] index.
2023-08-29 21:53:50 +02:00
24ae92ce1e
Consistently use Mark (not Range) for Arrangement markers
...
Otherwise changing the marker type will cause inconsistently
rendered marks
2023-08-29 17:00:24 +02:00
a14f216f3e
Highligh ranges in arrangement ruler
2023-08-29 00:34:29 +02:00
2f6a0abf04
Use "Arrangement" in GUI instead of Section
...
Reserve Section for time-selection without track selection
2023-08-28 21:02:43 +02:00
498c113750
Increase blueberry-milk tooltip contrast
2023-08-27 20:46:39 +02:00
32b18073e8
more enforcement of left->right freehand drawing (fixes velocity drawing)
2023-08-27 10:43:47 -05:00
40719ec67d
Section Arranger: overhaul selection and keyboard interaction
...
* clear treeview selection when time selectoin changes
* act on key-down for consitency, also helps with properly
prpagating shortcuts
2023-08-27 16:50:28 +02:00
b92e3e6695
move Range Properties to bottom of sidebar, to avoid juggling the Section items around
2023-08-27 08:38:07 -05:00
1f6db3a865
Add context menu to Section Arranger
2023-08-27 15:20:54 +02:00
1f772d30d3
Update Location UI to include section marker flags
2023-08-26 15:10:40 +02:00
3aadf2daf0
Add Section Arranger to Editor sidebar
2023-08-26 14:09:54 +02:00
9c984fc2ad
Add dedicated Section Ruler and UI for section boundary markers
2023-08-26 14:09:53 +02:00
c084c9dbfa
NO-OP: clang-format utils.cc
2023-08-26 14:06:33 +02:00
09e82c1607
Move format_position to utils
...
This will allow other places to reuse this method.
2023-08-26 14:06:33 +02:00
8dbd76e81c
UF8: add ctrl surface icon for SSL/UF8
2023-08-24 19:18:44 +02:00
30ed0669c0
Redraw markers when moving them between rulers
...
When un/setting the CD-marker flag the marker vanished
until the GUI forced a redraw of the ruler.
2023-08-23 03:18:42 +02:00
6c96c9bd4a
Add workaround for blank engine-dialog with some XWayland installs
2023-08-22 20:57:43 +02:00
b15fa57017
freehand draw; use ensure_snap to force non-magnetic snap during drag (if snapping)
2023-08-19 13:39:27 -06:00
c8819d73c8
freehand draw: require left-to-right drawing
2023-08-19 13:39:27 -06:00
5c423d3dda
freehand draw: slight logic improvement for first move
2023-08-19 13:39:27 -06:00
3b9c63fbac
editor: add additional parameter to ::snap_to_with_modifier()
...
Allows passing ensure_snap value through to ::snap_to_internal
2023-08-19 13:39:27 -06:00
c578695a64
in draw mode, mouse drags in automation tracks are always freehand drawing
2023-08-18 17:42:51 -06:00
Albert Graef
b354f41fc2
Fix compile error introduced in rev. 7c029f5f
.
2023-08-17 17:17:41 +02:00
23c7c0b4fd
no more beamed 1/8th note symbol in marker text
...
All locations use the same domain now, so it is redundant
2023-08-16 16:32:03 -06:00
bb8858be81
remove debug output from editor mouse -> tempo dragging startup
2023-08-16 09:06:43 -06:00
e53a70722a
fix ordering of reversible command initiation and tempo mapping ops
2023-08-16 09:05:18 -06:00
7c029f5f6a
next iteration of changes to handle time domain bounces as undoable (GUI)
2023-08-14 23:42:08 -06:00
36de312324
Update Russian translation
2023-08-11 05:03:52 +02:00