13
0
Commit Graph

8911 Commits

Author SHA1 Message Date
79fecf0b61 escape markup in region list 2015-10-02 19:38:32 +02:00
3aa24b222b add missing markup escape
(e.g. import file with ampersand)
2015-10-02 19:14:24 +02:00
eebbf64484 provide Main/cancel-solo as an action and make rude solo button(s) use it 2015-10-02 07:32:56 -04:00
520b78b841 Add parent window argument to ARDOUR_UI::check_audioengine
Ensures relevant placement of the dialog when presented
2015-10-01 09:10:19 +10:00
73acaf6de6 Display warning when closing Audio Setup dialog with engine stopped
Only show warning when a session is loaded
2015-10-01 09:10:19 +10:00
463bd470e8 Don't hide Audio Setup dialog when clicking 'OK' if engine fails to start
This has to be handled in two places, in ARDOUR_UI::do_audio_midi_setup and in
the dialogs response handler and in as the window can also be triggered via the
window action manager.
2015-10-01 09:10:19 +10:00
2768ce9b05 Use AudioSetupDialog as parent of the error message popup when failing to start engine
Without a session loaded this makes the message dialog appear in front of the
AudioSetup dialog instead of randomly up in the top left somewhere. This does
mean though that if the AudioSetup dialog is not visible the error message
popup will appear randomly up in the top left(at least on windows, it seems
fine on linux) but I will fix that shortly.
2015-10-01 09:10:19 +10:00
d19605aeaa Use AudioEngine::get_last_backend_error in message dialog when failing to start engine
If a backend is not returning AudioBackend::ErrorCode values to indicate the
type of error then the default string will be returned which is the same as
what was previously displayed.
2015-10-01 09:10:19 +10:00
André Nusser
c6f9a65081 Gray out "strip silence" and "rhtyhm ferret" for midi regions.
The former even triggered a segfault.
2015-09-30 23:20:27 +02:00
André Nusser
71f6f982e3 Fixed spelling. 2015-09-30 14:43:02 -04:00
André Nusser
6fdd3f47ac Make all the context menu entries of the track list work. 2015-09-30 14:43:02 -04:00
48b904fcee is there a better way to make gcc+enumwriter happy? 2015-09-29 16:09:01 +02:00
3f8857b129 Fix midi tracer to show MSB too. (fixes #6566) 2015-09-29 06:06:40 -07:00
08446f79e1 set waveform height depending on Layer mode
Fixes background peakfile/waveform creation. Waves need to be
created directly with the proper attributes as set by StreamView.
2015-09-29 13:47:21 +02:00
7f86418340 Revert "change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits"
This reverts commit 601770837e.

This work continued in the "clockwork" branch where it was done correctly.
2015-09-28 20:28:40 -04:00
deabc0f41b change clearlooks style file so that small_entry and related styles use text color for text even when selected 2015-09-28 18:20:54 -04:00
André Nusser
42647c9920 Introduce Ctrl+Shift+Click on lock solo in the mixer. 2015-09-28 17:58:40 -04:00
621fd845e6 Revert "add new action and loop marker menu item for setting up loop record"
This reverts commit ebb43508f1.
2015-09-28 17:44:04 -04:00
601770837e change the way the audio clock cursor is drawn (somewhat of an experiment but it has some benefits 2015-09-28 17:42:11 -04:00
3e0d801509 when editing an audio clock, swallow illegal keys rather than allowing them to reach the rest of the GUI 2015-09-28 17:42:11 -04:00
9cf56aab84 fix the logic of the GUI "toggle roll" action as it pertains to loop recording 2015-09-28 17:42:11 -04:00
ebb43508f1 add new action and loop marker menu item for setting up loop record 2015-09-28 17:42:11 -04:00
9f2aba1451 mixer-strip name context-menu cleanup
patch thanks to chaot4
2015-09-27 21:45:40 +02:00
2e6b455b19 add deva to authors. 2015-09-27 16:13:37 +02:00
e1c421c67b Close export directory browser dialog when clicking on 'Cancel' button, Fixes #6594 2015-09-27 21:55:20 +10:00
cf761d4f67 fix mixer group-tab width - #6572
EditorGroupTabs are re-exposed in the idle-callback, widgets
are packed and geometry is valid.

Mixer_UI::redisplay_track_list() does not have this property.
2015-09-27 01:33:02 +02:00
e935890fc5 fix crash at session-close, amend dec4790d 2015-09-25 01:05:13 +02:00
c3a7730c88 redisplay markers after removal - fixes #6596 2015-09-24 00:27:32 +02:00
cb0b22cb79 Hide create new item from Group Tab context menu
Creating a new empty group from the group tab area just looks broken since
nothing visible happens, so hide this item when the context menu is
triggered from this location.
2015-09-21 16:50:45 -05:00
Todd Naugle
203a72f883 Create new Groups with a consistent set of default properties.
This is part of a larger fix for #6450. Previously new route groups were
created with different default properties depending on which code created
the new group. The group tab method had all properties set and that is now
going to be the default for all other methods (mixer strip button, etc).
2015-09-21 14:52:25 -05:00
cba31db6fe processor-box: explicitly check for "Amp" (Fader) 2015-09-21 13:14:29 +02:00
e64e4e19bc save-as, update button sensitivity when dir changes 2015-09-21 12:05:31 +02:00
86c93292d4 add André to authors list. 2015-09-20 22:30:43 +02:00
André Nusser
6a248b61f0 fix duplicating multiple selected regions - fixes #6202 2015-09-20 22:22:39 +02:00
dec4790dff update SFDB settings when track selection changes 2015-09-20 20:03:09 +02:00
cff0852df9 fix initial state of Import Dialog 2015-09-20 20:02:40 +02:00
6c53ebc4c1 basic GUI support to auto-align video by LTC. 2015-09-20 18:37:39 +02:00
65f215bb4c GUI part of silence-trim fade constraint. 2015-09-20 01:28:37 +02:00
21c1d0f832 Silence detect: constrain duration in GUI. 2015-09-19 23:33:35 +02:00
a6caf6ed3a NOOP, whitespace. 2015-09-19 20:31:32 +02:00
dad0e390ff indicate that silence trim is already active. 2015-09-19 20:28:56 +02:00
c829c10a74 band-aid for Glib::operator<<
it seems that g_locale_from_utf8() (called by <<) is not thread safe,
at least not on OSX.

glib error-code 1, Invalid byte sequence in conversion input
-> throws Glib::Error.

possible fix for #6435, route-creation is interrupted via catch(...)
2015-09-19 19:00:43 +02:00
dfd7e80fda fix crash at exit, ctrl+s during quit. 2015-09-19 19:00:43 +02:00
646bc2bb43 fix possible endless loop in silence detection 2015-09-19 19:00:43 +02:00
6569301001 remove cruft 2015-09-19 19:00:43 +02:00
0e55dc470d StripSilence: invalidate Completed connection - fixes #6600 2015-09-19 19:00:42 +02:00
cdd76636a0 tweak colors for silence-detection
The text annotation needs to be visible:
 - above default background (dark gray)
 - above waveform (orange)
 - above silent-highly regions (violet, was bright turqoise)

old color (dark blue) failed for all but the waveform.
2015-09-19 19:00:42 +02:00
62a161195c fix progress reporter, use idle callback.
do not directly hook into Glib's Main Context.
2015-09-19 19:00:42 +02:00
2ef2ea0b59 create new Event-IDs for pasted midi-notes 2015-09-18 20:37:23 +02:00
b753704c3e Revert "work around bug or feature of string_compose()"
This reverts commit 17baf93626.
It's no longer needed since c1d6a2f
2015-09-18 00:04:42 +02:00
f3a1ac21cb associate label more closely with VST path button. the plugin tab needs a complete layout rethink, someday 2015-09-17 16:07:40 -05:00
ff80d66088 speficy gtk treeview style for consistency 2015-09-17 21:09:13 +02:00
17baf93626 work around bug or feature of string_compose()
string_compose("x%1x x%2x x%3x", "A", "", "C") 
-> "xAx xCx xx"
and not
-> "xAx xx xCx"
2015-09-17 20:51:11 +02:00
f27800ea41 use pbd's gstdio compatibility wrapper (GUI) 2015-09-17 14:38:09 +02:00
5d38d1c751 explicit glibmm/datetime include
On some distros. glibmm.h does not include glibmm/datetime.h
2015-09-17 13:37:52 +02:00
6829d1593f Use PBD::open_uri in about dialog to open website, should fix #6463 2015-09-17 11:55:22 +10:00
23a384f8ae fix #6588. use ardour-codename only for Ardour. 2015-09-17 00:40:58 +02:00
202b9cc82a fix a tautologically undefined comparison 2015-09-17 00:21:38 +02:00
4a10dbbc1b deleting pointers to incomplete types may cause undefined behavior 2015-09-17 00:13:43 +02:00
5d02c47d3a fix clang compilation.
pbd/configuration_variable.h:84:6: error: call to function 'operator>>' that is neither visible in the template definition nor found by argument-dependent lookup

ardour/types.h defines  std::istream& operator>> and must be included prior to pbd/configuration_variable.h
2015-09-17 00:10:50 +02:00
31c0a536ba fix missed but required merge resolution related to UIConfiguration's new status as a singleton in this branch. 2015-09-16 17:11:54 -04:00
69b44ee829 Use tooltips.h in ArdourButton to remove ardour_ui.h inclusion 2015-09-16 16:55:17 -04:00
1d42ed077e Use ARDOUR_UI_UTILS::set_tooltip rather than via ARDOUR_UI::set_tip
This removes the direct dependence on ARDOUR_UI/Gtk_UI for setting
tooltips. Removes inclusion of ardour_ui.h from 16 files.
2015-09-16 16:55:17 -04:00
2031007a3a Add tooltips.h header for setting tooltips rather than via ardour_ui.h 2015-09-16 16:55:17 -04:00
29f43af53a Add missing header include in midi_channel_selector.h 2015-09-16 16:55:17 -04:00
f9cba95a8f Add missing header include in shuttle_control.h 2015-09-16 16:55:17 -04:00
b8546e0b69 Add missing header include in plugin_selector.h 2015-09-16 16:55:17 -04:00
38bae2996a Remove ardour_ui.h header inclusion 2015-09-16 16:55:17 -04:00
c256075e63 Remove tooltips() member from ARDOUR_UI and use Gtk_UI::set_tip 2015-09-16 16:55:17 -04:00
b8e9ee50e0 Use Forward declaration for non-MSVC compilers in ardour_ui.h
I can't test this with MSVC so John might have to fix this, just
adding the necessary header includes inside MSVC specific ifdef
but I think it should be OK
2015-09-16 16:55:17 -04:00
513ecad1f0 Forward declare Meterbridge class in ardour_ui.h 2015-09-16 16:55:17 -04:00
553c3ef557 Remove ui_config.h inclusion from ardour_ui.h 2015-09-16 16:55:17 -04:00
6b019a4953 Move UIConfiguration Singleton into UIConfiguration header
This removes the direct dependence on ardour_ui.h from 39 files
2015-09-16 16:55:17 -04:00
45d487f16e Move ARDOUR_UI::ui_scale into UIConfiguration class 2015-09-16 16:55:17 -04:00
c99bf353a5 Remove inclusion of ardour_ui.h from ui_config.cc 2015-09-16 16:55:17 -04:00
fc1e7dbb55 Move DPIReset and ColorsChanged signals into UIConfiguration 2015-09-16 16:55:17 -04:00
0fd1aa3808 Remove unused header include 2015-09-16 16:55:17 -04:00
2d47183dc9 Move util functions into UIConfiguration as they depend on it anyway 2015-09-16 16:55:17 -04:00
2e8af0c917 Remove duplicate extern declaration
DPIReset signal is declared in global_signals.h
2015-09-16 16:55:17 -04:00
482b71d35e add datetime to snapshot sidebar
Currently only information, not sortable.
2015-09-16 22:17:34 +02:00
18afd09b3b unify recent session dialogs 2015-09-16 21:37:56 +02:00
f2f7a21aea fix d6029f9 (recent sort-order)
add one, because (-0 == +0)
2015-09-16 19:30:41 +02:00
eda0a24454 add Hour:Minute to last-modified. 2015-09-16 19:01:13 +02:00
d6029f9285 remeber recent-session sort-column 2015-09-16 18:59:04 +02:00
b3e447f421 highlight default sort column 2015-09-16 18:24:57 +02:00
7e65835c0e disable even/odd row highlight for GtKTreeview.
Almost all TreeViews in Ardour had this disabled.
A few cases where it wasn't produced odd rendering artifacts. e.g.:

* Radio-buttons in the Plugin Manager used "base color" regardless of even/odd lines
* Sortable trees only used even/odd background for the sort-column (not others)
2015-09-16 18:24:57 +02:00
570d92c527 user-sortable recent session list 2015-09-16 18:24:56 +02:00
1fb38a416a add "last modified" column to session-dialog 2015-09-16 18:24:56 +02:00
6c43ca5334 partially revert de53fac (pre-sort session list)
<glib> header includes and commends remain for later use
2015-09-16 18:24:56 +02:00
7b82277c7e Don't try and split a region when dragging, should fix bug #6338 2015-09-16 16:28:18 +10:00
c510d8a49d prepare time column in recent session 2015-09-16 01:28:55 +02:00
f1be9114c2 inspect snapshot for its info (not parent) 2015-09-16 01:28:55 +02:00
de53fac303 pre-sort recent-sessions by modification time - #6575 2015-09-16 01:28:55 +02:00
af2b8c73b9 expose the new use monitor fades option 2015-09-15 16:35:37 -04:00
fdcc209354 remove unused variable 2015-09-15 21:21:09 +02:00
cf9176c3bb don't allow to focus sidebar checkboxes - fixes #6445 2015-09-15 21:21:01 +02:00
93cd0d17e4 display active peak-builds 2015-09-15 17:50:27 +02:00
655c581ef2 expose transport fade option 2015-09-15 09:01:26 -04:00
b05912b0cb GUI part: cleanup peak-files 2015-09-15 14:44:05 +02:00
11c0adfbae pending-peaks: checker pattern. 2015-09-15 02:28:24 +02:00
7e1baa70e4 visually indicate peak-file rebuild
Not yet a checker pattern, but closing it :)
2015-09-15 00:19:02 +02:00
aabc5108f3 Revert inadvertently pushed commit
This reverts commit 3a6114c025.
The actual solution is http://dev.drobilla.net/ticket/1085
2015-09-13 04:10:14 +02:00
3a6114c025 center, don't expand plugin widgets 2015-09-13 04:09:24 +02:00
dae330489b valgrind: only use objc supression file on OSX 2015-09-12 21:48:26 +02:00
4a1f5c7f28 GUI part of memleak fixes 2015-09-12 20:05:46 +02:00
fd17b40e6f trick ardour to print main-thead mem-pool stats. 2015-09-12 02:18:38 +02:00
6048d2cd23 Have GUI Option reflect current state (in case toggle fails) 2015-09-11 13:21:16 +02:00
306f234a5b session->path() returns a dir (not the session file) 2015-09-10 17:39:32 +02:00
f970022838 ditto for the announcement message 2015-09-10 17:39:32 +02:00
b7fbd4e9c0 fix a small memleak.
downcase(char*) requires free(), downcase(std::string) does not.
2015-09-10 17:39:31 +02:00
1ebe22eeed catch mem-leaks more easily. 2015-09-10 17:39:31 +02:00
3eb7ee6ac1 Check that a route has a track before trying to insert time on it.
Routes which are busses don't have a track, and thus no playlists either:
avoid a crash when inserting time when a bus is selected and 'all
playlists' is chosen.
2015-09-10 11:50:20 +01:00
6e944121f6 Don't unload session with Session -> Open -> Cancel, Fixes #6568 2015-09-09 09:58:13 +10:00
54d216429c offer up (when possible) MBWF, RF64 and RF64 (WAV) options 2015-09-08 17:40:29 -04:00
Guy Sherman
045b878bd1 NOOP, whitespace only 2015-09-08 22:30:36 +02:00
929db238c9 fix prev. commit 2015-09-08 22:27:15 +02:00
2f1878a6f7 portable c-code for reading pingback/announcement message 2015-09-08 21:21:28 +02:00
d0fdcf2848 Use glib to open our 'announcements' file, rather than opening directly with ofstream
(on Windows, std::ofstream doesn't support UTF8)
2015-09-08 15:45:33 +01:00
78f028b690 fix redeclaration of symbol 2015-09-08 12:49:24 +02:00
c315c6f140 Allow to override A/V-lock (when moving audio) 2015-09-08 02:51:58 +02:00
88f532ed6a Allow to override A/V-lock (when moving video) 2015-09-08 01:35:35 +02:00
b08fd6483c add OSX/objc valgrind suppression file 2015-09-07 15:43:20 +02:00
c6e0c8430f image-surface/software rendering as preference 2015-09-07 13:35:11 +02:00
6ade16b38d Workaround to allow loading large sessions.
During session-load, ardour calls Route::SoloControllable::set_value() 
which calls Session::set_solo()  which in turn sends a session-rt event.

Along with other rt-events (locations,..) the current solo logic limits
Ardour to only load sessions with about >= 200 tracks.

now bumped to a few thousand tracks.. until a proper solution comes along.
2015-09-06 22:36:09 +02:00
fc079a0ea3 initialize some uninitialized variables.
really just nitpicking (keep valgrind clean).
2015-09-06 21:54:54 +02:00
ebe15849d4 gracefully handle LV2 GUI instantiation failure. 2015-09-06 19:32:13 +02:00
53cdc8046f catch duplicate shortcut folders. 2015-09-06 18:15:48 +02:00
2309bb2a7f Don't keep gtk-file-chooser around.
This fixes some odd-crashes in the gtk main-thread after loading a new
session in gtk_file_system_model_sort().
2015-09-06 18:15:13 +02:00
87d45542eb update region's constrained-name width with name 2015-09-06 16:45:48 +02:00
787fe69ff8 highlight regions with pending peak-files 2015-09-06 12:58:54 +02:00
1aa4c62abe properly disconnect peak-ready connection 2015-09-06 12:56:50 +02:00
e161bc0596 fix peak-thread, GUI-thread race condition 2015-09-06 12:39:53 +02:00
03163154a2 As an experiment, use PBD::ScopedFileDescriptor in preference to 'ofstream' which doesn't support UTF8 (on Windows at least)
This change should ensure that our "been_here_before" file ('.a3' or whatever) will get created successfully - even for user paths with non-English characters in them.

If this experiment works on all platforms, there are several other areas where we'll probably need something similar.
2015-09-05 18:02:32 +01:00
0b2af5b9b8 fix log-scale for automation lanes. 2015-09-05 17:25:59 +02:00
b6f1eac8b0 don't use gain-mapping (verbose-cursor) for plugin params. 2015-09-05 17:13:04 +02:00
1c9bb7de66 display session create/open failure errors. 2015-09-05 15:45:59 +02:00
b3b5646a30 Remove Apply button in Import dialog/Window and change OK to "Import"
Don't close the window when clicking on Import. Changing "OK" to "Import" makes
it clear what action is being taken by the button. I quite frequently imported
several files from different directories using "Apply" and then would click on
OK to finish using the dialog only to have the last import occur again
unintentionally.

Another option would of been to change "Apply" to "Import" and "OK" to "Import
and Close" and not have a Close button.
2015-09-04 09:45:09 +10:00
303b27a69b Change Cancel button in Import Dialog to Close button
This button closes the window, it doesn't actually cancel any importing that
has taken place and cancelling the import in progress is done by the Cancel
button in popup progress dialog
2015-09-03 22:32:53 +10:00
846a5d9446 Indentation and whitespace fixes in sfdb_ui.h 2015-09-03 22:13:43 +10:00
2e96b62a1e fix typo in 434416c 2015-09-02 16:03:44 +02:00
434416c31f show compile-time cpu-arch in about - closes #6548 2015-09-02 15:08:20 +02:00
dbe3500f24 Add utility method for choosing which device/s to display in Audio Setup dialog 2015-09-02 12:07:15 +10:00
25ff056921 Use previously set buffer size in EngineDialog if possible
This is also to support refreshing of devices so that the buffer size isn't
reset.
2015-09-02 12:07:15 +10:00
9626e0c413 Add "Refresh Devices" button in Audio Setup dialog for backends that support it
This allows the portaudio library to be reinitialized to pick up new devices
and changes to ASIO buffer changes made externally.
2015-09-02 12:07:15 +10:00
88b332412c Add some debugging output for state restoration in Audio Setup dialog 2015-09-02 12:07:15 +10:00
e6492319b1 Remove Apply button from Audio Setup dialog now that there is a start/stop button 2015-09-02 12:07:15 +10:00
dd275327a4 Change "Stop" button into a Start/Stop button in Audio Setup dialog 2015-09-02 12:07:15 +10:00
dc831e4d8b refine "recent" column headers 2015-09-01 23:17:38 +02:00
d467165927 Display column headers for "recent session"
Avoid confusion regarding "32bit"
2015-09-01 21:05:00 +02:00
e10e9ca77f handle GUIs of missing or disabled plugins 2015-09-01 13:28:33 +02:00