13
0
Commit Graph

5426 Commits

Author SHA1 Message Date
19fc040be1 Calculate length_beats of split MIDI regions from 'parent' region.
This is probably less than ideal, since setting the properties later will
recompute from frames values.  It is, however, slightly more rightish :)

Seemingly correct cases (i.e. where length_beats is correct):
 * Recording a new MIDI region
 * Splitting said region

Broken:
 * Loading a region from XML

Untested:
 * Import


git-svn-id: svn://localhost/ardour2/branches/3.0@8324 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-22 00:48:59 +00:00
9e5550254c Remove lying comment.
git-svn-id: svn://localhost/ardour2/branches/3.0@8323 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-22 00:09:42 +00:00
372880803f Less code.
git-svn-id: svn://localhost/ardour2/branches/3.0@8322 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-22 00:01:15 +00:00
10a4435198 Consistently mark all regions "interesting".
(I havn't used the shared_ptr debugging stuff, but presumably marking an arbitrary subset of allocated regions "interesting" is not the idea...).


git-svn-id: svn://localhost/ardour2/branches/3.0@8321 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-21 23:52:10 +00:00
da89cd0c9b Remove confuzzling offset_relative stuff from region construction (pre-properties "hangover").
This commit (in theory) only reorganizes code, not change actual functionality.
RegionFactory now uses a distinct Region constructor for each case, which is a bit easier to wrap around.
Note comment at region.cc:276, this case seems pretty weird to me (more hangover?).


git-svn-id: svn://localhost/ardour2/branches/3.0@8320 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-21 17:03:16 +00:00
71986da212 Only calculate length_beats from length (in frames) if length property (in frames) is given, but length_beats property is not.
git-svn-id: svn://localhost/ardour2/branches/3.0@8319 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-21 00:53:18 +00:00
4e62adfe1a Fix more broken whitespace.
git-svn-id: svn://localhost/ardour2/branches/3.0@8318 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-21 00:41:13 +00:00
384c418ae0 Set new (recorded) MIDI source length to length of entire capture (instead of length from start to last actual recorded event).
Precisely set length_beats of newly captured MIDI regions to source length in beats (no conversion).


git-svn-id: svn://localhost/ardour2/branches/3.0@8317 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-21 00:04:58 +00:00
fe79c42725 Remove unused Region constructor.
git-svn-id: svn://localhost/ardour2/branches/3.0@8316 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 23:24:43 +00:00
fb21bf1480 Fix more broken whitespace.
git-svn-id: svn://localhost/ardour2/branches/3.0@8315 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 23:05:18 +00:00
f6ed36a457 Fix more broken whitespace.
git-svn-id: svn://localhost/ardour2/branches/3.0@8314 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 22:51:17 +00:00
7e3404e2a0 Fix more broken whitespace.
git-svn-id: svn://localhost/ardour2/branches/3.0@8313 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 21:50:46 +00:00
3f30e8093e Clean up region.h and trim include tree.
git-svn-id: svn://localhost/ardour2/branches/3.0@8312 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 21:22:49 +00:00
Carl Hetherington
fe879145fe Fix converter origins for computing region length.
git-svn-id: svn://localhost/ardour2/branches/3.0@8309 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 19:06:58 +00:00
Carl Hetherington
1fd105fbd4 Fix split of midi regions after tempo / meter changes.
git-svn-id: svn://localhost/ardour2/branches/3.0@8308 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 18:47:18 +00:00
76e7a89a51 use notification of what was changed in MidiRegion::post_set() call
git-svn-id: svn://localhost/ardour2/branches/3.0@8307 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 16:11:23 +00:00
e178fb2e50 add notification of what was changed in Stateful::post_set() call
git-svn-id: svn://localhost/ardour2/branches/3.0@8306 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 16:10:58 +00:00
Carl Hetherington
0945b96986 Fix summary height scaling problems when there are not enough tracks to fill the editor window.
git-svn-id: svn://localhost/ardour2/branches/3.0@8305 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 15:35:15 +00:00
Carl Hetherington
3ec58e478c Allow deletion of program changes in the same way as notes.
git-svn-id: svn://localhost/ardour2/branches/3.0@8304 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 13:30:31 +00:00
Carl Hetherington
570ed69d2a Allow dragging of program change flags in MIDI regions.
git-svn-id: svn://localhost/ardour2/branches/3.0@8303 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 03:42:59 +00:00
Carl Hetherington
ed0deee747 Make sure that _POSIX_VERSION is available.
git-svn-id: svn://localhost/ardour2/branches/3.0@8302 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-20 01:17:24 +00:00
Carl Hetherington
5f4bdb233a Clean up plugin preset handling a bit.
git-svn-id: svn://localhost/ardour2/branches/3.0@8301 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-19 23:11:01 +00:00
Sakari Bergen
bb7dbe6d86 Fix function pointer to void* cast (and vice-versa) related warnings on POSIX systems
git-svn-id: svn://localhost/ardour2/branches/3.0@8300 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-19 23:09:30 +00:00
Carl Hetherington
e212c8de66 Fix some spacey tabs.
git-svn-id: svn://localhost/ardour2/branches/3.0@8299 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-19 20:02:55 +00:00
Carl Hetherington
1c3d7637b5 Hopefully fix visual glitches on dragging fade ins/outs.
git-svn-id: svn://localhost/ardour2/branches/3.0@8298 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-18 23:53:37 +00:00
Carl Hetherington
556c627fed Further fade handle twaeks.
git-svn-id: svn://localhost/ardour2/branches/3.0@8297 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-18 21:34:32 +00:00
Carl Hetherington
66be0059e7 Tweak positioning of fade handles.
git-svn-id: svn://localhost/ardour2/branches/3.0@8296 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-18 20:43:00 +00:00
Sakari Bergen
94c69b3c91 Finally implement position aware silence adding in export (i.e. bbt times are converted to frames correctly)
This will work when Session::convert_to_frames_at is fixed :)


git-svn-id: svn://localhost/ardour2/branches/3.0@8295 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-18 19:27:04 +00:00
Sakari Bergen
ffadfff650 Add "session rate" as a possible sample rate for export formats
git-svn-id: svn://localhost/ardour2/branches/3.0@8294 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-18 17:56:41 +00:00
Carl Hetherington
850b7d24a9 Fix comment. Fix believed erroneous add of ticks to a fractional beats value.
git-svn-id: svn://localhost/ardour2/branches/3.0@8293 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-17 19:20:34 +00:00
f7763f4d8c patch from lincoln to make mute controllable emit its Changed signal; note to self: should route really have a mute_changed() signal too?
git-svn-id: svn://localhost/ardour2/branches/3.0@8291 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-17 04:14:24 +00:00
428aabdcfc fix BeatFramesConverter so that it at least works even if its not optimally named/designed
git-svn-id: svn://localhost/ardour2/branches/3.0@8290 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-17 01:51:12 +00:00
Carl Hetherington
39ebb427b3 Missing i18n patch from prokoudine. Fixes #3610.
git-svn-id: svn://localhost/ardour2/branches/3.0@8289 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-16 21:25:17 +00:00
Carl Hetherington
3029935f0a Fix comment.
git-svn-id: svn://localhost/ardour2/branches/3.0@8288 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-16 21:25:04 +00:00
Carl Hetherington
b3fcaf71d4 Fix loading of PortInserts from 2.X sessions.
git-svn-id: svn://localhost/ardour2/branches/3.0@8287 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-16 12:48:50 +00:00
Carl Hetherington
9e4b7a45fe Fix deadlock.
git-svn-id: svn://localhost/ardour2/branches/3.0@8286 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-16 12:48:11 +00:00
b8429faada make track list solo-isolate column wide enough to show "SI" as its name
git-svn-id: svn://localhost/ardour2/branches/3.0@8284 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-15 03:38:52 +00:00
Carl Hetherington
5d8853b02f Fix a memory leak.
git-svn-id: svn://localhost/ardour2/branches/3.0@8283 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-15 03:38:44 +00:00
2a30df0827 fix stupid variable naming issue in last BBT commit
git-svn-id: svn://localhost/ardour2/branches/3.0@8282 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-15 03:03:30 +00:00
Carl Hetherington
a6ed335ae9 Restore VST preset saving without chunks. Fixes #3602.
git-svn-id: svn://localhost/ardour2/branches/3.0@8281 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-15 02:58:55 +00:00
Carl Hetherington
17d4d60052 Give VSTPluginUI its own header.
git-svn-id: svn://localhost/ardour2/branches/3.0@8280 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-15 02:21:44 +00:00
Carl Hetherington
0e74620ad4 Make VST preset files pre-preset rather than global. Clean up VST preset handling to use more of the bas class' code.
git-svn-id: svn://localhost/ardour2/branches/3.0@8279 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-15 02:21:25 +00:00
Carl Hetherington
3a1af63fed Save and Delete buttons for plugin presets, remove largely useless edit plugin presets dialog. Should fix #2662.
git-svn-id: svn://localhost/ardour2/branches/3.0@8278 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-15 01:06:57 +00:00
f09524b9d3 move ticks per beat from Meter to Timecode::BBT_Time, add new constructor for BBT_Time based on a double value; reduce BeatFramesConverted to 1 liners pending likely removal
git-svn-id: svn://localhost/ardour2/branches/3.0@8277 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-14 20:28:37 +00:00
ee5a37a306 minor safety check for symmetry
git-svn-id: svn://localhost/ardour2/branches/3.0@8276 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-14 20:28:11 +00:00
3c48aabbbe EXPERIMENTAL: allow GUI button clicks on transport controls to drive transport speed change initiation even when slaved
git-svn-id: svn://localhost/ardour2/branches/3.0@8275 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-14 20:27:54 +00:00
e3c67bceb8 implement methods in TempoMap for walking a given distance along a tempo map and returning the resulting time; add a new property, _length_beats, to MidiRegion; use previously mentioned methods to keep _length_beats up to date as regions are moved AND as tempo map changes occur
git-svn-id: svn://localhost/ardour2/branches/3.0@8274 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-14 20:03:40 +00:00
df5e700f90 fix some more incorrect casts to CanvasNote rather than CanvasNoteEvent (fixes crashes when a track is in perc mode
git-svn-id: svn://localhost/ardour2/branches/3.0@8273 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-14 20:01:18 +00:00
9882fe9ab0 Clean up libtimecode, make license of bbt_time.h LGPL.
git-svn-id: svn://localhost/ardour2/branches/3.0@8272 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-14 19:07:50 +00:00
4b861e6039 Rename libmusictime libtimecode (consistent with already used namespace "Timecode").
Move BBT_Time to libtimecode.


git-svn-id: svn://localhost/ardour2/branches/3.0@8271 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-12-14 18:13:37 +00:00