Commit Graph

38096 Commits

Author SHA1 Message Date
Ben Loftis 082c009e1b take Snap Target preference into account when snapping with grid enabled 2023-09-11 12:18:16 -05:00
Ben Loftis 7672ea9cfe add a ui_pref to store the users Snap Target preference 2023-09-11 12:18:16 -05:00
Ben Loftis e99305c4dd add enumeration type for SnapTarget
this defines how the grid interacts with other snap targets (ph, etc)

* Grid: we ignore other snap targets when the grid is enabled
* Both: we snap to both grid and other snap-targets when grid is enabled
* Other: we only snap to other snap-targets and ignore the grid, even
    though the grid is enabled
2023-09-11 12:18:15 -05:00
Paul Davis c7e5f38aa5 remove debug output 2023-09-11 10:26:54 -06:00
Paul Davis 28af3c2024 i like nullptr 2023-09-11 10:26:54 -06:00
Paul Davis fa78fe1f33 fix incorrect design of abort-tempo-map-edit operation 2023-09-11 10:26:54 -06:00
Paul Davis 4eb58e104c remove double-macro'ed debug of undo history; use nullptr
Also, prefer early return to conditionalized function body
2023-09-11 10:26:54 -06:00
Paul Davis 88b5613f46 suppress warning about memcpy() use on a struct/class 2023-09-11 10:26:54 -06:00
Paul Davis 734a62101f remove use of Tempo::active() from GUI
This has not been accessible in the GUI since 7.0.
2023-09-11 10:26:54 -06:00
Paul Davis eca4c83b7b temporal: remove concept of inactive tempos 2023-09-11 10:26:54 -06:00
Robin Gareus 730bec5dc1
Reduce ASAN clutter when starting Ardour
This currently prints warnings for statically linked libs
here: zita-resampler global Resampler_table::_mutex
Both libardour and ALSA backend statically link against zita-resampler.
2023-09-11 17:16:37 +02:00
Robin Gareus 81939faa1a
UF8 surface is currently only for Mixbus 2023-09-11 17:13:22 +02:00
Robin Gareus b98b984859
Update Codenames 2023-09-11 17:13:06 +02:00
Paul Davis 09b368f5db fix visual update of tempo markers during tempo marker drag 2023-09-10 20:07:41 -06:00
Paul Davis 3a19e7d48b fix redisplay of track headers after UI scale change
The suspend/resume routes code requires that there be a call to
Editor::redisplay_track_views() if anything is to happen on resume. This was
missing from the events triggered by a UI scale change.
2023-09-10 18:20:35 -06:00
Paul Davis 848e0e0a10 fix manual errors during rebase against master 2023-09-10 18:20:35 -06:00
Paul Davis 776d8590f9 fix crash when opening a session created before the midnam-channel GUI property existed 2023-09-10 18:20:35 -06:00
Paul Davis 511c3ef048 remove debug output 2023-09-10 18:20:35 -06:00
Paul Davis 907e5571b4 remove midi_scroomer.h from MSVC project file 2023-09-10 18:20:35 -06:00
Paul Davis 194f0fbed6 finalize (?) some details of note name display options 2023-09-10 18:20:35 -06:00
Paul Davis df95ec6b43 partial response to note name display option 2023-09-10 18:20:35 -06:00
Paul Davis 2f0bfedb58 include "Channel" in text for MIDNAM display channel selector 2023-09-10 18:20:35 -06:00
Paul Davis 090b9d4f60 remove MIDI scroomer from code 2023-09-10 18:20:35 -06:00
Paul Davis 605fd136e0 add preferances item for note name display 2023-09-10 18:20:35 -06:00
Paul Davis 8f41576491 add enum declarations 2023-09-10 18:20:35 -06:00
Paul Davis 71f168834d obey note name display preference 2023-09-10 18:20:35 -06:00
Paul Davis b81da94fa2 add UI config var for note name display 2023-09-10 18:20:35 -06:00
Paul Davis b4f684e02f missing enum convert 2023-09-10 18:20:35 -06:00
Paul Davis 6966a2b7d8 add basic Editing enums/types for note name display options 2023-09-10 18:20:35 -06:00
Paul Davis 5611e7eeed tweak gradient width in scroomer area 2023-09-10 18:20:35 -06:00
Paul Davis 0b9a54ac32 fix scope of a char* [] buffer 2023-09-10 18:20:35 -06:00
Paul Davis a3838f0c66 alex mitchell's piano roll header: add correct motion event handler 2023-09-10 18:20:35 -06:00
Paul Davis baa32aa5bd merged commit from alexander mitchell, implementing a new piano roll header 2023-09-10 18:20:35 -06:00
Robin Gareus 0e3594bb1c
Add Temporal::Beats Lua bindings 2023-09-10 22:23:57 +02:00
Robin Gareus d37f85f9d2
Emit selection `RegionsChanged` when region is removed
This is required to properly update the selection.
Previously deleting a region did not update selection
markers and other selection displays that depend on
Editor::get_selection_extents (which includes region selection).

This fixes a crash: Select a region (this sets a time-selection).
Delete the region, click on the time-selection markers (red triangles).
2023-09-10 15:25:12 +02:00
Maciej Bliziński 1c8b91ed86
Keep the search term in the dialog box.
When user wants to keep the dialog box open, it's probably with the intention to edit the search term rather than typing it from scratch again.
2023-09-09 21:48:21 +02:00
Robin Gareus c0287cb0de
Fix thinko in e81b2353cc, selection may not start at a marker
This fixes a crash when selecting a section, and then changing
the time-selection. Previously it was assumed that the section
context menu can only be shown for sections. But it applies to
any time[line]-selection.
2023-09-09 21:27:11 +02:00
Asahi Lina d1cc71150f Adjust interpretation of swing amount
Previously,

0 -> no swing (1:1, 50%)
50 -> triplet swing (2:1, 66%)
75 -> hard swing (3:1, 75%)
100 -> sextuplet swing (5:1, 83%) (default!)
150 -> absolute maximum (inf:1, 100%)

This is rather confusing...

One common interpretation uses percentages of the beat, where triplet
swing is 66%. However, that causes precision issues since it's really
66.666...

Since we already default to 100 and take "no swing" as zero, let's make
that reference point triplet swing. Then the scale becomes:

0 -> no swing (1:1)
100 -> triplet swing (2:1)
150 -> hard swing (3:1)
200 -> sextuplet swing (5:1)
300 -> absolute maximum (inf:1)

300 doesn't make any sense, so let's change the range to -250 .. 250
which covers all useful values.

Also remove the division through 100 and back, to avoid rounding issues.

Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Asahi Lina f1004a445e Fix quantization swing
- Fix selection of what beats to swing (was always done)
- Fix swing strength (lack of precision rounded to 50% or 100%)
- Fix model offset not being applied properly

Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Asahi Lina ca25b5c841 Fix quantize threshold setting
Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Asahi Lina 577918dc07 Fix quantize beat divisions
Signed-off-by: Asahi Lina <lina@asahilina.net>
2023-09-09 20:06:37 +09:00
Paul Davis aca5d7d988 place lollipops in correct location on timeline
It is not immediately clear to me why the + radius expression is reqired
2023-09-08 16:16:15 -06:00
Paul Davis 4ff8cff024 add velocity sense for MIDI Learn-ed clip triggering 2023-09-08 15:27:11 -06:00
Paul Davis 2f25592702 push2: add velocity sensitivity 2023-09-08 14:57:28 -06:00
Paul Davis 1249195516 push2: remove debug output 2023-09-08 14:57:07 -06:00
Paul Davis b440488295 launchpad pro: provide velocity info when launching clips/triggers 2023-09-08 14:41:21 -06:00
Paul Davis 36048ea651 triggerbox: change API to allow providing velocity information when "banging" triggers
... and by extension using it (based on the magnitude of the velocity effect setting) to set the gain of
audio triggers
2023-09-08 14:41:21 -06:00
Ben Loftis 503e6249f4 remove GridTypePlayhead 2023-09-08 15:27:04 -05:00
Robin Gareus d57676b9c7
Maybe clear time-selection when switching to draw tool 2023-09-08 14:50:43 +02:00
Ben Loftis e81b2353cc
Indicate arrangement section selection on canvas 2023-09-08 03:26:00 +02:00