Paul Davis
5d023b4c60
The old code assumed that the thread that created a request buffer for a given signal-emitting thread would be the latter thread, and thus a thread-local pointer to the request buffer could be used. This turns out not to be true: the GUI thread tends to be responsible for constructing the request buffers for pre-registered threads. That mechanism has been replaced by using a RWLock protected map using pthread_t as the key and the request buffer as the value. This allows any thread to create and register the request buffers used between any other pair of threads (because the lookup always uses a pthread_t). The symptoms of this problem were a signal emitted in an audioengine thread that was propagated to the target thread, but when the target thread scans its request buffers for requests, it finds nothing (because it didn't know about the request buffer). In a sense, the signal was successfully delivered to the target thread, but no meaningful work (i.e the signal handler) is performed. |
||
|---|---|---|
| .. | ||
| ARDOUR | ||
| bb | ||
| CrashReporter | ||
| doxy2json | ||
| fluid-patches | ||
| gccabicheck | ||
| icons | ||
| linux_packaging | ||
| misc_resources | ||
| omf | ||
| osx_packaging | ||
| patches | ||
| sanity_check | ||
| signal-test | ||
| smf-load | ||
| udev | ||
| videotimeline | ||
| vst3-patches | ||
| x-win | ||
| as-metainfo.its | ||
| autowaf.py | ||
| avahi.sh | ||
| clang-format | ||
| cstyle.py | ||
| ctagsparse.py | ||
| define_versions.sh | ||
| f2s | ||
| fmt-bindings | ||
| fmt-luadoc.php | ||
| jacktest.c | ||
| list_scripts.lua | ||
| misc.py | ||
| msvc32-fixup.pl | ||
| nofuzz.sh | ||
| objc.supp | ||
| peakdump.c | ||
| pre-commit | ||
| process-metadata | ||
| readtest.c | ||
| resample_session.pl | ||
| run-readtest.sh | ||
| run-threadreadtest.sh | ||
| run-writetest.sh | ||
| session_exchange.py | ||
| sfrtest.cc | ||
| sftest.cc | ||
| split_benchmark.lua | ||
| synthesize_sources.pl | ||
| thread_readtest.cc | ||
| update_fluidsynth.sh | ||
| update_luadoc.sh | ||
| update_lv2stack.sh | ||
| update_qm-dsp.sh | ||
| update_qm-vamp.sh | ||
| update_vst3.sh | ||
| valgrind.supp | ||