13
0
livetrax/libs/surfaces
Matthijs Kooijman a9a5787399
osc: Fix send and plugin page size in /set_surface
When handling the `/set_surface` command, the code would set
plug_page_size to the new value first, and call `sel_plug_pagesize()`
later. The latter then sees the page size is already the same, so it
leaves it unchanged and also does not send the page size to the
OSCSelectObserver object. In practice, this means that only the default
plugin page size from the preferences or set with
`/set_surface/plugin_page_size` take effect and values set with
`/set_surface` are ignored.

Exactly the same thing happens for the send page size.

This code has been like this since it was first introduced in comit
9c0f6ea948 (OSC: Allow set_surface to set send and plugin page sizes.,
2017-06-13)

This commit fixes this by omitting the first assignment.
2024-09-03 00:40:11 +02:00
..
cc121
console1 Remove #include <boost/algorithm/string/trim.hpp> 2024-08-29 23:08:42 +02:00
contourdesign
faderport faderport: fix SNAFU caused by switching to Mixbus-style use of user button 2024-07-23 18:21:43 -06:00
faderport8 faderport8: Better debug trace when not probing the midi ports 2024-07-25 13:50:54 +02:00
frontier
generic_midi Fix ctrl surface shutdown sequence 2024-07-11 19:19:21 +02:00
launch_control_xl
launchkey_4 use new launckkey image file for surface GUI dialog 2024-08-29 18:54:11 -06:00
launchpad_pro redesign API and internals of CoreSelection for more universality 2024-08-02 11:50:21 -06:00
launchpad_x Fix ctrl surface shutdown sequence 2024-07-11 19:19:21 +02:00
mackie Remove #include <boost/smart_ptr.hpp> 2024-08-29 23:08:43 +02:00
maschine2
osc osc: Fix send and plugin page size in /set_surface 2024-09-03 00:40:11 +02:00
push2 redesign API and internals of CoreSelection for more universality 2024-08-02 11:50:21 -06:00
tranzport
us2400 Remove #include <boost/smart_ptr.hpp> 2024-08-29 23:08:43 +02:00
websockets Narrow scope of boost::hash_combine include 2024-08-29 23:08:41 +02:00
wiimote
wscript add new novation LK4 surface support 2024-08-29 18:31:00 -06:00