ardour/livetrax
13
0
Fork 0
Code

osc: Fix send and plugin page size in /set_surface

Browse Source 
When handling the `/set_surface` command, the code would set
plug_page_size to the new value first, and call `sel_plug_pagesize()`
later. The latter then sees the page size is already the same, so it
leaves it unchanged and also does not send the page size to the
OSCSelectObserver object. In practice, this means that only the default
plugin page size from the preferences or set with
`/set_surface/plugin_page_size` take effect and values set with
`/set_surface` are ignored.

Exactly the same thing happens for the send page size.

This code has been like this since it was first introduced in comit
9c0f6ea948 (OSC: Allow set_surface to set send and plugin page sizes.,
2017-06-13)

This commit fixes this by omitting the first assignment.
This commit is contained in:
Matthijs Kooijman 2024-06-30 18:04:41 +02:00 committed by Robin Gareus
parent 142fa9f55d
commit a9a5787399
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/surfaces/osc/osc.cc
View File

@ -1882,8 +1882,6 @@ OSC::set_surface (uint32_t b_size, uint32_t strips, uint32_t fb, uint32_t gm, ui
} else {
s->usegroup = PBD::Controllable::NoGroup;
}
s->send_page_size = se_size;
s->plug_page_size = pi_size;
if (s->temp_mode) {
s->temp_mode = TempOff;
}