13
0
Commit Graph

28836 Commits

Author SHA1 Message Date
fa2c935581
Fix re-packing of toolbar meter
This fixes a gtk-warning when loading a session from a
running instance:
IA__gtk_table_attach: assertion 'child->parent == NULL' failed"
2020-01-13 20:17:58 +01:00
fd4c35d46a
Add rubberband Lua bindings to process ardour regions 2020-01-13 17:57:35 +01:00
868d752b4f Processor list should use the same bg color as other lists 2020-01-12 18:13:57 -06:00
6d62352673 Add missing theme elements, and fix some thinkos 2020-01-12 18:13:52 -06:00
30553a2675 Apply some missing widget names 2020-01-12 18:13:47 -06:00
66e24f3333
Fix preference pane to access for external-sync 2020-01-12 18:05:16 +01:00
6487d6c62b
Fix external timecode GUI display
Only show mis/matching TC if FPS has been detected and
timecode master is locked.
2020-01-12 18:04:12 +01:00
c87bec07cd
Fix thinko in eee01188 (engine pulse spacing) 2020-01-12 00:16:19 +01:00
e508bb1396
Add test synth to debug capture alignment 2020-01-11 22:33:32 +01:00
03c4335c1e fix drawing of zero-length notes
Note that the result is too narrow to be manipulated, though it can be moved
2020-01-11 10:57:21 -07:00
d79e869da8 use "extends to numeric_limits<Beats>::max()" rather than "zero length" for nascent (incoming) notes 2020-01-11 10:57:21 -07:00
8547a23e9c removal incorrect/unnecessary forward decl 2020-01-11 10:57:21 -07:00
929bd7c8ac use Note::end_time() == numeric_limits<Beats>::max() as the indicator that a note is in-process w.r.t. recording
We used to use length() == 0, but this clashes with actual zero-length notes
2020-01-11 10:57:21 -07:00
00150e105c
Fix AFL position
* update AFL position when preference changes
* "after post-fader processors (before pan)" is before
  the main-out (not at the end).
* Fix "immediately post-fader":
  The amp, when added was the last element. ++after_end then
  made the iterator point to .end()

This likely worked in the past when the monitor send was added
immediately after adding the fader/amp before any other processors.
2020-01-11 17:48:42 +01:00
Carl Hetherington
1f14a9d9a5 Scale the port matrix with the GUI/font-scaling setting. 2020-01-11 01:17:42 +01:00
a883afbd64
Clarify insert-time option 2020-01-10 18:59:09 +01:00
abc6f24d10
Stop engine for new session creation
This restores Ardour5 behavior and works around a missing "OK"
button in the engine-dialog.
2020-01-10 18:11:42 +01:00
afe52fbff5
Special case JACK, sample-rate cannot be changed for new sessions 2020-01-10 02:14:30 +01:00
242774eada
Allow to configure sample-rate of new sessions
When creating a session from the Editor (after Session > Close,
or directly via Session > New) the engine-dialog needs to be displayed
to allow configuring the sample-rate.

This also consolidates scripted session setup: meta_session_setup()
is now called from build_session(), instead of all callers.
2020-01-09 23:53:07 +01:00
Nikolaus Gullotta
c2da64f7ad
NOP: Trim whitespace and convert tabs to spaces 2020-01-09 14:01:37 -06:00
Nikolaus Gullotta
dac127c897 Update reset_mixer script to use new well-known controls 2020-01-09 13:54:43 -06:00
0771717dd5
Remove unused variable 2020-01-09 18:21:48 +01:00
16549e86e3
Latency debug script: include MIDI ports 2020-01-09 18:21:48 +01:00
Nikolaus Gullotta
0f85a33487
Fix typo in Lua binding for compressor enable control 2020-01-09 10:22:00 -06:00
0e42708685 expand comment to include (more of?) the full story about uncombining and copies 2020-01-08 22:21:21 -07:00
965bf74f2b expand the test used to decide if we need to make copies when uncombining a compound region 2020-01-08 22:21:21 -07:00
1c86b0ce13 never remove entries from the CompoundAssociation map 2020-01-08 22:21:21 -07:00
7373e3ac14 add concept of an owner region (by ID) to PlaylistSource 2020-01-08 22:21:21 -07:00
d1c2098c11 fix bugs (thinkos?) that confused PlaylistSource's id() with its original() 2020-01-08 22:21:21 -07:00
0098072904 NOOP: reindent 2020-01-08 22:21:21 -07:00
4d6ad4a499 increase explicit refcnt for playlists when used by a PlaylistSource 2020-01-08 22:21:21 -07:00
d1433992fb
Fix MIDI loop recording - Revert "Fix MIDI disk-writer flush"
This reverts commit 254f22e372.
2020-01-09 03:53:02 +01:00
16677e80cd
Towards fixing MIDI capture alignment
When there is no overlap (Evoral::OverlapNone) of local transport
position and the record-range, MIDI data does not need to be
offset.

This matches audio recording: Only write to the capture ringbuffer
when there is an overlap.

(There is still some unknown, unresolved discrepancy remaining
to be tracked down)
2020-01-09 03:37:21 +01:00
5b8765d6dd
Fix CaptureAlignment debug messsage 2020-01-09 00:20:43 +01:00
2ae327fa8f prevent MIDI note starts being drawn earlier than their region start 2020-01-08 10:22:08 -07:00
563a8b15e0
Revert to use an image surface for CairoWidgets
This partially reverts 2edbda2526 and is a follow up to 0b266a54f,
to fix performance issues with MS Windows graphics performance.
2020-01-08 04:24:51 +01:00
c59c46a70a
Mini-timeline, use explicit cairo-group to consolidate rendering 2020-01-08 04:24:51 +01:00
5ff28f9ab7 fix required offset when reading MIDI data near loop end/start 2020-01-07 19:27:04 -07:00
901f17dd67 improved/new DEBUG_TRACE output 2020-01-07 19:27:04 -07:00
5948d14012 plugins should NOT resolve MIDI notes at loopend
Their data will come from (1) disk, in which case the DiskReader will do the resolve (2) live input
in which case the player/user will do the resolve
2020-01-07 19:27:04 -07:00
11d7803e57 imrpove debug msg 2020-01-07 19:27:04 -07:00
0ac09d1f67 fix serious but rare error in RTMidiBuffer's storage of MIDI events with size > 3
sizeof (T) is in units of bytes, not bits. Use C++ standard CHAR_BITS instead.
2020-01-07 19:27:04 -07:00
c6493aa81b
Fix samples_as_time_string formatting 2020-01-08 00:41:08 +01:00
9091838b82
Fix MIDI Port-latencies
Only audio ports have additional latency due to I/O re-sampling
for vari-speed playback/capture.. MIDI ports are not affected.
2020-01-08 00:40:18 +01:00
7f33d95937
Remove debug output 2020-01-07 04:21:38 +01:00
254f22e372
Fix MIDI disk-writer flush
to_write must not exceed `total = _samples_pending_write`.
If the write succeeds (events spanning `to_write` samples are written)
to_write is atomically subtracted from `_samples_pending_write`.
2020-01-07 03:59:25 +01:00
f15297e24c
Amend 8a5cbb8: fix variable-names and comments 2020-01-07 01:14:42 +01:00
Nikolaus Gullotta
8a5cbb8510
Reenable the correct sort column and type when redisplaying regions 2020-01-06 16:08:55 -06:00
eee01188b4
Dummy: Engine-Pulse audio/midi generators
This produces synchronous events on Audio and MIDI ports.
One rvent per second, exactly at every second since engine-start.

MIDI: C-4 Note-on/off (1 sample long)
Audio: +1/-1 transition:
       +1 in sync with Note-on,
       -1 in sync with Note-off
2020-01-06 22:43:30 +01:00
beb39092b9
Proper forward declaration for Lua bindings (amend 2afef6e4bd) 2020-01-06 17:14:10 +01:00