13
0
Commit Graph

34069 Commits

Author SHA1 Message Date
e609c9f417 trigger_ui: implement menu option for quantization=None 2021-12-27 18:03:13 -06:00
bad4fdc48a trigger_ui: better display+handling of FA enable and probability 2021-12-27 18:03:13 -06:00
f5c2697f4f trigger_ui: trigger-master button should follow conventions of other Stop buttons
Normally the Stop occurs quantized (on bar ending). Primary-modifier means 'stop now'
2021-12-27 18:03:13 -06:00
a43e3d88e5 triggerbox: notify the UI when we Clear a trigger 2021-12-27 18:03:13 -06:00
3a506ac7a1 triggerbox: mark session dirty when a Trigger's properties are changed
also make an effort to damp callbacks that are prone to gui feedback loops
 i.e.  CheckMenu Items and Adjustments
2021-12-27 18:03:13 -06:00
be190f611d cruft removal 2021-12-27 18:03:13 -06:00
b722a23f39 triggerbox colors (gtk part) 2021-12-27 18:03:13 -06:00
cc5fb209ab triggerbox: Triggers may be assigned a color
colors can be transmitted to some surfaces (Launchpad et al), so must be store in Trigger::
2021-12-27 18:03:13 -06:00
8ac1b40694 pixel-pushing: tweak text position 2021-12-27 18:03:13 -06:00
3324882fe0 pixel-pushing: remove horizontal divider lines 2021-12-27 18:03:13 -06:00
13b907af5b pixel-pushing: better icons for Any and Other 2021-12-27 18:03:13 -06:00
12dbcd90bf triggerbox: fix quantized stop via ::unbang() 2021-12-27 16:24:35 -07:00
163fc541d2 triggerbox: alter MIDITrigger::run() to work like its AudioTrigger counterpart 2021-12-27 15:08:20 -07:00
af37a51b65 triggerbox: triggers estimated to be 1 bar long are not one-shots 2021-12-27 15:07:44 -07:00
f9903a7a8b triggerbox: use custom (threaded) deleter for MIDITriggers just like AudioTriggers 2021-12-27 12:04:39 -07:00
3755c04786 triggerbox: fix some const qualifier usage 2021-12-27 12:04:21 -07:00
8e2b36d43d triggerbox: NOOP: add explanatory comment 2021-12-27 11:24:21 -07:00
610125b87c remove call to #ifdef'ed code 2021-12-27 11:24:03 -07:00
75d5d54cb6 triggerbox: position triggerbox after disk reader, before polarity, by default 2021-12-27 11:20:40 -07:00
d82d8dd7d4 NO-OP: fix spelling mistake 2021-12-27 11:20:40 -07:00
18fe2e2c4e
Fix C++11/14 array initialization (clang < 3.7)
C++11 array initialization won't call copy constructor, leading to
an error: array initializer must be an initializer list.

Specifically this affects the copy c'tor: line 93: peaks (other.peaks)

A workaround is to use a vector instead of a fixed size array.
This fixes macOS builds.
2021-12-27 16:42:26 +01:00
a71ab327a3 triggerbox UI: set ruler metric 2021-12-24 15:34:30 -07:00
b2bd748672 ruler: make ::set_metric() API consistent with constructor by using ptr 2021-12-24 15:34:18 -07:00
8c2bd1a555 triggerbox: get thread-based deletion system to actually work
Needed to pass custom deleter to the shared_ptr<Trigger>::reset() call where the
trigger is replaced
2021-12-24 15:00:58 -07:00
a5c37e6fd4 fix one remaining trigger lookup in trigger UI 2021-12-24 14:42:52 -07:00
c18823c0e0 triggerbox: change entire UI side to avoid using TriggerPtr
Lifetime management of Triggers is unlike anything(?) we've dealt with in
Ardour so far. The parent object (Triggerbox) has a normal lifetime
pattern, but Triggers can come and go in a way that few other objects
do (although Processors and particularly PluginInsert are somewhat similar).
We do not want the GUI to hold references to the actual Triggers, because the
end of life of a Trigger is not really a signal for the GUI element to go
away (the Trigger will be replaced in the slot). Consequently, we do not
want TriggerPtr used as a member variable anywhere in the UI. Instead we use a
TriggerReference which can "lookup" a Trigger on-demand (by box and slot
number). The (G)UI now uses these exclusively.

Work still needed to pick up trigger swap signals from the boxen.
2021-12-24 14:18:10 -07:00
401411d5c3 triggerbox: initial implementation of thread-based deleter for Triggers
Uses a custom deleter for the shared_ptr<Trigger>'s that we create. Will
likely evolve to use an allocator so that we can use make_shared's
cousin allocate_shared().
2021-12-24 14:17:23 -07:00
7afc8f7a31 triggerbox: remove unused local variable 2021-12-24 14:17:23 -07:00
4d15bf9f18 triggerbox: move TriggerReference object into ARDOUR::Triggerbox
Also, change box handle to a pointer so that we can have a
default (empty) constructor.
2021-12-24 14:17:23 -07:00
ce71ee010e triggerbox: fix API/virtual issue with ::start_offset() method 2021-12-24 14:17:23 -07:00
753d1c9754 rulers: change API to accept a pointer instead of a reference to a Metric
We need to be able to construct Metrics after the ruler is constructed
in order to deal with Triggers which are potentially short-lived. We
stored the reference as a pointer anyway, so it's not as much of a change
as it appears.
2021-12-24 14:17:23 -07:00
7f3681c7ac
Scale export-analysis dataset 2021-12-24 21:59:03 +01:00
4fa8af3e20
prefer ARDOUR::ui_scale_factor over ARDOUR::ui_scale_factor 2021-12-24 21:58:59 +01:00
8221b22ffd
Push UI scaling to libardour 2021-12-24 21:58:57 +01:00
50c60c031d
Allow to use UI scaling to libardour
This will replace LV2Plugin::_ui_scale_factor,
and be useful for export-analysis.
2021-12-24 21:58:53 +01:00
31159c2f77
NO-OP: clang-format 2021-12-24 19:54:00 +01:00
d0792a7721
Update Export Graph rendering for variable size 2021-12-24 19:54:00 +01:00
122d219354
Prepare scaleable analysis (variable width, bins) 2021-12-24 19:54:00 +01:00
ea9512ff1a trigger_ui: various thinkos. fixes property editor FA buttons 2021-12-23 22:35:52 -06:00
42069bc7e2 trigger_ui: implement clear_all_triggers in Master button context menu 2021-12-23 22:35:52 -06:00
e87c7d96fb trigger_ui: code cleanup; consistently use X_to_string; add missing items 2021-12-23 22:35:52 -06:00
68990d2dbd trigger_ui: add a set_all_X context menu to Cue buttons 2021-12-23 22:35:52 -06:00
31228c8635 triggerbox: clear_all_triggers (libardour part) 2021-12-23 22:35:52 -06:00
bc8994d5c8 trigger_ui: implement Audition Action (press A to audition, spacebar to stop) 2021-12-23 22:35:52 -06:00
216ff53bb9
C++11 Lambda FTW! 2021-12-24 02:13:50 +01:00
cf5dcd12ee
Use a callback instead of subtractive char math 2021-12-24 02:13:03 +01:00
7a8775382f
Remove ASCII limit when naming files/regions 2021-12-24 00:31:01 +01:00
d78364f90b
Un-hardcode number of trigger-slots 2021-12-24 00:31:01 +01:00
b2b9c38bc3
Leave a note about trigger-slot IDs using western alphabet
Ideally these would be translatable into Cyrillic, Greek,
Chinese or any other alphabet (and not be limited to 26 either).
2021-12-24 00:31:01 +01:00
00b2b21878 remove debug output 2021-12-23 15:46:31 -07:00