13
0
Commit Graph

29394 Commits

Author SHA1 Message Date
d7500056fc stop transport clocks from jumping after the playhead is moved via a CursorDrag 2020-03-25 19:24:38 -06:00
eeb2e99a3b
Display unit-label of VST parameters -- #7938 2020-03-26 02:17:22 +01:00
8fe3c367cf
Fix compiler warning 2020-03-26 02:17:22 +01:00
6291433e27 set Editor::_pending_locate_request to true before sending locate request. 2020-03-25 18:39:59 -06:00
25c0bd9274 Prevent updates to the playhead when a locate is pending after a drag/click is used to move the playhead.
There are two problem cases:

  1) the drag "fake-located" the playhead, but a redraw happens before the locate itself finishes.
  2) the transport emits Session::PositionChanged from Session::non_realtime_stop(), even though
     this is occuring in the "middle" of the locate process (we stop first).

In the first case, the drag code sets _pending_locate_request, since we need this to be true even
before the queued SessionEvent for the locate has been processed. So to deal with this case

In the second case, we use Session::locate_initiated() to decide if we're in the middle of a locate.
2020-03-25 18:39:59 -06:00
84f8b8beae
Convert polarity invert state from v2 sessions 2020-03-25 23:58:15 +01:00
51165aec0b remove some additional debug output 2020-03-25 16:14:25 -06:00
0622d69196 change text for a couple of UI config options 2020-03-25 16:10:27 -06:00
5d1b75bd4f likely fix for cases where a button release event falls through from the canvas to the editor, during a drag
The drag code expects coordinates in canvas coordinates, but we were not translating them at the editor level (canvas event handling
does do this, but cannot affect the situation if the event falls through to the editor)
2020-03-25 15:30:52 -06:00
4151ec1907 remove accumulated debug output 2020-03-25 15:12:30 -06:00
a0f2ae4833
Do not allow aux sends from the master-bus
This always leads to feedback situations. It may be acceptable
via the "allow feedback" option and accepting 1 cycle delay.
yet Aux-sends from the master bus are just bad practice,
and no found on any mixing desk.
2020-03-25 21:38:44 +01:00
53c666f1b8
Add restrictions for aux send cut/copy/paste & DnD
This prevents adding duplicate sends via copy/paste, or
creating invalid aux-send in the destination bus.
2020-03-25 21:38:44 +01:00
4a24cc5083
Fix Aux-Send names on copy/paste
Sends do not have any ports, so a unique name is not required.
Since 82541b33a4 custom aux names are kept when setting state.

Previously this "worked" because set_state() change the name
of the new aux-send to the name of the target-bus.
2020-03-25 21:38:44 +01:00
dbcf7dd666 more playhead-drag/click locate debugging 2020-03-25 13:50:23 -06:00
dbcd78cf71 more playhead-drag/click locate debugging 2020-03-25 13:18:58 -06:00
1b05ebbafa more playhead-drag/click locate debugging 2020-03-25 12:33:46 -06:00
77ab1a39b8 more playhead-drag/click locate debugging 2020-03-25 11:48:53 -06:00
becfad91c2 more playhead-drag/click locate debugging 2020-03-25 11:48:18 -06:00
f8b16e9e83 remove a few cerr outputs and change a couple to use cout, since they are not errors 2020-03-25 11:39:32 -06:00
04aebc920e more playhead-drag/click locate debugging 2020-03-25 11:23:45 -06:00
41ff788a76 more playhead-drag/click locate debugging 2020-03-25 11:03:18 -06:00
4b40243f2b fix two poorly-formed uses of Glib::DateTime 2020-03-25 10:45:00 -06:00
3d6eaf8e69 remove old, undocumented mechanism to set PBD::DEBUG flags from environment variable
An app-level mechanism now exists in main(), via ARDOUR_DEBUG_FLAGS, and will do the same thing
2020-03-25 10:36:10 -06:00
447a045828 do not parse debug options in a non-debug build 2020-03-25 10:34:16 -06:00
3e962da4bb improve debug flag setting message 2020-03-25 10:30:40 -06:00
b3cbd8f44e if user chooses not to delete a scratch session, removed the file that identifies it as unnamed (GUI) 2020-03-25 10:25:00 -06:00
1157c7d457 if user chooses not to delete a scratch session, removed the file that identifies it as unnamed
This way they will not be asked again if they reload and then quit the session
2020-03-25 10:24:47 -06:00
ec345037b0
Suppress debug output in optimized builds 2020-03-25 16:43:24 +01:00
89904468b3
Fix generic UI crash when plugin has ctrl outputs -- #7937
build_control_ui() special cases `AutomationControl mcontrol = NULL`
to create read-only output display. So Iterating over
Evoral::Control that are not AutomationControl must not crash.

This fixes a bug introduced in a44fecb740.
"Edit with generic controls" caused crashes for plugins with ctrl outs.
2020-03-25 16:36:54 +01:00
807915b40c remove debug output 2020-03-24 21:15:57 -06:00
900bab7271 basic pass at deleting scratch sessions 2020-03-24 21:15:32 -06:00
4d9017a1fb
Also allow scratch sessions via Session > New 2020-03-25 02:43:20 +01:00
993cba5a7c
NO-OP: whitespace 2020-03-25 02:34:17 +01:00
e3e794f3a8
Fix crash at exit when closing session before quit 2020-03-25 02:23:16 +01:00
777ac65831 debug output 2020-03-24 18:55:16 -06:00
384ded905d debug output 2020-03-24 18:39:46 -06:00
4d91637b45 handle scratch session when quitting 2020-03-24 18:26:12 -06:00
75fec524d2 add debug trace output for locate 2020-03-24 18:22:39 -06:00
ad7ff1ffd7
Do not trim MIDI region end to last event on session-load
This amends 295fb3ff5a. Tape tracks were only available
for audio data.
2020-03-24 23:45:23 +01:00
Nil Geisweiller
fe6c5f98b2
Remove redundant AZERTY Virtual MIDI Keyboard Layout 2020-03-24 22:36:20 +01:00
97340a5c89 when saving an unnamed session, rename it (GUI edition)
Note that this is done at the GUI level, might need to double check if there are
other paths into a "save" that should be covered. Control surfaces use the action, but
Lua comes to mind
2020-03-24 14:10:39 -06:00
5f1d802307 when saving an unnamed session, rename it
Note that this is done at the GUI level, might need to double check if there are
other paths into a "save" that should be covered. Control surfaces use the action, but
Lua comes to mind
2020-03-24 14:10:39 -06:00
e9be6c23a8 a better approach to the name of the "unnamed" indicator file; remove file after successful save 2020-03-24 14:10:39 -06:00
5d4ad01b58 introduce the idea of an "unnamed" session (GUI edition) 2020-03-24 14:10:39 -06:00
5766989319 introduce the idea of an "unnamed" session 2020-03-24 14:10:39 -06:00
23d72eedbf remove unused variable 2020-03-24 14:10:39 -06:00
20717b68bf fix startup behavior if answering "No" to "Do you want to open (this existing session)?" 2020-03-24 14:10:39 -06:00
ccc9042bf2 detect whether or not user edited the name for a new session
Suprisingly hard/irritating. Thanks, GTK! (Gtk::Entry::set_text() emits all
the same signals that actual user interaction can trigger, except for key events)
2020-03-24 14:10:39 -06:00
78cf1ed119 prefill new session name with a date-based default
Select it, so that typing will immediately replace it
2020-03-24 14:10:39 -06:00
fbcb7b9ffc
Add Lua binding for bounded roll 2020-03-24 18:47:39 +01:00