13
0
Commit Graph

25925 Commits

Author SHA1 Message Date
c591368133 Remove unreachable code.
if (working_on_selection) {
  ...
} else {
  if (working_on_selection) { .. never reached .. }
}

Found by PVS: https://www.viva64.com/en/b/0540/
2017-11-23 10:51:20 +01:00
5e04e288a0 NO-OP: cleaner syntax 2017-11-23 10:46:44 +01:00
43f329256e Consistent default argument for virtual fn. 2017-11-23 10:45:04 +01:00
12a5102713 Catch exceptions by const reference 2017-11-23 10:38:52 +01:00
3009fd7574 Fix a potential(?) nullptr dereference 2017-11-23 10:38:05 +01:00
07f940016c fix call to std::unique; to actually erase dups. 2017-11-23 10:23:54 +01:00
3ac66ce022 Fix potentially ambiguous printf()
Not a real issue, since it's just supposed to be some unique number.
but still.

Reported by PVS-Studio - https://www.viva64.com/en/b/0540/
2017-11-23 10:12:34 +01:00
4f82d1ba99 No need for memset to clear a byte. 2017-11-23 10:10:32 +01:00
1a46ee716d remove useless test, fgets() already ensures MAX_STRING_LEN
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
2017-11-23 09:56:57 +01:00
2fec64f0bd Fix another duplicate if from session/system config consolidation
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
2017-11-23 09:53:50 +01:00
a593a81db3 Fix size-request call
use  Requisition Gtk::Widget::size_request () 	const;
and not deprecated
void Gtk::Widget::size_request 	(const Requisition&);

Found by PVS-Studio - https://www.viva64.com/en/b/0540/
2017-11-23 09:53:09 +01:00
55ee5d2e50 Fix duplicate if(A) else if (A) condition
Issue came to be from consolidating Session and UI configuration.
Found by PVS-Studio - https://www.viva64.com/en/b/0540/
2017-11-23 09:50:50 +01:00
7d4353dddc Fix typo in 318e7efb 2017-11-23 00:13:46 +01:00
98439cf88c GUI to set clock-origin marker 2017-11-23 00:13:44 +01:00
15150c57c1 Implement clock delta modes
* use new config variable
* update GUI to select delta-modes
* delegate delta-calculation to MainClock
* save offset to calculate absolute-time
2017-11-23 00:13:32 +01:00
1be2790cac Add clock-delta mode enum 2017-11-23 00:12:00 +01:00
e275154a40 Introduce a dedicated "Clock Origin" Marker 2017-11-23 00:11:55 +01:00
84337d3018 Fix switch statements in ExportTimespanSelector 2017-11-22 20:36:58 +01:00
867460cd30 Add seconds as clock-unit 2017-11-22 20:36:28 +01:00
318e7efb9e Release (debug) lock before emitting signal 2017-11-22 18:12:29 +01:00
0073206508 Revert "editor_pt_import: Process wav indexes once only"
This reverts commit 7422ffe692.
2017-11-18 15:28:39 +11:00
18306f3d37 OSC: only reset cue sends that do not have a new send 2017-11-13 17:19:09 -08:00
a6205cef40 OSC: /cue/previous_aux should always refresh 2017-11-13 17:19:09 -08:00
2d85eceb0e OSC: cue buttons can accept float or int 2017-11-13 17:19:09 -08:00
1a5887865c Fix typo (missing quote) in patch-change window title 2017-11-13 23:32:03 +01:00
e6f2d77605 Add API to allow buffer offsets when applying gain 2017-11-12 00:22:34 +01:00
93e32af9f4 Add a noise generator (Lua DSP) 2017-11-12 00:22:34 +01:00
52aa9bf848 a-comp: Fix typo with previous patch 2017-11-12 00:16:44 +11:00
f3efff4c7e a-comp: Fix noise floor - asymptotics 2017-11-11 14:26:50 +11:00
69603bb76e OSC link: make whole link set follow strip_types
strip should not run periodic when blank - crash fix
2017-11-10 08:38:08 -08:00
634c620b07 OSC: set_surface sets linkset, linkid
/set_surface/* deals with linked surfaces
2017-11-08 09:36:32 -08:00
3a2c481b96 OSC: catch bad commands on /cue/* created crash on exit 2017-11-07 20:18:59 -08:00
4c58ada24b Fix a-reverb bypass/enable 2017-11-08 01:38:17 +01:00
ba383b4726 OSC link: Clean up link not ready and surface refresh 2017-11-07 09:31:14 -08:00
bb8d65c528 OSC link: make selection work correctly 2017-11-06 13:38:18 -08:00
77a94e1015 Optimize zresampler for no re-sampling case. 2017-11-06 00:13:14 +01:00
4cdd3f5df6 Some further notes (and experiments) on optimizations 2017-11-06 00:12:32 +01:00
da4cea0526 Add some notes for future optimizations (and prepare API) 2017-11-04 17:11:10 +01:00
8366fbaa62 Change Delayline to use power-of-two size and bitmasking 2017-11-04 16:39:08 +01:00
06abdee652 [Re]-Implement Delayline flush.
Also don't automatically flush the delayline at transport or monitor-
changes anymore.

With full-graph latency compensation, delaylines are before the
disk-reader, aligning input (disk uses read-ahead to align).

Flushing the delayline should only happen when input-monitoring
is disengaged. It's best degated to the Route or object using the
Delayline (potentially latency-aligned delayed flush).
2017-11-04 16:24:09 +01:00
d26ad5573c Optimize Delaylines: block-process (not one sample at a time)
This also tweaks fade behavior when the latency changes to prefer a
x-fade when possible.

This new variant does not support concurrent re-allocation and
execution. Hence the auto-connect thread needs to take a lock before
updating latencies (actually there's no need for an explicit update with
built-in backends, so this case remains to be updated further)
2017-11-04 07:14:12 +01:00
5fdd6ca21e Clean up delayline API: don't use 'get_' for accessor method-name 2017-11-04 07:14:12 +01:00
3eee4fe8a5 OSC link: first working commit for linking two surfaces as one 2017-11-03 14:04:52 -07:00
caedbbf543 Fix scroll-wheel on mixer-sliders
74c986534b changes the semantics of fader-flags:
NoVerticalScroll  was "ignore vertical scroll for horizontal faders".
Now the flag ignores all vertical scrolling.
2017-11-03 15:55:33 +01:00
edff34a59b Auditioner, silence buffer at end. 2017-11-03 04:26:33 +01:00
c63f7f775d Don't crash when auditioning empty .mid files. 2017-11-03 04:14:23 +01:00
0c041dc372 Fix polarity-control size (and crash during audition)
Also initialize new polarity-invert with gain 1.0, not inverted.
Don't fade-in.
2017-11-03 03:06:22 +01:00
f7bca32ab1 Accommodate newly added/removed source(s) in our MSVC project (libardour) 2017-11-02 10:16:24 +00:00
c291cb64b1 Wrap automation on loop-position, split plugin processing 2017-11-01 15:46:23 +01:00
c411e05b6f Click-free polarity inversion, also use accelerated (AVX, SSE) Amp 2017-10-31 22:21:12 +01:00