13
0
Commit Graph

13490 Commits

Author SHA1 Message Date
be7da2e952 Fix opening of recent sessions with mismatched directory & file names
When populating the list of recent sessions, and there's only one session
file in the session folder, don't assume that the base name of the session
file is the same as the name of the session directory.

Allows loading sessions that were created with trailing spaces in their
names from the recent sessions list, and also helps in the case that the
session file (or directory) was renamed.

There are actually two implementations of the 'recent sessions' chooser:
this applies to both. I suppose a useful project one of these days
would be to unify the two...
2014-06-12 23:20:06 +01:00
83ce8dde6b Prevent creation of session directory with leading or trailing space. 2014-06-12 23:20:06 +01:00
60349bcee6 Show Soundcloud credentials and upload options only when required
A slightly hacky patch to make the Soundcloud username & password and the
upload options only become visible when at least one export format is
chosen for upload to Soundcloud.

I think that changing ExportDialog::soundcloud_selector to a
boost::shared_ptr is the right thing to do, but I must confess to having
only a hazy understanding of what boost::scoped_ptr was doing in the first
place.

Also it feels a bit wrong to be passing a pointer to ExportDialog's
SoundcloudExportSelector around, but I can't (for the moment, at least)
think of any better way to affect its visibility from inside
ExportFileNotebook.
2014-06-12 23:20:06 +01:00
5abf3624f4 Use Ardour 3 credentials for soundcloud upload
I registered 'Ardour 3' as an app with Soundcloud - here are the
client_id and client_secret I got back. Probably the client_secret
shouldn't be here - I'll try to understand what should really happen and
fix this up in due course. Probably we should be using OAuth.

Also remove a couple of bits of dead code and fix a few whitespace
oddities.
2014-06-12 23:20:06 +01:00
d5cbb098da Add #include guards to soundcloud_export_selector.h 2014-06-12 23:20:06 +01:00
a82aba8581 Actually pass Soundcloud downloadable flag to export handler 2014-06-12 23:20:06 +01:00
cc2e6aeac3 Remove unused function
Remove the unused ExportFileNotebook::get_nth_format_name()
2014-06-12 23:20:05 +01:00
f0dbd6c085 Export dialog: tidy code, & remove some superfluous debug output
Remove some debug output, tidy up a few whitespace inconsistencies, use
DEBUG::Soundcloud in one more place, and zap a couple of unused variables.
2014-06-12 23:20:05 +01:00
70308f5174 Post-export hook tweaks
Remove the Soundcloud username & password from the parameter substitutions
passed to the post-export hook: having thought about this now, I can't
actually think of a case where these are of any use at all.

In compensation, add %s and %n parameters that expand to the session
directory and name - maybe people will think of uses for these.
2014-06-12 23:20:05 +01:00
724a69a8d5 Search $PATH for command when creating SystemExec from command line
When creating a SystemExec from a command-line, search $PATH for the
command to execute, so that post-export hooks don't need to specify a full
path.
2014-06-12 23:20:05 +01:00
a245250409 use the alpha/opacity value for the region base whether track colors are in use or not 2014-06-12 18:14:55 -04:00
684d45c0cc restored track height adjustment using alt-scroll on track headers 2014-06-12 17:21:41 -04:00
720a9b73a5 fixed rulers stealing all canvas scroll events and corrected computation of correct track for track-height adjustment using alt-scroll 2014-06-12 17:21:23 -04:00
6958409187 remove no-longer-used code 2014-06-12 16:18:38 -04:00
85e2c60673 add back click behaviour for canvas rulers, and also cursor enforcement 2014-06-12 16:06:31 -04:00
ea355bfe15 add canvas rulers event dispatch and reinstate scrolling behaviour 2014-06-12 15:58:05 -04:00
590882f3c8 change Canvas heirarchy and constructors
Items no longer need a parent group (they require a Canvas pointer instead), so all constructors have been rationalized
and have two variants, one with a parent and one with a canvas.

All Items now inherit from Fill and Outline, to banish diagonal inheritance and virtual base classes and all that.

There were zero changes to the Ardour GUI arising from these changes.
2014-06-12 14:53:44 -04:00
551014240a drag handles no longer exist as distinct item types (failed experiment) 2014-06-12 14:51:51 -04:00
23d7893910 remove drag handle canvas object - it was just a stupid unfinished experiment 2014-06-12 10:40:43 -04:00
887e75260d use new ArdourCanvas::Ruler constructor 2014-06-12 10:35:32 -04:00
87a6f633a1 derive ArdourCanvas::Ruler from Rectangle 2014-06-12 10:35:16 -04:00
0762708d83 add new canvas vars for rulers 2014-06-12 10:32:34 -04:00
79c30ab766 make rulers color-sensitive (e.g. theme manager editable, etc) 2014-06-12 01:07:58 -04:00
e1825361b5 remove hard-coded colors 2014-06-12 01:07:58 -04:00
b2ee6b4344 add new default colors for canvas rulers 2014-06-12 01:07:58 -04:00
95fc5ab0a8 removed unused rule GTK widget style definition 2014-06-12 01:07:58 -04:00
3d81944b1d remove unused GTK style 2014-06-12 01:07:58 -04:00
0ab69cb8c7 OS X specific cleanup after canvas ruler introduction 2014-06-12 00:19:42 -04:00
9461fcb271 remove header file includes of now-removed gtk custom ruler 2014-06-12 00:18:58 -04:00
4b07d01532 remove header file includes of now-removed gtk custom ruler 2014-06-12 00:18:15 -04:00
6c9f4e9598 final ruler file removal 2014-06-12 00:01:30 -04:00
43e2baf54e remove gtk ruler widget implementation - no longer in use 2014-06-12 00:01:06 -04:00
b73352880e use canvas rulers now instead of gtk widgets
Some bugs that exist in master are still present.
2014-06-11 23:54:28 -04:00
143f9509ea many fixes and improvements for a now-working ArdourCanvas::Ruler item 2014-06-11 23:54:28 -04:00
f5fc4a6b09 add ruler.cc to canvas wscript 2014-06-11 23:54:28 -04:00
2cab65062d add Ruler to Canvas fwd.h 2014-06-11 23:54:28 -04:00
18190eaa5e clamp zoom level to show 3 days on a 4000 pixel wide screen; comment unused variable for now 2014-06-11 23:54:28 -04:00
5ee4f41925 add initial (untested) implementation of canvas ruler item 2014-06-11 23:54:28 -04:00
e1b82caeb9 delayline: properly hand-over the shared-pointer. 2014-06-12 02:10:37 +02:00
266953cb96 add latency callback to dummy backend 2014-06-11 22:01:21 +02:00
b6362a76a8 fix possible crash when setting delivery name w/o panshell 2014-06-11 20:21:14 +02:00
6003aea385 NOOP, re-indent using tabs 2014-06-11 17:14:31 +02:00
4d0e564fa7 align internal sends using delaylines 2014-06-11 17:14:26 +02:00
ca3c9cae6e basic integration of delaylines (still un-nused) 2014-06-11 17:14:18 +02:00
626b2daa82 add delayline implementaion (in prep for latency compensation) 2014-06-11 16:31:29 +02:00
621e92f268 NOOP, re-indent & whitespace 2014-06-11 16:27:30 +02:00
33db3c854d prepare midi buffer API for midi-delaylines 2014-06-11 16:27:23 +02:00
0400fa64da fix midi buffer erase() 2014-06-11 16:26:27 +02:00
22f45b5a78 Revert "do not allow canvas cursor changes while a drag is in progress". This
was a bad idea. There are lots of reasons to want to change cursors while
dragging, even if we don't do that yet.

This reverts commit 144033e55c.
2014-06-10 18:50:42 -04:00
144033e55c do not allow canvas cursor changes while a drag is in progress 2014-06-10 16:46:09 -04:00