b2d553cc51
editor: fix HitCreateDrag to (a) not crash (b) use the right length (c) snap correctly
2022-06-22 13:31:08 -06:00
d47b581cbb
remove RegionRippleDrag
...
This used to be a distinct kind of drag, but ended up being refactored into
something that happens during a regular drag. Has not been used in quite some time.
2022-06-21 15:52:16 -06:00
265f5d8342
numerous fixes for meter marker drag
2022-05-30 21:14:57 -06:00
fdd634f530
add ctrl-drag on tempo bar/ruler to adjust tempo more directly
2022-05-29 14:19:27 -06:00
69ee83e6ce
require explicit time domain for most region-centric drags
...
This removed one #warning nutempo line.
2022-05-27 15:57:14 -06:00
e0f9f11dfc
automation-range-drag: if lane is empty, use current value for guard points
...
* in the case where there are no existing automation points, then
initiating an automation range drag (select range, switch to Draw)
should initialize the line at the current knob position
2022-05-16 07:16:25 -05:00
6f973af1e1
tempo end drag: make this work with new implementation
2022-05-13 19:05:13 -06:00
66a3513dbd
remove copy option for TempoMarkerDrag
...
This just seems like a dumb UI to implement. Drag-copying tempo markers is not a thing
2022-05-10 09:46:08 -06:00
b5487415ec
editing: a partiaally implemented version of TempoTwistDrag, to be completed.
2022-05-02 16:47:23 -06:00
e02a96ec6b
all Drag objects use an RAII object to block binding activation while they exist
2022-04-18 12:22:56 -06:00
883a44e6a4
temporal: TempoMap::use() returns a const ptr to enforce semantics (GUI version)
...
This commit leaves two issues outstanding:
1. unclear/ugly semantics for drag operations that reset the GUI thread's tempo map to the writable copy
2. undo/redo for the tempo map
These will be addressed in future commits
2022-04-08 11:58:04 -06:00
582661dbd0
as an experiment, prevent redisplay of (MIDI) regions during trimming
...
This doesn't actually work right now because of a conflicting design in MidiRegionView, but
could be promising. Or it might be reverted
2022-04-05 20:52:10 -06:00
luz paz
364f2f0788
Fix typos in gtk2_ardour/ directory
...
Found via `codespell -q 3 -S *.po,./share/patchfiles,./libs -L ba,buss,busses,doubleclick,hsi,ontop,ro,seh,siz,sur,te,trough,ue`
2022-01-26 12:35:38 -05:00
c916d3d952
Substantial overhaul of tempo display code
...
Major changes: do not delete and recreate markers and curves for every tempo map
change, attach tempo curves directly to their (preceding) tempo marker, notable
cleanup of TempoCurve class to remove unnecessary members.
More tweaks expected since algorithm for matching markers and tempo map
points is not correct yet.
2022-01-18 19:47:20 -07:00
1d2fa465d3
remove mistaken handling of cue marker bar events
2022-01-05 13:27:47 -07:00
b1f73d25bf
actual GUI interaction for cue marker ruler
2022-01-04 15:23:51 -07:00
845b5d81a9
add Drag::pixel_to_time() which reflects the Drag's _time_domain setting
2021-12-04 19:38:26 -07:00
fc155e76b4
give every Drag an explicit time domain
2021-12-04 18:44:57 -07:00
7fca55eeb5
Fix placement of drawn MIDI notes.
...
Important logic from 6.9 was either missing or incorrectly implemented. New
version is much simpler - we just use the RoundDownMaybe mode of round_to_bbt()
to ensure that the note start is always within the current grid even if the
mouse is more than halfway "through" it.
2021-11-04 18:27:02 -06:00
b6f290add2
timeline type changes for new ripple code and post-conflict-resolution fixups
2021-08-13 12:51:36 -06:00
31b7244856
fix timeline types (post rebase conflict resolution)
2021-08-13 12:51:36 -06:00
39f52cd3ce
remove unused and unnecessary Drag::snap_delta_music() code
2021-08-13 12:51:34 -06:00
cb66ae496c
don't even pretend to use non-modal dialog API for the BBT marker dialog
2021-08-13 12:51:34 -06:00
d4f52498fa
somewhat working dialog for BBT/Position marker creation
2021-08-13 12:51:34 -06:00
dee71c0a97
mostly fix region- and note-create drags
2021-08-13 12:51:32 -06:00
84d33f3ec3
manual fixups after rebase against master (GUI edition)
2021-08-13 12:51:31 -06:00
f8df966914
clean up MeterMarkerDrag
2021-08-13 12:51:30 -06:00
534c08074d
changes to get program to actually run (missing symbols)
...
Still crashes at startup due to static initialization of initial tempo map.
2021-08-13 12:51:29 -06:00
749a49c278
incorporating new tempo map API
2021-08-13 12:51:29 -06:00
f67029bd02
random commit to facilitate trivial move of work from laptop back to main system
2021-08-13 12:51:29 -06:00
5b2a435e02
getting editor_drag.cc to compile
2021-08-13 12:51:29 -06:00
7433bc27e0
intermediate, unfinished snapshot of ongoing timeline types work on GTK GUI
2021-08-13 12:51:29 -06:00
0a469527f1
updated Temporal::Beats ... GUI edition
2021-08-13 12:51:28 -06:00
23aa663f9d
when doing a ripple-all drag, move relevant markers during the drag too
...
Note that this is purely GUI-level: the ARDOUR::Locations are changed at the end of the drag
in Editor::ripple_marks()
2021-08-13 12:51:28 -06:00
b04ea33f18
move Drag::_earliest_time_limit to be protected, not private
2021-08-13 12:51:27 -06:00
fbd6c7eaee
add earliest_time_limit for Drag class
2021-08-13 12:51:27 -06:00
0c77a35178
completely remove RegionRippleDrag, and merge Editor::add_region(_copy,}_drag() into one method
2021-08-13 12:51:27 -06:00
9d54bb08e7
remove almost all of RegionRippleDrag, collapsing down to just collecting additional RegionViews that need to be moved during the drag
2021-08-13 12:51:27 -06:00
77e67809f9
we removed Splice mode from the GUI 7 years ago; now remove all code related to Splice mode (GUI edition)
2021-08-13 12:51:27 -06:00
eac366ec8e
remove RegionRippleDrag::allow_moves_across_tracks since this was already unconditionally set to false
...
It was also commented "rippling across all tracks is the future", and created notable technical debt
2021-08-13 12:51:27 -06:00
45bd2c47d8
Brush Drag: refactor Brush-drag into its own Drag class (operation is still weird though)
2021-06-17 10:56:30 -05:00
69af0e6964
Abort a copy-drag in the case where it would result in a copy at the same location
...
also code cleanup: clear_draggingview_list() avoids duplicated code
2021-06-17 10:56:30 -05:00
f281e7e3c3
Slip Contents Drag: disambiguate Slip Contents from prior Contents Trim
2021-06-17 10:56:30 -05:00
3d8bccb508
Slip Contents Drag: remove ContentsTrim modifier from the region boundaries
...
*now that you can grab "anywhere" in the region, trim edges are inferior because they are hard to hit
*modifier had to change anyway (since CTRL is used as a copy-drag on both mac and win), so that invalidates prior muscle memory
*potentially frees up modifier on the trim edge for some other purpose (anchored_trim)
2021-06-17 10:56:27 -05:00
fea3fb9e71
Slip Contents Drag: add ContentsDrag
2021-06-17 10:56:22 -05:00
ab2357dfa1
implement dragging for region/cue markers
2021-05-24 12:28:19 -06:00
2016710865
skeleton for RegionMarkerDrag
2021-05-24 09:12:19 -06:00
ce1e05fc3d
Update DnD min. movement threshold -- #8686
...
Previously x-axis threshold was in samples. This is
useless unless zoomed in to the max. So in most cases
the first-move was always in x-direction, making constrained
y-axis drags near impossible.
Furthermore the threshold for copy-drags was increased
as per #8686
2021-05-08 04:28:36 +02:00
b59e687f83
prevent addition mouse button press/release events while an existing drag is still underway from interfering ( fixes #8529 )
2021-01-07 22:55:44 -07:00
Tyler Stank
0cfee47867
Disable vertical autoscroll for UI elements where it doesn't make sense
...
Fixes issue 6396 as well as a few other instances where autoscroll could be annoying
2020-12-02 23:10:13 +01:00