8431d102b9
Do not restore engine state if we don't have control
...
When connecting to already running jack, display jack's buffersize
correctly.
2015-10-06 14:40:51 +02:00
ef0f13cb84
Stop engine when clicking back button in latency measurement tab of EngineControl dialog
...
The engine is started when you switch to latency measurement tab but it isn't
stopped if you just click the back button without measuring for latency.
2015-10-06 13:29:57 +10:00
cd4dd08931
Add EngineControl::stop_engine method to show errors when stopping engine
...
This replaces using ARDOUR_UI::disconnect_from_session which is only used by the
EngineControl class. ARDOUR_UI::disconnect_from_session also disconnects from
the AudioEngine::Halted signal which seems unnecessary as Halted is not emitted
when stopping the engine and calling update_sample_rate() which is already
handled when the AudioEngine::Stopped signal is emitted.
2015-10-06 13:29:57 +10:00
1195aeb64e
Handle all errors when starting backend in EngineDialog
2015-10-06 13:29:57 +10:00
4b9e738636
Align switch statement with case labels to reduce indentation in EngineDialog
2015-10-06 13:29:57 +10:00
dc36b063bf
remove unused fstream includes
2015-10-05 22:15:18 +02:00
22b07e0233
NOOP, remove trailing tabs/whitespace.
2015-10-05 16:17:49 +02:00
520b78b841
Add parent window argument to ARDOUR_UI::check_audioengine
...
Ensures relevant placement of the dialog when presented
2015-10-01 09:10:19 +10:00
73acaf6de6
Display warning when closing Audio Setup dialog with engine stopped
...
Only show warning when a session is loaded
2015-10-01 09:10:19 +10:00
463bd470e8
Don't hide Audio Setup dialog when clicking 'OK' if engine fails to start
...
This has to be handled in two places, in ARDOUR_UI::do_audio_midi_setup and in
the dialogs response handler and in as the window can also be triggered via the
window action manager.
2015-10-01 09:10:19 +10:00
b7fbd4e9c0
fix a small memleak.
...
downcase(char*) requires free(), downcase(std::string) does not.
2015-09-10 17:39:31 +02:00
fc079a0ea3
initialize some uninitialized variables.
...
really just nitpicking (keep valgrind clean).
2015-09-06 21:54:54 +02:00
dbe3500f24
Add utility method for choosing which device/s to display in Audio Setup dialog
2015-09-02 12:07:15 +10:00
25ff056921
Use previously set buffer size in EngineDialog if possible
...
This is also to support refreshing of devices so that the buffer size isn't
reset.
2015-09-02 12:07:15 +10:00
9626e0c413
Add "Refresh Devices" button in Audio Setup dialog for backends that support it
...
This allows the portaudio library to be reinitialized to pick up new devices
and changes to ASIO buffer changes made externally.
2015-09-02 12:07:15 +10:00
88b332412c
Add some debugging output for state restoration in Audio Setup dialog
2015-09-02 12:07:15 +10:00
e6492319b1
Remove Apply button from Audio Setup dialog now that there is a start/stop button
2015-09-02 12:07:15 +10:00
dd275327a4
Change "Stop" button into a Start/Stop button in Audio Setup dialog
2015-09-02 12:07:15 +10:00
c734f82ff2
use program-name for internal ports
2015-08-27 16:50:09 +02:00
59a8fc9e64
Fix state restoration in EngineControl dialog for backends with driver selection
...
We want to save the driver name even when the engine is running and the driver
combo is insensitive
2015-08-13 00:19:01 +10:00
ad9cebe247
hide “Midi Setup” button on OSX and Windows.
2015-08-12 03:16:09 +02:00
687921a760
remove -Woverload-virtual ambiguity (from 1d3690d)
2015-08-11 23:50:56 +02:00
bf1b65029c
update driver selection sensitivity
2015-08-11 22:04:28 +02:00
212a4c1f8d
refine "Running" message.
2015-08-11 19:44:14 +02:00
6cc029f5da
don't allow to change devices while engine is running.
2015-08-11 19:13:10 +02:00
52c25cab36
allow to stop engine for re-configure
2015-08-11 15:38:38 +02:00
6bb51a26eb
consolidate engine-dialog widget sensitivity logic.
...
Use a single function with the complete logic.
Since the callgraph is complex, there is internal state as well as GUI
state (different pages), do not rely on individual methods to get it
right.
A widget's sensitivity should only be controlled by one function.
2015-08-11 15:38:31 +02:00
a3b2b1bcfa
Engine Dialog: use new API
2015-08-11 15:38:19 +02:00
22acbc1cee
Fix to ensure there are always sample rates and buffer sizes in the dropdown
...
This can happen if both input and output devices are set to None for instance
on backends that report no supported SR or buffer size for the None device.
2015-08-11 14:20:43 +10:00
c80e4c04c5
Extract two utility methods from EngineControl::set_samplerate/bufferize_popdown_strings
2015-08-11 14:13:06 +10:00
a8daa36901
Use a union of all sample rates and buffer sizes for all devices in EngineControl
...
Using just the input device doesn't work in the case that the input device is
an invalid/None device
2015-08-11 14:00:57 +10:00
5e5db3c402
Check the default SR is available for a device when setting SR in EngineControl
2015-08-11 09:57:38 +10:00
4651b10345
Remove unnecesary clearing of local variable in EngineControl
2015-08-11 09:46:46 +10:00
ab7cf8c7a7
Fix state restoration in EngineControl dialog for backends with driver selection
...
This also prevents backend_changed from being called more that once in the
EngineControl ctor
2015-08-11 09:24:53 +10:00
c165c991ca
Use the current backend device names to set active text in device dropdowns if available
...
Compare device names with enumerated devices rather than assume an empty string
has special meaning
2015-08-11 09:24:53 +10:00
6451060bd1
Remove Unwinder instances in EngineControl::set_*_device_popdown_strings
...
These are not necessary since SignalBlocker will prevent signal emission
2015-08-11 09:24:53 +10:00
495dd2e52a
Compare the string returned by backend->driver_name() against driver names in EngineControl
...
Don't assume an empty string has any meaning and compare string returned with
enumerated drivers
2015-08-11 09:24:52 +10:00
e20d74079a
Remove Unwinder instance from EngineControl::set_driver_popdown_strings
...
Not necessary now that signal emission is blocked via backend_changed()
2015-08-11 09:24:52 +10:00
dfa9a2326a
Reimplement method using code extracted from EngineDialog::backend_changed
...
EngineControl::set_driver_popdown_strings is now like the other
set_*_popdown_strings methods in that it sets the driver strings and a
default active entry and returns false if no drivers are available.
2015-08-11 09:24:52 +10:00
1bea87e10a
Remove previous fix attempt at restoring state for backends with driver selection
...
The fix does not work properly anymore for the Portaudio backend and needs
fixing in another manner. It will now be temporarily back to the broken state
it was in before the "fix".
2015-08-11 09:24:52 +10:00
eaf5ed2b18
Use SignalBlocker class in EngineControl to block widget signal emission
...
This stops a whole lot of redundant signal emission and makes it much easier to
think about what is going on. It also makes the dialog present much faster.
2015-08-11 09:24:52 +10:00
001c1a0910
Extract part of EngineControl::backend_changed into EngineControl::update_midi_options
2015-08-11 09:24:52 +10:00
6e0d062773
Move call to EngineControl::device_changed into EngineControl::list_devices ()
...
This prevents devices_changed from being called twice with backends that have
separate input and output devices
2015-08-11 09:24:52 +10:00
c8f8f75831
Add debug output to blocking/unblocking signals in EngineControl dialog
2015-08-11 09:24:52 +10:00
1bd15bef6c
Add methods in EngineControl for blocking and unblocking signals
...
Only intended to be used with the nested SignalBlocker class
2015-08-11 09:24:52 +10:00
324b5ffbac
Refactor part of EngineDialog ctor into connect_changed_signals method
2015-08-11 09:24:52 +10:00
ecd9950413
Add some basic debug output in EngineControl dialog
...
This should make it easier to see what affect subsequent commits have on
reducing the amount of unnecessary device querying and signal emission
2015-08-11 09:24:52 +10:00
f428cb4bf1
Refactor part of EngineControl::set_state into new set_current_state method
2015-08-11 09:24:52 +10:00
a9c149216d
Remove unused method in EngineControl dialog
2015-08-11 09:24:52 +10:00
caae165cd3
Defer to device_changed when input or output devices change
...
This reduces the amount of unnecessary querying of samplerate and buffersize
for devices
2015-08-11 09:24:51 +10:00
