bf5864aaca
Use PBD::to_string() from pbd/string_convert.h in JACK utils
...
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to
remain locale independent and not have to use a LocaleGuard.
2017-04-19 09:37:00 +10:00
ca7bbea6d8
Use PBD::string_to/to_string when de/serializing in AutomationList class
...
This avoids requiring a LocaleGuard to get the correct numeric formatting and
saves/restores the automation data to the precision required for roundtrip
equality.
2017-04-19 09:37:00 +10:00
c65f30b4b1
Remove unused header include in ARDOUR::Amp source file
2017-04-19 09:36:59 +10:00
18011482bb
Use PBD::string_to/to_string in IO::find_possible_bundle
...
Possible issue with numeric formatting using std::streams in locales with
grouping. Although I don't think it would be an issue in this case use locale
independant alternative for numeric formatting anyway.
2017-04-19 09:36:59 +10:00
e15524cc64
Use PBD::to_string instead of std::ostream when setting up video server url
...
To avoid issues with locales that use grouping/thousands separators.
2017-04-19 09:36:59 +10:00
ab30f45bba
Use PBD::to_string to convert period count in EngineControl class
...
The functionality is the same so might as well use it.
2017-04-19 09:36:59 +10:00
0739bada9e
Use PBD::to_string to convert bufsize to string in EngineControl class
...
string_compose uses std::ostream/stringstream which will insert thousands
separators in some locales. This was not a problem when LocaleGuard set the
global C++ locale to "C"
2017-04-19 09:36:59 +10:00
df2b0e33b9
Use PBD::string_to functions in VideoUtils::video_query_info
...
LocaleGuard is in use so float <=> string conversions must be expected in C
locale format
2017-04-19 09:36:59 +10:00
e7a23eaaa8
Use snprintf instead of std::stringstream when converting color values to strings
...
std::ostream/stringstream will use the current locale to determine the numeric
formatting. If the locale uses grouping then thousands separators will be
inserted in the output which produces an invalid color string in
UIConfiguration::reset_gtk_theme() and when converting colors to strings in
UIConfiguration::store_color_theme()
This has not been a problem so far because it appears that LocaleGuard does not
reset the LC_NUMERIC value for the global C++ locale. So if a LocaleGuard is
created at any time before these functions are called(even if it goes out of
scope) the numeric formatting used by std::streams will use the "C" locale
formatting facets.
2017-04-19 09:36:59 +10:00
0656d5ab1a
Use XMLNode::get/set_property API in Faderport surface
2017-04-19 09:36:59 +10:00
ac8b5192cd
Remove now unused PBD::string_is_affirmative function
...
The equivalent function is now PBD::string_to<bool>
2017-04-19 09:36:59 +10:00
71fc5b9e8b
Use PBD::string_to<bool> in MidiTimeAxisView class
...
As the conversion was performed with PBD::to_string
2017-04-19 09:36:59 +10:00
b540817b5b
Use PBD::string_to<bool> in RouteTimeAxisView class
...
As they were converted from bool to string using PBD::to_string
2017-04-19 09:36:59 +10:00
edb9868e76
Remove conditional checks that are always true in RouteTimeAxisView class
2017-04-19 09:36:59 +10:00
23eb1fbf01
Use PBD::string_to<bool>() in GenericMidiControlProtocol class
...
Equivalent to PBD::string_is_affirmative()
2017-04-19 09:36:59 +10:00
04a027a031
Use PBD::string_to<bool> in legacy ARDOUR::Route methods
2017-04-19 09:36:58 +10:00
9ce1d7c357
Use PBD::string_to<bool> in ARDOUR::Processor class
2017-04-19 09:36:58 +10:00
603d944530
Use PBD::string_to<bool> in AudioPlaylist class
2017-04-19 09:36:58 +10:00
8e07e4bd68
Use AxisView::get/set_gui_property API in RouteTimeAxisView class
2017-04-19 09:36:58 +10:00
634207dd6a
Use AxisView::get/set_gui_property API in MixerStrip class
2017-04-19 09:36:58 +10:00
13d2670e96
Use AxisView::get_gui_property API in AutomationTimeAxis class
2017-04-19 09:36:58 +10:00
de80767c8c
Use AxisView::get_gui_property in AudioRegionView class
2017-04-19 09:36:58 +10:00
2c4e801183
Use AxisView::get_gui_property API in TimeAxisView class
2017-04-19 09:36:58 +10:00
be59503364
Use AxisView::get_gui_property API in AxisView class
2017-04-19 09:36:58 +10:00
9d2d0ddf00
Add AxisView::get_gui_property method, use PBD::string_to<T> for string conversion
2017-04-19 09:36:58 +10:00
66004a5036
Use PBD::to_string to convert non-string types in AxisView::set_gui_property
2017-04-19 09:36:58 +10:00
7fdbabcd79
Let AxisView::set_gui_property perform type conversion in TimeAxisView::set_height
2017-04-19 09:36:57 +10:00
6e467153a0
Remove unused XMLNode::add_property methods
...
These are now unused and functionality is replaced by XMLNode::set_property
set_property is a better name as a node can only have properties with unique
names and the property will be set or reset(if it already exists). Changing the
name also makes it easier to transition and test the new API.
2017-04-19 09:36:57 +10:00
e4b1ece143
Use XMLNode::set_property API in xml tests
2017-04-19 09:36:57 +10:00
0c75813129
Use XMLNode::set_property API in copy-mixer Session utility
2017-04-19 09:36:57 +10:00
a6d71df0d0
Use XMLNode::get_property in AudioClock class
2017-04-19 09:36:57 +10:00
1534a2a4d1
Use XMLNode::get/set_property API in VideoTimeLine class
2017-04-19 09:36:57 +10:00
47f1183a15
Use XMLNode::set_property API in VideoMonitor class
2017-04-19 09:36:57 +10:00
b00b83f95a
Use XMLNode::set_property API in UIConfiguration class
2017-04-19 09:36:57 +10:00
3ba34e13b1
Use XMLNode::get/set_property API in SelectionMemento class
2017-04-19 09:36:57 +10:00
8219e3c6ee
Use XMLNode::get/set_property API in Selection class
...
There were many possible value truncations occuring and some precision loss
with the double conversions.
2017-04-19 09:36:57 +10:00
5b97b1a191
Use XMLNode::get/set_property API in ProcessorBox and ProcessorWindowProxy classes
2017-04-19 09:36:56 +10:00
657e32290e
Use XMLNode::get/set_property API in ProcessorBox class
2017-04-19 09:36:56 +10:00
5cd88fa050
Use XMLNode::get/set_property API in MeterBridge class
2017-04-19 09:36:56 +10:00
4bf8f9f1a8
Use XMLNode::set_property API in LuaInstance class
...
Didn't seem worth converting from XMLNode::property API to
XMLNode::get_property and there may be some ordering issues.
2017-04-19 09:36:56 +10:00
a2c1e79660
Use XMLNode::get/set_property API in LocationUI class
2017-04-19 09:36:56 +10:00
7cb78301eb
Use XMLNode::get/set_property API in Keyboard class
2017-04-19 09:36:56 +10:00
5b71470449
Use XMLNode::get_property API in AutomationTimeAxis class
2017-04-19 09:36:56 +10:00
8d90723e8c
Use XMLNode::set_property API in GUIObject class
2017-04-19 09:36:56 +10:00
0bfdab738b
Use XMLNode::get/set_property in ExportVideoDialog class
2017-04-19 09:36:56 +10:00
a8420d4b6b
Use XMLNode::get/set_property API in EditorRulers class
2017-04-19 09:36:56 +10:00
df33a6e53a
Use XMLNode::get/set_property API in EditorRegions class
2017-04-19 09:36:56 +10:00
346123e619
Use XMLNode::set_property API in ARDOUR_UI class
2017-04-19 09:36:55 +10:00
41493d556a
Use XMLNode::get/set_property API in ARDOUR_UI class
2017-04-19 09:36:55 +10:00
dcc21b19a9
Add AudioClock::on() method as convenience method for serialization
2017-04-19 09:36:55 +10:00
