13
0
Commit Graph

36025 Commits

Author SHA1 Message Date
8ba21e7fff
Fix region-gain when trimming, cutting or partitioning regions
The during trim-front, the call order is
 1. Region::set_position_internal
 2. Region::set_length_internal

::set_position_internal sets `_last_length.set_position (position());`
but the later call ::set_length_internal does `_last_length = _length;`
This sets last_position() == position(), and later Region::mid_thaw()
does not call Region::recompute_at_start().

Region gain envelope was not updated.

see also 00a1b7cb24 and 13d10582f0
2022-09-26 14:57:25 +02:00
d39f064756 library dialog: catch exception and behave appropriately 2022-09-26 01:10:20 -06:00
f2eddd404b downloader: create destdir if it does not already exist, throw exception if this fails 2022-09-26 01:10:20 -06:00
3b274bd433 rename loop download dialog (breaks string freeze) 2022-09-26 01:10:20 -06:00
12ffd962b3
Update SMF profile tool to show number of temmp changes 2022-09-25 03:30:15 +02:00
97b3aef0fa
Significantly speed up display of MIDI file information (again)
This regressed with changes to SMFSource to unconditionally load
the model. "Black MIDI Trilogy 2" now shows again in under 4 sec.
Before this change it took roughly 3 mins (!) and the UI was marked
as unresponsive.
2022-09-25 03:29:42 +02:00
5d9fc950c5
Update SMF-load test tool 2022-09-25 02:48:00 +02:00
bfe655775a
Set SMF::open option, do not scan since information is not needed 2022-09-25 02:47:14 +02:00
e09913ced7
Set SMF::open option, do not scan when loading the model 2022-09-25 02:46:59 +02:00
0457646387
Allow to scan midi file during file read
This partially reverts eced764480. In many places Ardour uses
SMF directly, without loading the MIDI model in a libardour SMFSource.

In this case no information (track, channel-count) was available,
after eced764480, and worse various members were not initialized
and showed random numbers.

This fixes various import options.
2022-09-25 02:46:09 +02:00
7428f13e15 MIDI: unlinked region copies get sources that are copies of the original
Previously, the copied source file only contained data within the initial region bounds. This
meant that you could not trim the (unlinked) copy to beyond its initial bounds. Seems wrong.
2022-09-24 15:38:45 -06:00
4f83eea46c Revert "step entry: do not pass auto_partition=true to Playlist::add_region()"
This was an error of understanding.

This reverts commit e9f98fe230.
2022-09-24 15:21:05 -06:00
e9f98fe230 step entry: do not pass auto_partition=true to Playlist::add_region()
This code path is only followed if there is no region at the start of step entry, so auto-partition
makes no sense anyway
2022-09-24 14:53:06 -06:00
fba4a5ff73 fix region drag across tracks that auto-partitioned the receiving playlist
Confusion caused during nutempo development when a boolean related to nick_m's old
"for music" concept ended up becoming the "auto_partition" argument instead
2022-09-24 14:27:20 -06:00
7e5fe695d0 Increase coreMIDI robustness, do not drop late events
see also https://discourse.ardour.org/t/ardour-not-getting-all-messages-from-midi-keyboard/107618/13
2022-09-24 02:29:50 +02:00
451fb3e761 fix crash when dragging BBT marker (must use audio time) 2022-09-23 15:51:17 -06:00
47e9bb05c8 midi editing: if nudge clock says zero, use grid for nudging notes 2022-09-23 11:30:17 -06:00
c4b63221d1
Allow to delete preset from context menu 2022-09-23 05:40:05 +02:00
2e0bfae628 midi note drawing: use RoundNearest not RoundDownMaybe for note ends 2022-09-22 16:21:07 -06:00
04d367fdfe midi note drawing: fix snap used to place ghost note 2022-09-22 16:16:20 -06:00
91df1d8e94 NO-OP: fix switch statement indentation 2022-09-22 16:10:34 -06:00
0cd87a917c push2: apply concept in 0af0e3a8e8 to push2 code (unused follow action icon) 2022-09-22 09:20:01 -06:00
0af0e3a8e8 remove unused code: an unused follow-action icon 2022-09-22 08:10:29 -05:00
af28394bfd push2: fix an apparent bug in cairo when drawing follow action icons
It seems that using ::move_to() followed by Pango::Layout::show_in_cairo_context() leaves
the context in a state that is not correctly restored when using ::restore(). Therefore,
clear the path to avoid leaving any dangling current point
2022-09-22 00:43:38 -06:00
7cad01ae1e clip list: add a Refresh button to the file list
It is tempting to update the list automatically when the dire contents change,
 but this can lead to the list changing while the user is clicking to audition
 or drag.

Instead, we should sensitize the button only when the dir contents have changed.
2022-09-21 20:47:23 -05:00
luz paz
7f06beda50 Fix typos
Found via `codespell -q 3 -S *.po,./.git,./share/patchfiles,./libs,./msvc_extra_headers,./share/web_surfaces,*.patch  -L acount,ba,buss,busses,discreet,doubleclick,hsi,ontop,retrn,ro,scrollin,seh,siz,sord,sur,te,trough,ue`
2022-09-21 19:09:55 -06:00
dbolton
078544482f Add Korg Kross 2 midnam 2022-09-21 19:05:19 -06:00
9b65be0e17
Add debug information for coreMIDI events 2022-09-22 00:42:56 +02:00
56c5db9115
Fix indent of previous commit 2022-09-21 22:38:22 +02:00
b3c95e8946
Allow to create presets from processor context-menu 2022-09-21 22:19:32 +02:00
135a54effd
Cleanup processor-box sensitivity, mixbus backport 2022-09-21 21:17:21 +02:00
7d75ac0f14
Add Lua binding to remove plugin-preset 2022-09-21 18:21:27 +02:00
9c64771636 remove some debug output 2022-09-21 10:17:13 -06:00
0b0f49412d remove some debug output 2022-09-21 09:13:26 -06:00
2316df357b remove some debug output 2022-09-21 09:13:17 -06:00
8db55bdda9 remove clip editor bindings (for now), since we do not show the clip editor 2022-09-21 08:51:36 -06:00
86f0f0ca11
Fix VST2 state restore for plugins without custom UI
VST preset restore has to happen in the GUI thread, specifically
the plugin's own UI event-loop (which on Linux and Windows is
not usually Ardour's Thread 1). However if there is no plugin
GUI, it should be safe to use Ardour's UI thread.
2022-09-21 16:13:18 +02:00
3ad819da4c
Add Lua binding to create/save plugin presets 2022-09-21 14:48:04 +02:00
3ca0f4e43d
Prepare API to resample session to engine when SR mismatches 2022-09-21 00:34:03 +02:00
f76e63fd89
Update size-request when font/style is set 2022-09-20 03:33:15 +02:00
5ef2d04cd8
Remove unused size_request-for_text helpers 2022-09-20 03:33:12 +02:00
1b7b3543e8
Remove thin abstraction, directly call get_pixel_size 2022-09-20 03:33:08 +02:00
2a42743270
Fix ArdourDropdown sizes 2022-09-20 03:33:01 +02:00
8508b3dba4
Allow multiple sizing texts for ArdourButton/Dropdown
A widget's style (font) is only set after the widget has been
packed and inherits relevant information from the top-level window.

`set_size_request_to_display_given_text()` produces incorrect
results when it is called for widgets without a top-level
(here ARDOUR_UI::setup_windows() _main_window.add(), changes the
font from "Sans 11" to "Sans 9" for ArdourDropdowns).

`set_size_request_to_display_given_text()` must subscribe to
`signal_style_changed()`, however in case of ArdourButton UI-scaling
of elements also needs to be taken into account. It is preferable
to allow for multiple sizing-texts directly.
2022-09-20 02:35:26 +02:00
d1bf8428fc
Allow vertical scroll to change gain on the cue-page
This is consistent with inline controls (which also allows
vertical scrolling to change the gain).
2022-09-20 00:44:42 +02:00
a3806e2946
Implement Draw-tool opaqueness option 2022-09-19 23:40:58 +02:00
6f9f7fb831
Fix typo, shorten dropdown strings 2022-09-19 23:24:42 +02:00
99b2fb2859
Remove cruft 2022-09-19 22:50:53 +02:00
a61072060e
Remove now unused "layered button" color defintion 2022-09-19 22:50:50 +02:00
45cd07aa5a
Remove old layered-record-mode config 2022-09-19 22:50:47 +02:00