6e3d3706dc
MIDI region combine: fix conceptual errors (GUI edition)
2022-10-31 14:22:17 -06:00
d93c8d64bc
MIDI region combine: fix conceptual errors
2022-10-31 14:22:17 -06:00
f4a57f83e6
evoral: Sequence::clear() needs to remove patch changes and sysexes too
2022-10-31 14:22:17 -06:00
fded5063d9
Yet another automation time-domain fix
...
This issue was fixed in 6a55146fd489c9ace9
2022-10-31 16:23:20 +01:00
cooltehno
17457fcc02
Update blueberry_milk-ardour.colors
2022-10-30 23:44:11 -06:00
9c2c08973d
tempo map: fix incorrect computation of ::bbt_at() ( #9049 )
...
This caused problems with TempoMap::get_grid() ("gone backwards").
2022-10-30 19:35:58 -06:00
bdacfb8724
Fix invalid use of Doxygen "@param" command
...
This is never for inline references to parameters, only for starting parameter
documentation blocks. The "@p" command is for this, although unfortunately
Doxygen doesn't actually do anything with it and it's just an alias for code
text.
2022-10-30 20:44:28 -04:00
96bab3ce46
NO-OP: doxygenize timepos_t::distance
2022-10-31 00:22:21 +01:00
21e8885e00
region duplication: fix positioning of multi-region duplicates
2022-10-30 17:07:22 -06:00
77f28aa6f9
Fix time calculation in edit-note dialog #9045
2022-10-30 16:02:44 +01:00
1eaaf4303b
jack backend: catch some possible errors in ::get_port_name()
2022-10-29 09:37:17 -06:00
e06bd481a1
fix color of MIDI notes during capture so that they are visible
2022-10-28 16:41:15 -06:00
492073e47d
fix display of MIDI notes during recording
...
Note that the notes are almost invisible due to coloring
2022-10-28 16:39:38 -06:00
6449bf5464
source: provide a little syntactic sugar via ::time_since_capture_start()
2022-10-28 16:38:46 -06:00
31f78813e3
fix another mis-use of timepos_t::increment()
2022-10-28 14:34:59 -06:00
c58d052a8e
fix position of duplicated regions
...
Several thinkos here but the most important one is that timepos_t::increment() returns
a value, rather than modifying the object
2022-10-28 14:34:34 -06:00
a3795031da
patch changes: fix/supply missing code to position patch changes on session load
...
For one reason or another, the required computation from 6.9 had been
replaced with "x = 0".
2022-10-28 14:06:45 -06:00
cmhmpsn
f334db581a
Update about.cc
...
Removing my own name from credits as I no longer wish to be associated in any way with the project.
2022-10-28 16:39:39 +02:00
ElizabethHarmon
ddeb6ef621
Move position of "Only Analyze" Button
2022-10-28 16:39:21 +02:00
1139b38db5
Update comment (amend bd339713)
2022-10-28 13:20:04 +02:00
0fe297374d
Remove superfluous call (amend bd339713)
...
Graph::prep is a private function called initially from the main
process-callback before doing any work, and later at the end of
each process cycle. This sets up the process graph-chain and
process trigger queue.
Tempo information is irrelevant here.
2022-10-28 13:14:13 +02:00
efdc47bc74
fix MidiRegion::merge() to allow final events of a region to be part of the newly merged result
2022-10-27 17:35:56 -06:00
bd33971346
triggers/graph: fix location of calls to TempoMap::fetch()
...
This ensures that RT graph threads have the correct tempo map,
and thus run triggers correctly when timestretch is required.
2022-10-27 16:33:46 -06:00
b195a04281
fix loading 6.x sessions with initial meter not at sample zero
2022-10-27 15:02:12 -06:00
b1118910c7
time signature not meter mark
2022-10-27 13:51:38 -06:00
97a544390d
use TempoMapChange to manage all feasible tempo map editing operations
2022-10-27 13:43:13 -06:00
21a05f539b
tweak PublicEditor API to include virtuals for tempo map edits
2022-10-27 13:42:58 -06:00
09c9ab5c75
extend TempoMapChange API to allow for replacing, not editing, the map
2022-10-27 13:40:29 -06:00
5d5c1ee9fc
use TempoMapChange for editor tempo marker edits
2022-10-27 12:12:52 -06:00
9c5d396334
use TempoMapChange for define_one_bar
2022-10-27 12:12:28 -06:00
0e20c4b3eb
new RAII object for tempo map editing
2022-10-27 12:06:23 -06:00
33770d0777
remove stacktrace() from TempoMap::dump()
2022-10-27 11:58:39 -06:00
2cf59a988c
Handle tempo-map changes in sync from the calling thread
...
This is required to collect relevent undo/redo information, notably
automation-data changes from Playlist::update_after_tempo_map_change and
DiskReader::playlist_ranges_moved.
The realtime thread should not move regions to begin with, and debug
builds woudl also assert since no undo operation was started.
2022-10-27 08:40:09 -06:00
39b85bd2d4
Commit TempoChange undo operation after map update
...
Tempo Map updates can change a region's position/length, in which case
region-automation may follow the region, and DiskReader:: playlist_ranges_moved
will save additional undo information.
These MementoCommand(s) need to be included in the undo operation.
2022-10-27 08:40:09 -06:00
fa71c87358
remove debug output from automation line reset callback
2022-10-27 08:31:57 -06:00
a3d3fb9c14
fix placement (snap) of percussive-mode drawn notes ( #9041 )
2022-10-27 08:31:44 -06:00
04131077b3
NOOP: remove newline
2022-10-26 22:26:29 -06:00
15b92334dc
remove dangerous and unused RegionView::source_relative_distance() method
2022-10-26 22:25:51 -06:00
a6b63b1cca
automation region paste: snap at paste, not at cut
...
This fixes various issues with this operation, mostly because it was really the
wrong concept to begin with.
2022-10-26 22:23:14 -06:00
fa858a0386
Fix pan automation
...
The time-domains need to match in order to use the
raw underlying .val() as double for interpolation.
2022-10-27 04:28:07 +02:00
5dd60c03df
automation lines: fix missing line segments
2022-10-26 16:57:06 -06:00
389577b1e9
automation line: use return value from (new API) model-to-view method
2022-10-26 16:56:22 -06:00
44f169bc56
automation line drag: fix crash during segment drags
...
a drag on a segment without adjacent points would crash because we never
set the _grab_button for the Drag, so the LineDrag object never gets deleted
on mouse-up. This leaves a dangling reversible command, which will then
cause an assert(false) crash in the next Editor::begin_reversible_command()
2022-10-26 16:55:27 -06:00
83ad0a10b5
automation line: drop ::redisplay() method
2022-10-26 14:01:59 -06:00
d41e66f169
changes to the way automation lines are drawn to show edge-lines
...
this adds points to the lines so that they always extend to the edge of
regions (not control points).
more work to come to unify ::redisplay() and ::reset_callback()
2022-10-26 14:01:59 -06:00
f32d36f63e
fix initialization order warning
2022-10-26 14:01:59 -06:00
489c9ace9f
Fix looping automation - see also 6a55146f
2022-10-26 21:03:08 +02:00
bc5d21b235
Xcolors theme update from LAM
2022-10-26 10:30:12 -06:00
753fb30734
NOOP: remove doubled-comment text
2022-10-25 18:34:12 -06:00
29daf3ca4b
fix initialization of insert/delete clocks (amend 3447869f21)
...
Also, remove debug output
2022-10-25 18:26:55 -06:00
