13
0
Commit Graph

17770 Commits

Author SHA1 Message Date
555ef50521 no c99 2015-09-19 01:22:14 +02:00
7648824773 speed-up smf_track_delete() from O(N^2) to O(n) 2015-09-19 00:38:32 +02:00
2ef2ea0b59 create new Event-IDs for pasted midi-notes 2015-09-18 20:37:23 +02:00
a5141fdaf3 NOOP - SMF debugging. 2015-09-18 17:37:36 +02:00
21b720fddc Midi CC events have no event-ID
Prior to this change the last iterator's ID was used. (event's ID was
not updated for CCs)
2015-09-18 17:37:03 +02:00
8b2fb88f15 fix ever increasing MIDI event IDs
Iterating over a const Midi-Sequence calls Evoral::Sequence::set_event(),
which in turn used Evoral::Event::operator=()  which always created
a new event-ID (create copy of the event).

Issues fixed:
 - Saving *unmodified* MIDI produced new event-IDs on every save;
   files changed with every save. - greetings to Deva.
 - all [GUI] operations that use IDs to refer to notes e.g. undo.
   invalid undo-history.

Also clarify assignment operator name. Prefer explicit assign() over =.
2015-09-18 17:36:15 +02:00
c12e8cc47c Modify Strip Silence so that it can't create regions with -ve lengths
AFAICT this could happen if a region's end time (on the timeline) was earlier than the end time in the actual recording. This could cause a situation where the last block of detected silence would have an end time greater than the end tome for the region being processed. Strip Silence would create its new regions - but the last one it created would usually come out with a negative duration.
2015-09-18 10:44:07 +01:00
b548b6213d MSVC - add support for newly introduced gtk2_ardour/tooltips.cc and tooltips.h 2015-09-18 10:29:31 +01:00
d609217c55 Make sure that those recently moved functions will be visible if they're needed outside of libpbd 2015-09-18 10:27:27 +01:00
44ea59495c MSVC projects - accommodate some modules that recently got moved or removed
(mostly these got moved out of the PortAudio backend and into libpbd)
2015-09-18 10:25:11 +01:00
b753704c3e Revert "work around bug or feature of string_compose()"
This reverts commit 17baf93626.
It's no longer needed since c1d6a2f
2015-09-18 00:04:42 +02:00
c1d6a2fd92 add string_compose argument specializations so that empty std::string and empty C strings are handled as intended 2015-09-17 17:16:23 -04:00
f3a1ac21cb associate label more closely with VST path button. the plugin tab needs a complete layout rethink, someday 2015-09-17 16:07:40 -05:00
ff80d66088 speficy gtk treeview style for consistency 2015-09-17 21:09:13 +02:00
17baf93626 work around bug or feature of string_compose()
string_compose("x%1x x%2x x%3x", "A", "", "C") 
-> "xAx xCx xx"
and not
-> "xAx xx xCx"
2015-09-17 20:51:11 +02:00
e44212321e Add test to libpbd to check PBD::touch_file and pbd/gstdio_compat.h
GStatBuf is not usable on 32 bit Windows without the redefinition in
pbd/gstdio_compat.h so add a test to check for the correct behavior of
g_stat and g_utime on all platforms now that the issue is fixed.
2015-09-17 23:26:38 +10:00
95b55c7346 fix g_lstat() 2015-09-17 15:01:26 +02:00
f27800ea41 use pbd's gstdio compatibility wrapper (GUI) 2015-09-17 14:38:09 +02:00
7ac691ec82 use pbd's gstdio compatibility wrapper 2015-09-17 14:37:57 +02:00
c90bab4d4e add glib/stdio compat wrapper for mingw64-w32 2015-09-17 14:36:47 +02:00
5d38d1c751 explicit glibmm/datetime include
On some distros. glibmm.h does not include glibmm/datetime.h
2015-09-17 13:37:52 +02:00
6829d1593f Use PBD::open_uri in about dialog to open website, should fix #6463 2015-09-17 11:55:22 +10:00
23a384f8ae fix #6588. use ardour-codename only for Ardour. 2015-09-17 00:40:58 +02:00
96cc1dbe80 Revert "add an Amp to Delivery, remove it from Send, make use of this in various ::run() methods"
This reverts commit 601a34521c.
2015-09-16 18:38:44 -04:00
202b9cc82a fix a tautologically undefined comparison 2015-09-17 00:21:38 +02:00
4a10dbbc1b deleting pointers to incomplete types may cause undefined behavior 2015-09-17 00:13:43 +02:00
5d02c47d3a fix clang compilation.
pbd/configuration_variable.h:84:6: error: call to function 'operator>>' that is neither visible in the template definition nor found by argument-dependent lookup

ardour/types.h defines  std::istream& operator>> and must be included prior to pbd/configuration_variable.h
2015-09-17 00:10:50 +02:00
31c0a536ba fix missed but required merge resolution related to UIConfiguration's new status as a singleton in this branch. 2015-09-16 17:11:54 -04:00
69b44ee829 Use tooltips.h in ArdourButton to remove ardour_ui.h inclusion 2015-09-16 16:55:17 -04:00
1d42ed077e Use ARDOUR_UI_UTILS::set_tooltip rather than via ARDOUR_UI::set_tip
This removes the direct dependence on ARDOUR_UI/Gtk_UI for setting
tooltips. Removes inclusion of ardour_ui.h from 16 files.
2015-09-16 16:55:17 -04:00
2031007a3a Add tooltips.h header for setting tooltips rather than via ardour_ui.h 2015-09-16 16:55:17 -04:00
29f43af53a Add missing header include in midi_channel_selector.h 2015-09-16 16:55:17 -04:00
f9cba95a8f Add missing header include in shuttle_control.h 2015-09-16 16:55:17 -04:00
b8546e0b69 Add missing header include in plugin_selector.h 2015-09-16 16:55:17 -04:00
38bae2996a Remove ardour_ui.h header inclusion 2015-09-16 16:55:17 -04:00
c256075e63 Remove tooltips() member from ARDOUR_UI and use Gtk_UI::set_tip 2015-09-16 16:55:17 -04:00
b8e9ee50e0 Use Forward declaration for non-MSVC compilers in ardour_ui.h
I can't test this with MSVC so John might have to fix this, just
adding the necessary header includes inside MSVC specific ifdef
but I think it should be OK
2015-09-16 16:55:17 -04:00
513ecad1f0 Forward declare Meterbridge class in ardour_ui.h 2015-09-16 16:55:17 -04:00
553c3ef557 Remove ui_config.h inclusion from ardour_ui.h 2015-09-16 16:55:17 -04:00
6b019a4953 Move UIConfiguration Singleton into UIConfiguration header
This removes the direct dependence on ardour_ui.h from 39 files
2015-09-16 16:55:17 -04:00
45d487f16e Move ARDOUR_UI::ui_scale into UIConfiguration class 2015-09-16 16:55:17 -04:00
74db5abc7e Add ardour/types.h to ardour/parameter_descriptor.h for AutomationType 2015-09-16 16:55:17 -04:00
c99bf353a5 Remove inclusion of ardour_ui.h from ui_config.cc 2015-09-16 16:55:17 -04:00
fc1e7dbb55 Move DPIReset and ColorsChanged signals into UIConfiguration 2015-09-16 16:55:17 -04:00
0fd1aa3808 Remove unused header include 2015-09-16 16:55:17 -04:00
2d47183dc9 Move util functions into UIConfiguration as they depend on it anyway 2015-09-16 16:55:17 -04:00
2e8af0c917 Remove duplicate extern declaration
DPIReset signal is declared in global_signals.h
2015-09-16 16:55:17 -04:00
482b71d35e add datetime to snapshot sidebar
Currently only information, not sortable.
2015-09-16 22:17:34 +02:00
18afd09b3b unify recent session dialogs 2015-09-16 21:37:56 +02:00
f2f7a21aea fix d6029f9 (recent sort-order)
add one, because (-0 == +0)
2015-09-16 19:30:41 +02:00