13
0
Commit Graph

36131 Commits

Author SHA1 Message Date
45e21de209 implement and adopt new conventions for AudioClock use
The class now has two separate methods for setting a duration or a point
value. They MUST be used appropriately, because their behavior is different.

When ::set_duration() is used in timecode mode, an extent (inclusive-end
length) is shown rather than a length.

Some objects, such as the TimeInfoBox, now deliberately shown an inclusive end
for their "end" clock, but this not universally followed, pending more feedback
from users and investigating of conventions in other DAWs.
2022-10-07 16:24:56 -06:00
1ce17c1903 fix time domain for new BBT markers created from context menu/dialog 2022-10-07 16:24:56 -06:00
be9fdd9873 libs: use {de,in}crement_by_domain() instead of {de,in} (libs) 2022-10-07 16:24:46 -06:00
27d5843f7a temporal: replace Range::extent() with Range::length()
We want to encourage/enforce the use of exclusive-end conventions
everywhere in the libraries that make up ardour
2022-10-07 16:16:14 -06:00
c4d737dd87 temporal: provide ::decrement_by_domain() methods for time{pos,cnt}_t
audio time nominally uses superclocks as its canonical unit. However
many things at a higher level only understand samples. If we
increment or decrement a superclock value by 1, the vast majority of
the time we will still get the same sample value after
conversion. Thus to correctly alter an audio time by an amount
that will manifest as 1 sample's difference, we have to use
samples_to_superclock(1)
2022-10-07 16:16:14 -06:00
617a517a60 temporal: add timecnt_t::increment() and Range::extent() (length+1) 2022-10-07 16:16:14 -06:00
b4d7ca06b8
Add Luabindings for MPControl (required for VBM) 2022-10-07 18:52:00 +02:00
8d045e15dc Do not add whole-file regions to playlists
Various operations, notably time-stretch and other filters, directly
added the generated whole-file region to the playlist.
The editor has not listed the generated Region in the RegionList.
2022-10-07 00:36:57 +02:00
f6e471f48d Remove explicit overrides
see 27dcb7560c1cab and 8c83149c4c
2022-10-07 00:36:43 +02:00
d9c6842ea3 Fix region property inheritance (GUI) 2022-10-07 00:36:20 +02:00
e40f58c106 Inherit Region Properties
This also adds special cases when splitting or splicing locked regions.
2022-10-07 00:36:10 +02:00
2f810ad34e Allow to override region lock, and derive properties
This is required when adding locked regions to a playlist.
e.g. after a split or partition operation. It is only supposed
to be used from Playlist::add_region_internal() and
Playlist::partition_internal().
2022-10-07 00:35:51 +02:00
ebf59d4426 Insert_or_assign properties, allow to override properties
This allows to copy a property list and then selectively
replace various properties. e.g.

```
PropertyList plist (region->properties ());
plist.add (Properties::length, len);
plist.remove (Properties::start);
```

See also 8b0ab38675
and 97f0fac7d5
This also fixes the issue referenced in
8c83149c4c
2022-10-07 00:32:14 +02:00
ddec1a9a98 Silence some clang warnings 2022-10-07 00:31:48 +02:00
ba41f22f88
Resize plugin-scan dialog as needed for UI scaling 2022-10-06 15:41:56 +02:00
7a0da94ba3 fix RangeTest to account for Range now using exclusive ends, not inclusive 2022-10-05 17:30:45 -06:00
2af00a3f69 Revert "route group dialog grabs focus when shown"
Unnecessary change.

This reverts commit fe0cde3781.
2022-10-05 15:57:41 -06:00
91bdfaa824 add all new 7.0 contributors, and fix FSF address in GPL text 2022-10-05 14:43:47 -06:00
03295869ce
Revert "Small test tool for PBD::Transmitter thread-safety tests"
This reverts commit d9ce918c41.
2022-10-05 22:25:07 +02:00
413285b713 FIx path on macOS when running from source-tree
This fixes access to local clip library files. Absolute paths are
required, otherwise FileSource::find searches the session folder.
2022-10-05 19:52:01 +02:00
f858132a25 more appropriate sizeing and scrolling for library downloader
Without this it just grows to be tall enough to show all downloaded descriptions
2022-10-05 10:46:50 -06:00
908bcf3150
Fix bundling Ardour media for Linux packages 2022-10-05 16:59:56 +02:00
99d0cc47b7 Remove outdated script 2022-10-05 05:23:30 +02:00
0c2176dd71 move default_triggers_per_box into a namespace ; change value for Ardour to 16 (GUI edition) 2022-10-04 19:55:15 -06:00
3c0820e36e move default_triggers_per_box into a namespace ; change value for Ardour to 16 2022-10-04 19:55:05 -06:00
34d339ab5d MIDI copies are now unlinked by default 2022-10-04 18:32:02 -06:00
0d9e362e8c
Bring back useful clip files for testing when building from source
This reverts commit efca0ee433.
and commit a410a6fd26.
2022-10-04 22:27:03 +02:00
efca0ee433 remove .daw-meta.xml from share/media 2022-10-04 13:44:06 -06:00
a410a6fd26 remove useless click clips from share/media 2022-10-04 13:44:06 -06:00
e14bef1619
Fix unzip, allow to overwrite .daw-meta.xml file 2022-10-04 20:39:14 +02:00
980404d73c refill library download dialog on show 2022-10-04 11:18:55 -06:00
d7a88eecb1 libraryfetch: add description count 2022-10-04 11:18:40 -06:00
bbe68542e8 fetch and include MIDI bundled content during packaging of Ardour 2022-10-04 11:01:59 -06:00
b40179854a Revert "no bundled content for Ardour"
this was a mistake.

This reverts commit 9662e6eac0.
2022-10-04 11:01:59 -06:00
Mads Kiilerich
a23e137723 When exporting with .cue file, use latin1 for filename as well
Before, the .cue file could end up with a mix of latin1 and utf-8
encodings. Utf-8 works better for many things, but that doesn't matter
when the .cue file has to be in latin-1.
2022-10-04 16:52:04 +02:00
b269a1298c
Fix memory leak for invalid SMF event 2022-10-04 03:29:52 +02:00
88bd2115a0
Consolidate signal emission, fix RWLock deadlock
Play loop, change loop-location, undo.

Undo calls Locations::set_state, takes a writer-lock,
and calls Location::set_state which emits a Changed signal.
This triggers Editor::location_changed, and if loop-location
changed while looping, update_loop_range_view() queries the
loop location, taking a reader-lock.

This leads to a recursive lock, RWLock::ReaderLock after
a RWLock::WriterLock does not cause a deadlock, however
releasing the ReaderLock effectively also unlocks the WriterLock.
This leads to a deadlock next time a writer-lock is acquired.
2022-10-04 01:12:50 +02:00
a0c93328ea push2: fix intended behavior of push2 "lower buttons" 2022-10-03 15:41:50 -06:00
9662e6eac0 no bundled content for Ardour 2022-10-03 15:21:40 -06:00
0938d21c30 change add new bbt marker from primary-click to context-click on BBT ruler 2022-10-03 14:16:34 -06:00
374ff2b12d fix thinko in unbang behavior 2022-10-03 13:47:55 -05:00
fe0cde3781 route group dialog grabs focus when shown 2022-10-03 12:15:43 -06:00
aedf697646
Fix crashes due to missing return value
due to -fomit-frame-pointer a missing return value leads
to stack corruption. This also fixes the return type.
2022-10-03 19:38:30 +02:00
a0a2138651
Highlight auditioned clips
This changes the color of auditioned clips in the clip-list.
The highlight is reset when changing folders or when importing
a clip via DnD.
2022-10-03 01:19:50 +02:00
61fc46ff79
Fix missing Lua bindings
* RecordMode is required for Session Config set/get_record_mode.
* TempoMap::dump requires C++ std::ostream&
2022-10-02 14:33:06 +02:00
9ed82713de On popular demand, hide splash instead of push it back
Sadly some popular Window Managers do not follow
freedesktop.org specifications.  This results in Ardour's splash
screen obscuring session setup dialogs on those systems.
2022-10-01 19:38:43 +02:00
0f6a2f7320 Remove unneeded scope 2022-10-01 19:01:49 +02:00
0b70550b42 Fix width of draw-grid dropdown menu 2022-10-01 19:01:30 +02:00
751de3889e Fox grid dropdown menu width
Take submenu items into account, which have strings longer than
GridTypeBeatDiv32 text
2022-10-01 18:53:45 +02:00
a626f1f0d5 Synchronize grid menus (#8973) 2022-10-01 18:04:30 +02:00