13
0
Commit Graph

147 Commits

Author SHA1 Message Date
485b74e0b9 rename EditorSummary::Position as Editor::SummaryPosition 2021-08-13 12:51:34 -06:00
18d64f0402 change all Region::nt_*() methods to names without the nt_ prefix (GUI version) 2021-08-13 12:51:30 -06:00
7433bc27e0 intermediate, unfinished snapshot of ongoing timeline types work on GTK GUI 2021-08-13 12:51:29 -06:00
283cade057
Update GUI Region[s]PropertyChanged signal handlers (2/3) 2021-05-07 23:29:25 +02:00
ac53a9bbf8 remove unnecessary 2nd argument from Session::request_locate() calls (default value is identical) 2021-05-03 17:40:41 -06:00
44528f4fd0
Fix editor summary exposure rectangle
Rectangle uses position and width, not coordinate pairs.
2021-01-08 18:39:57 +01:00
4769c387f3
Expose EditorCursor via public editor API
This is in preparation to subscribe to playhead cursor position
changes in the recorder-UI.

This change also clean up the API, replacing a public variable
with a const access method and follows #12 of
https://ardour.org/styleguide.html
2021-01-08 18:39:56 +01:00
47767738b9 rename DoTheRightThing to RollIfAppropriate 2020-01-18 08:49:18 -07:00
3c00048b0c Session::request_locate() takes a tri-valued second argument for "roll-after-locate"
This allows callers to defer logic about auto-play/current rolling state and more to TransportFSM where it
can be cnentralized and is less ambiguous
2020-01-18 08:49:18 -07:00
4050ca5633
Update GPL boilerplate and (C)
Copyright-holder and year information is extracted from git log.

git history begins in 2005. So (C) from 1998..2005 is lost. Also some
(C) assignment of commits where the committer didn't use --author.
2019-08-03 15:53:15 +02:00
31815b5f26
NO-OP: whitespace
This fixes mostly <tab> after <space> and similar <tab> not used
for indenting as well as some related code alignment issues.
2019-04-13 17:57:46 +02:00
51df70b405 ActionManager::get_all_actions() no longer includes <Actions> in the paths it returns, part 3 (GUI) 2019-03-20 11:15:47 -07:00
2e5daf2eeb
Reduce #includes - avoid ardour_ui.h 2019-03-08 01:53:55 +01:00
7b96fa1c5e
Fix some Gtk::Menu memory leaks
A Gtk::manage()d widget will be deleted when its parent container
is destroyed. Top-level context menus are not inside a container and
hence need to be manually deallocated.

The solution here is to use a shared Gtk::Menu pointer that is
centrally de/re-allocated.

This works because the GUI is single-threaded and at most one
context menu is visible at a time.
2019-03-07 23:50:50 +01:00
c881b4a85f Summary View should use the playhead color from config. 2019-02-12 11:36:04 -06:00
108162c757 Aborted attempt to further optimize the editor-summary. Commented for future generations. 2018-07-14 08:40:07 -05:00
ceac42cc03 NO-OP: whitespace
- remove trailing whitespace
- remove space after opening brackets and before closing brackets
- add space around operators
- do not use '//' for multi-line comments, do not use "//" on line-start
  to comment-out code breaking indenting (-Wmisleading-indent)
- do add a single space after comment-start /*{SPACE}... or //{SPACE}...
- reserve duplicate whitespace "  " for alignment, remove other duplicate
  whitespace
- use established "TODO" and "XXX" (highlighted keywords)
- remove equal-sign series "====" (those indicate merge conflicts)
2018-02-24 13:55:20 +01:00
30b087ab3d globally change all use of "frame" to refer to audio into "sample".
Generated by tools/f2s. Some hand-editing will be required in a few places to fix up comments related to timecode
and video in order to keep the legible
2017-09-18 12:39:17 -04:00
7e300c93f2 Editor zooming: right-click on summary -> context menu -> reset to session extents. 2017-08-26 23:32:02 -05:00
71d9ea7270 Editor zooming: Tweak the Summary to stop at right edge, use session_gui_extents(). 2017-08-26 22:44:58 -05:00
243d55f3c2 Remove an unused variable 2017-07-30 02:42:55 +02:00
611a150dfb Editor Summary: Don't require user to re-click to scroll + zoom.
* Use conventions similar to those used in CursorDrag.
2017-07-20 14:15:40 -05:00
3b47a42127 Editor Summary: thinko in initial value 2017-07-19 15:44:14 -05:00
6666ea593d Editor Summary: likely fix for crash-on-quit 2017-07-19 15:41:19 -05:00
394b30fe42 Editor Summary: Tweaks
* Only draw track bg lines if they will actually be recognizable.
* limit zoom-in capability of the summary box until it works correctly.
2017-07-19 15:37:59 -05:00
1decc225c9 Editor Summary: fix yet another thinko in zoom direction. 2017-07-19 14:13:18 -05:00
29002b9ac9 Editor Summary: The view rectangle should never exceed the bounds of the scroll area. 2017-07-19 13:58:56 -05:00
0cb44f9d56 Editor Summary: fix thinko in mouse cursors (trim cursor). 2017-07-19 08:20:25 -05:00
255d633edd Editor Summary: implement summary_zoom_step() to lessen redundant code. 2017-07-19 08:12:25 -05:00
1955ff3ad2 Editor Summary: fix direction of scroll zoom to match other conventions 2017-07-19 06:58:16 -05:00
ea05241771 Editor Summary: Changes to behavior
* Remove up/down buttons.
* Allow the summary to shrink smaller.
* Vertical drag results in zoom.
* Scroll-wheel results in zoom.
* Tweak mouse cursor to better indicate behaviors.
* ToDo:  refactor the zooming code.
2017-07-18 10:37:35 -05:00
7e4f261853 Turn Summary into a horizontal scrollbar (drop y-axis sensitivity) 2017-07-14 20:01:45 +02:00
Thomas Brand
63ea7b6516 NO-OP whitespace (updated GH PR #357) 2017-07-01 19:28:26 +02:00
d06de26a4f Towards a consistent render() API.
This fixes an -Woverloaded-virtual ambiguity introduced in b5e613d45

  void render (cairo_t*, cairo_rectagle*)
  void render (Cairo::RefPtr<Cairo::Context> const&, cairo_rectangle_t*)

ArdourCanvas prefers cairomm and CairoWidget itself uses Cairo::Context,
this improves overall API consistency.
2017-03-20 17:12:08 +01:00
3294b82e25 Use NSGLView for EditorSummary 2017-03-20 17:12:08 +01:00
nick_m
23da9acf7e Minimise duplicate calls to CairoWidget::set_dirty() in the editor summary.
- many regions may be changed by one operation.
2016-07-10 02:18:38 +10:00
3e12d4b4a6 use PresentationInfo color to set route colors. GUI appears to respond as expected 2016-06-05 17:16:20 -04:00
9d3aba30c4 Stripable signals moved to PresentationInfo 2016-06-05 16:33:01 -04:00
e0ff70cf86 first vaguely working version using PresentationInfo
remote control ID and "order keys" have been removed.
2016-05-31 15:30:42 -04:00
2a13891970 Change scrolling in the Editor track canvas summary area
Keep scroll distance consistent when scrolling up and down with horizontal
modifier as when scrolling left to right.

Scroll horizonally by half a page so that no sections of the canvas are skipped
when scrolling.

Scroll by half a page rather than a step like when scrolling in the track
canvas area as it is a summary area so larger steps seem acceptable and having
it use the same scroll distance as when scrolling in the track canvas seems
pointless as you would then just scroll in the track canvas area.
2016-01-21 11:25:56 +10:00
22b07e0233 NOOP, remove trailing tabs/whitespace. 2015-10-05 16:17:49 +02:00
4dc63966f0 globally remove all trailing whitespace from ardour code base.
Paul Davis was responsible for introducing almost all of this.
2015-10-04 14:51:05 -04:00
6b019a4953 Move UIConfiguration Singleton into UIConfiguration header
This removes the direct dependence on ardour_ui.h from 39 files
2015-09-16 16:55:17 -04:00
1ca9cd228e update track-height scaling:
“number of visible tracks”: count automation lanes
as tracks. Distribute equally.

“Summary View”: the visual lane represents both
track + automation. Set the total height.

Left to do: recursive “Shrink” and “Expand” tools
if there is no explicit selection.
2015-03-19 21:55:28 +01:00
26ba494083 prevent single-axis drags in the editor summary from affecting the other axis.
In theory, the EditorSummary::get_editor()/set_editor() calls
should be no-ops if the values are just passed between them,
but this turns out to be not precisely the case. Rather than
figure out exactly how ensure that this is true, mark the
new rect boundaries for the non-moving axis with -1 so that
we know to leave it alone
2015-03-15 12:13:03 -05:00
81c196e9ca Improve contrast of summary. 2015-01-07 01:42:49 -05:00
64fa63212f move all (G)UI related configuration parameters into UIConfiguration, not RCConfiguration 2014-12-22 13:39:46 -05:00
1d0612ceb6 redraw summary when theme preference changes & consolidate code. 2014-10-29 16:07:13 +01:00
300d765f17 fix summary display (offset on-canvas rulers) 2014-10-29 12:06:20 +01:00
ea26d70cad fix summary re-size
w/USE_CAIRO_IMAGE_SURFACE
2014-10-29 12:06:20 +01:00