13
0
Commit Graph

14805 Commits

Author SHA1 Message Date
2bdf9e447f OSX gcc does not support local-typedef warning 2014-11-24 04:24:58 +01:00
3a7652200d also search for 32bit xjadeo on 64bit windows 2014-11-24 01:43:31 +01:00
c0e8647806 amend c4533939b9 2014-11-24 00:04:45 +01:00
3aea7af3fd lost quote 2014-11-24 00:00:58 +01:00
cd91fa0046 hotfix windows-compilation (unfinished bfe49540b9)
..at least it compiles and starts. Mackie support etc
is probably still broken.
2014-11-23 23:57:56 +01:00
1b6cbf743b update harvid & ffmpeg binary path discovery on windows (64 & 32 bit) 2014-11-23 23:57:55 +01:00
8ddeb712f6 make debug message more useful 2014-11-23 23:57:55 +01:00
5aba4df252 fix/silence various compiler warnings.
* ifdef unused static functions
* brackets around assignment and comparision
* no return statement in function returning non-void
* boost concept_checks.hpp unused-local-typedefs
2014-11-23 23:57:55 +01:00
f1926dc863 Fix build with a certain awful broken compiler. 2014-11-23 16:31:59 -05:00
ec01682714 -Wunused-function on windows 2014-11-23 21:01:39 +01:00
40764f4cb3 use NULL not 0 for c-functions (even in c++ code)
4.3 KBytes less compiler warnings.
2014-11-23 21:01:39 +01:00
bfe49540b9 remove use of CrossThreadChannel::selectable() to allow cross-platform implementation of CrossThreadChannel via Glib::IOSource 2014-11-23 17:37:13 +02:00
dcf632d99f assign minsec_ruler_scale and minsec_mark_modulo when zoomed very far out
Avoids crash when computing % minsec_mark_modulo.
2014-11-23 14:36:38 +02:00
57c1b6e261 Fix quantization and other time-related ops. 2014-11-22 21:49:42 -05:00
231e0009b4 Max is max and min is min and I am dumb. 2014-11-22 16:33:32 -05:00
bed95a64a0 Fix note resizing. 2014-11-22 15:33:40 -05:00
42b5ed3904 Fix clang and MSVC build. 2014-11-22 15:26:41 -05:00
73ad993597 Fix invisible discrete control points. 2014-11-22 04:39:30 -05:00
c1cfa12d6e Wrap MusicalTime in a class.
This lets us get a more explicit handle on time conversions, and is the main
step towards using actual beat:tick time and getting away from floating point
precision problems.
2014-11-22 04:05:42 -05:00
cae74309a5 Fix assert failure in control list interpolation.
How we never hit this before is beyond me, it's in some ooooold code.
2014-11-22 00:46:15 -05:00
01493b14cf Fix const violation warnings in tempo.cc. 2014-11-22 00:46:15 -05:00
24f7eccc86 Factor out copy-paste code to get grid type in beats defaulting to 1. 2014-11-22 00:46:15 -05:00
41a9060df9 Move time converters only to the region views that actually need them.
A step towards sorting out time issues more solidly, the time situation of MIDI
region views and automation region views is slightly different.
2014-11-22 00:46:15 -05:00
2966dd4a9f add a variable to specify windows build concurrency 2014-11-21 23:12:17 +01:00
4bc0d1c475 Fix lost MIDI note offs and controllers.
Fix initial read of discrete MIDI controllers.

Fix spurious note offs when starting to play in the middle of a note.

Faster search for initial event when cached iterator is invalid.

So much for dropping the cached iterator.  The iterator is responsible for
handling note offs, so that doesn't work.  This design means we have some stuck
note issues at the source read level, but they should be taken care of by the
state tracker anyway.
2014-11-20 15:36:11 -05:00
8bba63282a Reduce unnecessary non-const MIDI buffer access. 2014-11-20 15:32:06 -05:00
7def8de5a3 Use memento_command_binder() to (probably) fix MSVC build and other things.
Remove ugly hack that does the same thing.
2014-11-20 12:01:39 -05:00
8f8a4878f3 Clean up some MIDI code. 2014-11-20 11:31:31 -05:00
9d8bbf4b9a Remove unused variables. 2014-11-20 11:31:31 -05:00
0c4869dc35 debug trace lost midi-messages 2014-11-20 02:46:30 +01:00
a9936205b1 Fix dropped MIDI events, especially with record enabled.
I am not precisely sure why the cached iterator was causing this problem, it
shouldn't be invalidated, and the times make sense.  It may be some lock
related issue since the iterator holds a lock on the source.

In any case, this cached iterator was just to avoid repeated linear search of
the model, but since the model has a logarithmic search, instead just scrap all
this problematic persistent state and search for the appropriate start time
every read.  No need to be careful about invalidating when anything changes.
2014-11-19 19:24:16 -05:00
4ffdc99c5f fix range selection of mixer strips; shift+selecting a single strip would select from there til the end 2014-11-19 17:27:13 -06:00
e3e85a92db some const'ness and hints for clang 2014-11-19 20:38:50 +01:00
cc5f5c7738 copy hotspots file when packaging windows cursors 2014-11-19 00:21:32 +01:00
9bac4df9ec also load hotspot file (if it exists) for default cursors 2014-11-19 00:21:31 +01:00
0fb91e10b4 allow dummy backend for any product 2014-11-18 17:04:23 -06:00
41128d1fd4 fix windows icon deply path 2014-11-18 22:32:06 +01:00
f082c42994 drop hotspot info when changing cursors. 2014-11-18 22:11:12 +01:00
68b3568ab0 deploy square cursors as default for windows 2014-11-18 22:08:51 +01:00
37a1717c22 add square cursors (for windows)
cursor icons squared with north-west gravity.
hotspots are identical to original icons.

otherwise gdkcursor-win32 creates square cursors with
center gravity and hotspot X/Y differs.
2014-11-18 22:00:58 +01:00
4389fd2ace tabs are tabs and spaces are spaces
see http://ardour.org/styleguide.html #26
2014-11-18 21:59:28 +01:00
7518c363e5 assert no null pointer dereference 2014-11-18 21:59:04 +01:00
Jeremy Carter
fe6e6e3f35 Plugin Automation All: Fix bug where Switches weren't being changed. 2014-11-18 14:26:50 -05:00
e8716de015 Make MIDI channel selector rows/col constraints actually do something.
Seems kind of pointless since it's always 4 anyway, but whatever.
2014-11-18 02:55:04 -05:00
bd577a0663 Avoid possible use of uninitialized values.
This could only happen with a broken widget, but it shuts up clang and doesn't
hurt.
2014-11-18 02:55:03 -05:00
976a150e6b Remove obviously dead/redundant code. 2014-11-18 02:55:03 -05:00
07d4f50689 Clean up funny code and initialize variables. 2014-11-18 02:55:03 -05:00
881d77f1e5 Constrain variable scopen and avoid uninitialized values existing at all.
Note: dead assignments trigger scan-build dead code warnings, which
initializations do not.
2014-11-18 02:55:03 -05:00
6e482b3488 Remove unused variable and redundant arithmetic. 2014-11-18 02:55:03 -05:00
8dde26da7b Gracefully avoid importing audio that somehow has 0 channels. 2014-11-18 02:55:03 -05:00