ardour/livetrax
13
0
Fork 0
Code

don't move faders on click.

Browse Source 
for one, it can mess up the value when switching to
numeric-entry. It is also rather useless and not
Fader-like (faders are not scrollbars).
Besides, "stepvalue" is way to large and causes jumps
(sometimes step-value is even negative, see
"fast lookahead limiter", "release time"
 -> some other bug)
This commit is contained in:
Robin Gareus 2014-11-29 17:31:41 +01:00
parent 48bb90eb88
commit c77f4b7a18
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/gtkmm2ext/pixfader.cc
View File

@ -431,6 +431,7 @@ PixFader::on_button_release_event (GdkEventButton* ev)
_adjustment.set_value (_default_value); _adjustment.set_value (_default_value);
} else if (ev->state & Keyboard::GainFineScaleModifier) { } else if (ev->state & Keyboard::GainFineScaleModifier) {
_adjustment.set_value (_adjustment.get_lower()); _adjustment.set_value (_adjustment.get_lower());
#if 0 // ignore clicks
} else if (ev_pos == slider_pos) { } else if (ev_pos == slider_pos) {
; // click on current position, no move. ; // click on current position, no move.
} else if ((_orien == VERT && ev_pos < slider_pos) || (_orien == HORIZ && ev_pos > slider_pos)) { } else if ((_orien == VERT && ev_pos < slider_pos) || (_orien == HORIZ && ev_pos > slider_pos)) {
@ -438,6 +439,7 @@ PixFader::on_button_release_event (GdkEventButton* ev)
_adjustment.set_value (_adjustment.get_value() + _adjustment.get_step_increment()); _adjustment.set_value (_adjustment.get_value() + _adjustment.get_step_increment());
} else { } else {
_adjustment.set_value (_adjustment.get_value() - _adjustment.get_step_increment()); _adjustment.set_value (_adjustment.get_value() - _adjustment.get_step_increment());
#endif
} }
} }
return true; return true;