From c77f4b7a186e030f0295cae03f8e3c0662f77781 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Sat, 29 Nov 2014 17:31:41 +0100 Subject: [PATCH] don't move faders on click. for one, it can mess up the value when switching to numeric-entry. It is also rather useless and not Fader-like (faders are not scrollbars). Besides, "stepvalue" is way to large and causes jumps (sometimes step-value is even negative, see "fast lookahead limiter", "release time" -> some other bug) --- libs/gtkmm2ext/pixfader.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libs/gtkmm2ext/pixfader.cc b/libs/gtkmm2ext/pixfader.cc index f62e703d73..51a397ffbe 100644 --- a/libs/gtkmm2ext/pixfader.cc +++ b/libs/gtkmm2ext/pixfader.cc @@ -431,6 +431,7 @@ PixFader::on_button_release_event (GdkEventButton* ev) _adjustment.set_value (_default_value); } else if (ev->state & Keyboard::GainFineScaleModifier) { _adjustment.set_value (_adjustment.get_lower()); +#if 0 // ignore clicks } else if (ev_pos == slider_pos) { ; // click on current position, no move. } else if ((_orien == VERT && ev_pos < slider_pos) || (_orien == HORIZ && ev_pos > slider_pos)) { @@ -438,6 +439,7 @@ PixFader::on_button_release_event (GdkEventButton* ev) _adjustment.set_value (_adjustment.get_value() + _adjustment.get_step_increment()); } else { _adjustment.set_value (_adjustment.get_value() - _adjustment.get_step_increment()); +#endif } } return true;