Commit Graph

36648 Commits

Author SHA1 Message Date
David Robillard d568bb5a06 Fix unused computed values
For example:

../libs/pbd/reallocpool.cc:138:38: warning: value computed is not used
[-Wunused-value]
  138 |                 ASSERT (_asize (ptr) <= newsize);
2022-12-11 11:54:03 -05:00
Robin Gareus 483ca4e19d
MIDI tracer: disable trace when window is closed
This fixes a bug with some MIDI port constantly tracing,
because trace_parser is never unset.
2022-12-11 13:13:02 +01:00
Robin Gareus 5637e811f9
MIDI Tracer connects to ports, remove unused tracer port 2022-12-11 12:53:57 +01:00
Paul Davis 39c324b620 temporal: fix ::get_grid() crash condition
We cannot call TempoMetric::superclock_at (BBT_Time) if the BBT time is beyond
the range of the current TempoMetric. We must discover that *before* we make
that call, not as part of the test to see if we've exceeded the range.
2022-12-10 22:59:58 -07:00
Paul Davis 5e9e21911c corrections for methods that move playhead to region boundaries
1. "not found" is now indicated by a timepos_t::max() value, not a negative one.
2. if the direction to search is negative we should decrement (when possible)
before searching, to avoid finding the current position.
2022-12-10 18:13:48 -07:00
Robin Gareus d62cba8ba5
Add tooltip for mixer-strip color/number label 2022-12-10 22:22:31 +01:00
Paul Davis db3e87a7e4 do nothing gracefully if asked to remove only tempo 2022-12-10 14:14:12 -07:00
Paul Davis dc74decdf7 remove luminance changes from ARDOUR_UI_UTILS::unique_palette_color() 2022-12-10 13:45:07 -07:00
Paul Davis 6ed1402812 use ItemChangeBlocker to improve performance of RegionView::remove_silent_frames() 2022-12-10 13:40:06 -07:00
Paul Davis ab34861388 canvas: provide a means of blocking change notifications from Item propagating up the object tree 2022-12-10 13:37:16 -07:00
Paul Davis 8237a8115c cleanup unused variables in Editor ruler display code 2022-12-10 10:48:59 -07:00
Paul Davis 303f838a53 define new actions for stopping triggers/slots 2022-12-10 10:33:39 -07:00
Paul Davis c2c23172bd ctrl surfaces: add method to BasicUI to stop slots in a given trigger box 2022-12-10 10:33:24 -07:00
Paul Davis 9403b116ad Mackie: make AudioInstruments button work correctly
Also toggle Global View LED appropriately
2022-12-10 10:32:47 -07:00
Paul Davis 4fdd8646b4 fix positioning of regions during multiduplicate or fill track operations 2022-12-10 09:43:43 -07:00
Paul Davis 425f84493b fix display of selection end point and duration (again!) 2022-12-10 09:43:43 -07:00
Robin Gareus cb2f08f50c
Consistent ruler area colors
This fixes a special case of the loop/punch ruler, which
only had effect on session-reload due to a copy/edit bug
(canvas_transport_marker_bar_event used "range marker bar")
2022-12-10 15:14:39 +01:00
Robin Gareus eb42318d3e
Consolidate ruler prelight events
This fixes various copy/edit bugs (e.g. transport ruler uses
"range marker bar" colors, but only after a enter/leave event).
2022-12-10 15:14:29 +01:00
Robin Gareus 3875468935
Remove unused "opaque region base" from themes 2022-12-10 02:37:05 +01:00
Robin Gareus 516bf1fa17
Set "opaque region base" alpha to 1.0 2022-12-10 02:37:05 +01:00
Robin Gareus a0d36a03b4
Tweak ARV waveform colors to match new transparency model 2022-12-10 02:37:05 +01:00
Robin Gareus fc53754055
Remove "midi frame base" from themes 2022-12-10 02:37:05 +01:00
Robin Gareus 3442500002
Remove "midi frame base", consistent TAV color (1/2) 2022-12-10 02:37:05 +01:00
Robin Gareus 0bb81a9a18
Do not shade transparent regions in Layered mode
There already is a shaded coverage frame indicating
if a layer is audible. This leads to a more consistent view.

In addition changing layered mode now has to update the
colors (set_frame_color).
2022-12-10 02:37:05 +01:00
Robin Gareus 6c524b3f3b
Use a dedicated Canvas Group for ARV 2022-12-10 02:37:05 +01:00
Robin Gareus f003bee985
Use a dedicated Canvas Group for MRV
This fixes rendering of opaque MIDI regions (previously
MIDI regions were always transparent). This change provides a
way to "flatten" layered MIDI regions, while still allowing
to show the note-line and grid behind the regions.
2022-12-10 02:37:05 +01:00
Robin Gareus 1efa5e9a55
Prepare themes for region/grid transparency 2022-12-10 02:37:05 +01:00
Robin Gareus 70b00f5201
Canvas: allow to group rendering of child items
> This group functionality can be convenient for performing
> intermediate compositing. One common use of a group is to
> render objects as opaque within the group, (so that they
> occlude each other), and then blend the result with
> translucence onto the destination.
https://www.cairographics.org/manual/cairo-cairo-t.html#cairo-push-group

The main use case where will be to render opaque layered
[MIDI] regions transparently onto a grid.
2022-12-10 02:37:04 +01:00
Robin Gareus dcf981fe07
Remove remnants from AudioMidi Tracks
This fixes meter faceplace background color when adding
a MIDI port to an audio track.
2022-12-10 02:36:46 +01:00
Robin Gareus b2fddeb43d
Add named ranges to quick export dialog 2022-12-09 19:22:59 +01:00
Robin Gareus c629f3ffcb
Fix Lua biqaud filter parameter range 2022-12-08 18:54:20 +01:00
Paul Davis 74f95ff0dd when use stripable palette colors, use them sequentially
Also break this code out into a separate method
2022-12-08 10:52:57 -07:00
Paul Davis cd4b6e85a8 pick route colors from the color palette (with random variation) #9115 2022-12-07 21:27:51 -07:00
Robin Gareus cd7c981e6e Use macOS API to open finder at given path 2022-12-08 02:15:29 +01:00
Robin Gareus 201617f03b Fix macOS URI open
curl_easy_escape() escapes slashes, which fails with openURL on modern macOS.
Also add missing call to curl_easy_cleanup().
2022-12-08 02:12:15 +01:00
Robin Gareus ea50799ce2 Remove duplicate implementation
`bool cocoa_open_url (const char*)` is implemented in 
libs/pbd/cocoa_open_uri.mm
2022-12-08 01:32:41 +01:00
Robin Gareus d3e736f7d3
Consistent audio/MIDI monitor modes
Now that both Audio And MIDI tracks support all three record
modes. Monitoring should be consistent. When recording
"Sound on Sound" does cue monitoring, while "layered" (opaque).
and "non-layered" monitors only the input.

Two differences remain: (1) when not recording MIDI tracks still
monitor both Input and Disk (unless Non-layered is set), and
a final special case is that MIDI tracks always monitor input
as fallback. the latter ties in with (2) audio tracks can
use hardware monitoring.
2022-12-07 22:49:08 +01:00
Paul Davis b9f9531fa1 duration clocks: fix display when mode is changed 2022-12-07 12:11:31 -07:00
Paul Davis ad9757e73c fix nudge/duration clocks when scrolling in BBT mode 2022-12-07 11:13:49 -07:00
Paul Davis 9f85a0aaba fix behavior of duration clocks when scrolling in all modes except BBT 2022-12-07 11:13:49 -07:00
Paul Davis 4beca98e28 temporal: fix various incorrect uses of ::samples() in audio time arithmetic
It is a wonder that this has not caused more visible issues since 7.0
2022-12-07 11:13:49 -07:00
Robin Gareus 313f7ad344
Use new API to compare export format/spec 2022-12-07 17:57:56 +01:00
Robin Gareus e28e079c9f
Consolidate Export Format/Spec comparision 2022-12-07 17:56:07 +01:00
Robin Gareus 1005fc5716
Allow to import opus files 2022-12-07 13:36:57 +01:00
Robin Gareus 85a1c463e5
Add Lua method to show system env
`for v in ARDOUR.LuaAPI.env():iter() do print(v) end`
2022-12-07 00:28:21 +01:00
Robin Gareus 0abbe651ea
Remove debug output 2022-12-07 00:28:21 +01:00
Paul Davis f37687a985 various fixes for AudioClock duration/!duration confusion 2022-12-06 11:11:08 -07:00
Paul Davis 716501defa potential fix for "/bus/... master ..." target in MIDI binding maps failing 2022-12-06 11:11:08 -07:00
Paul Davis 7850628f6f fix manual drawing of MIDI automation (avoid offset) #9142
Change assumption that the "pos" argument to AutomationRegionView::add_automation_event is region-relative, by
making it global.

This did not affect non-MIDI automation because that used
AutomationTimeAxisView::add_automation_view() instead.
2022-12-06 11:11:08 -07:00
Robin Gareus 32b6db092c
NO-OP: whitespace and comment 2022-12-06 17:30:59 +01:00