Commit Graph

16750 Commits

Author SHA1 Message Date
nick_m d9c0aa4236 Amend last commit. 2015-06-22 00:53:31 +10:00
nick_m d45a25e4a8 Clicking an automation track line without a move adds a point on the line. 2015-06-22 00:47:08 +10:00
nick_m e0a076d2b6 Mkae automation line / gain line cursors consistent. 2015-06-21 22:14:03 +10:00
nick_m 63269b3063 Automation selection fixes.
- display selected comtrol points in region gain lines
	- display selected points in internal edit mode
	- allow dragging of region gain lines in MouseContent mode
2015-06-21 05:27:45 +10:00
nick_m aa1cdd26ca AudioRegionView now uses ControlList::editor_add(). 2015-06-19 05:02:06 +10:00
nick_m 1768e9817e Fix another LineDrag click crash. 2015-06-19 03:39:51 +10:00
nick_m dcd3e3823c Don't begin command on start_grab for AutomationRangeDrag and NoteResizeDrag
- fixes a crash when clicking to resize without movement.
	- minor readability fix for _drag_had_movement
2015-06-19 00:02:09 +10:00
nick_m 6ecbeed8e8 Fix ControlList::editor_add () wrt guard points. 2015-06-18 10:03:18 +10:00
nick_m 16109ebcc8 Rework last commit, clicking on an automation line no longer adds history.
- fixes a crash when clicking on automation lines repeatedly.
2015-06-18 06:27:37 +10:00
nick_m 0280989276 Single control points can now be dragged up and down properly.
- preserves the zero notch, but doesn't mess up the cumulative drag.
2015-06-18 04:42:30 +10:00
nick_m 639750f815 Don't add history by clicking a control point, fix control point selection.
- also make set_selected_control_point_from_click () return
	  something useful.
2015-06-18 03:48:39 +10:00
nick_m 80090f0f71 Fix thinko in automation write undo.
- also allow saved automation list state to be touch or off if
	  actually in write mode.
2015-06-17 22:19:21 +10:00
nick_m 44790ebff0 More _reversible_command() auditing in the gui.
- try to keep begin/commit pairs in the same file where possible.
2015-06-17 09:54:23 +10:00
nick_m d019ee836c Use a better pattern to avoid abort_reversible_command().
- also, duplicated regoins are now selected and some end-of sesion
	  bugs fixed there.
	- should fix lack of tempomap undo in Editor::insert_time ()
2015-06-17 09:54:23 +10:00
nick_m 4c1d79af4a Unbreak region brush drag wrt undo, avoid some dangling commands in the gui
- also allow moving of automation lines in internal mouse mode.
	- this is also a first pass at ensuring that if an operation does
	  nothing, avoid an undo entry.
2015-06-17 09:54:22 +10:00
nick_m 15336d06e4 Add undo for automation write. 2015-06-17 09:54:22 +10:00
nick_m 15819f0896 Automation -use editor_add in gui, record straight lines with fewer points.
- don't keep setting/unsetting write pass when transport frame
	  remains the same (think larger jack buffer sizes)
	- insert guards are now 64 frames after when.
	- refactor previous approach.
2015-06-17 09:54:22 +10:00
nick_m 7cb9dbb8af Rudimentary automation touch undo/redo. 2015-06-17 09:54:22 +10:00
nick_m 57ce447fd1 Fix some workflow problems wrt automation.
- clearing automation points sets control to "off" rather than touch.
	- multiple touches on the same pass acts consistently (no more
	  fader jumps on mouse button press
	- use actual value for initial point rather than some arbitrary
	  default. clarify new semantics of add () (with_default->with_initial).
	- clean some whitespace
	- add guard points as needed in stop.
	- catch grab broken signal (i can't trigger it, but the docs seem
	  to think it is essential).
2015-06-17 09:54:22 +10:00
Robin Gareus 9d4c93aca7 -Wsign-compare 2015-06-16 19:27:22 +02:00
Paul Davis 90220998af add Record-Safe feature to libardour (from Nikolay Polyanovskii) 2015-06-16 08:44:03 -04:00
Paul Davis d65f03d074 fixes for canvas text display on Retina (from Valeriy) 2015-06-16 07:52:00 -04:00
Robin Gareus 3f157f961a use mpeg4 for internal video format (not mjpeg)
reduces file size.
xjadeo > 0.8 and harvid >= 0.8 handle this fine.
2015-06-16 00:47:53 +02:00
Robin Gareus dc2030cfd7 ALSA backend: add support for half-duplex devices 2015-06-14 22:26:06 +02:00
Robin Gareus acd95215a4 allow to scan for half-duplex ALSA devices 2015-06-14 22:26:06 +02:00
Robin Gareus 94c146c780 prepare ALSA backend for half-duplex 2015-06-14 22:26:06 +02:00
Robin Gareus 573ec69a9a probe buffersize if jackd is already running. 2015-06-14 18:10:31 +02:00
Robin Gareus b86a8edcff NOOP, reindent code. 2015-06-13 22:05:29 +02:00
Robin Gareus c8e16998bf fix crash on OSX displaying MIDI sysex, or similar text. 2015-06-13 22:04:31 +02:00
Paul Davis cc543280d9 We were 2 more debug "bits" away from overflow, so recast PBD::DEBUG mechanism away from a 64bit integer and toward std::bitset.
Clean up a few minor related PBD::DEBUG issues along the way
2015-06-12 18:14:09 -04:00
Paul Davis 10643779b6 more refactoring of WaveView threaded code to try to get to heart of crash bug 2015-06-11 17:04:08 -04:00
Paul Davis 077e625734 don't queue a callback with the idle event for waveview image generation if one is already queued.
Also, hold relevant lock when waking image rendering thread.
2015-06-11 13:35:01 -04:00
Paul Davis ceb3c38090 comment tweak 2015-06-11 13:35:01 -04:00
Robin Gareus 97de6efe5d fix transport loop sub-state events
Loading a session with a loop-range, or setting
a loop-range adds LoopDeclick events.
Normal play back (no loop) never processes/clears the events.
Ardour was constantly doing split cycles for nothing.

This lead to stuck midi-notes: Split cycle calls
increment_global_port_buffer_offset() but the midi_diskstream
itself was not aware of any loop positions or offsets.

Entering loop playback adds those events explicitly
in Session::set_play_loop(). auto_loop_changed() only
needs to add/replace session-events when actively looping.
2015-06-11 15:08:22 +02:00
Paul Davis 753d1ac392 possible fix for crashes related to vanishing waveviews (and if it doesn't fix anything, it is still more correct than it was) 2015-06-10 22:26:58 -04:00
Paul Davis 59dc0881fb remove left-over debugging code 2015-06-10 22:04:20 -04:00
Paul Davis ac2b0a327c fix basic error with computation of partial image width; add use of DEBUG_TRACE (DEBUG::WaveView,...) 2015-06-10 18:48:12 -04:00
Paul Davis 1c6c9e95ba add PBD::DEBUG::WaveView 2015-06-10 18:48:12 -04:00
Paul Davis 9edd8d4b3b no Save-As progress dialog if we're not copying media 2015-06-10 18:48:12 -04:00
nick_m 392f48709c Magnetic snap now works on note moves / resizes. 2015-06-11 02:20:37 +10:00
nick_m b3a4c88e0e Make absolute snap the default snap.
- also fixes a couple of absolute snap bugs wrt midi notes.
2015-06-11 01:36:34 +10:00
Robin Gareus 9563e75cca hide the aggregate device, again
further amends to 17453ec debugging.
2015-06-10 03:00:00 +02:00
Robin Gareus df840cec13 undo debug (17453ec) info.
The problem was: OSX i386 builds used --dist-target=leopard
which forced the deprecated 10.5 CoreAudio API.
(build-host config has been changed now).

There is currently insufficient support in ardour’s
CoreAudioPCM::create_aggregate_device() for the old API,
COREAUDIO_108 needs to be defined or aggregate devices stop
working on OSX 10.8 or later.
2015-06-10 02:46:10 +02:00
Robin Gareus aad43bce4a fix video-image request, zoom before video start. 2015-06-09 23:26:43 +02:00
Robin Gareus 9a8d5583f4 fix OSX optimized builds (NDEBUG) 2015-06-09 22:24:46 +02:00
Robin Gareus 17453ec855 debug aggregate device issue - i386/10.8 only 2015-06-09 21:34:16 +02:00
Robin Gareus 70a0ee504c coreaudio: initialize [output] variable.
possible fix for 32bit/10.8,
AudioObjectGetPropertyDataSize error
2015-06-09 19:18:59 +02:00
John Emmas 7a966c81bd Don't close OSC server sockets explicitly (the subsequent call to 'lo_server_free()' will close the socket anyway) 2015-06-09 16:25:20 +01:00
John Emmas 801af5df9e Add the new (UINTSDEFINED) preprocessor directive to all out MSVC projects (just to be on the safe side) 2015-06-09 13:18:42 +01:00
John Emmas f33c8aeb33 Add a new preprocessor directive (UINTSDEFINED) which is rather annoyingly needed if liblo gets built with MSVC 2015-06-09 12:09:21 +01:00