13
0
livetrax/gtk2_ardour/processor_selection.h
Robin Gareus a07bd2d585 Make static analysis happy..
If the copy c'tor of ProcessorSelection was actually used,
assigning the XMLProcessorSelection
    processors = other.processors;
would lead to duplicate free() of the XMLNode*
XMLProcessorSelection would need a dedicated copy c'tor that
duplicates allocates a new XMLNode.
see also #10 at https://www.viva64.com/en/b/0540/

Anyway, the copy c'tor and assignment is never used. This commit makes
this explicit.
2017-11-23 11:29:07 +01:00

87 lines
2.0 KiB
C++

/*
Copyright (C) 2004 Paul Davis
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
#ifndef __ardour_gtk_processor_selection_h__
#define __ardour_gtk_processor_selection_h__
#include <vector>
#include "pbd/signals.h"
#include "pbd/xml++.h"
class XMLProcessorSelection {
public:
XMLProcessorSelection() : node (0) {}
~XMLProcessorSelection() { if (node) { delete node; } }
void set (XMLNode* n) {
if (node) {
delete node;
}
node = n;
}
void add (XMLNode* newchild) {
if (!node) {
node = new XMLNode ("add");
}
node->add_child_nocopy (*newchild);
}
void clear () {
if (node) {
delete node;
node = 0;
}
}
bool empty () const { return node == 0 || node->children().empty(); }
const XMLNode& get_node() const { return *node; }
private:
XMLNode* node;
};
class ProcessorSelection : public PBD::ScopedConnectionList, public sigc::trackable
{
public:
ProcessorSelection () {}
XMLProcessorSelection processors;
sigc::signal<void> ProcessorsChanged;
void clear ();
bool empty();
void set (XMLNode* node);
void add (XMLNode* node);
void clear_processors ();
private:
ProcessorSelection& operator= (const ProcessorSelection& other);
ProcessorSelection (ProcessorSelection const&);
};
bool operator==(const ProcessorSelection& a, const ProcessorSelection& b);
#endif /* __ardour_gtk_processor_selection_h__ */