13
0
Go to file
Robin Gareus 84c51a1411
Fix BaseUI x-thread signal vs thread-start race
Control surfaces c'tor usually subscribe to signals e.g.
PortConnectedOrDisconnected. This happens after the parent BaseUI
is created, but before set_active() -> BaseUI::run() is called.

At this point in time there is no run_loop thread.

There are two options to handle AbstractUI::call_slot():

 A. Queue the event in the event-loop, using the thread-local
    request buffer of the caller. Then hope the BaseUI
    thread is started, and calls ::handle_ui_requests() before
    the memory pool runs out of space.

 B. Handle the event in the calling thread. -- This may not be
    rt-safe and may call functions with locks held by the caller.
    It will however not accumulate events.

This takes approach (B). If _run_loop_thread is NULL, directly
handle the signal.

In the past, prior to 50abcc74b5, approach (A) was taken.
NULL never matched Glib::Threads::Thread::self().

This also reverts a prior attempt (e417495505) to address this issue.
2022-03-02 21:19:12 +01:00
doc Update source-tree layout 2022-02-03 14:47:24 +01:00
gtk2_ardour Don't allow dropdown scroll for patch-banks 2022-03-02 18:26:23 +01:00
headless
libs Fix BaseUI x-thread signal vs thread-start race 2022-03-02 21:19:12 +01:00
luasession
msvc_extra_headers
MSVCardour3
MSVCMixbus3
MSVCvst_scan
nutemp
session_utils
share Rename file extension to get Akai MPK249 map to be picked up by waf 2022-03-01 23:11:46 +01:00
tools Fix bundling 3rd party content with windows binaries 2022-03-01 04:14:20 +01:00
.dir-locals.el
.gitattributes
.gitignore
ardour.1
COPYING
instant.xml.sae
msvc32-fixup.pl
nutempo-todo
PACKAGER_README
README
README-GITHUB.txt
system_config
testfile.flac
testfile.ogg
TRANSLATORS
waf
wscript

Please see the Ardour web site at https://ardour.org/ for all documentation..

For information on building ardour: 
      
     https://ardour.org/development.html