ardour/livetrax
13
0
Fork 0
Code
37243ce61b
livetrax/libs/surfaces
History
Robin Gareus 72db091619
Fix crash at exit with classic Faderport 
FaderPort::~FaderPort () can be called while
FaderPort::map_gain() is called from FaderPort::periodic()

```
Thread 71 Crashed:
0      libardour_faderport.dylib          	0x0000000110539c3a ArdourSurface::FaderPort::map_gain() + 138
1      libardour_faderport.dylib          	0x000000011053996d ArdourSurface::FaderPort::periodic() + 109
2      libglibmm-2.4.1.dylib                  	0x000000010bf21da8 Glib::TimeoutSource::dispatch(sigc::slot_base*) + 56
3      libglibmm-2.4.1.dylib                  	0x000000010bf20c97 Glib::Source::dispatch_vfunc(_GSource*, int (*)(void*), void*) + 39
4      libglib-2.0.0.dylib                      	0x000000010c012496 g_main_context_dispatch + 326
5      libglib-2.0.0.dylib                      	0x000000010c01281a g_main_context_iterate + 474
6      libglib-2.0.0.dylib                      	0x000000010c012b3f g_main_loop_run + 191
7      libpbd.dylib                                    	0x000000010bcee42e BaseUI::main_thread() + 254
8      libglibmm-2.4.1.dylib                  	0x000000010bf16373 (anonymous namespace)::call_thread_entry_slot(void*) + 35
9      libglib-2.0.0.dylib                      	0x000000010c03dd0a g_thread_proxy + 90
10    libsystem_pthread.dylib              	0x00007fff759e42eb _pthread_body + 126
11    libsystem_pthread.dylib              	0x00007fff759e7249 _pthread_start + 66
12    libsystem_pthread.dylib              	0x00007fff759e340d thread_start + 13
```

While the GUI thread has already closed the MIDI ports in ~FaderPort
and proceeded to take down the FP GUI.

```
Thread 0:: Dispatch queue: com.apple.main-thread

47    libgtkmm-2.4.1.dylib                    	0x000000010ca69a56 Gtk::ComboBox::~ComboBox() + 22
48    libardour_faderport.dylib          	0x000000011055a6e5 ArdourSurface::FPGUI::~FPGUI() + 149
49    libardour_faderport.dylib          	0x000000011055a8b5 ArdourSurface::FPGUI::~FPGUI() + 21
50    libardour_faderport.dylib          	0x0000000110551396 ArdourSurface::FaderPort::tear_down_gui() + 70
51    libardour_faderport.dylib          	0x0000000110536507 ArdourSurface::FaderPort::~FaderPort() + 535
52    libardour_faderport.dylib          	0x0000000110536b9e ArdourSurface::FaderPort::~FaderPort() + 14
53    libardour.dylib                              	0x000000010ac13f08 ARDOUR::ControlProtocolManager::drop_protocols() + 168
54    libardour.dylib                              	0x000000010b0ba7e4 ARDOUR::Session::destroy() + 212
55    libardour.dylib                              	0x000000010b0bbe01 ARDOUR::Session::~Session() + 113
56    libardour.dylib                              	0x000000010b0bdb5e ARDOUR::Session::~Session() + 14
2021-04-07 02:25:52 +02:00
..
cc121 Update Ctrl-surface MIDI port list when ports change 2021-02-04 06:19:37 +01:00
contourdesign Fix --no-nls, i18n include order in libs -- #8361 2020-08-19 17:39:32 +02:00
control_protocol control surfaces: make methods used for transport control (BasicUI) do the right thing w.r.t. default speed 2021-02-12 09:36:52 -07:00
faderport Fix crash at exit with classic Faderport 2021-04-07 02:25:52 +02:00
faderport8 Update Ctrl-surface MIDI port list when ports change 2021-02-04 06:19:37 +01:00
frontier surfaces transport hotfix: surfaces should query the transport state via BasicUI, when possible 2020-02-23 09:02:25 -06:00
generic_midi MSVC changes to support the new code modules (Tabbable API stuff) 2021-02-24 14:32:23 +00:00
launch_control_xl Update Ctrl-surface MIDI port list when ports change 2021-02-04 06:19:37 +01:00
mackie MSVC changes to support the new code modules (Tabbable API stuff) 2021-02-24 14:32:23 +00:00
maschine2 Maschine Mikro MK2 support 2021-04-01 20:07:55 +02:00
osc OSC: fix some compiler warnings 2021-02-28 20:01:06 +01:00
push2 Update Ctrl-surface MIDI port list when ports change 2021-02-04 06:19:37 +01:00
tranzport surfaces transport hotfix: surfaces should query the transport state via BasicUI, when possible 2020-02-23 09:02:25 -06:00
us2400 Update Ctrl-surface MIDI port list when ports change 2021-02-04 06:19:37 +01:00
websockets WebSockets: log hostname and listen-port 2020-11-23 20:12:57 +01:00
wiimote surfaces transport hotfix: surfaces should query the transport state via BasicUI, when possible 2020-02-23 09:02:25 -06:00
wscript Add websockets surface module 2020-02-22 23:10:24 +01:00