Tim Mayberry
b074ff0dd5
Currently when a GhostRegion is deleted by its "parent" RegionView it emits the static GhostRegion::CatchDeletion signal which is connected to the RegionView::remove_ghost method of every RegionView instance. With a static GhostRegion::CatchDeletion signal a particular test session causes 31 Million calls of RegionView::remove_ghost on Session deletion and the session takes 70 seconds to close with a debug build. The lifetime of a ghost region is tied to both the TimeAxisView(TAV) and RegionView(RV) in that when a RegionView is deleted all GhostRegion instances associated with the RegionView should be deleted or when a TimeAxisView is deleted all ghost regions that are contained in the view should be deleted. This means that there needs to be notification between GhostRegion and both classes. Instead of using a signal for this as we know there are only two listeners and GhostRegion already holds a reference to the TimeAxisView, also take a reference to the parent RegionView in the GhostRegion constructor and use it to notify the RegionView when GhostRegion destructor is called so it can drop any references it holds. Using a direct function call in the GhostRegion destructor to notify the TimeAxisView and RegionView "parents" brings the unload/close time down for the test session from 70 seconds to 4.5 seconds. The GhostRegion also references canvas items that are added to the TimeAxisView canvas group or at least a canvas group that it manages. So when the TimeAxisView is destroyed and the canvas group that is the parent of those items is destroyed, the GhostRegion's canvas items will also be deleted/destroyed by the parent canvas item/group. This means the GhostRegions must be destroyed when the TimeAxisView they are contained in is destroyed or there will be dangling references to canvas items that have already been deleted and trying to delete them again will be bad.
127 lines
3.1 KiB
C++
127 lines
3.1 KiB
C++
/*
|
|
Copyright (C) 2004 Paul Davis
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
|
|
*/
|
|
|
|
#ifndef __ardour_gtk_ghost_region_h__
|
|
#define __ardour_gtk_ghost_region_h__
|
|
|
|
#include <vector>
|
|
#include "pbd/signals.h"
|
|
|
|
namespace ArdourCanvas {
|
|
class WaveView;
|
|
}
|
|
|
|
class NoteBase;
|
|
class Note;
|
|
class Hit;
|
|
class MidiStreamView;
|
|
class TimeAxisView;
|
|
class RegionView;
|
|
|
|
class GhostRegion : public sigc::trackable
|
|
{
|
|
public:
|
|
GhostRegion(RegionView& rv,
|
|
ArdourCanvas::Container* parent,
|
|
TimeAxisView& tv,
|
|
TimeAxisView& source_tv,
|
|
double initial_unit_pos);
|
|
|
|
virtual ~GhostRegion();
|
|
|
|
virtual void set_samples_per_pixel (double) = 0;
|
|
virtual void set_height();
|
|
virtual void set_colors();
|
|
|
|
void set_duration(double units);
|
|
|
|
guint source_track_color(unsigned char alpha = 0xff);
|
|
bool is_automation_ghost();
|
|
|
|
RegionView& parent_rv;
|
|
/** TimeAxisView that is the AutomationTimeAxisView that we are on */
|
|
TimeAxisView& trackview;
|
|
/** TimeAxisView that we are a ghost for */
|
|
TimeAxisView& source_trackview;
|
|
ArdourCanvas::Container* group;
|
|
ArdourCanvas::Rectangle* base_rect;
|
|
};
|
|
|
|
class AudioGhostRegion : public GhostRegion {
|
|
public:
|
|
AudioGhostRegion(RegionView& rv,
|
|
TimeAxisView& tv,
|
|
TimeAxisView& source_tv,
|
|
double initial_unit_pos);
|
|
|
|
void set_samples_per_pixel (double);
|
|
void set_height();
|
|
void set_colors();
|
|
|
|
std::vector<ArdourCanvas::WaveView*> waves;
|
|
};
|
|
|
|
class MidiGhostRegion : public GhostRegion {
|
|
public:
|
|
class GhostEvent : public sigc::trackable {
|
|
public:
|
|
GhostEvent(::NoteBase *, ArdourCanvas::Container *);
|
|
virtual ~GhostEvent ();
|
|
|
|
NoteBase* event;
|
|
ArdourCanvas::Item* item;
|
|
};
|
|
|
|
MidiGhostRegion(RegionView& rv,
|
|
TimeAxisView& tv,
|
|
TimeAxisView& source_tv,
|
|
double initial_unit_pos);
|
|
|
|
MidiGhostRegion(RegionView& rv,
|
|
MidiStreamView& msv,
|
|
TimeAxisView& source_tv,
|
|
double initial_unit_pos);
|
|
|
|
~MidiGhostRegion();
|
|
|
|
MidiStreamView* midi_view();
|
|
|
|
void set_height();
|
|
void set_samples_per_pixel (double spu);
|
|
void set_colors();
|
|
|
|
void update_range();
|
|
|
|
void add_note(NoteBase*);
|
|
void update_note (NoteBase*);
|
|
void remove_note (NoteBase*);
|
|
|
|
void clear_events();
|
|
|
|
private:
|
|
|
|
MidiGhostRegion::GhostEvent* find_event (NoteBase*);
|
|
|
|
typedef std::list<MidiGhostRegion::GhostEvent*> EventList;
|
|
EventList events;
|
|
EventList::iterator _optimization_iterator;
|
|
};
|
|
|
|
#endif /* __ardour_gtk_ghost_region_h__ */
|