13
0
Commit Graph

14325 Commits

Author SHA1 Message Date
f715edf7bc
Yet Another Splash Push/Pop Fix
Don't explicitly `show()` the splash when a message arrives.
On macOS and Windows the splash is not z-axis re-stacked but
hidden. Calling show() makes it visible again.
2021-06-28 15:52:32 +02:00
537b8ff12d fix crash when context-clicking on a region/source cue marker 2021-06-27 22:13:54 -06:00
fe6e3615c7 changes to performance meter update code to allow for i18n 2021-06-27 13:32:46 -06:00
cce703bc9a
Resolve microseconds_t ambiguity #3 2021-06-27 17:49:31 +02:00
bcab07af63
Resolve microseconds_t ambiguity 2/2 2021-06-27 17:33:06 +02:00
6077cf1f7b Playlist UI Tweaks: only trigger playlist changes on a user-selection, not libardour
* avoid redundant updates when the user selects a playlist
* every track potentially has a playlist selector so avoid recursive updates
2021-06-27 09:54:06 -05:00
31a2d6f555 window compilation fix 2021-06-26 19:09:07 -06:00
6b6114eb75 GUI fix for get_microseconds() move to libpbd 2021-06-26 18:27:54 -06:00
83b9ab1bee
Temporarily revert ongoing varispeed development
This reverts bf88f3fe64
until 35813db0f4

in order to move development into a branch, until after the
upcoming 6.8 release
2021-06-26 18:58:24 +02:00
35813db0f4 Default_Play_Speed: add color for blinking varispeed label to themes 2021-06-25 11:51:35 -05:00
3454a34ba4 Default_Play_Speed: change some speeds from assuming "1.0" to "default_speed" (gtk part) 2021-06-25 11:51:35 -05:00
5b8835483e Default_Play_Speed: simple varispeed GUI 2021-06-25 11:51:34 -05:00
af19e1e7e7 Default_Play_Speed: nuke shuttle Wheel mode (gtk part) 2021-06-25 11:51:34 -05:00
b4eba1a30b Default_Play_Speed: prep work (gtk2)
* request_transport_speed should -never- set default_play_speed
2021-06-25 11:51:34 -05:00
838279c5e8
Fix C++11ism, enums are not classes in C++98 2021-06-24 18:14:06 +02:00
68e3d3d672
Fix endless loop if port-handle is n/a #8760 2021-06-24 17:20:44 +02:00
944eae53e6 Add a Midi port per Midi Tracer window that can be connected to for debugging. 2021-06-23 17:54:58 -05:00
6f251f8b2f Fix Midi Tracer handling of different port types
Transport Masters and Async MIDI port already have a parser available, so
just connect to it.

Normal Midi ports are the only one that need to use the Midi Tracers parser.
2021-06-23 17:54:58 -05:00
8237add6d2
Keep track of splash visibility behind dialogs
This fixes various issues, esp on macOS and Windows where
the window is only hidden, not re-stacked:

* plugin scan dialog hides the splash, but
  the plugin-manager emits BootMessage
  (this worked mostly because gtk event loop didn't
  have time to catch up)

* More than one dialog can pop back/front the splash,
  e.g. scripted session-setup or error messages when
  loading recent sessions.
2021-06-23 17:55:01 +02:00
da8e4da34f
Never say never 2021-06-23 01:02:23 +02:00
3b1c52dbd0
Override Ubuntu global menu
This causes a crash in libappmenu-gtk-module.so
-> gtk_widget_get_toplevel() and apart from that breaks
ardour's layout with status-bar at the top.
2021-06-21 05:23:01 +02:00
45bd2c47d8 Brush Drag: refactor Brush-drag into its own Drag class (operation is still weird though) 2021-06-17 10:56:30 -05:00
69af0e6964 Abort a copy-drag in the case where it would result in a copy at the same location
also code cleanup: clear_draggingview_list() avoids duplicated code
2021-06-17 10:56:30 -05:00
87ecc9b4ca Slip Contents Drag: fix undo 2021-06-17 10:56:30 -05:00
295d9100ec Slip Contents Drag: slip_contents should obey edit_mode:Locked, and locked regions 2021-06-17 10:56:30 -05:00
f281e7e3c3 Slip Contents Drag: disambiguate Slip Contents from prior Contents Trim 2021-06-17 10:56:30 -05:00
3d8bccb508 Slip Contents Drag: remove ContentsTrim modifier from the region boundaries
*now that you can grab "anywhere" in the region, trim edges are inferior because they are hard to hit
*modifier had to change anyway (since CTRL is used as a copy-drag on both mac and win), so that invalidates prior muscle memory
*potentially frees up modifier on the trim edge for some other purpose (anchored_trim)
2021-06-17 10:56:27 -05:00
fea3fb9e71 Slip Contents Drag: add ContentsDrag 2021-06-17 10:56:22 -05:00
5e1e55c982 use UTF8 lower-left corner chars in performance meter to indicate nesting of values 2021-06-16 19:29:03 -06:00
4efe5b7ada continued tweaks for perf meters (including show average and dev in tooltip) 2021-06-15 14:03:55 -06:00
c62b6e0e3e Control Points should not obey Lock Edit, which was intended to lock regions and notes at the time where they were recorded.
Control Points should ignore x_constraint which is set in Drag::motion and potentially other places.
The only thing that should prevent CP sliding is can_slide which is false for the points at the ends of a region.
2021-06-14 11:51:16 -05:00
6553d5adfc small tweak to perf display if timing stats are not available 2021-06-13 18:35:33 -06:00
86e00471d9 use library function to reset meters 2021-06-13 12:21:21 -06:00
86325ef89b perfmeters: adjust sizing 2021-06-13 11:21:59 -06:00
3df49bad7d performance meters: worst case for all 2021-06-13 11:05:19 -06:00
56d9d5376c continued tweaks to DSP performance meters window 2021-06-13 10:28:51 -06:00
e1495100a8 continuing work on presenting useful data in perf meter window 2021-06-12 15:00:46 -06:00
434bd2486e start showing some DSP stats in the perf meter window
Lots of work to be done to decide what data to show and how to best present it
2021-06-12 09:20:58 -06:00
Edgar Aichinger
f81d3ce333
minor german translation update 2021-06-12 15:14:43 +02:00
John Emmas
87e295fc7e Add MSVC support for the upcoming dsp stats window 2021-06-12 10:42:27 +01:00
a47348f2a2 integration of new dsp stats window with window proxy system, part 3 2021-06-11 21:17:44 -06:00
081c2525fd integration of new dsp stats window with window proxy system, part 2 2021-06-11 21:10:20 -06:00
dcee5067f5 integration of new dsp stats window with window proxy system 2021-06-11 21:07:47 -06:00
51df20796b skeleton for dsp stats window 2021-06-11 21:02:06 -06:00
78738ec5a1 skeleton for DSP stats GUI 2021-06-11 18:55:25 -06:00
0f6b9e759c fix out-of-order initialization 2021-06-11 18:55:24 -06:00
11798f7e86 fix crash caused by not explicitly deleting the line component of a Marker (#8737) 2021-06-11 10:24:49 -06:00
d5d9800738
Improve CPU/DMA tooltip, add warning if device isn't writable 2021-06-11 00:02:45 +02:00
e22720f59a
Offer DMA latency matching state transitions for the given CPU 2021-06-10 23:42:48 +02:00
5af30601a9
Update CPU-DMA preference note 2021-06-10 20:22:12 +02:00
f37ad624f6
Fix crash on session-reload or close (amend 1c9bb9ab41)
RouteUI is also used in the recorder-ui and meterbridge,
not all of which call RouteUI::init() since only the abstraction
itself is required.
2021-06-10 05:14:58 +02:00
88e85fcd17
Add preference option to set CPU DMA Latency 2021-06-10 04:30:10 +02:00
cc104d3fd3 Playlist UI tweaks: bugfix: mapover_groupd_routes should include the basis route (but only once) 2021-06-08 12:43:26 -05:00
c46410a1b0 MIDI region extend-selection should select all after start of selection, not all after end of selection 2021-06-08 08:31:41 -06:00
11cb981e30 add extend_selection() to MIDI region bindings; expose invert-selection also 2021-06-08 07:40:54 -06:00
f4d4dddbeb Paste Mode: overwrite-paste, naive implementation using rec-mode (for testing) 2021-06-08 08:33:48 -05:00
7cc92d8f27 Playlist UI tweaks: add global playlist buttons to Rec page (tentative, for testing) 2021-06-08 08:33:48 -05:00
e63dc0eb29 Playlist UI tweaks: move pgroup_id out of the menu text, and into a column of the playlist selector 2021-06-08 08:33:48 -05:00
1c9bb9ab41 Playlist UI tweaks: refactor PlaylistSelector (life-cycle, code-cleanup)
* You can now show a selector for each track, rather than one global dialog
* Removed the 'cancel' button: it was too easy to unintentionally revert your selection
* Correctly sort and name new playlists when they are added or renamed from the P menu
* Fix problem where list contents disappeared when changing desktops (on_unmap_event)
2021-06-08 08:33:48 -05:00
285101d88c Cruft removal: behavior of Region List no longer needs these functions (gtk part) 2021-06-08 08:33:48 -05:00
1665d0e1bc Playlist UI tweaks: add Actions and menu items for global plist functions 2021-06-08 08:33:48 -05:00
a8395718bc Playlist UI tweaks: rationalize playlist functions in Editor::
* new global playlist functions for {all | rec-armed | selected} tracks.
* new API passes (bool copy) arg instead of separate functions for copy_X.
* consistently use mapover_X functions to consolidate code
* update Lua bindings to match
2021-06-08 08:33:48 -05:00
cf999ecaa9 Playlist UI tweaks: clarify purpose of get_region{view}s_corresponding_to 2021-06-08 08:33:48 -05:00
4484b60b13 Revert "extend API of ARDOUR_UI_UTILS::emulate_key_event() to allow it to pass modifiers too"
No need to extend/change this API, since relay_key_press() can already take a window argument.

This reverts commit 2e0fa8943a.
2021-06-06 08:11:26 -06:00
66264eb68f use existing API for key forwarding 2021-06-06 08:11:13 -06:00
b03c8e7849 add key forwarding to playlist selector dialog 2021-06-06 08:06:11 -06:00
2e0fa8943a extend API of ARDOUR_UI_UTILS::emulate_key_event() to allow it to pass modifiers too 2021-06-06 08:05:59 -06:00
032aceff28
Remove custom generic plugin UIs (a-eq) 1/2
Mostly a failed experiment, that also does not play well with
themes. Superseded by Harrison's ACE-EQ GUI.
2021-06-04 01:43:01 +02:00
6e72232636 Playlist UI tweaks: revert to generic Gtk terms on dialog 2021-06-01 17:55:09 -05:00
70529c0b56 Playlist UI tweaks: renaming a plist should apply to all plists created in that group 2021-06-01 17:55:09 -05:00
b339d083a8 Playlist UI tweaks: relax requirement that playlists have a discrete name, and use pgroup for organization instead 2021-06-01 11:59:13 -05:00
25786ac130 Playlist UI tweaks: change sort order to use pgroup when one is available 2021-06-01 09:39:50 -05:00
32bf85502f Playlist UI tweaks: annotate grouped playlist actions with '(for group)' rather than the overloaded term 'take' 2021-06-01 09:39:50 -05:00
561aef3736 Playlist UI tweaks: always prompt the user for a new playlist name, not just for grouped playlists 2021-06-01 09:39:50 -05:00
892d641987 Playlist UI tweaks: Add (select, share, copy, steal) operations to the playlist selector (under Advanced... menu)
Use the same sorting for the menu list and playlist_selector items
Implement Copy, Share and Steal playlist actions. Need a RouteTimeAxis for this.
Rename persistent dialog buttons to make it clear you can Revert
2021-06-01 09:39:39 -05:00
Nikolaus Gullotta
a51e51b4f2 Playlist UI tweaks: Update PlaylistSelector (gtk2_ardour part)
Window is now no longer modal
Subscribes to new Track::PlaylistAdded signal
Move RouteUI setting to new dedicated method
Rename show_for to show
Hide PlaylistSelector if DropReference signal is emitted
2021-06-01 09:16:41 -05:00
8af5f1df02 Selecting a playlist is not currently an undo-able action. Stop trying to make an undo record for it. 2021-06-01 09:14:07 -05:00
cc60b3b8d5 Fix use of uninitialized variable (Wsometimes-uninitialized) 2021-05-30 20:17:45 -04:00
74e21e942e Remove unused variables (Wunused-variable) 2021-05-30 20:09:35 -04:00
aae8252341
Fix engine-dialog MIDI Dropdown issue
Sensitivity is managed by EngineControl::update_sensitivity,
prior settings in update_midi_options() were ignored.

This also fixes the layout (MIDI dropdown width) and midi-option
value when changing backends.
2021-05-30 18:54:00 +02:00
adcc5be728 Retain devices when device list changes
EngineControl::device_list_changed calls
list_devices, which clears and refills the
I/O dropdown. This resulted in changed callbacks
EngineControl::input_device_changed which in turn
unsets the device in the backend:
set_input_device_name("").

The I/O devices were reset (use first available).
2021-05-29 17:54:39 +02:00
51d57a3fb6 Source and Region list: fix disappearing list items (break out of the loop instead of returning, so the list always gets thawed) 2021-05-28 18:51:35 -05:00
537d44e3ae Track selection as a side-effect of a Range selection should obey group->selection property 2021-05-28 18:51:22 -05:00
b17629bddf implement option to move markers during a "remove gaps" operation 2021-05-28 17:43:33 -06:00
pafri
ac1fd6d448
Update cs.po
I've completed (100 %) the translation file. Please commit it. Greetings, Pavel Fric
2021-05-29 00:30:42 +02:00
Porrumentzio
1bce8b57d4
Updated Basque translation 2021-05-29 00:27:07 +02:00
2cf0e94d16 code cleanup of Editor::remove_gaps() (removing functionality derived from copy-n-paste of insert-time) 2021-05-28 13:44:39 -06:00
bbcdd959bf dialog for remove gaps operation 2021-05-28 13:44:39 -06:00
6b09ea42f1
Loudness conformity UTF8 font compatibility for macOS 2021-05-28 21:02:26 +02:00
d0f94dd63d add "remove gaps" editing operation
Like the libardour functionality it uses, this likely needs work to properly deal with the
intended cross-track workflow
2021-05-28 12:36:17 -06:00
cd7c10c902 implement working undo/redo for region/cue marker operations 2021-05-27 17:17:40 -06:00
3bfb01a77b improved logic for Editor::add_region_marker() 2021-05-27 17:17:40 -06:00
270b043e8f
Minor code cleanup 2021-05-27 01:03:08 +02:00
c444a81f1a offer alternative region marker "promotion" method to CD marker (rather than just global marker) 2021-05-25 14:10:36 -06:00
8774740e72 add action to "promote" region cue markers to global marks 2021-05-25 14:01:30 -06:00
232af15b51 fix position of region cue markers during drag and after when region position is not zero 2021-05-25 14:01:30 -06:00
54e0b7f230 renaming cue markers (via dbl-click) 2021-05-24 20:23:06 -06:00
6277419673 Rulers: do not trigger ruler auto-display when only selecting between bbt subdivisions (#8717)
Also remove 'nonmusical' construct which was a convoluted way
 to handle GridNone when determining how to draw grid lines.
2021-05-24 16:45:42 -05:00
ab2357dfa1 implement dragging for region/cue markers 2021-05-24 12:28:19 -06:00
2016710865 skeleton for RegionMarkerDrag 2021-05-24 09:12:19 -06:00
63ef9bdb9e Revert "hide region marker actions in menus"
This reverts commit b2ca7ac01e.
2021-05-23 21:27:54 -06:00
f1fe1c7066
Amend 445f9a51bf 2021-05-23 23:22:18 +02:00
65afd57856
Remove debug message 2021-05-23 22:23:27 +02:00
445f9a51bf
Fix ripple undo/redo
Ripple edit undo/redo needs a "recursive diff" of all regions
in the playlist. To work properly owned changes have to be
cleared first, previously unrelated edits were be collected too.

This includes a more consistent version of
7a89d56009 using rdiff() instead of explicitly
saving region diffs.
2021-05-23 17:42:33 +02:00
31bbf03a67
NO-OP: always use braces (styleguide #4) 2021-05-23 17:37:28 +02:00
fd3220c3d7
Set uninitialized variable (fix playhead dragging) 2021-05-21 17:57:56 +02:00
5fdbd71d89 Fix bounced file+region names: concatenating all the names was a bad idea. (gtk part) 2021-05-20 11:42:48 -05:00
a8561d531f adjust preferences label for "rewind/ffwd like a tape deck" 2021-05-19 18:54:41 -06:00
b2ca7ac01e hide region marker actions in menus 2021-05-19 16:32:20 -06:00
159fa49dbb change chat URL to one that redirects via ardour.org 2021-05-19 15:49:50 -06:00
ad69a564a0 Revert "come to a complete stop if rewind/ffwd steps past -40 semitones slower"
This reverts commit 05ef7f2647.

This stopping behavior was not satisfactory. The behavior after this revert is not great, but better than the stop.
2021-05-18 22:59:22 -06:00
3047b25527 split out region marker actions to their own submenu; implement remove and clear all 2021-05-18 20:59:37 -06:00
9d865f241d
Prevent user from indirectly disabling LAN amp 2021-05-19 02:10:29 +02:00
b167e6f2ed fix crash when deleting a marker
the line (if non-null) is owned by the marker's group, and will be deleted when the group is
2021-05-18 18:02:22 -06:00
35a68ad324 remove unusued variables 2021-05-18 18:01:49 -06:00
60a972a7de implement region marker deletion 2021-05-18 18:01:38 -06:00
bd2d8b8c87 tweak Editor remove-marker APIs to set state for removing region cue markers 2021-05-18 16:50:55 -06:00
baee1a2f01 add API to make sure that region cue markers are above any waveviews or MIDI etc 2021-05-18 16:50:27 -06:00
b76991c00b reset region cue marker colors when colors change 2021-05-18 16:17:37 -06:00
eb8c25edce remove debug output 2021-05-18 16:17:37 -06:00
3713175bf1 allow user to set name for new region cue marker 2021-05-18 16:17:37 -06:00
1de3ba6cc2 try a tweak to region cue marker color 2021-05-18 16:17:37 -06:00
91ec860b3b redesign color mgmt when entering/leaving markers of various kinds 2021-05-18 16:17:37 -06:00
35022caf4f
Tweak record-time axis name edit #8712
This allow to use the entry context menu,
and also cancels edit when clicking outside of the entry
2021-05-18 22:24:56 +02:00
c9bc0ff578
Fix VST2 enter/return ambiguity -- thanks to falktx 2021-05-18 01:39:26 +02:00
ElizabethHarmon
0e0327b1cd
Update export_format_dialog.cc 2021-05-16 01:04:09 +02:00
689d33ddd5 get line for region markers functioning and visible 2021-05-14 18:37:50 -06:00
4151c22802 explicit color for region marks, and default to fully opaque 2021-05-14 18:37:50 -06:00
b4d7944750 place the line associated with markers in the cursor scroll group, so that it above everything else 2021-05-14 18:37:50 -06:00
3c1ffd1743 add line height API to Marker
This will allow region markers, which do not span the whole canvas height, to have a line
2021-05-14 18:37:50 -06:00
1685843082 global marker objects do not need a canvas height, so remove member and API to manage it
They extend (down) from an origin to COORD_MAX. The height is irrelevant
2021-05-14 18:37:50 -06:00
8859f76f48 new structure/design for managing visible cue markers 2021-05-14 18:37:50 -06:00
272b4f5cdc redraw region markers after a region color change 2021-05-14 18:37:50 -06:00
681b60463b fix color and position of region markers 2021-05-14 18:37:50 -06:00
822864e301 remove debug output 2021-05-14 18:37:50 -06:00
ea94a045ae update region markers after a regions bounds change (they may have moved) 2021-05-14 18:37:50 -06:00
f1390ca7f7 add (theoretical) undo-ability for region markers and use source API instead of region 2021-05-14 18:37:50 -06:00
82d502f67a avoid crash in RegionView constructors, caused by accessing _region too early 2021-05-14 18:37:50 -06:00
5c9626648c extra alpha modifier for use with region markers 2021-05-14 18:37:50 -06:00
738cdcc55c tweaks to ArdourMarker to enable it to be used for RegionCue markers 2021-05-14 18:37:50 -06:00
5ab6807710 NOOP: whitespace adjustment 2021-05-14 18:37:50 -06:00
a1c68460be add basic/initial code for action to add a region marker 2021-05-14 18:37:50 -06:00
297760885c add UI option to control region cue mark visibility 2021-05-14 18:37:50 -06:00
56857302f4 add cue markers to RegionViews 2021-05-14 18:37:50 -06:00
2b7ae1a79f
Use sub-menus for > 32 processor automation parameters 2021-05-14 16:47:46 +02:00
Edgar Aichinger
ffcf90eacb update german translation 2021-05-13 11:02:23 -06:00
084d7e221b centralize naming of a couple of context menus 2021-05-13 10:29:19 -06:00
fe5c56ecca remove pointless line of code
If _size_menu was non-null, we just return it. Ergo, it was already null when we reached
this line, which makes calling delete on it completely pointless
2021-05-13 10:29:19 -06:00
798b968610 do not test for gobj() being null when deciding if _size_menu exists
This test was added because of confusion about when/where dynamically constructed menus
were constructed and deleted. This should be consistent now, and this additional check
(on top of _size_menu itself being null) should be unnecessary
2021-05-13 10:29:19 -06:00
95c674e3be rationalize where a TimeAxisView::_size_menu is detached from its parent menu
This happens before the parent menu is deleted and rebuilt
2021-05-13 10:29:19 -06:00