13
0
Commit Graph

8024 Commits

Author SHA1 Message Date
e243d328a4 Fix a couple of issues when displaying the 'Preferences' dialog on Windows:-
1) When changing the 'Default folder for new sessions' we weren't responding to the appropriate signal (so the change wasn't getting saved in our user's 'config' file). We now respond to the 'selection-changed' signal.

2) If the above path happened to contain a tilde character we weren't interpreting it to mean the user's home folder. I've copied across a function called 'poor_mans_glob()' which Ardour uses elsewhere for dealing with this situation in other file dialogs.

Once we confirm that issue #2 is now working for all platforms, I'd suggest moving 'poor_mans_glob()' into libpbd. At the moment we have at least 3 definitions of it (all identical) scattered around in various places.
2015-03-09 15:57:15 +00:00
nick_m
4d66c6c1ab Add route dialog responds to enter key being pressed. 2015-03-10 02:27:40 +11:00
nick_m
44d4652995 Introduce theme preference "transients follow front" which, when enabled,
sets transient windows to be transients for the front window when switching
between the editor and mixer. This is the current behavior on non-osx
builds.
When disabled, there is no reparenting of transient windows. This is the
current behavior on osx.
This preference defaults to off.

Also fix "all windows are dialogs" checkbox being out of sync with the ui
state.
2015-03-10 02:25:25 +11:00
59f12bd31a fix ‘pure virtual’ crash at exit.
Finally tracked down.
AudioEngine::instance()->Halted.connect_same_thread() .. call_slot().
Since the calling thread has (eg JACK) has no event loop: crash

__cxa_pure_virtual + 18
PBD::EventLoop::invalidate_request(void*) + 61 (event_loop.cc:71)
sigc::trackable::notify_callbacks() + 63
BaseUI::~BaseUI() + 173 (base_ui.cc:64)
AbstractUI<Gtkmm2ext::UIRequest>::~AbstractUI() + 137 (abstract_ui.h:59)
Gtkmm2ext::UI::~UI() + 279 (gtk_ui.cc:131)
ARDOUR_UI::~ARDOUR_UI() + 3556
ARDOUR_UI::~ARDOUR_UI() + 21
ARDOUR_UI::~ARDOUR_UI() + 25
main + 2396  

at event_loop.cc:71
    Glib::Threads::Mutex::Lock lm (ir->event_loop->slot_invalidation_mutex());
print *ir->event_loop
    (PBD::EventLoop) $1 = {}

see  http://pastebin.com/zvWJbqwf for a call_slot call on OSX/Coreaudio.
2015-03-09 03:04:27 +01:00
c12b7bc9d8 explicitly shutdown engine at exit
Callbacks like EngineHalted or DeviceListChanged 
can be deadly while the UI is being torn down.
2015-03-09 01:41:34 +01:00
4100e1f7b7 Bundle API user update 2/2
cherry-pickable follow up to 0582221
2015-03-08 22:40:00 +01:00
90110c4308 allow to drag gain-envelope points 2015-03-08 20:18:50 +01:00
ba8b91679a fix typo, list output bundles properly. 2015-03-08 19:02:32 +01:00
1ad42b249b use pretty names in port-matrix
maybe this should be an option? So far it’s
the matrix only.. gotta start somewhere.

PS. No, this is not a new feature. Ardour not doing this
is a major bug that severely reduces usability:
system:midi_capture_47 WTF? ;-)
2015-03-08 19:02:31 +01:00
80bb72bbe2 fix drag-motion over TAV w/o view() 2015-03-08 03:42:33 +01:00
50041cb450 avoid non-integer loop conditions. 2015-03-08 02:01:48 +01:00
23a6526de7 remove unneeded debug output 2015-03-07 17:10:19 -06:00
f4e5f078af another 0cb096a fixup 2015-03-07 22:07:15 +01:00
49657dc56c more OSX weirdness fixes 0cb096a 2015-03-07 21:45:52 +01:00
de078a04e2 Fix LV2 preset deletion and clash between plugins.
Before this, LV2 preset deletion in Ardour was doubly broken: the wrong file
was being removed, and removing the correct file would only result in a broken
preset.  This change uses a new version of Lilv which has a more sophisticated
mechanism for preset deletion.

Also, fix "clashing" presets saved with the same name for different plugins, by
prefixing the plugin name to the bundle (this is now a recommendation in the
LV2 preset specification).
2015-03-07 14:54:03 -05:00
0cb096a978 Use Ardour widgets consistently in plugin UI.
Several reasons:

* This previously looked horribly inconsistent.

* The Gtk selector was broken for plugins with many presets,
  making it impossible to select presets.  For whatever reason,
  the use of a menu fixes this bug.

* Towards a hierarchical menu for banked presets.
2015-03-07 14:04:45 -05:00
7eb849ad21 Increase editable region alpha slightly.
Previously the region was nearly invisible when editable which is
problematic ("oops, I made a new region").  The distinction isn't quite as
profound as it probably should be, but I don't want to mess with the other
region colours too much.
2015-03-07 14:04:45 -05:00
dd6ee69ef8 engine dialog, update device is changed. 2015-03-07 14:35:33 +01:00
82e23ecd2a fix device changes..
backend_changed() stopped the backend.
2015-03-07 14:35:32 +01:00
c9a053c47a Hide automation state options for MIDI controls.
These don't do anything, except mislead the user into expecting this stuff
works like track automation.
2015-03-06 04:14:00 -05:00
818ed5fe12 update Engine Dialog when devices are dis/connected. 2015-03-06 06:24:56 +01:00
408090adce Add MIDI readahead to options editor. 2015-03-05 18:48:33 -05:00
a8aae56d92 Handle edits while playing precisely.
This avoids stuck notes if active notes are edited, but without stopping all
active notes in the region on any edit as before.

This implementation injects note ons in places that aren't actually note
starts.  Depending on how percussive the instrument is, this may not be
desired.  In the future, an option for this would be an improvement, but there
are other places where "start notes in the middle" is a reasonable option.  I
think that should be handled universally if we're to do it at all, so not
considering it a part of this fix for now.
2015-03-05 17:30:31 -05:00
f6f64d3f81 get started on coreaudio/midi backend 2015-03-05 16:46:20 +01:00
411c3ee70a possible fix for #6187 - assert(backend) 2015-03-01 16:48:14 +01:00
03229f4fe9 add AU cache/blacklist actions to prefs. 2015-02-28 15:52:28 +01:00
803a239310 MSVC - accommodate some newly introduced calls to 'rintf()'
('rintf()' isn't available in MSVC)
2015-02-28 13:01:02 +00:00
3c3586a4e1 AU presets: allow to save & directly use. 2015-02-28 08:04:14 +01:00
60bb5986e2 rework video-export dialog, remember settings 2015-02-28 02:38:18 +01:00
09e187630a VTL: add webm export-preset and amend 1184660. 2015-02-28 02:36:59 +01:00
c90400364a prepare saving video-export settings.
* migrate dialog from Editor to UI.
* make it a WM proxied window
* prepare applying state after construction..
2015-02-28 02:36:58 +01:00
c0411de949 video export: allow to use ffmpeg format-defaults 2015-02-28 02:36:58 +01:00
15f57d01cf video-export dialog: allow keyboard navigation 2015-02-28 02:36:58 +01:00
e77e7f1f3d fix carbon GUI focus/re-exposure 2015-02-27 19:43:36 +01:00
2249b98f53 cabron? 2015-02-26 19:51:30 +01:00
f4203cce7e Potential fix for confusion for Input/Output buttons on tracks with audio+midi ports 2015-02-25 17:19:44 -06:00
fbdf6a8151 recover the most recent audio setup settings from config 2015-02-24 14:29:02 -06:00
a0eeb80885 fix embedded plugin UI keyboard handling
When the GUI is opened the first time all is fine, focus is on the
embedded widget. However once a user presses one of the preset buttons
(Add, Save,...) there is no possibility to return focus to the
embedded widget. Ardour always 'sees' it as focus=GtkButton and passes
the event to the editor.
2015-02-21 03:16:04 +01:00
642e4950b9 hook up focus_button for LV2 GUIs 2015-02-21 03:00:33 +01:00
12ad41675d fix memory leak in case LV2 GUI fails. 2015-02-19 20:39:26 +01:00
b489385bf1 fix some static-analysis warnings 2015-02-19 20:37:58 +01:00
3f8583f8d6 stop dragged regions moving to the dropzone during autoscrolling towards the top track 2015-02-18 12:27:11 -05:00
dd8f2cfe18 fixes for non-overlapping fade in/out even in regions not at zero 2015-02-16 16:27:50 -05:00
6fd947fe82 Increase transparency of Loop rectangle so tempo lines are visible
Should fix bug#6163
2015-02-16 11:52:20 +10:00
ef99814f7a add john and todd to contributor list 2015-02-14 07:52:36 -06:00
5b3ff655f1 Fix LV2 UIs with spacey paths (e.g. Pianoteq). 2015-02-13 22:00:38 -05:00
cc7f9d7f46 fix up recent cherry-picks from waves' tracks 2015-02-13 17:08:25 -05:00
236f549caa insanely complex fixes for dragging to and from the drop zone.
This probably breaks some of ardour's functionality (e.g. layered mode), but seems to
be either just right or very close to it for tracks

Conflicts:
	gtk2_ardour/editor_routes.cc
2015-02-13 17:00:30 -05:00
8304471062 fix up recent cherry-picks from waves' tracks 2015-02-13 16:42:05 -05:00
6f98f91f18 prevent fade in/fade out on audio regions from overlapping each other 2015-02-13 16:22:08 -05:00