13
0
Commit Graph

11063 Commits

Author SHA1 Message Date
b5239317d4 more stuff compiles 2013-07-31 19:47:20 -04:00
4dc74ae2ea use zeroed scratch buffers for "silent" plugin runs
Plugins rewrite the buffer data in-place and some plugins
can produce output even when fed with silence.

Hence, during a PluginInsert::silence() run a plugin can
inject data into the "silent" buffers which causes side-effects.

Kudos to Chris 'oofus' Goddard for finding this issue.
2013-08-01 00:35:24 +02:00
f81cbe06ea tiny detail.. GUI-callback may try to check vmonitor->is_started() or issue a periodic seek update while it's going away 2013-07-31 20:19:57 +02:00
7a02d9e08d clean up some valgrid "Uninitialised value was created by a heap allocation" wanings 2013-07-31 19:29:20 +02:00
c7fcba77b8 correct error message 2013-07-31 19:29:15 +02:00
9993ac23ca fix close_allv() sentinel 2013-07-31 19:29:06 +02:00
bd92bfe643 valgrind ignore glib UTF8 warnings 2013-07-31 19:23:20 +02:00
bd65018d74 initialize two more uninitialized vars.. 2013-07-31 15:52:41 +02:00
ef0c4ed0e6 fix typo in c212c16eb 2013-07-31 15:24:46 +02:00
b5a2b4e84e initialize some uninitialized values 2013-07-31 15:22:51 +02:00
c212c16eb8 catch assert() 2013-07-31 15:17:22 +02:00
097d851730 LV2 - use scratch buffers to scratch :) 2013-07-31 14:45:02 +02:00
1c08b910f0 another amend to 00f26394a9 2013-07-31 14:21:40 +02:00
fbfa0acebe remove compile errors (still will not link and JACKPortEngine is not close to done) 2013-07-30 23:26:46 -04:00
e8dc221191 fix stupid copy/paste error in 00f26394a9 2013-07-31 02:00:31 +02:00
476da4f3df minimize meter-peak re-draw area 2013-07-31 01:59:50 +02:00
5e0c6af406 jack_audiobackend.cc finally compiles 2013-07-30 17:48:57 -04:00
ab7842edfd RMS meter: remove unused peak-detection 2013-07-30 20:22:31 +02:00
362976a2fd adjust meterbridge label-heigh options 2013-07-30 20:21:02 +02:00
d2d285724b add name-tooltips to the meterbridge meters 2013-07-30 18:28:06 +02:00
9b091a52cb clean up 44fc92c3 (not a threading issue but sigc++ problem)
RouteUI is not sigc::trackable itself (only derived classes are)
RouteUI::~RouteUI() does not disconnect from signals on destruction.
2013-07-30 17:54:52 +02:00
00f26394a9 use dedicated buffers for route (and track)
"scratch buffers are by definition scratch and their contents are undefined at all times"
"silent buffers are by definition all-zero and should not be used for real data"

But track & route were using those for actual data; plugins (which may run
in the same thread and may get the same buffers) use them for scratch thereby
overwriting real data.

In particular get_silent_buffers() (used by LadspaPlugin::connect_and_run)
clears the buffer which can holds real data:
e.g. via  Route::passthru_silence() -> plugin1 -> plugin2 (clears output of plugin1)
2013-07-30 16:55:33 +02:00
44fc92c33d disconnect AuxSend connection when deleting bus
fixes crash:
 - add bus
 - aux-send a signal to that bus
 - delete bus
 - add another bus
 - aux-send a signal to "another bus"
 - click "Aux Send" button on "another bus"
 - crash
2013-07-30 15:12:32 +02:00
a9691abf3b small steps toward getting this all working - add new JackConnection object to share jack_client_t between AudioBackend and PortEngine 2013-07-29 23:41:41 -04:00
4af022c7f6 Revert "fix issue with generator plugins and no-roll disk monitoring"
This reverts commit bd34ab04cd.
2013-07-30 03:02:45 +02:00
bd34ab04cd fix issue with generator plugins and no-roll disk monitoring 2013-07-30 02:27:06 +02:00
47ec32fa15 Merge branch 'clang-rebased' of https://github.com/axetota/ardour 2013-07-29 16:03:50 -04:00
Michael Fisher
6fd7ec3fc9 Return an empty string instead of a bool 2013-07-29 14:43:12 -05:00
Michael Fisher
cdc9d95e92 Cast param for std::time to a pointer of time_t
- bleeding clang (trunk 186535 v3.4) fails here
2013-07-29 14:43:12 -05:00
Michael Fisher
a8456b3766 Proper OSX/CLANG/CXX11 support in stl_delete.h
- replaces fix in 066df0d218
- Check if _LIBCPP_VECTOR is defined for vector_delete.
  This is defined in libc++'s headers which Apple is using
  instead of libstdc++
2013-07-29 14:43:11 -05:00
Michael Fisher
c442fea139 Housekeeping, code style 2013-07-29 20:05:11 +02:00
Michael Fisher
d391989444 Moving Mclk locating code to ticker.cc. Housekeeping 2013-07-29 20:05:11 +02:00
Michael Fisher
3538fa8442 Add method to send a song position pointer message 2013-07-29 20:05:11 +02:00
Michael Fisher
79d134ca78 Send a song position pointer with mmc and fullframe fake locating 2013-07-29 20:05:10 +02:00
Michael Fisher
20189330d1 Add relavent OSX midi options in the startup dialog
- MIDI driver options are now "None" and "coremidi" on OSX
- If coremidi is selected, jack will start with midi activated
- Requires Jack OSX version 0.90 beta 15 (or another version that
  supports midi
2013-07-29 20:05:10 +02:00
741bb8e7fb tweak meterbridge-label height 2013-07-29 20:02:57 +02:00
c934062403 change default BBC-meter color 2013-07-29 19:43:34 +02:00
059df390e6 fix compiler warning 2013-07-29 19:43:19 +02:00
7f4e13a2a5 use K-20 meter as default master bus 2013-07-29 19:43:05 +02:00
58f4d66899 add option to resize meterbridge track-labels 2013-07-29 19:42:41 +02:00
5cedc24517 explicitly re-init meter when theme changes.
fixes:
14:14 < oofus> rgareus: BBC meter colour changed, all meters
               except the one on the tool bar picked it up
2013-07-29 16:31:33 +02:00
3ab25dc6f3 change metric-scale on the sides of meterbridge when scrolling 2013-07-29 15:26:36 +02:00
2faaf71573 allow to configure color of BBC meter 2013-07-29 03:54:43 +02:00
60dde29038 left/right meter marks in mixer (narrow red-stripe) 2013-07-28 22:34:28 +02:00
a2ceba6fbe change default meter-fall-off to 13.3 dB/sec 2013-07-28 21:34:01 +02:00
893e26cc68 use 3px for peak-hold in LED mode -> display 2 bright lines 2013-07-28 21:24:27 +02:00
cbcde35376 fix diamond inheritance - gtkmm main class is sigc::trackable 2013-07-28 20:43:21 +02:00
cd28d62b26 fix compiler warnings. 2013-07-28 20:32:52 +02:00
d1c2d53afe tweak meter-LED style 2013-07-28 18:29:39 +02:00
Edgar Aichinger
4c1b0fcb2b update german translation for libardour
fixes x42's screwup with prev commit.
2013-07-28 16:50:26 +02:00