83d0892777
when drawing notes, the grid should be scaled to the zoom scale
...
this prevents the case where have enabled snap, and you add a note that
appears to be on a bar line. but actually it is {some Grid value} off,
it just looks right because of pixel rounding.
2022-05-11 11:45:33 -05:00
a60dfc19d2
take Snap enablement into account when drawing new notes
...
* snap_to_bbt assumes that snap is enabled and you want to snap to bbt
* snap_to() is the generic form to snap to the user's snap+grid settings
2022-05-11 11:38:54 -05:00
de9f18b4f9
when Drawing MIDI notes, enforce a minimum length
...
This fixes the issue where you click to create a note, but move the mouse
just a little, resulting in a note of invisibly small length
Do the calculation in ::motion so it displays the final
size while you are dragging. "what you see is what you will get"
2022-05-10 20:00:26 -05:00
5f6f01a8e2
fix trim_region_to_{loop|punch} ... coverage logic was reversed
2022-05-10 15:47:56 -05:00
764aa75f09
reset_region_scale_amplitude is redundant with reset_region_gain
2022-05-10 15:47:56 -05:00
62fd8ecd35
crop_region_to_selection: remove redundant check for a Range
...
get_edit_op_range() already checks for the existence of a Range
2022-05-10 15:47:56 -05:00
256549e0c7
correctly abort the undo record when Editor::clear_markers (et al) have no effect
...
* move abort_reversible_command into the correct bracketed location
* check for missing _session at top of function to avoid unnecessary nesting
* this fixes an undo 'assert' when an action like "clear xrun markers" has no effect
* this was likely a copy+paste thinko since they are adjacent in the code
2022-05-10 15:47:56 -05:00
dbd80a6dd0
fix thinko in command name ('set session END' not start)
2022-05-10 15:47:56 -05:00
07b468b108
fix undo for toggle_region_mute
2022-05-10 15:47:56 -05:00
ee137333b9
midi_region_view: implement undo for duplicating a note selection
2022-05-10 15:47:56 -05:00
dbe49ae8c4
editor::paste fix a thinko in undo nesting
2022-05-10 15:47:56 -05:00
5310e1e099
create_note: fix a few thinkos which resulted in nested undo
2022-05-10 15:47:56 -05:00
1fa7a72f72
midi_region_view: rename 'apply_diff' to 'apply_note_diff' for clarity
...
these functions operate on the _note_diff_command,
which is explicitly a NoteDiff, not a generic DiffCommand
also fix a few thinkos where the ambiguous naming led to errors
2022-05-10 15:47:48 -05:00
133600d5dc
midi_region_view::apply_diff: implement using renamed midi_model functions
2022-05-10 15:47:48 -05:00
9fcf8b3a11
midi_region_view: rename commit_resizing -> finish_resizing
...
* 'commit' suggests that this function would commit an undo record
2022-05-10 15:47:48 -05:00
f9c9fd099d
midi_region_view: adopt midi_model renaming (gtk patch_change part)
...
* apply_diff_command_as_commit explicitly tells us we don't
need the begin/commit pair here
2022-05-10 15:47:47 -05:00
f9d73957ce
midi_list_editor: adopt midi_model diff function renaming (gtk part)
2022-05-10 15:47:47 -05:00
9c9273e694
scrolling the midi track/region works only if pointed-at-region is selected
2022-05-10 11:45:52 -06:00
126a85aaca
midi editing: simple click on region in internal edit/draw modes selects region
2022-05-10 11:45:10 -06:00
26816fc696
remove debugging output
2022-05-10 11:44:51 -06:00
6f9aa3677f
tempo markers: ctrl-drag now alters tempo for that section
2022-05-10 09:46:08 -06:00
be2a29b8c3
remove debug output during tempo marker redisplay
2022-05-10 09:46:08 -06:00
9b51d80210
explanatory comment
2022-05-10 09:46:08 -06:00
66a3513dbd
remove copy option for TempoMarkerDrag
...
This just seems like a dumb UI to implement. Drag-copying tempo markers is not a thing
2022-05-10 09:46:08 -06:00
eff34f2e1b
use editor tempo editing API rather than TempoMap API
2022-05-10 09:46:08 -06:00
b26f0b3e85
I/O Plugin GUI: set min height, fix context menu generic/edit
2022-05-10 16:01:35 +02:00
John Emmas
04c7cba961
Add a missing #include (needed when building with MSVC)
2022-05-10 11:20:43 +01:00
3d7b8f0df3
Implement I/O Plugin GUI
2022-05-09 17:39:06 +02:00
f8e1202ed4
Bootstrap IO Plugin UI
2022-05-09 17:39:05 +02:00
d4c15aab3f
List I/O Plugins in DSP-load window
2022-05-09 17:39:05 +02:00
9b1440ab23
Use new Route fed-by API (1/2)
2022-05-06 14:02:35 +02:00
f2016f2408
Prepare for GraphNode::feeds () and fed-by API update (1/2)
2022-05-06 14:02:34 +02:00
itmuckel
b4edbae7af
Add hidden ui config for close without asking
2022-05-06 10:12:17 +02:00
itmuckel
d7f2c35beb
Cruft removal
2022-05-06 10:12:17 +02:00
fd33784e45
Suppres debug output from optimized builds
...
see also dc9eb38a27
Even though it may be useful to get timing information from
optimized builds, this should not be enabled by default.
2022-05-03 20:12:21 +02:00
b5487415ec
editing: a partiaally implemented version of TempoTwistDrag, to be completed.
2022-05-02 16:47:23 -06:00
ccc4cd1bb1
fix incorrect drawing of tempo curves
2022-05-02 12:20:48 -06:00
69ee24c22b
editor: improved handling of tempo map changes
...
This splits apart the actual signal handler from the work that needs to be done
to update the GUI in response to a tempo map change. This allows us to do the
visual update when we are manipulating the thread-local write copy of the map
during e.g. a drag operation.
2022-05-02 12:02:04 -06:00
33622474af
editor: change return type of begin_tempo_map_edit()
...
This allows us to get the write-copy of the tempo map in one step.
2022-05-02 12:01:12 -06:00
0a99d67dac
meter marker drag: better initialization of map member
2022-05-02 11:50:34 -06:00
90a38a2b31
fix tempo marker drag crash caused by use of uninitialized map member
2022-05-02 11:49:43 -06:00
706140181e
Refactor IOButton::update, expose API to set connection-text
2022-04-27 23:31:24 +02:00
9e77d8923a
MIDI: ctrl-d now duplicates selected notes
...
This commit also fixes selection-after-paste, so that the selection is always
the newly pasted notes.
2022-04-27 08:13:09 -06:00
8d4516228a
Update default time-domain logic
...
MinSec, CD-Frame, and Timecode grid should use AudoTime
2022-04-27 15:08:34 +02:00
0e804be818
Fix typo in 1dafa5017e
(first automation point on line)
2022-04-27 12:56:32 +02:00
b8ebdbc44a
Fix showing automation lane on touch
...
In the past ui-change event "track_height" was used to force
a redraw. This changed in c1fb7bc05d
2022-04-26 00:26:02 +02:00
1dafa5017e
Always place first automation point using the current value
...
This is in preparation to always show a line, which show
the current value in case there are no automation points yet.
It also unconditionally snapshots the current value without
changing automation modes to touch/write first.
2022-04-25 18:32:23 +02:00
b416a4f168
gtk2_ardour: fix a couple of cosmetic typos in preferences
2022-04-21 12:28:42 +01:00
ae32daa148
allow ARDOUR::Filter to be used with MIDI regions/sources
2022-04-20 17:11:29 -06:00
sra
76a0b3c70e
Disable sandbox in lua SessionInit scripts.
2022-04-21 00:34:10 +02:00