13
0
Commit Graph

12746 Commits

Author SHA1 Message Date
b6c222555f NO-OP: re-order code, add comments 2017-04-20 17:19:03 +02:00
8add4eefad FP8: some code comments and cleanup 2017-04-20 16:06:47 +02:00
873a469686 Changes needed for building Tim's new 'string_convert' stuff with MSVC (libardour) 2017-04-19 17:25:52 +01:00
251db7a608 Changes needed for building Tim's new 'string_convert' stuff with MSVC (libpbd) 2017-04-19 17:25:51 +01:00
df98be1240 Don't explicitly store Auditioner -> Monitor connections.
The monitor section connection is implicit and done by default.
This fixes an issue with the auditioner connections being lost when
switching between sessions that use/don't use the monitor-section.

Previously:
1) load session with monitor section, save session
  -> global config explicitly saved
  "auditioner-output-left" -> "ardour:Monitor/audio_in 1"

2) Load a session w/o monitor-section. The config is parsed,
  "ardour:Monitor/audio_in" port does not exist, connection was lost.
2017-04-19 16:41:51 +02:00
c8aa78af07 Prefer boolean over literal 2017-04-19 12:51:11 +02:00
8f1cc261a2 Remove cruft. ChanCount::INFINITE is not used 2017-04-19 11:43:08 +02:00
89815f7d59 Change header include order to try and avoid INFINITE define on windows
This doesn't seem to be an issue with a newer version of the Mingw-w64 headers
that I use (5.0.2rc2).
2017-04-19 18:08:40 +10:00
21077018b8 Use PBD::string_to_uint32 in Playlist class instead of boost::lexical_cast 2017-04-19 09:37:02 +10:00
e097e0511f Use fixed size type for Playlist sort id as it is serialized 2017-04-19 09:37:02 +10:00
1ce58ad90a Add additional PBD::string_to/to_string specializations for PBD::ID 2017-04-19 09:37:02 +10:00
baa1bff5ec Use PBD::to_string to set state-dir property in LV2Plugin
To prevent issues with numeric grouping with formatting used by string_compose
template/stringstream when global C++ locale != "C"
2017-04-19 09:37:01 +10:00
19f9158dc6 Use PBD::to_string() in LV2Plugin instead of string_compose for state_dir
To prevent issues with numeric grouping with formatting used by string_compose
template/stringstream when global C++ locale != "C"
2017-04-19 09:37:01 +10:00
f2e32efc92 Use std::string::operator+ instead of string_compose in VSTPlugin 2017-04-19 09:37:01 +10:00
af1f4b933b Use std::string::operator+() instead of string_compose template in Route class
Using string_compose in this instance doesn't seem necessary, is worse in terms
of readability and is no doubt slower.
2017-04-19 09:37:01 +10:00
4367b51e56 Remove PBD::to_string() function from pbd/convert.h
All uses of this function have now been replaced by PBD::to_string() from
pbd/string_convert.h

Remove this function so that it isn't mistakenly used to perform numeric to
string conversion when the result is being used for serialization as that only
works if the global C++ locale is set with LC_NUMERIC=C, which is the case
currently but may not be in the future.
2017-04-19 09:37:01 +10:00
926a064744 Use PBD::to_string from pbd/string_convert.h in WaveView debug code 2017-04-19 09:37:01 +10:00
aede5c85d5 Use PBD::to_string from pbd/string_convert.h in ARDOUR::VCAManager
The numeric formatting is equivalent to iostreams when global C++ locale is set
to "C" without the need for a LocaleGuard.

I'm not sure this would have been an issue as the number of VCA's may never get
high enough for digit grouping of the locale to affect numeric output, but now
it is not a possibility.
2017-04-19 09:37:00 +10:00
2386dc7ede Use PBD::string_to/to_string in ARDOUR::user_config_directory_name()
The numeric formatting is equivalent without requiring a LocaleGuard or the
global C++ locale is "C".
2017-04-19 09:37:00 +10:00
797fbfc5de Use PBD::to_string from pbd/string_convert.h in ARDOUR::ExportFilename
The numeric formatting is equivalent to using iostreams in the C locale without
having to use a LocaleGuard or set global C++ locale.
2017-04-19 09:37:00 +10:00
0ae2985a21 Use XMLNode::get_property in ARDOUR::ElementImporter 2017-04-19 09:37:00 +10:00
5c387b76b8 Use PBD::to_string/string_to in ARDOUR::ElementImporter class 2017-04-19 09:37:00 +10:00
37d76e4104 Use PBD::to_string API from pbd/string_convert.h in AudioFileTagger
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to
remain locale independent and not have to use a LocaleGuard. The formatting is
equivalent.
2017-04-19 09:37:00 +10:00
0dbb9e6346 Use PBD::to_string API from pbd/string_convert.h in AudioTrackImporter
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to
remain locale independent and not have to use a LocaleGuard. The formatting
is equivalent.

The code in this file has been disabled in the GUI for some time...and I doubt
it would now work correctly.
2017-04-19 09:37:00 +10:00
0de5722fb1 Use PBD::to_string() from pbd/string_convert.h in ardour ALSA utils
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to
remain locale independent and not have to use a LocaleGuard. The formatting is
equivalent
2017-04-19 09:37:00 +10:00
bf5864aaca Use PBD::to_string() from pbd/string_convert.h in JACK utils
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to
remain locale independent and not have to use a LocaleGuard.
2017-04-19 09:37:00 +10:00
ca7bbea6d8 Use PBD::string_to/to_string when de/serializing in AutomationList class
This avoids requiring a LocaleGuard to get the correct numeric formatting and
saves/restores the automation data to the precision required for roundtrip
equality.
2017-04-19 09:37:00 +10:00
c65f30b4b1 Remove unused header include in ARDOUR::Amp source file 2017-04-19 09:36:59 +10:00
18011482bb Use PBD::string_to/to_string in IO::find_possible_bundle
Possible issue with numeric formatting using std::streams in locales with
grouping. Although I don't think it would be an issue in this case use locale
independant alternative for numeric formatting anyway.
2017-04-19 09:36:59 +10:00
0656d5ab1a Use XMLNode::get/set_property API in Faderport surface 2017-04-19 09:36:59 +10:00
ac8b5192cd Remove now unused PBD::string_is_affirmative function
The equivalent function is now PBD::string_to<bool>
2017-04-19 09:36:59 +10:00
23eb1fbf01 Use PBD::string_to<bool>() in GenericMidiControlProtocol class
Equivalent to PBD::string_is_affirmative()
2017-04-19 09:36:59 +10:00
04a027a031 Use PBD::string_to<bool> in legacy ARDOUR::Route methods 2017-04-19 09:36:58 +10:00
9ce1d7c357 Use PBD::string_to<bool> in ARDOUR::Processor class 2017-04-19 09:36:58 +10:00
603d944530 Use PBD::string_to<bool> in AudioPlaylist class 2017-04-19 09:36:58 +10:00
6e467153a0 Remove unused XMLNode::add_property methods
These are now unused and functionality is replaced by XMLNode::set_property

set_property is a better name as a node can only have properties with unique
names and the property will be set or reset(if it already exists). Changing the
name also makes it easier to transition and test the new API.
2017-04-19 09:36:57 +10:00
e4b1ece143 Use XMLNode::set_property API in xml tests 2017-04-19 09:36:57 +10:00
7085d7305d Use locale independent string conversion functions in SVAModifier class 2017-04-19 09:36:55 +10:00
9488cb0b69 Use XMLNode::get/set_property API in Gtkmm2ext::WindowProxy class 2017-04-19 09:36:55 +10:00
6779770fee Use XMLNode::get/set_property API in Gtkmm2ext::Tearoff class 2017-04-19 09:36:55 +10:00
c627da0a9f Use XMLNode::get/set_property API in Gtkmm2ext::Tabbable class 2017-04-19 09:36:55 +10:00
1f3589b122 Use XMLNode::get/set_property API in Gtkmm2ext::Keyboard class 2017-04-19 09:36:55 +10:00
ac89bfd229 Use XMLNode::set_property API in Gtkmm2ext::Bindings class 2017-04-19 09:36:54 +10:00
7170dd84d8 Use XMLProperty::get/set_property API in CC121 Surface module 2017-04-19 09:36:54 +10:00
bd533e305d Use XMLNode::set_property API in WiimoteControlProtocol class 2017-04-19 09:36:54 +10:00
bd3965e278 Use XMLNode::get/set_property in Push2 surface
Fix push2 property names to use hyphen word separator.
2017-04-19 09:36:54 +10:00
0df955412e Use XMLNode::set_property in OSC_GUI class 2017-04-19 09:36:54 +10:00
6c1e7153ef Use XMLNode::get/set_property API in OSC class 2017-04-19 09:36:54 +10:00
1680811dbf Use XMLNode::get_property API in Mackie DeviceInfo class 2017-04-19 09:36:54 +10:00
77b4e041ac Use XMLNode::get/set_property API in mackie Surface class 2017-04-19 09:36:54 +10:00