13
0
Commit Graph

36598 Commits

Author SHA1 Message Date
cc30495ba0
Properly convert v6 MusicTime locked MIDI regions 2022-10-22 05:36:23 +02:00
30ec62a953 This is clearly broken
Partially revert previous commit. Otherwise snap to bar/beat
clocks-displays display rounded down X|Y|1919 instead of X|Y+1|0
2022-10-22 03:09:32 +02:00
14da117bc8 Add explicit round/floor integer multiply/divide
This fixes various rounding issues. Notably superclock to sample
conversion must always round down when playing forward.

`::process (start, end, speed = 1)` uses exclusive end.
Processing begins at `start` and end ends just before `end`.
Next cycle will begin with the current end.

One example where this failed:
 - New session at 48kHz
 - Change tempo to 130 BPM
 - Enable snap to 1/8 note
 - Snap playhead to 1|3|0
 - Enable Metronome
 - Play

`assert (superclock_to_samples ((*i).sclock(), sample_rate()) < end);`

end = 177231 samples == superclock 1042118280
A grid point is found at superclock 1042116920 (that is < 1042118280).
However converting it back to samples rounded it to sample 177231 == end,
while actual location is 1360 super-clock ticks before end.

The metronome click has to be started this cycle, since the same
position will not be found at the beginning of the next cycle, with
start = 177232.

Similarly a samplecnt_t t, converted to music-time and back must not be
later than the given sample.

```
timepos_t tsc (t);
assert (timepos_t::from_ticks (tsc.ticks ()).samples () <= t);
```

IOW. When playing forward, all super-clock time between 1|1|0 and 1|1|1
should round down to 1|1|0. "We have not yet reached the first tick".
2022-10-22 02:10:05 +02:00
e9bafde628
Catch manual removal of subgroup bus (#9022) 2022-10-21 20:40:27 +02:00
b9b4313873
Use libardour's SimpleExport
Selection range export now needs to be handled by the GUI
2022-10-21 19:59:16 +02:00
2e860cd10d
Move SimpleExport to libardour, add Lua bindings
This allows to export a session from the commandline tool

```Lua
AudioEngine:set_backend("None (Dummy)", "", "")
s = load_session ("/path/to/session", "snapshot")
assert (s);
e = s:simple_export()
assert (e:check_outputs ())
e:run_export ()
e = nil
```
2022-10-21 19:50:26 +02:00
0852f898a3
Prepare to move SimpleExport to backend 2022-10-21 19:35:17 +02:00
03642d3707
Mark window invisible after deleting it
This fixes an issue when destroying VST plugin UIs
rather than hiding them. Even though is hidden before destroying it,
the vistracker is also destroyed in the same function call, before
the event can be processed. The window state remains visible="1"
2022-10-21 18:11:19 +02:00
ace2cc095c
Fix typo in 7fb82690b 2022-10-21 18:04:11 +02:00
7fb82690bd
Fix Windows builds (uname is POSIX only) 2022-10-21 17:11:38 +02:00
5d7b421a0b remove debug output 2022-10-21 07:55:24 -06:00
cf83815133 add clear-all-cues item to cue marker ruler context menu 2022-10-21 07:52:23 -06:00
d69a2c3c13 small change to Locations::clear_cue_markers() API to bring it into line with other clear_* methods 2022-10-21 07:51:53 -06:00
a327e01ff3
Fix copy/paste (is_cue_marker Lua binding) 2022-10-21 13:06:22 +02:00
6a55146fdc
Fix music-time parameter automation #9019
Music-time has a significantly reduced resolution.
When evaluating parameter automation using sample-time, different
samples can be mapped back to the same beat-tick. This can result in
endless loops.

The same automation event is found again:

```
start: 112640 next_event.when: b13334 -> dist a5892029@a662323200 in dist.samples: 1002
start: 113642 next_event.when: b13334 -> dist a269@a668214960 dist.samples: 0
```

Note this fix may not be correct, since time-domains are mixed.
"end" is using sample-time. Furthermore The loop is only entered
if there is an event found using  timepos_t(start).

Further work will be required (ideally use the same resolution for
all time-domains, or force everything that is evaluated in RT-context
to a single time-domain)
2022-10-21 12:40:30 +02:00
b634cbba4c
Shrink connection matrix tabs
Program-name is not required to indicate "Tracks", "Busses", etc
Those are always by provided by PROGRAM_NAME.

"Other" really indicates external JACK (or Pipewire) applications.
Here "External" is a better label.

"Misc" can potentially be interpreted ambiguously, hence keeping
PROGRAM_NAME is useful.
2022-10-21 01:37:35 +02:00
23da78c013
Separate I/O Pre and Post plugins to dedicated matrix tabs 2022-10-21 01:22:45 +02:00
3447869f21 fix for initial value of insert/remove time duration clock 2022-10-20 14:04:50 -06:00
1faefb5afd
Implement simple/quick export dialog 2022-10-20 21:38:45 +02:00
d585ef1319
Update export presets
* Add WAV export preset
* Add mp3 export preset
* clarify "CD" preset name
2022-10-20 21:38:45 +02:00
5c05e8d047
Prepare ExportPresetSelector read-only mode (for quick export) 2022-10-20 21:38:45 +02:00
56fd2a299f
NO-OP: clang-format 2022-10-20 21:38:44 +02:00
506528a70c
Add API to query current export preset 2022-10-20 21:38:40 +02:00
6ba740d37a add freesound dir to prepopulated dirs in clip list 2022-10-20 12:49:19 -06:00
91309619b8
Pingback: remove unused CPU/OS version detection
OS specific versions part of a http query has been Ardour
only. Mixbus never posted any of this information. The section
was #ifdef'ed out. Removing this code for good, simplifies merges.
2022-10-20 19:44:15 +02:00
19e190cc93
Improve connection button labels for internal connections
* Update button when the name of a connected route changes
* Indicate partial internal connections (previously only the
  client name ("ardour") was displayed.
* Escape markup in I/O plugin and client names
* Refactor code, use a common base-class for route and
  route-less I/O Buttons
2022-10-20 18:55:21 +02:00
de84ac2d6f Update Russian translation 2022-10-20 15:29:49 +03:00
73ab0d3472 change pingback URL and no longer send OS release or machine info (GUI edition) 2022-10-19 20:26:39 -06:00
63677347c9 change pingback URL and no longer send OS release or machine info 2022-10-19 20:26:39 -06:00
39c6ea6813 editor region list: allow name column to be resizable 2022-10-19 20:26:39 -06:00
b75be7f975
Another attempt for ssl-cert support on RHEL/Fedora #9005
When /etc/pki/tls/certs/ca-bundle.crt exists, jus use
that file and do not set any PATHs. Disable default
built-in /etc/ssl/certs
2022-10-19 18:23:03 +02:00
9914732004
Potential fix for C++20 std::set::* ambiguity
(until C++20) bool empty() const noexcept;
(since C++20) [[nodiscard]] bool empty() const noexcept;
2022-10-19 16:06:47 +02:00
22829e96b1
Fix MIDI Clock sync
This fixes a deadlock, because tempo-map write copy
was not released. A later call to TempoMap::write_copy
will deadlock and in this case also hold the process lock.

This can happen if there is more than one tempo on the
timeline or if the tempo-difference is too large.
2022-10-18 20:44:16 +02:00
073d6f5e80
Disable cert check if no SSL certs are found (#9005) 2022-10-18 19:37:06 +02:00
54a98cd320
Remove visible spacer right of the mini-timeline
This improves consistency, the center widgets are already
visibly separated by their background.
2022-10-18 02:14:31 +02:00
3a98d6133c
Hide draw-tools spacer when draw-tools are hidden 2022-10-18 02:11:09 +02:00
452eedc994
Pixelpushing: align toolbar buttons
Removing the shadow makes toolbar and editor-tool buttons align
when the editor-mixer is hidden. It also improves consistency
with all other tabs that have no shadow on the left.

Increasing the table border width to 1, makes aligns the
editor-mixer button with the main toolbar.
2022-10-18 01:45:55 +02:00
7c6c6290ee
Fix #8996 (show/hide VCAs from script) 2022-10-18 00:08:36 +02:00
64dc16a460
GUI for partial mixer scene restore 2022-10-18 00:08:36 +02:00
b52ef52ddf
Allow to filter MixerScene restore by AutomationType 2022-10-18 00:08:35 +02:00
5352f5516e
Remove AutomationControlSet 2022-10-18 00:08:35 +02:00
1b23021303
Replace AutomationControlSet with ControllableSet (2/2) 2022-10-18 00:08:35 +02:00
08a10b7e84
Replace AutomationControlSet with ControllableSet (1/2) 2022-10-18 00:08:27 +02:00
5016c950d0
Move ControllableSet up in PBD's namespace
This is in preparation to supersede AutomationControlSet
with a lower level generic std::set usable in any relevant
context.
2022-10-18 00:08:21 +02:00
46b14498f8
Prepare Lua bindings for std::set::insert 2022-10-17 23:09:04 +02:00
f6cc01d4f5
Implement cycle profiling for ppc64
Thanks to Frédéric Bonnard <frediz@debian.org>
2022-10-17 16:02:12 +02:00
a9b785d89c
Fix typos - #9000 2022-10-17 15:57:01 +02:00
aaddf5f385 Add API to restore mixer scenes for given set or Routes only 2022-10-17 06:44:29 +02:00
800d07a633 Add API to query all AutomationControls from an Automtable
This is in preparation for selective MixerScene restore.
2022-10-17 06:42:49 +02:00
d29f7a4e00
Expose PluginGUIBehavior Preference
This also subgroups plugin UI prefs, to save vertical screen space
when showing the preference pane on small screens.
2022-10-17 00:49:46 +02:00