13
0
Commit Graph

318 Commits

Author SHA1 Message Date
81dbb977c5 fixups for rebase of show-region-name option 2019-05-29 17:37:48 -06:00
8463fb728f add option to show/hide region names 2019-05-29 15:24:40 -06:00
c285229423
Follow up f5bc64d00e - add gap to range-selection rect as well 2019-04-18 16:46:44 +02:00
b799c05c1a
Found another one -- does this ever end? :)
Undo s/sample/frame/ replacement.
2019-04-12 22:23:48 +02:00
9f1293bfe5
Tab to prev/next name-entry: skip only rec-armed tracks 2018-12-04 22:07:27 +01:00
a593a81db3 Fix size-request call
use  Requisition Gtk::Widget::size_request () 	const;
and not deprecated
void Gtk::Widget::size_request 	(const Requisition&);

Found by PVS-Studio - https://www.viva64.com/en/b/0540/
2017-11-23 09:53:09 +01:00
997f70d9cb switch from std::auto_ptr<> (deprecated) to boost::scoped_ptr<> 2017-10-26 15:41:47 -04:00
ea5fa64c0b manually fix up various cases where Gtk:Frame foo_frame had been changed to foo_sample 2017-09-18 14:59:11 -04:00
30b087ab3d globally change all use of "frame" to refer to audio into "sample".
Generated by tools/f2s. Some hand-editing will be required in a few places to fix up comments related to timecode
and video in order to keep the legible
2017-09-18 12:39:17 -04:00
a3dd948c02 Allow to rename VCAs in the editor 2017-07-28 02:12:19 +02:00
3d50563620 Properly propagate TAV TimeSelection 2017-07-21 15:49:28 +02:00
92a1d3619b Const'ness where const'ness is due 2017-07-19 22:15:22 +02:00
601c317d70 Clean up library inheritance (colors.h, utils.h)
make libwidget independent of libcanvas.
Confine basics to pbd and gtkmm2ext.
2017-07-17 21:06:04 +02:00
eb1e423b75 Remove <gtkmm.h> include from header files. 2017-07-17 21:06:04 +02:00
b5e9451bc7 Remove unused sources & includes 2017-07-17 21:06:04 +02:00
f6e182b937 Move Gtkmm2ext widgets into libwidget 2017-07-17 21:06:04 +02:00
5c92613698 Separate Ardour UI widgets into dedicated library 2017-07-17 21:06:04 +02:00
68c106eab5 Fix VCA Automation Lane selection
This moves child-selection API up into TAV (Superclass of StripableTAV
which actually owns the children)
2017-07-07 14:47:36 +02:00
Thomas Brand
63ea7b6516 NO-OP whitespace (updated GH PR #357) 2017-07-01 19:28:26 +02:00
dc0139d4af use CoreSelection for track selection 2017-05-05 18:56:25 +01:00
2c4e801183 Use AxisView::get_gui_property API in TimeAxisView class 2017-04-19 09:36:58 +10:00
7fdbabcd79 Let AxisView::set_gui_property perform type conversion in TimeAxisView::set_height 2017-04-19 09:36:57 +10:00
962e7a214a Revert "consistent use of context-menu popups"
This reverts commit b3722f7063.

In some cases ardour shows context-menu on right-mouse-button
release. In this case selecting a menu-entry should happen
with the left-mouse button (or any button?!)

Using ev->button is only correct if the menu is temporary and only
visible while the button is held, button release then activates the
menu-item.

This needs further work, in some cases allowing any button (0) to work
makes sense and overall consistency needs to be improved.
Different places use different strategies for context-menus which
don't always match the button used in the event-handler.

This is a hotfix (to make TAV context menus work again with left-click)
2017-03-24 14:48:46 +01:00
b3722f7063 consistent use of context-menu popups 2017-03-16 02:36:48 +01:00
6a823402e6 This turns out to have been a band-aid over a deeper issue in libcanvas, fixed
in commit 49422aa89

Revert "fix an issue with selection rects not being redrawn correctly"

This reverts commit fa1a7ae9b9.
2017-01-25 16:54:48 +01:00
fa1a7ae9b9 fix an issue with selection rects not being redrawn correctly 2017-01-25 16:47:42 +01:00
nick_m
37e858da7d only update GhostEvents on visible trackviews.
- this requires that MidiGhostRegion::update_contents_height()
	  also controls visibility.
2016-12-23 02:55:51 +11:00
37233fe92f TimeAxisView::set_selected() needs to call AxisView::set_selected() 2016-09-27 14:59:32 -05:00
0ab81183c0 don't show empty time axis view context menus 2016-08-18 08:16:31 -04:00
822810b88f the endless quest to plug memory leaks -- episode 379 2016-07-25 17:38:59 +02:00
cf52d6e4b4 enough with umpteen "i18n.h" files. Consolidate on pbd/i18n.h 2016-07-14 14:45:23 -04:00
da7d7f9502 many changes associated with rationalizing selection flow 2016-07-06 13:39:10 -04:00
01812f53c3 use, or mostly use PresentationInfo for selection status of Routes.
Needs extension to Surfaces, replacing GuiSelectionChanged signal concept
2016-06-05 20:50:57 -04:00
c31435b474 RouteUI is now also derived from SessionHandlePtr but NOT AxisView. Fix initialization.
Only "most derived" classes can initialize virtual base classes (SessionHandlePtr)
2016-06-05 16:33:01 -04:00
a98015e11a NO-OP: add blank line to make comments clearer 2016-06-03 16:12:32 -04:00
0d999ea4ec remove un-used name_hbox widget from TimeAxisView 2016-06-01 21:57:43 -04:00
43b6a7aca3 remove unneeded widget style definition 2016-06-01 21:57:43 -04:00
428ed8ae1b stop playing silly games with widget packing when editing a route name in the edito
Use a FloatingTextEntry instead. All clever functionality from previous
implementation has been retained.
2016-05-31 15:30:44 -04:00
670e79f7d1 do not accidentally try to select VCA time axis views for context clicks or other conditional ops 2016-05-31 15:30:44 -04:00
e626db22a0 make selectability of a TimeAxisView be overridable 2016-05-31 15:30:44 -04:00
63f50b1fc5 no-op: move comment to make scope more clear 2016-05-31 15:30:44 -04:00
a12ce428d0 fix wierd TimeAxisView initial attachment for the name hbox 2016-05-31 15:30:44 -04:00
d4070a7e3e pre-size TimeAxisView controls_table to something more like the correct rows x cols 2016-05-31 15:30:44 -04:00
653ae4acd6 universal change in the design of the way Route/Track controls are designed and used. The controls now own their own state, rather than proxy for state in their owners.
Massive changes all over the code to accomodate this. Many things are not finished. Consider this a backup safety commit
2016-05-31 15:30:40 -04:00
d5050cd0f4 mark initial TAV as hidden to speed up initial display.
This prevents an extra call to "redisplay" from TAV::hide() which
triggers handle_gui_changes.
Visible TAVs are positioned using show_at() which unsets _hidden.
2016-05-03 14:27:42 +02:00
Julien ROGER
1fbe4253aa Fix 6609: Right-click in active track name box crashes
When right-clicking in the text entry, popup menu grabs focus. Consequently, the "focus out" handler is called, destroys the text entry and replaces it by the label name of the track.
When menu pops up, it tries to access to a widget no longer available.
2016-02-13 12:30:31 +10:00
b074ff0dd5 Remove GhostRegion::CatchDeletion signal to reduce session close times
Currently when a GhostRegion is deleted by its "parent" RegionView it emits the
static GhostRegion::CatchDeletion signal which is connected to the
RegionView::remove_ghost method of every RegionView instance.

With a static GhostRegion::CatchDeletion signal a particular test session
causes 31 Million calls of RegionView::remove_ghost on Session deletion and the
session takes 70 seconds to close with a debug build.

The lifetime of a ghost region is tied to both the TimeAxisView(TAV) and
RegionView(RV) in that when a RegionView is deleted all GhostRegion instances
associated with the RegionView should be deleted or when a TimeAxisView is
deleted all ghost regions that are contained in the view should be deleted.

This means that there needs to be notification between GhostRegion and both
classes. Instead of using a signal for this as we know there are only two
listeners and GhostRegion already holds a reference to the TimeAxisView, also
take a reference to the parent RegionView in the GhostRegion constructor and
use it to notify the RegionView when GhostRegion destructor is called so it can
drop any references it holds.

Using a direct function call in the GhostRegion destructor to notify the
TimeAxisView and RegionView "parents" brings the unload/close time down for the
test session from 70 seconds to 4.5 seconds.

The GhostRegion also references canvas items that are added to the TimeAxisView
canvas group or at least a canvas group that it manages. So when the
TimeAxisView is destroyed and the canvas group that is the parent of those
items is destroyed, the GhostRegion's canvas items will also be
deleted/destroyed by the parent canvas item/group. This means the GhostRegions
must be destroyed when the TimeAxisView they are contained in is destroyed or
there will be dangling references to canvas items that have already been
deleted and trying to delete them again will be bad.
2015-10-22 11:51:03 -04:00
22b07e0233 NOOP, remove trailing tabs/whitespace. 2015-10-05 16:17:49 +02:00
4dc63966f0 globally remove all trailing whitespace from ardour code base.
Paul Davis was responsible for introducing almost all of this.
2015-10-04 14:51:05 -04:00
1d42ed077e Use ARDOUR_UI_UTILS::set_tooltip rather than via ARDOUR_UI::set_tip
This removes the direct dependence on ARDOUR_UI/Gtk_UI for setting
tooltips. Removes inclusion of ardour_ui.h from 16 files.
2015-09-16 16:55:17 -04:00