1f58f81aa6
Fix order of parameters to stop_touch() in Mackie::Control
...
Reverse the parameters of Mackie::Control::stop_touch() to make them
consistent with AutomationControl::stop_touch(), and fix up the call to
AutomationControl::stop_touch() to have the parameters in the correct
order.
Unfortunately, I don't possess any devices that speak the Mackie protocol, so
though the patch seems logical and correct to me, I have no way of testing it.
If anyone has a device with touch faders that speaks Mackie, I'd be glad of any
confirmation that it at least doesn't break anything.
2014-11-25 14:59:48 +00:00
421a1d9912
Revert "Don't add non-clang flag regardless of platform."
...
Apple's g++ on 10.6. does not understand -Wno-unused-local-typedefs
either
This reverts commit 9dd8024e41
.
2014-11-25 14:06:15 +01:00
97981e9007
fix indentation nightmare from 9559cf3947
2014-11-25 12:17:26 +02:00
5101916a17
fix case of included header file
2014-11-25 12:17:26 +02:00
VKamyshniy
c14c365419
[Summary] Fixing behavior of the FloatingTextEntry
2014-11-25 12:17:26 +02:00
76334847c5
quick sanity check
2014-11-25 10:35:50 +01:00
8a58ffd151
NOOP, fix some “missing sentinel” -Wformat
2014-11-25 10:23:10 +01:00
a2475509e5
Check for clang with an actual code check.
...
Turns out Apple in its infinite wisdom installs clang as /usr/bin/g++, so
guessing based on executable name doesn't work.
2014-11-25 02:20:21 -05:00
ea5876b836
Remove dead code.
2014-11-25 02:11:44 -05:00
8b268344f9
Shup up clang about gtkmm/papertraits.h.
2014-11-25 02:08:35 -05:00
9dd8024e41
Don't add non-clang flag regardless of platform.
2014-11-25 02:07:40 -05:00
634a348296
Fix clang check for versioned clang executables.
2014-11-25 02:07:07 -05:00
d953f1ce0e
when dragging on the canvas, use x,y pointer coordinates to decide if motion has occured.
...
Using _last_pointer_frame breaks when dragging to the left of the canvas, because we clamp
the value of the frame to >= 0. Motion would step once the pointer crossed the left edge
of the canvas because the frame value would always be zero.
This is not a problem when using the pointer x,y values which end up appropriately negative
under all conditions.
2014-11-24 21:59:29 +02:00
78218e8c07
fix OSX open URL in browser
2014-11-24 20:35:38 +01:00
da6062a0b9
Add a newly introduced header file to our MSVC project (gtk2_ardour)
2014-11-24 13:01:16 +00:00
bf2625de40
Now that we're building pango's language modules statically (i.e. no longer as DLLs) it's not necessary to edit the user's 'pango.modules' file
2014-11-24 12:58:26 +00:00
c7ddedc5b8
Simulate 'trunc()' which isn't available in MSVC
...
(needed by 'gtk2_ardour/editor.cc')
2014-11-24 12:56:07 +00:00
018f559aad
Remove a commented out line in 'pbd/stacktrace.h'
...
(was probably just needed for testing at some stage)
2014-11-24 12:53:24 +00:00
25745758aa
Changes needed to accommodate building libevoral with MSVC
...
Note that class 'MusicalTime' needn't be exportable (with a little work, this could be reverted if it affects the other builds)
2014-11-24 12:51:54 +00:00
7b3263891f
waf is fun
2014-11-24 04:56:31 +01:00
2bdf9e447f
OSX gcc does not support local-typedef warning
2014-11-24 04:24:58 +01:00
3a7652200d
also search for 32bit xjadeo on 64bit windows
2014-11-24 01:43:31 +01:00
c0e8647806
amend c4533939b9
2014-11-24 00:04:45 +01:00
3aea7af3fd
lost quote
2014-11-24 00:00:58 +01:00
cd91fa0046
hotfix windows-compilation (unfinished bfe49540b9
)
...
..at least it compiles and starts. Mackie support etc
is probably still broken.
2014-11-23 23:57:56 +01:00
1b6cbf743b
update harvid & ffmpeg binary path discovery on windows (64 & 32 bit)
2014-11-23 23:57:55 +01:00
8ddeb712f6
make debug message more useful
2014-11-23 23:57:55 +01:00
5aba4df252
fix/silence various compiler warnings.
...
* ifdef unused static functions
* brackets around assignment and comparision
* no return statement in function returning non-void
* boost concept_checks.hpp unused-local-typedefs
2014-11-23 23:57:55 +01:00
f1926dc863
Fix build with a certain awful broken compiler.
2014-11-23 16:31:59 -05:00
ec01682714
-Wunused-function on windows
2014-11-23 21:01:39 +01:00
40764f4cb3
use NULL not 0 for c-functions (even in c++ code)
...
4.3 KBytes less compiler warnings.
2014-11-23 21:01:39 +01:00
bfe49540b9
remove use of CrossThreadChannel::selectable() to allow cross-platform implementation of CrossThreadChannel via Glib::IOSource
2014-11-23 17:37:13 +02:00
dcf632d99f
assign minsec_ruler_scale and minsec_mark_modulo when zoomed very far out
...
Avoids crash when computing % minsec_mark_modulo.
2014-11-23 14:36:38 +02:00
57c1b6e261
Fix quantization and other time-related ops.
2014-11-22 21:49:42 -05:00
231e0009b4
Max is max and min is min and I am dumb.
2014-11-22 16:33:32 -05:00
bed95a64a0
Fix note resizing.
2014-11-22 15:33:40 -05:00
42b5ed3904
Fix clang and MSVC build.
2014-11-22 15:26:41 -05:00
73ad993597
Fix invisible discrete control points.
2014-11-22 04:39:30 -05:00
c1cfa12d6e
Wrap MusicalTime in a class.
...
This lets us get a more explicit handle on time conversions, and is the main
step towards using actual beat:tick time and getting away from floating point
precision problems.
2014-11-22 04:05:42 -05:00
cae74309a5
Fix assert failure in control list interpolation.
...
How we never hit this before is beyond me, it's in some ooooold code.
2014-11-22 00:46:15 -05:00
01493b14cf
Fix const violation warnings in tempo.cc.
2014-11-22 00:46:15 -05:00
24f7eccc86
Factor out copy-paste code to get grid type in beats defaulting to 1.
2014-11-22 00:46:15 -05:00
41a9060df9
Move time converters only to the region views that actually need them.
...
A step towards sorting out time issues more solidly, the time situation of MIDI
region views and automation region views is slightly different.
2014-11-22 00:46:15 -05:00
2966dd4a9f
add a variable to specify windows build concurrency
2014-11-21 23:12:17 +01:00
4bc0d1c475
Fix lost MIDI note offs and controllers.
...
Fix initial read of discrete MIDI controllers.
Fix spurious note offs when starting to play in the middle of a note.
Faster search for initial event when cached iterator is invalid.
So much for dropping the cached iterator. The iterator is responsible for
handling note offs, so that doesn't work. This design means we have some stuck
note issues at the source read level, but they should be taken care of by the
state tracker anyway.
2014-11-20 15:36:11 -05:00
8bba63282a
Reduce unnecessary non-const MIDI buffer access.
2014-11-20 15:32:06 -05:00
7def8de5a3
Use memento_command_binder() to (probably) fix MSVC build and other things.
...
Remove ugly hack that does the same thing.
2014-11-20 12:01:39 -05:00
8f8a4878f3
Clean up some MIDI code.
2014-11-20 11:31:31 -05:00
9d8bbf4b9a
Remove unused variables.
2014-11-20 11:31:31 -05:00
0c4869dc35
debug trace lost midi-messages
2014-11-20 02:46:30 +01:00