706a9ab59f
fix mistakenly-placed semi-colon
2019-10-28 17:21:46 -06:00
b97e2d5013
to avoid deadlock in JACK1 scenarios, do not invoke AudioEngine::update_latencies() from update_latency_compensation() if called from a process thread
2019-10-28 16:55:29 -06:00
6b654039fb
better comments
2019-10-28 16:53:00 -06:00
43eb64d23b
add new debug bit (DebugTimestamps) that adds timestamps to all debug messages
2019-10-28 16:52:18 -06:00
4073e7573d
add DEBUG_TRACE for all (?) backend callbacks
2019-10-28 16:07:38 -06:00
5704f1ca9e
sort debug bits in libardour alphabetically
2019-10-28 15:55:01 -06:00
b4addf5297
add new debug bit for backend callbacks
2019-10-28 15:54:18 -06:00
fe56c5931c
do not hold a lock when calling AudioEngine::update_latencies() from Session::update_latency_compensation().
...
Only when using JACK1 is ::update_latencies() a synchronous call (ending up in Session::update_latency() which tries to take the
same lock). But the semantics of ::update_latencies() are sufficiently ill-defined that entering that call with a lock held
seems like a bad idea, so we release the lock unconditionally here.
2019-10-28 13:40:18 -06:00
8befc818eb
add explanatory comment
2019-10-28 13:40:18 -06:00
7f1134e550
move reset (deletion) of click_io and ltc_output objects until after we are disconnected from the engine
...
We use those objects unconditionally and without caching inside process(), which could be invoked by the engine during their
deletion
2019-10-28 13:40:18 -06:00
John Emmas
5e9e7e6ed4
Add/remove source(s) in our MSVC project (gtk2_ardour)
2019-10-28 16:45:52 +00:00
Rui Nuno Capela
bd46b2df8e
Fixup prev commit (LV2 X11 UI) -- #7837
2019-10-28 17:31:03 +01:00
e4601e54e9
Improve 1477bca76, ensure suil supports x11-in-gtk2
2019-10-28 17:24:54 +01:00
1477bca76e
Skip X11 LV2UI check on Windows and MacOS
2019-10-28 16:14:30 +01:00
86337810fe
NO-OP: whitespace and comments
2019-10-28 16:14:24 +01:00
Rui Nuno Capela
760a7fda81
Prefer X11 Plugin UIs
...
Let LV2 Plugin UI support (via SUIL) prefer and select a X11 UI whenever
multiple UI type options are provided by LV2 plugins (eg. Vee-One's do
present several but their native Qt5UI should never be raised by Ardour,
on any chance:)).
Signed-off-by: Rui Nuno Capela <rncbc@rncbc.or
2019-10-28 16:00:48 +01:00
36ea069722
Fix use of std::map<> in const methods
...
Prefer iterators, instead of C++11 `at() const`.
This should also fix MSVC error C2663
2019-10-28 15:37:13 +01:00
1d20feef83
make transport work after rewind/ffwd are used
2019-10-27 11:17:49 -06:00
474a3c5f69
Virtual-keyboard: allow octave switches while hand-pedaling
2019-10-27 13:54:47 +01:00
b53431a089
Virtual-keyboard: consolidate options
...
Remove use options for annotations, force them "always on",
and request space to draw them.
Add option to pick single-line octave bindings
2019-10-27 00:06:14 +02:00
9fd0813d16
Add support for single-octave "asdfg.." key-bindings
2019-10-26 23:49:57 +02:00
f1d614b15d
Show PluginScanDialog only if needed (cancel VST scan)
2019-10-26 01:12:05 +02:00
c398576e4a
Fix latency compensation race-condition
...
Remove need for explicit `initialize_latencies` call that used
to be called from GUI-thread post_engine_init(), as well as
Session::engine_running().
Further reduce calls, `graph_reordered` implies a latency-update
and fix ordering issue. update_latency_compensation() must be called
*after* resort_routes().
2019-10-26 01:06:04 +02:00
35788fbaaa
Virtual-keyboard: prefer dropdown for channel & transpose
...
This addresses issue with text-entry and input focus
2019-10-25 23:53:23 +02:00
d51ca5d398
remove unintended leading space
2019-10-25 15:48:32 -06:00
7bb67d0402
Virtual-keyboard: fix text-entry in config widgets
2019-10-25 21:54:16 +02:00
12d4d6daa7
Virtual-keyboard: never-ending details
...
- Fix key-bindings (first propagate to piano, ignore global bindings)
- Allow to switch octaves with left/right arrow key
- Tweak font-sizes used for annotations
2019-10-25 21:24:25 +02:00
c0c1fd8b60
Rename PianoKeyboard class, avoid ambiguities
...
A C++ class "PianoKeyboard" in the global namespace may cause
issues with some plugins that export and use an identically
named symbol.
2019-10-25 21:24:25 +02:00
61f32339ef
Continue C++ification of PianoKeyboard
2019-10-25 21:24:25 +02:00
6272678a90
Add gtk-pianokeyoard author to about
2019-10-25 21:24:25 +02:00
7672b1cb43
NO-OP: whitespace
2019-10-25 21:24:25 +02:00
683f7a0be7
better english
2019-10-25 12:21:16 -06:00
a53448846b
make comment about discovering plugins in the main thread more accurate
2019-10-25 12:20:10 -06:00
c6b8fc78c8
make logic for creation of startup plugin scan a little clearer
...
Also, do not actually show dialog unless it's a new user or the user explicitly
asks for VST scan at startup
2019-10-25 11:55:55 -06:00
12c81d9a67
add another DEBUG_TRACE line
2019-10-25 11:55:42 -06:00
faeaf14e3b
fix deletion/pointer error
...
Not sure why the now deleted hack was ever necessary for the compiler
2019-10-25 08:00:22 -06:00
48161d7f51
somewhat substantial changes to StartupFSM to try to get relationships betweem various dialogs, plugin scanning and splash screen correct
...
Added extensive comments to try to explain the nightmare of plugin discovery
2019-10-24 21:32:46 -06:00
eeb57bfef1
clean up use of startupFSM
2019-10-24 21:32:46 -06:00
f925611395
make ARDOUR_UI::gui_idle_handler() public and remove API that became part of PluginScanDialog
2019-10-24 21:32:46 -06:00
be12af293d
remove now-unused member variable
2019-10-24 21:32:46 -06:00
0ea395b934
startupFSM is now responsible for attaching GUI to AudioEngine
2019-10-24 21:32:46 -06:00
bc0dcd3996
add new source file
2019-10-24 21:32:46 -06:00
616c82d16a
use PluginScanDialog to initiate plugin manager refresh
2019-10-24 21:32:46 -06:00
fc5076f926
refactor plugin scan dialog into its own object
2019-10-24 21:32:46 -06:00
f40b859ff7
add startupFSM enums to enumwriter
2019-10-24 21:32:46 -06:00
b62091d7d2
add new DEBUG bit for GuiStartup
2019-10-24 21:32:46 -06:00
64af49f6c3
non-GUI startup should only use plugin cache and not discover new ones
2019-10-24 21:32:46 -06:00
015eb03bd5
remove debug output
2019-10-24 21:32:46 -06:00
a4723ab8d9
NOOP: newline removal; space injection
2019-10-24 21:32:46 -06:00
4abdfe19d1
don't inadvertently create a Splash when a dialog is shown
2019-10-24 21:32:46 -06:00
