13
0
Commit Graph

13205 Commits

Author SHA1 Message Date
6f80a5ba0f Turn AutomationCtrl into a SessionHandleRef
This fixes a crash with GUI elements which are only deleted during GUI
Idle and hold a Reference to a Controllable,
The session is already destroyed at that point:

ARDOUR::CoreSelection::remove_control_by_id(PBD::ID const&)
ARDOUR::AutomationControl::~AutomationControl()
ARDOUR::SlavableAutomationControl::~SlavableAutomationControl()
ARDOUR::MonitorControl::~MonitorControl()
boost::detail::sp_counted_base::destroy()
boost::detail::sp_counted_impl_p<AudioGrapher::Interleaver<float>::Input>::dispose()
boost::detail::sp_counted_base::release()
boost::detail::shared_count::~shared_count()
boost::shared_ptr<PBD::Controllable>::~shared_ptr()
boost::shared_ptr<PBD::Connection>::~shared_ptr()
ArdourWidgets::BindingProxy::~BindingProxy()
ArdourWidgets::ArdourButton::~ArdourButton()
VCAMasterStrip::~VCAMasterStrip()
int idle_delete<VCAMasterStrip>(VCAMasterStrip*)
2017-07-30 02:42:55 +02:00
ea48c56061 NO-OP: name-change (_list and _lock are also used in other places)
Derived classes need to explicitly specify namespace and class
to avoid ambiguities (even for private members)
2017-07-30 02:42:55 +02:00
80ecac672f Modify our MSVC project to add libltc as a dependency of 'dummy_backend' (which now needs to link to it) 2017-07-29 10:46:53 +01:00
7f03c9a664 Fix an ambiguous call to 'floor()'
MSVC complains, so let's specify which override we want.
2017-07-29 10:44:00 +01:00
b5e0b5b09f PortManager::unregister_port() must be called with process lock
This fixes "Failed to register <surface> port" when re-loading a session.
2017-07-28 20:15:15 +02:00
964b88e651 Delete CoreSelection at session close 2017-07-28 20:11:55 +02:00
7b7cc9ea6d Add a LTC generator to the dummy backend 2017-07-28 17:47:36 +02:00
d67056562b Fix write-pass re-start while in an active write-pass 2017-07-27 17:50:52 +02:00
3899c06fae Start a new write-pass when writing automation and locating while rolling 2017-07-27 01:40:13 +02:00
28c29ab22d Fix initial sync to LTC with small buffersizes
Ardour follow_slave() does nothing (not even seek) if the slave is not
locked.

The LTC-slave assumes it's locked if LTC is stable for 5 continuous
process-calls.

If the difference of Ardour's transport-position to the LTC-timecode
is large (> 2sec), the slave reset itself (assuming drift, seek don't vari-
speed).

A LTC-slave does reset does reset the locked counter.

Hence: If initially Ardour's transport differs > 2 sec and the buffersize
is small (many process-callbacks), the slave kept resetting itself
never informing Ardour that it locked to the external TC, and Ardour
never issued a seek.
2017-07-26 22:58:16 +02:00
b804109e8e update libltc 2017-07-26 22:58:12 +02:00
2fa34614d0 Remove unnecessary tests for touch-state 2017-07-25 20:16:04 +02:00
bde3edf1c8 Make start_touch() truly idempotent
Also don't allow outsiders to call Controllable::set_touching()
2017-07-25 20:15:12 +02:00
681ab52330 fix e838e7f359 2017-07-24 22:26:04 +02:00
e838e7f359 Fix Mixbus "well known" send-names and enable ctrls 2017-07-24 21:54:31 +02:00
a41198305e Update WritePass logic + AutomationList Undo
Fixes various issues when changing AutomationState while rolling.
2017-07-24 21:00:12 +02:00
8c260a647a update japanese translation (Hiroki Inagaki) 2017-07-24 14:59:11 -04:00
b694ee9e53 OSC: only use gain change signals if value changes 2017-07-24 10:21:31 -07:00
3ab4a1d147 OSC: add use groups to GUI 2017-07-24 10:21:31 -07:00
f3e0fcbb7e OSC: port mode by default should be manual 2017-07-24 10:21:31 -07:00
f1632fcfd2 OSC: make sure initialization is complete before we allow periodic to run 2017-07-23 20:08:02 -07:00
07e869fda8 OSC: simplify route observer 2017-07-23 20:08:02 -07:00
b29b46d371 Fix saving automation record undo
Calling AutomationList::before() clears the state.
2017-07-24 02:59:09 +02:00
30f85faa49 Update amp.cc to use gain_t for maths (no more double)
Also tweak threshold for LPF, assume gain-differences < 10-e5 as
no-change
2017-07-24 01:59:24 +02:00
fde0e293a3 Remove unused "mark" parameter from stop_touch() API 2017-07-24 01:59:18 +02:00
2006701f73 Fix ctrl-list guard-points and concurrency issues
* lock list when editing (prevent concurrent modification of insert
  iterator
* don't add a guard-point if an event is already present between the
  target and guard-point-position
* remove existing automation-events (old guard points) when
  touching automation w/o change
* don't unset "new write pass" when not rolling
  (fixes issues when not rolling but locating with write-enabled)
2017-07-24 01:59:08 +02:00
183351f333 Add touch-events signal emission to ArdourKnob 2017-07-23 19:40:20 +02:00
1508838bde OSC: add /use_group 1/0 command 2017-07-22 12:12:41 -07:00
b42dbe9e4e Sanitize printing of a-eq gain parameters 2017-07-22 17:41:35 +02:00
c21345fc93 NO-OP: whitespace 2017-07-22 15:41:08 +02:00
24829c93b8 AutomationWatch: single DropReferences connection per AC 2017-07-22 15:40:27 +02:00
48ec6dd5c4 NO-OP: whitespace 2017-07-22 15:17:09 +02:00
fba2c2467d Fix Route mute automation touch (owned control) 2017-07-22 15:16:54 +02:00
24e92c1861 NO-OP: consistent [internal] API name for Automatables 2017-07-22 04:45:48 +02:00
f756dc69f4 NO-OP: Consistent API name 2017-07-22 04:25:07 +02:00
038c391d55 More non-rt calls to VCA - fixes VCA automation writing
This calls for a unified API to invoke
Automatable methods  ::transport_located() and ::transport_stopped()
on Stripables,  rather than indirectly calling it via
Route::non_realtime_locate(), Route::nonrealtime_handle_transport_stopped()
2017-07-21 23:07:51 +02:00
243cd35a36 Fix VCA Automation: end write pass 2017-07-21 21:48:20 +02:00
nick_m
886f4e6bc8 TempoMap legacy session loading fixes
Ensure we set the last tempo end note types per minute.
Clarify that we only set the end ntpm if unset.
2017-07-22 02:15:20 +10:00
nick_m
e4e3c10a90 Fis stray break statement when checking for a legacy tempo map
This could result in legacy sessions not being identified correctly and
loading with end tempi of -1.0.
2017-07-22 02:15:20 +10:00
nick_m
2925fd52e5 Rework tempo marker editing menu functions
Setting a tempo to 'Continue' via right click puts it in a permanent state
of continuing the previous section's end tempo (basically what
'Lock Continue' should have been). This can be disabled (unlocked) by
selecting 'Don't Continue'.

Remove the previous temporary 'Continue' function.

Reorganise menu to separate position lock style from more commonly
used functions.
2017-07-22 02:15:20 +10:00
nick_m
1c51435fa3 Calculate clamped tempo stretch ratios using the correct (musical) domain 2017-07-22 02:15:20 +10:00
nick_m
90547112e2 TempoMap : Remove old solve_map debugging code 2017-07-22 02:15:20 +10:00
nick_m
bb71a31b0c Move some duplicated replace/add tempo section code
Resets the previous tempo section's end ntpm to match the start
of a new section whenever a section is added to the map.
2017-07-22 02:15:20 +10:00
nick_m
1399ef391d Remove redundant beat arg from TempoMap::add_meter
BBT time should be enough to determine the beat.
2017-07-22 02:15:20 +10:00
nick_m
c03da364ad Fix incorrect double-snap when moving audio-locked tempi 2017-07-22 02:15:20 +10:00
nick_m
b0a306f9d0 Check for identical meter positions in old sessions by beat rather than pulse 2017-07-22 02:15:20 +10:00
8af27a7a2e OSC make all group dispositions the same 2017-07-21 08:22:02 -07:00
Johannes Mueller
0109042e7b Increase range of a-comp#stereo release time
Like for the mono version in f52443e17e
2017-07-21 16:11:17 +02:00
d977cc3238 Non-layered MIDI recording
This does not merge MIDI data, but trims MIDI regions at rec-stop like
non-layered audio-recording does.
2017-07-21 00:39:22 +02:00
Johannes Mueller
67bec5b5be Set the name of the route in a route template to the template name 2017-07-20 20:09:53 +02:00