36bbd14113
towards fixing #5711
...
Don’t call ::output() [here: SilenceTrimmer::process()]
with no data to process.
If (position + N * period-size) % chunksize == 0;
frames_left == 0 before the last call to ::output().
chunker.h:60 keeps the ProcessContext<T>::EndOfInput
flag and the SilenceTrimmer will already have done ‘in_end’ processing.
2015-01-27 23:13:55 +01:00
Valeriy Kamyshniy
6377fe89a6
[Summary] Adding missing initialization of the date &time formats. “Init trashes” caused a bit ruined logic of the export dialog.
2015-01-27 17:06:54 -05:00
bc7b5844a9
fix printf format-security warning.
...
warning: format string is not a string literal (potentially insecure) [-Wformat-security]
2015-01-27 14:04:19 +01:00
302dc2bea3
Don't try to dereference a NULL ptr (the function 'ARDOUR::IO::nth()' can return an invalid ptr, so let's make sure we test for it)
...
Note 1: Potentially we could have the same issue with 'AutomationLine::nth()' (although the current code seems okay)
Note 2: This (specific) problem seems mostly to affect Mixbus3 when it tries to load an old (version2) session from Ardour2. Mixbus can mark certain IO ports as being 'unused'. While loading sessions, function 'ARDOUR::IO::ensure_ports_locked()' deletes any unused ports. But later, the function 'ARDOUR::IO::make_connections_2X()' was crashing while trying to connect those (now NULL) ports. This commit fixes that crash but there's some evidence that it might only have moved the problem elsewhere. The version2 sessions now open successfully - but an MSVC (Debug) build now crashes whilst closing them (the Release build however, is okay). Someone who's more familiar with the code than me should review the Mixbus3/Ardour2 loading procedure to make sure it's safe.
2015-01-27 11:59:23 +00:00
0f46d7b107
ignore context menu click events, notably during drag but also for a couple of other purposes
...
Conflicts:
gtk2_ardour/editor_canvas_events.cc
2015-01-26 16:39:22 -05:00
b9464fc4db
remove unnecessary commented-out line.
...
Session is marked as in-deletion during deletion itself
2015-01-26 11:58:43 -05:00
cab01bac6c
on OS X, do not require click to activate the application
2015-01-26 11:55:58 -05:00
47f8125b35
amend e3da18fd
2015-01-26 17:14:24 +01:00
208a2a1926
rename ARDOUR_UI::idle_load() to ARDOUR_UI::load_from_application_api() to correctly indicate function
2015-01-26 10:39:14 -05:00
78ec211733
fix incorrect logic when loading session via NextStep document API
2015-01-25 12:53:48 -05:00
bd3643a597
fix declaration of Cocoa NSApplicationDelegate methods
2015-01-25 12:52:26 -05:00
7c7f642a6f
Revert "alter default disk chunk sizes"
...
This reverts commit 3068e55e51
2015-01-25 11:42:35 -05:00
031f68fb9d
add a simple status indicator to the Engine Dialog
2015-01-25 10:19:46 +01:00
e6bb75cf01
audio-engine use internal API to stop
...
emit signal(s) when engine is stopped due to backend
change.
2015-01-25 10:19:06 +01:00
37b8412aa3
fix latency measurement result display
...
If measurement is fast (<100ms), the GUI timeout function
never displayed the measured value.
2015-01-25 10:18:33 +01:00
232d67bc53
midi note paste undo fix.
2015-01-25 01:56:19 +01:00
1fb83d698c
make butler thread merely ask for session state save, not actually do the save itself.
...
This prevents the possibility of cross-thread calls in the GUI when it adds its state
to the session via extra XML
2015-01-24 19:27:28 -05:00
0b5ceaca4e
add handler for, and connect to, Session::SaveSessionRequested
2015-01-24 19:17:13 -05:00
ab3ec791ea
Add a new signal (not yet used) to initiate session saves; alter signal name for existing signal used to allow other objects to add XML state to session
2015-01-24 19:06:31 -05:00
3068e55e51
alter default disk chunk sizes
2015-01-24 19:05:05 -05:00
5ff6402dad
add function to get data width for ARDOUR::SampleFormat
2015-01-24 18:53:10 -05:00
ccd881d518
ScrollGroup::covers_{window,canvas}() need to account for possible non-zero position of the group.
...
They also do NOT need to consider scroll offset
2015-01-24 18:48:28 -05:00
e84e1f7403
ScrollGroups are kept in their own list, so ::window_to_canvas() does not need to inspect root group children to find them
...
Conflicts:
libs/canvas/canvas.cc
2015-01-24 18:48:15 -05:00
db28eefc49
ALSA backend: synchronous switch to/from freewheeling
2015-01-24 23:39:41 +01:00
f2ea059db3
DummyBackend: sync switch to freewheeling
2015-01-24 22:45:42 +01:00
e3da18fd2f
fix copy/drag abort.
2015-01-24 20:40:07 +01:00
22435bb53d
make MouseCursors invalid cursor API be static; use to initialize default cursor value in Drag API; use C API to set canvas cursor
2015-01-24 12:26:58 -05:00
b4e32cd94b
make -n (numfiles) argument do something
2015-01-23 16:17:35 -05:00
90c1e0ffd2
allow use of null pointer as a valid cursor (implies using cursor of parent window)
2015-01-23 15:19:36 -05:00
fe08965d91
fix indentation from prior commit
2015-01-23 13:45:21 -05:00
GZharun
6976a78100
[Summary] Fixed bug 45163: Trim range from right corner of timeline leads Tracks to crash
...
[Details] Crash was provoked because of an attempt to add commands to the session reversible command, but when autoscroll started and trim began with autoscroll the session reversible command was not created for for Trim Drag.
2015-01-23 13:43:52 -05:00
21cb2d6ff9
add write tester script
2015-01-23 12:25:49 -05:00
849da554a7
adjust sftest.cc to be more usable as a write-bandwidth tester
2015-01-23 12:25:49 -05:00
85f9615c26
fix small bug when using -N for nocache
2015-01-23 12:25:49 -05:00
3b2c23be93
split apart read and write chunk size and offer platform-dependent sizes for reading. Write chunk size should remain unchanged from before.
2015-01-23 12:25:49 -05:00
1473442204
fix crash at exit if location-ui was used
...
LocationEditRow members are destroyed after ~LocationUI()
destroys the clock_group. -> segfault in ~LocationEditRow()
2015-01-23 02:24:26 +01:00
611073790b
move control app button adjacent to sample rate and bufsize settings
2015-01-22 15:00:13 -06:00
dcaf8d89c1
remove channelcount selectors for mixbus
2015-01-22 14:54:56 -06:00
6980fc9aee
really re-fix linux cache clear
2015-01-22 12:21:49 -05:00
2afe09a834
calculus is a lost art.
2015-01-22 18:17:01 +01:00
744ca2397c
fix buffer cache flush for linux, and avoid incorrect indirection in interleaved case
2015-01-22 12:15:39 -05:00
7ef0df7904
Revert "use product-neutral name for LV2 install dir"
...
This reverts commit 44ca3c948c
2015-01-22 11:38:28 -05:00
95660a06e2
adjust run-readtest.sh so that it can be used as-is for testing multiple blocksizes
2015-01-22 11:27:49 -05:00
a2e77c0c4e
remove useless error output
2015-01-22 11:22:29 -05:00
44ca3c948c
use product-neutral name for LV2 install dir
2015-01-21 21:20:15 -05:00
01d99870ff
update selection clock
2015-01-21 22:26:14 +01:00
c7c8cc7dc7
set Theme buttons on state reset
...
cleaner version of last commit, set GUI elements
on state-reset.
2015-01-21 20:24:39 +01:00
0c8947491a
initialize theme > gradient sliders.
2015-01-21 19:41:15 +01:00
f282884094
apply Theme > “Show waveform clipping”
...
fixes http://tracker.ardour.org/view.php?id=5589#c15515
2015-01-21 19:35:04 +01:00
174838f3c7
correct run-readtest.sh for use on OS X as well
2015-01-20 17:19:23 -05:00
